searching for reviewer(chmanchester)
128eaae4deb421e72350366371168235cf9fbb4e: Bug 1561474 - Use sparse-profile on Windows generate tasks; r=firefox-build-system-reviewers, chmanchester a=RyanVM
Mike Shal <mshal@mozilla.com> - Tue, 16 Jul 2019 00:47:19 +0300 - rev 544608
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1561474 - Use sparse-profile on Windows generate tasks; r=firefox-build-system-reviewers, chmanchester a=RyanVM Differential Revision: https://phabricator.services.mozilla.com//D37808 Depends on D37807
3416303a9b4a7c49272e956f9a83395e4e4ad985: Bug 1473498 - [mach] Enable test_logger with Python 3 r=firefox-build-system-reviewers,chmanchester
Andrew Halberstadt <ahalberstadt@mozilla.com> - Tue, 02 Jul 2019 20:59:46 +0000 - rev 543896
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1473498 - [mach] Enable test_logger with Python 3 r=firefox-build-system-reviewers,chmanchester Depends on D36101 Differential Revision: https://phabricator.services.mozilla.com/D36102
7123c3146d812a050e52941c008c3b549abcde0c: Bug 1473498 - [mach] Enable test_config with Python 3 r=firefox-build-system-reviewers,chmanchester
Andrew Halberstadt <ahalberstadt@mozilla.com> - Tue, 02 Jul 2019 20:59:03 +0000 - rev 543895
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1473498 - [mach] Enable test_config with Python 3 r=firefox-build-system-reviewers,chmanchester Depends on D36100 Differential Revision: https://phabricator.services.mozilla.com/D36101
152598dd91a82111b96bbf85e33e787702e19214: Bug 1473498 - [mach] Enable test_entry_points with Python 3 r=firefox-build-system-reviewers,chmanchester
Andrew Halberstadt <ahalberstadt@mozilla.com> - Tue, 02 Jul 2019 20:58:14 +0000 - rev 543894
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1473498 - [mach] Enable test_entry_points with Python 3 r=firefox-build-system-reviewers,chmanchester Differential Revision: https://phabricator.services.mozilla.com/D36100
54ea59c8c99db1796013ddedc00135f9cd0be7f1: Bug 1473498 - [mach] Enable test_dispatcher with python 3 r=firefox-build-system-reviewers,chmanchester
Andrew Halberstadt <ahalberstadt@mozilla.com> - Tue, 02 Jul 2019 21:27:35 +0000 - rev 543893
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1473498 - [mach] Enable test_dispatcher with python 3 r=firefox-build-system-reviewers,chmanchester This test is working with minimal effort. Let's get it running to prevent future regressions. Differential Revision: https://phabricator.services.mozilla.com/D36098
5a867f13f12e246e386a7f5050ce1d80e958c5d9: Bug 1560755 - Merge Android PGO profile data in run task; r=firefox-build-system-reviewers,chmanchester
Mike Shal <mshal@mozilla.com> - Tue, 02 Jul 2019 21:51:23 +0000 - rev 543862
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1560755 - Merge Android PGO profile data in run task; r=firefox-build-system-reviewers,chmanchester Android profile runs don't always fully write out the profile data. In this case, the corrupted profile data is successfully uploaded, but future profile-use PGO builds try to merge the data and fail. Retrying the profile-use builds doesn't help, since they all pull from the same job that published the corrupt data. We can detect this in the run task by using llvm-profdata merge, and if the merge fails the task can automatically be retried. Note that the data gets redundantly merged in the profile-use build, but it may not be possible to run the merge in the run task on all platforms (eg: OSX), so we have to keep the merge there as well. Differential Revision: https://phabricator.services.mozilla.com/D36294
fae8c77ea4ad7880b7297c564376b3aaa1a9da93: Bug 1562768 - Enable 3-tier PGO in Linux32 devedition builds; r=firefox-build-system-reviewers,chmanchester
Mike Shal <mshal@mozilla.com> - Tue, 02 Jul 2019 01:13:35 +0000 - rev 543806
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1562768 - Enable 3-tier PGO in Linux32 devedition builds; r=firefox-build-system-reviewers,chmanchester Depends on D36543 Differential Revision: https://phabricator.services.mozilla.com/D36544
3e6f208a59d30ef4028e1b305b85a08aac2fabc9: Bug 1562768 - Remove redundant linux64/devedition mozconfig PGO settings; r=firefox-build-system-reviewers,chmanchester
Mike Shal <mshal@mozilla.com> - Tue, 02 Jul 2019 01:13:21 +0000 - rev 543805
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1562768 - Remove redundant linux64/devedition mozconfig PGO settings; r=firefox-build-system-reviewers,chmanchester Bug 1553065 made this redundant by putting the profile-use mozconfig settings in build/unix/mozconfig.unix. We no longer need them in each leaf mozconfig. Differential Revision: https://phabricator.services.mozilla.com/D36543
9bc355a1aea3bdfdc04bc6c14a657b5e6aa6a972: Bug 1562725 - export UPLOAD_PATH in run-profileserver.sh; r=firefox-build-system-reviewers,chmanchester
Mike Shal <mshal@mozilla.com> - Mon, 01 Jul 2019 20:32:35 +0000 - rev 543678
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1562725 - export UPLOAD_PATH in run-profileserver.sh; r=firefox-build-system-reviewers,chmanchester When adding Windows compatibility in bug 1557785, we stopped exported UPLOAD_PATH by default. UPLOAD_PATH is used by profileserver.py to determine where to store the logs; when it is unset, the logs go to stdout and the artifacts aren't created. We should always export UPLOAD_PATH to get the same logging behavior on all platforms. Differential Revision: https://phabricator.services.mozilla.com/D36521
4cb7eb5b8a428f82b8db1fd60e591a3a06e142b8: Bug 1557762 - ensure we define NS_FREE_PERMANENT_DATA for single-stage pgo builds, r=chmanchester
Gijs Kruitbosch <gijskruitbosch@gmail.com> - Fri, 28 Jun 2019 16:38:14 +0000 - rev 543420
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1557762 - ensure we define NS_FREE_PERMANENT_DATA for single-stage pgo builds, r=chmanchester Differential Revision: https://phabricator.services.mozilla.com/D35469
455dff329fcc9d8fa0647ca662ce5c8451004c87: Bug 1557762 - ensure we define NS_FREE_PERMANENT_DATA for single-stage pgo builds, r=chmanchester
Gijs Kruitbosch <gijskruitbosch@gmail.com> - Thu, 27 Jun 2019 19:53:07 +0000 - rev 543265
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1557762 - ensure we define NS_FREE_PERMANENT_DATA for single-stage pgo builds, r=chmanchester Differential Revision: https://phabricator.services.mozilla.com/D35469
61aa0e6727f5495cde716c89dde7dd47d0e80b4d: Bug 1561728 - Set NEED_XVFB for linux32 PGO run tasks; r=firefox-build-system-reviewers,chmanchester
Mike Shal <mshal@mozilla.com> - Wed, 26 Jun 2019 20:46:21 +0000 - rev 543058
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1561728 - Set NEED_XVFB for linux32 PGO run tasks; r=firefox-build-system-reviewers,chmanchester Small fixup for bug 1561147 - Linux run tasks now have to set NEED_XVFB to true in order to get the virtual framebuffer needed to run Firefox in automation. Differential Revision: https://phabricator.services.mozilla.com/D36086
b20b355373b444b5a9a303777631f99141149a2b: Bug 1560545 - Change libdrm version check in configure. r=chmanchester
Mike Hommey <mh+mozilla@glandium.org> - Wed, 26 Jun 2019 05:02:42 +0000 - rev 542972
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1560545 - Change libdrm version check in configure. r=chmanchester Differential Revision: https://phabricator.services.mozilla.com/D35753
a961572fed142f07043653cce2a86f6955db6f68: Bug 1560545 - Force-enable wayland support in Linux builds. r=chmanchester
Mike Hommey <mh+mozilla@glandium.org> - Wed, 26 Jun 2019 06:03:20 +0000 - rev 542971
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1560545 - Force-enable wayland support in Linux builds. r=chmanchester So that we don't end up disabling it by accident. Differential Revision: https://phabricator.services.mozilla.com/D35752
31177fcc31230e0c4d7274b2c66a09cfe23b9e94: Bug 1560545 - Change libdrm version check in configure. r=chmanchester
Mike Hommey <mh+mozilla@glandium.org> - Tue, 25 Jun 2019 20:22:48 +0000 - rev 542964
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1560545 - Change libdrm version check in configure. r=chmanchester Differential Revision: https://phabricator.services.mozilla.com/D35753
e3e1ad8d7709af71fc1cdb22b9a4b74410fa922a: Bug 1560545 - Force-enable wayland support in Linux builds on automation. r=chmanchester
Mike Hommey <mh+mozilla@glandium.org> - Tue, 25 Jun 2019 20:22:15 +0000 - rev 542963
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1560545 - Force-enable wayland support in Linux builds on automation. r=chmanchester So that we don't end up disabling it by accident. Differential Revision: https://phabricator.services.mozilla.com/D35752
91b34c90d2a9e87ab5cd796768ba7274739e7960: Bug 1557785 - Process install manifests in 3-tier Windows builds; r=firefox-build-system-reviewers,chmanchester
Mike Shal <mshal@mozilla.com> - Wed, 19 Jun 2019 22:06:14 +0000 - rev 542935
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1557785 - Process install manifests in 3-tier Windows builds; r=firefox-build-system-reviewers,chmanchester Windows 1-tier PGO builds only partially clobber between the profile-generate and profile-use stages, so that exports/installed files don't have to be reprocessed. Unfortunately we can't skip the install manifests in 3-tier PGO because the profile-generate build happens on a different machine, so we have to differentiate between 1-tier and 3-tier PGO builds. A new variable, MOZ_1TIER_PGO, is used for this purpose. Eventually this logic can be cleaned up in bug 1557788 once all PGO builds use the 3-tier model. Differential Revision: https://phabricator.services.mozilla.com/D34802
3430c89be449991836d52314869269cc0afa8227: Bug 1557785 - Allow LLVM_PROFDATA to work even if not explicitly set in the environment; r=firefox-build-system-reviewers,chmanchester
Mike Shal <mshal@mozilla.com> - Wed, 19 Jun 2019 22:05:56 +0000 - rev 542932
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1557785 - Allow LLVM_PROFDATA to work even if not explicitly set in the environment; r=firefox-build-system-reviewers,chmanchester Windows finds llvm-profdata in the PATH, in contrast to Linux or Android builds that set LLVM_PROFDATA as an environment variable in mozconfigs. The pgo_profile_path() configure checks should still work in this case. Differential Revision: https://phabricator.services.mozilla.com/D34799
0b6522f13bcfe979c1cd25e58447eecac2df9b34: Bug 1557785 - Hook MOZ_PGO_PROFILE_USE environment variable into common Windows mozconfig; r=firefox-build-system-reviewers,chmanchester
Mike Shal <mshal@mozilla.com> - Wed, 19 Jun 2019 22:05:52 +0000 - rev 542931
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1557785 - Hook MOZ_PGO_PROFILE_USE environment variable into common Windows mozconfig; r=firefox-build-system-reviewers,chmanchester MOZ_PGO_PROFILE_USE is set when the use-pgo attribute is defined in the task. This environment variable is used to enable --enable-profile-use and related configure flags. Differential Revision: https://phabricator.services.mozilla.com/D34798
2989571031f9691269ef4441129432d31c5b66dc: Bug 1557785 - Update run-profileserver.sh for Windows compatibility; r=firefox-build-system-reviewers,chmanchester
Mike Shal <mshal@mozilla.com> - Wed, 19 Jun 2019 22:05:41 +0000 - rev 542929
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1557785 - Update run-profileserver.sh for Windows compatibility; r=firefox-build-system-reviewers,chmanchester The run-profileserver.sh script is a bridge between the Taskcluster task and profileserver.py. It was originally written as a Linux-only script, but with a few modifications it can support Windows as well. The xvfb support needs to be optional, and the UPLOAD_PATH and PGO_RUNDIR variables must not assume a Linux filesystem. Differential Revision: https://phabricator.services.mozilla.com/D34796
021c05e47e6f4932a63fc1eeabc3c965fae6e882: Bug 1561102 - Add license exception for the mach crate. r=chmanchester
Mike Hommey <mh+mozilla@glandium.org> - Tue, 25 Jun 2019 20:25:44 +0000 - rev 542915
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1561102 - Add license exception for the mach crate. r=chmanchester Differential Revision: https://phabricator.services.mozilla.com/D35743
0c2b80c35820bfaaa8f86f7602f0dc684a58b172: Bug 1560340 - Only add confvars.sh as a dependency to config.status when it exists. r=chmanchester
Mike Hommey <mh+mozilla@glandium.org> - Thu, 20 Jun 2019 18:43:25 +0000 - rev 542552
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1560340 - Only add confvars.sh as a dependency to config.status when it exists. r=chmanchester Differential Revision: https://phabricator.services.mozilla.com/D35447
de9be674a6db6949aae3fa523a9999282c086055: Bug 1547217 - Reshuffle how verifymar is linked. r=chmanchester
Mike Hommey <mh+mozilla@glandium.org> - Wed, 19 Jun 2019 23:26:40 +0000 - rev 542108
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1547217 - Reshuffle how verifymar is linked. r=chmanchester The conditions under which verifymar is built were not aligned with what kind of setups are actually doing something. For instance --disable-signmar --enable-verify-mar was building the verifymar library but not doing anything with it. OTOH, building with --enable-signmar --disable-verify-mar did build it but its code was eliminated at link time because it's unused. Finally, the conditions between modules/libmar/verify/moz.build and toolkit/mozapps/update/updater/updater-common.build weren't aligned and broke some non-Linux tier-3 platforms. We remedy the latter by moving the flags and libraries verifymar needs to verifymar, so that things that link verifymar inherit them. And while in the vicinity, replace a use of NSPR_LIBS with the pseudo-library `nspr` which has the same effect. Differential Revision: https://phabricator.services.mozilla.com/D34620
f0f958b29d69ceaa0faa34955e98c63ecd94af7b: Bug 1557583 - Add a --enable-frame-pointers option. r=chmanchester
Mike Hommey <mh+mozilla@glandium.org> - Wed, 12 Jun 2019 22:30:46 +0000 - rev 541385
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1557583 - Add a --enable-frame-pointers option. r=chmanchester We've been relying on frame pointers being indirectly enabled via things like --enable-profiling for some time, but this doesn't scale because some things may want frame pointers while wanting --disable-profiling. So we move MOZ_FRAMEPTR_FLAGS to python configure and add a new option to decide whether to enable frame pointers or not. Differential Revision: https://phabricator.services.mozilla.com/D34117
86f8d38c42c9d7c130c799cb4fdc5726d8eb08b1: Bug 1557336 - Unset LC_CTYPE when executing pipenv. r=chmanchester
Mike Hommey <mh+mozilla@glandium.org> - Tue, 11 Jun 2019 20:24:04 +0000 - rev 541167
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1557336 - Unset LC_CTYPE when executing pipenv. r=chmanchester Differential Revision: https://phabricator.services.mozilla.com/D34484
79047a5ff644139de16f80330cc2d7776ded71f4: Bug 1557171 - Update vendored lmdb-rkv-sys to 0.8.4. r=chmanchester
Mike Hommey <mh+mozilla@glandium.org> - Tue, 11 Jun 2019 20:23:10 +0000 - rev 541166
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1557171 - Update vendored lmdb-rkv-sys to 0.8.4. r=chmanchester The only change is a fix for building for mips. Differential Revision: https://phabricator.services.mozilla.com/D34096
33fbb6ff15cd2f14d801caf9de47d35c068d8131: Bug 1551368 - Part 3: Don't remove the rust incremental cache when clobbering. r=chmanchester
Eric Rahm <erahm@mozilla.com> - Thu, 06 Jun 2019 18:35:33 +0000 - rev 540780
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1551368 - Part 3: Don't remove the rust incremental cache when clobbering. r=chmanchester Skips over the incremental cache when performing a clobber. The incremental compilation cache is located at: `$(objdir)/$(rust_target)/$(rust_build_kind)/incremental` When cross compiling there can be two caches, one for the host and one for the target so we handle both. Differential Revision: https://phabricator.services.mozilla.com/D31310
f35cdcfa0a28fc03cd192507f5695a3e36c72fcd: Bug 1551368 - Part 2: Make the Clobberer aware of substs. r=chmanchester
Eric Rahm <erahm@mozilla.com> - Thu, 06 Jun 2019 18:35:11 +0000 - rev 540779
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1551368 - Part 2: Make the Clobberer aware of substs. r=chmanchester Pass in the substs dictionary to `Clobberer` so that we can use it to query `cargo` paths. Differential Revision: https://phabricator.services.mozilla.com/D31309
5a8df036968e20b8d18e04983d2f120b4a628c27: Bug 1551368 - Part 1: Factor out subdirectory logic. r=chmanchester
Eric Rahm <erahm@mozilla.com> - Thu, 06 Jun 2019 18:35:07 +0000 - rev 540778
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1551368 - Part 1: Factor out subdirectory logic. r=chmanchester Pull out the logic for filtering subdirectories and deleting them into reusable functions. Differential Revision: https://phabricator.services.mozilla.com/D31308
03a254a256396eea7313972a2b894895473ef199: Bug 1472091 - Bootstrap clang from automation on Mac. r=chmanchester
Mike Hommey <mh+mozilla@glandium.org> - Fri, 07 Jun 2019 00:46:15 +0000 - rev 540606
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1472091 - Bootstrap clang from automation on Mac. r=chmanchester Differential Revision: https://phabricator.services.mozilla.com/D34077
028c8f1b6b5b1975255307245a69321adbdac9a8: Bug 1551368 - Part 1: Factor out subdirectory logic. r=firefox-build-system-reviewers,chmanchester
Eric Rahm <erahm@mozilla.com> - Tue, 21 May 2019 20:46:43 +0000 - rev 539862
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1551368 - Part 1: Factor out subdirectory logic. r=firefox-build-system-reviewers,chmanchester Pull out the logic for filtering subdirectories and deleting them into reusable functions. Differential Revision: https://phabricator.services.mozilla.com/D31308
7f00cff63f590fa922a3b54731c534f24895a7a8: Bug 1556880 - Support GCC ARM preprocessor defines to detect the ARM target. r=chmanchester
Mike Hommey <mh+mozilla@glandium.org> - Wed, 05 Jun 2019 02:53:01 +0000 - rev 539744
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1556880 - Support GCC ARM preprocessor defines to detect the ARM target. r=chmanchester Also set `fpu` to None for when we don't find it. Differential Revision: https://phabricator.services.mozilla.com/D33720
ccd1356fc8f1d0bfa9d896e88d3cc924425623da: Bug 1526857 - Improve bindgen configuration wrt clang. r=chmanchester
Mike Hommey <mh+mozilla@glandium.org> - Wed, 05 Jun 2019 02:48:20 +0000 - rev 539742
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1526857 - Improve bindgen configuration wrt clang. r=chmanchester The current setup for bindgen relies on either finding clang/libclang from the output of llvm-config, or from the paths given via the configure flags --with-clang-path/--with-libclang-path. One _very_ common problem is that the llvm-config we end up using does not correspond to the clang used for compilation, which has some undesirable side effect, like failing to build. So instead of relying on llvm-config, we do the following: - when the compiler is clang, we just use that - when the compiler is clang-cl, we use clang from the same directory - otherwise, we either try to find clang in PATH, or rely on --with-clang-path. Once clang is found, we try to deduce the location of the corresponding libclang via the output of `clang -print-search-dirs`, or rely on --with-libclang-path. Differential Revision: https://phabricator.services.mozilla.com/D33241
4f56db8e65a66117845de2276a1ce77e060ea9cd: Bug 1553065 - Move profile-use mozconfig info into common mozconfigs; r=firefox-build-system-reviewers,chmanchester
Mike Shal <mshal@mozilla.com> - Fri, 31 May 2019 23:56:16 +0000 - rev 539321
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1553065 - Move profile-use mozconfig info into common mozconfigs; r=firefox-build-system-reviewers,chmanchester The 3-tier PGO builds used a separate mozconfig called 'profile-use' for the final tier. This created a problem when it rode to beta, since the same mozconfig was used for all trees, which meant we ended up with nightly branding on beta builds. With the PGO-enabling logic in common mozconfigs, we can enable it by setting the MOZ_PGO_PROFILE_USE environment variable from the task definition. All of the final-tier PGO builds now use the nightly, beta, etc mozconfigs like before, so branding should be intact. Differential Revision: https://phabricator.services.mozilla.com/D33172
8245ccd3c94891c11cb2bce17678e45ddd358e76: Bug 1553065 - Use MOZ_LTO environment variable in mozconfig.unix; r=firefox-build-system-reviewers,chmanchester
Mike Shal <mshal@mozilla.com> - Fri, 31 May 2019 23:56:12 +0000 - rev 539320
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1553065 - Use MOZ_LTO environment variable in mozconfig.unix; r=firefox-build-system-reviewers,chmanchester This makes it consistent with bug 1530908 and 1536194. Differential Revision: https://phabricator.services.mozilla.com/D33171
16872c13ee938da5981ee5ed3d66bf66aa4c7241: Bug 1554286 - move Mac builds to Rust 1.36-beta; r=chmanchester
Nathan Froyd <froydnj@mozilla.com> - Fri, 31 May 2019 17:50:38 +0000 - rev 539274
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1554286 - move Mac builds to Rust 1.36-beta; r=chmanchester We would like to switch to using cross-language LTO on all of our platforms, and we need to use a beta version of Rust on Mac to do that. Differential Revision: https://phabricator.services.mozilla.com/D33316
a4cb3416b991dc3f13a29b71dc9f989cce3aaa17: Bug 1552080 - Don't clobber library features with test features in the make backend. r=chmanchester
Emilio Cobos Álvarez <emilio@crisal.io> - Tue, 28 May 2019 21:05:03 +0000 - rev 538822
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1552080 - Don't clobber library features with test features in the make backend. r=chmanchester We weren't honoring the case where the library features differ from the tests features (situation which my previous patch does). We were incorrectly overriding `rust_feature_flags`, which of course ended up with a working rusttests with my patches, but a bunch of negative leaks :) Name the test features differently so that they don't affect the regular library features. Differential Revision: https://phabricator.services.mozilla.com/D32777
2ccb516a980645257aed469ae481fd0086250ea5: Bug 1554078 - Remove now unnecessary STL wrapping. r=chmanchester
Mike Hommey <mh+mozilla@glandium.org> - Wed, 29 May 2019 00:07:22 +0000 - rev 538808
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1554078 - Remove now unnecessary STL wrapping. r=chmanchester Some parts of mozglue used to be STL wrapped because mozalloc used to be a separate library, but that was changed a while ago (in bug 868814, 4 years ago), and those wrappings are not necessary anymore. Differential Revision: https://phabricator.services.mozilla.com/D32430
802132d21228135899b6e062410c5d9957ef28a3: Bug 1338099 - Ensure sourcestamp.txt has a buildid; r=firefox-build-system-reviewers,chmanchester
Edmund Wong <ewong@pw-wspx.org> - Tue, 28 May 2019 19:54:56 +0000 - rev 538797
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1338099 - Ensure sourcestamp.txt has a buildid; r=firefox-build-system-reviewers,chmanchester The $(BUILDID) make variable tries to use either application.ini or platform.ini to fetch the buildid, and if those don't exist then we end up with an empty buildid. An error message is displayed, but it doesn't cause the make invocation to fail because it happens inside a $(shell). Instead we can fetch the buildid similar to the source url, by generating buildid.h and grabbing the value via awk. Differential Revision: https://phabricator.services.mozilla.com/D32518
d799c2e1cd02bbd0fbba0871e4fe04f66c7be7a5: Bug 1542963 - Insert unicode_literals into python/mozbuild/mozpack and called mozbuild/* files. r=firefox-build-system-reviewers,chmanchester
Justin Wood <Callek@gmail.com> - Tue, 28 May 2019 14:23:25 +0000 - rev 538711
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1542963 - Insert unicode_literals into python/mozbuild/mozpack and called mozbuild/* files. r=firefox-build-system-reviewers,chmanchester Lint python/mozbuild/{mozbuild,mozpack}. This makes sure we use byte strings (type(b'')) in many places. This also has a few places where we know we want unicode, by enforcing it. This code also has a few places where we call into windows API's which expect either all args to be unicode, or all args to be bytestrings (not-unicode) so make sure those calls align. This is the most risky of the stack, since there are some mach commands and codepaths that are neither excercised in automation nor excercised in tests. Differential Revision: https://phabricator.services.mozilla.com/D26645
bf11356a308cd40eb03f84ddfcd295247ff336c1: Bug 1542963 - Fix most flake8 issues in python/mozbuild/mozbuild/* r=firefox-build-system-reviewers,chmanchester
Justin Wood <Callek@gmail.com> - Tue, 28 May 2019 14:22:20 +0000 - rev 538707
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1542963 - Fix most flake8 issues in python/mozbuild/mozbuild/* r=firefox-build-system-reviewers,chmanchester Leaving one fix for an explicit review. Lint python/mozbuild/{mozbuild,mozpack}. r=#build Differential Revision: https://phabricator.services.mozilla.com/D26641
bd7bac95cd92ff936212b0243c993f920720771e: Bug 1542746 - switch clang{,-cl} to use IR-based instrumentation for PGO; r=firefox-build-system-reviewers,chmanchester
Nathan Froyd <froydnj@mozilla.com> - Fri, 24 May 2019 19:52:41 +0000 - rev 538302
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1542746 - switch clang{,-cl} to use IR-based instrumentation for PGO; r=firefox-build-system-reviewers,chmanchester This form of instrumentation is more like our other platforms, and also opens the possibility of interacting properly with Rust IR-level PGO. Differential Revision: https://phabricator.services.mozilla.com/D31133
13461d98a55fe4a7e7bf492b9812418c548c6a85: Bug 1542746 - use a static MOZ_PROFILE_ORDER_FILE; r=nalexander,chmanchester
Nathan Froyd <froydnj@mozilla.com> - Fri, 24 May 2019 01:54:59 +0000 - rev 538301
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1542746 - use a static MOZ_PROFILE_ORDER_FILE; r=nalexander,chmanchester We're planning on switching to IR-based profiling, so we can't use the frontend-based instrumentation to collect the order in which functions are executed...at least not during the build itself. Performance tests indicate that not having the order information decreases performance significantly. So we're going to check in static files for Win32 and Win64 and use those to perform the ordering. It's OK if these files are slightly out of date; as of this writing, builds that generate and then use these files complain that ~1/3 of the functions can't be found (!). We're just trying to do something slightly smarter than whatever the linker default is. Differential Revision: https://phabricator.services.mozilla.com/D31132
b09e197ba5a3213026316668e89707749d5f3821: Bug 1550956: Import builtins in Python 3 compatible way r=firefox-build-system-reviewers,chmanchester
Kagami Sascha Rosylight <saschanaz@outlook.com> - Thu, 23 May 2019 03:57:17 +0000 - rev 538016
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1550956: Import builtins in Python 3 compatible way r=firefox-build-system-reviewers,chmanchester Differential Revision: https://phabricator.services.mozilla.com/D30790
3e785d8704585cc8de56d94abbd47653ceb09ad4: Bug 1548563 - move symbol file logic into the moz.build frontend; r=firefox-build-system-reviewers,chmanchester
Nathan Froyd <froydnj@mozilla.com> - Wed, 22 May 2019 13:25:06 +0000 - rev 537799
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1548563 - move symbol file logic into the moz.build frontend; r=firefox-build-system-reviewers,chmanchester This way compilation backends don't all have to figure out the right way to handle symbol files. Differential Revision: https://phabricator.services.mozilla.com/D29673
fa4c37c31dfd7b4de6ff271222bc6e9561c66609: Bug 1550956: Import builtins in Python 3 compatible way r=firefox-build-system-reviewers,chmanchester
Kagami Sascha Rosylight <saschanaz@outlook.com> - Tue, 21 May 2019 18:38:46 +0000 - rev 537709
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1550956: Import builtins in Python 3 compatible way r=firefox-build-system-reviewers,chmanchester Differential Revision: https://phabricator.services.mozilla.com/D30790
b632ea1ae36e49a6ab60ed2b34ee2e967dcb26d9: Bug 1547217 - Reshuffle how verifymar is linked. r=chmanchester, a=jcristau
Mike Hommey <mh+mozilla@glandium.org> - Wed, 19 Jun 2019 23:26:40 +0000 - rev 537055
Push 2082 by ffxbld-merge at Mon, 01 Jul 2019 08:34:18 +0000
Bug 1547217 - Reshuffle how verifymar is linked. r=chmanchester, a=jcristau The conditions under which verifymar is built were not aligned with what kind of setups are actually doing something. For instance --disable-signmar --enable-verify-mar was building the verifymar library but not doing anything with it. OTOH, building with --enable-signmar --disable-verify-mar did build it but its code was eliminated at link time because it's unused. Finally, the conditions between modules/libmar/verify/moz.build and toolkit/mozapps/update/updater/updater-common.build weren't aligned and broke some non-Linux tier-3 platforms. We remedy the latter by moving the flags and libraries verifymar needs to verifymar, so that things that link verifymar inherit them. And while in the vicinity, replace a use of NSPR_LIBS with the pseudo-library `nspr` which has the same effect. Differential Revision: https://phabricator.services.mozilla.com/D34620
4f6a9270754a0ca4e368bb0bf3256c72669fe79c: Bug 1553065 - Move profile-use mozconfig info into common mozconfigs; r=firefox-build-system-reviewers,chmanchester a=RyanVM
Mike Shal <mshal@mozilla.com> - Fri, 31 May 2019 23:56:16 +0000 - rev 536954
Push 2082 by ffxbld-merge at Mon, 01 Jul 2019 08:34:18 +0000
Bug 1553065 - Move profile-use mozconfig info into common mozconfigs; r=firefox-build-system-reviewers,chmanchester a=RyanVM The 3-tier PGO builds used a separate mozconfig called 'profile-use' for the final tier. This created a problem when it rode to beta, since the same mozconfig was used for all trees, which meant we ended up with nightly branding on beta builds. With the PGO-enabling logic in common mozconfigs, we can enable it by setting the MOZ_PGO_PROFILE_USE environment variable from the task definition. All of the final-tier PGO builds now use the nightly, beta, etc mozconfigs like before, so branding should be intact. Differential Revision: https://phabricator.services.mozilla.com/D33172
4a7962ae170f16bc2b7b0e50348322ca1f01a7dc: Bug 1553065 - Use MOZ_LTO environment variable in mozconfig.unix; r=firefox-build-system-reviewers,chmanchester a=RyanVM
Mike Shal <mshal@mozilla.com> - Fri, 31 May 2019 23:56:12 +0000 - rev 536953
Push 2082 by ffxbld-merge at Mon, 01 Jul 2019 08:34:18 +0000
Bug 1553065 - Use MOZ_LTO environment variable in mozconfig.unix; r=firefox-build-system-reviewers,chmanchester a=RyanVM This makes it consistent with bug 1530908 and 1536194. Differential Revision: https://phabricator.services.mozilla.com/D33171
73460fd9b68d7ddd5266cda0d0693ec4b15de14c: Bug 1557336 - Unset LC_CTYPE when executing pipenv. r=chmanchester a=test-only
Mike Hommey <mh+mozilla@glandium.org> - Tue, 11 Jun 2019 20:24:04 +0000 - rev 536912
Push 2082 by ffxbld-merge at Mon, 01 Jul 2019 08:34:18 +0000
Bug 1557336 - Unset LC_CTYPE when executing pipenv. r=chmanchester a=test-only Differential Revision: https://phabricator.services.mozilla.com/D34484