searching for reviewer(bzbarsky)
71e7d47597e9eef2e9f02b1ba2dac12f43fc95b8: Bug 1584907 - Deny internal entities closing the doctype. r=bzbarsky a=RyanVM
Peter Van der Beken <peterv@propagandism.org> - Fri, 04 Oct 2019 09:38:58 +0000 - rev 555600
Push 2165 by ffxbld-merge at Mon, 14 Oct 2019 16:30:58 +0000
Bug 1584907 - Deny internal entities closing the doctype. r=bzbarsky a=RyanVM Differential Revision: https://phabricator.services.mozilla.com/D47704
d5b7b61bb2d288e6077c7960be6c56266a37aa04: Bug 1583684 - Fix some rooting hazards in DOM bindings r=bzbarsky a=lizzard
Steve Fink <sfink@mozilla.com> - Thu, 26 Sep 2019 23:50:14 +0000 - rev 555452
Push 2165 by ffxbld-merge at Mon, 14 Oct 2019 16:30:58 +0000
Bug 1583684 - Fix some rooting hazards in DOM bindings r=bzbarsky a=lizzard Differential Revision: https://phabricator.services.mozilla.com/D47020
cf805c2c2f93ae076fb8b58dad458dcd1d6238b6: Bug 1581548: Handle new BrowsingContexts becoming discarded during nested event loop. r=bzbarsky a=RyanVM
Kris Maglione <maglione.k@gmail.com> - Tue, 17 Sep 2019 22:19:50 +0000 - rev 555173
Push 2165 by ffxbld-merge at Mon, 14 Oct 2019 16:30:58 +0000
Bug 1581548: Handle new BrowsingContexts becoming discarded during nested event loop. r=bzbarsky a=RyanVM Differential Revision: https://phabricator.services.mozilla.com/D46088 MANUAL PUSH: Cannot update reopened Phabricator revisions.
17b847ad15633a9419e8b98254000c4f413575db: Bug 1573245 - Change AuthenticatorTransport to be string, not `enum` r=bzbarsky,keeler a=RyanVM
J.C. Jones <jjones@mozilla.com> - Tue, 17 Sep 2019 07:50:44 +0000 - rev 555168
Push 2165 by ffxbld-merge at Mon, 14 Oct 2019 16:30:58 +0000
Bug 1573245 - Change AuthenticatorTransport to be string, not `enum` r=bzbarsky,keeler a=RyanVM Upstream: https://github.com/w3c/webauthn/issues/1268 Differential Revision: https://phabricator.services.mozilla.com/D41620
0c68a3df6ebdf1669a0bd2752cee275e82ac8511: Bug 1399803 - Consider all IPv4 loopback addresses as secure context; r=bzbarsky,dragana
Ehsan Akhgari <ehsan@mozilla.com> - Fri, 30 Aug 2019 07:57:34 +0000 - rev 554650
Push 2165 by ffxbld-merge at Mon, 14 Oct 2019 16:30:58 +0000
Bug 1399803 - Consider all IPv4 loopback addresses as secure context; r=bzbarsky,dragana Differential Revision: https://phabricator.services.mozilla.com/D43633
b78fd9e42adcaeac7548f5a999630b5c75d5c039: Bug 1577592 - Properly set the has part attribute bit when cloning a XUL element. r=bzbarsky
Emilio Cobos Álvarez <emilio@crisal.io> - Fri, 30 Aug 2019 00:10:36 +0000 - rev 554591
Push 2165 by ffxbld-merge at Mon, 14 Oct 2019 16:30:58 +0000
Bug 1577592 - Properly set the has part attribute bit when cloning a XUL element. r=bzbarsky Test is in the other revision for this bug. Do the same we do for the other bits. This setup looks pretty error prone though... Differential Revision: https://phabricator.services.mozilla.com/D44069
d3fe24ea630981ac7b2fe46912a03aff2665e1b6: Bug 817058 - VMX acceleration for nsTextFragment. r=bzbarsky
Cameron Kaiser <spectre@floodgap.com> - Wed, 28 Aug 2019 05:03:54 +0000 - rev 554075
Push 2165 by ffxbld-merge at Mon, 14 Oct 2019 16:30:58 +0000
Bug 817058 - VMX acceleration for nsTextFragment. r=bzbarsky Differential Revision: https://phabricator.services.mozilla.com/D43566
99fa9dc45ddc665417995b52708657dbff2448a9: Bug 1561502, r=bzbarsky,Honza
Gijs Kruitbosch <gijskruitbosch@gmail.com> - Tue, 20 Aug 2019 13:11:58 +0000 - rev 552710
Push 2165 by ffxbld-merge at Mon, 14 Oct 2019 16:30:58 +0000
Bug 1561502, r=bzbarsky,Honza Differential Revision: https://phabricator.services.mozilla.com/D42120
bd6df046c082cdab22dac956e16e357c1d9b5f4b: Bug 1572349 - Add Document::ResolveWithBaseURI. r=bzbarsky
Kagami Sascha Rosylight <saschanaz@outlook.com> - Fri, 16 Aug 2019 03:38:31 +0300 - rev 552139
Push 2165 by ffxbld-merge at Mon, 14 Oct 2019 16:30:58 +0000
Bug 1572349 - Add Document::ResolveWithBaseURI. r=bzbarsky Summary: This adds a helper method that enables simpler code in D41047 and D36714. Reviewers: bzbarsky, marcosc Reviewed By: bzbarsky Bug #: 1572349 Differential Revision: https://phabricator.services.mozilla.com/D41902
1b097ae05490a3b2c5e1c125160b0adea3515fe2: Bug 1414372: Introduce interface mixins r=bzbarsky
Kagami Sascha Rosylight <saschanaz@outlook.com> - Thu, 15 Aug 2019 16:53:49 +0000 - rev 552041
Push 2165 by ffxbld-merge at Mon, 14 Oct 2019 16:30:58 +0000
Bug 1414372: Introduce interface mixins r=bzbarsky Add IDLInterfaceMixin with a new superclass shared with existing IDLInterfaceOrNamespace. Differential Revision: https://phabricator.services.mozilla.com/D38802
8e9d1223d391da60c16ea3e4087123f6c3b9f3a4: Bug 1572349 - Add Document::ResolveWithBaseURI r=bzbarsky
Kagami Sascha Rosylight <saschanaz@outlook.com> - Thu, 15 Aug 2019 14:49:19 +0000 - rev 552040
Push 2165 by ffxbld-merge at Mon, 14 Oct 2019 16:30:58 +0000
Bug 1572349 - Add Document::ResolveWithBaseURI r=bzbarsky This adds a helper method that enables simpler code in D41047 and D36714. Differential Revision: https://phabricator.services.mozilla.com/D41902
b1133e4b7e953cbb539e27ac7034b357a4e7b326: Bug 782551 - Remove two quirks that other browsers don't have. r=bzbarsky
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 15 Aug 2019 15:57:42 +0000 - rev 552015
Push 2165 by ffxbld-merge at Mon, 14 Oct 2019 16:30:58 +0000
Bug 782551 - Remove two quirks that other browsers don't have. r=bzbarsky Differential Revision: https://phabricator.services.mozilla.com/D42148
31defc04f73a3e33c4b279fc317953614c953cbb: Bug 1572526 - Move a bunch of code that's only called by HTMLLinkElement out of Link.cpp. r=bzbarsky
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 15 Aug 2019 14:10:08 +0000 - rev 551990
Push 2165 by ffxbld-merge at Mon, 14 Oct 2019 16:30:58 +0000
Bug 1572526 - Move a bunch of code that's only called by HTMLLinkElement out of Link.cpp. r=bzbarsky Seems like a more logical place for it to live. Differential Revision: https://phabricator.services.mozilla.com/D41270
b3194a6ba51e91aefe3933da163e6ba622b0c9f7: Bug 1572246 - Make <link> always unvisited. r=bzbarsky
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 15 Aug 2019 14:10:07 +0000 - rev 551989
Push 2165 by ffxbld-merge at Mon, 14 Oct 2019 16:30:58 +0000
Bug 1572246 - Make <link> always unvisited. r=bzbarsky Intent email: https://groups.google.com/d/msg/mozilla.dev.platform/1NP6oJzK6zg/ftAz_TajAAAJ For now do the obvious check rather than bigger refactorings, since we keep them matching :link or not depending on whether they have an href. I'll file an HTML spec issue about not making them traversable, and a MathML issue about the craziness that it is that almost all MathML elements can be links. Differential Revision: https://phabricator.services.mozilla.com/D41269
9a51c0c9a0f7b16b0fbaa675300e8b4b29add727: Bug 1573419 - Fix assertion failure finalizing JSObjects during shutdown r=bzbarsky
Jon Coppeard <jcoppeard@mozilla.com> - Thu, 15 Aug 2019 08:29:26 +0000 - rev 551952
Push 2165 by ffxbld-merge at Mon, 14 Oct 2019 16:30:58 +0000
Bug 1573419 - Fix assertion failure finalizing JSObjects during shutdown r=bzbarsky The problem is that if there is a leak at shutdown we can end up calling ClearWrapper on a wrapper that has already been cleared by the JS engine. The patch just relaxes the assertion to allow this. I tested this on try with a bunch of retriggers and it seems to fix the problem. Differential Revision: https://phabricator.services.mozilla.com/D41938
0bef6c2195bc758dffd7265b06c0502d1612918f: Bug 1573720 - Convert security.view-source.reachable-from-inner-protocol to a static pref. r=bzbarsky
Nicholas Nethercote <nnethercote@mozilla.com> - Thu, 15 Aug 2019 05:29:35 +0000 - rev 551939
Push 2165 by ffxbld-merge at Mon, 14 Oct 2019 16:30:58 +0000
Bug 1573720 - Convert security.view-source.reachable-from-inner-protocol to a static pref. r=bzbarsky Differential Revision: https://phabricator.services.mozilla.com/D41912
7b86930a9d34358e931f85148832fd0190fbf9d9: Bug 1573537 - add parentheses for property info count `static_assert`; r=bzbarsky
Nathan Froyd <froydnj@mozilla.com> - Tue, 13 Aug 2019 17:47:04 +0000 - rev 551505
Push 2165 by ffxbld-merge at Mon, 14 Oct 2019 16:30:58 +0000
Bug 1573537 - add parentheses for property info count `static_assert`; r=bzbarsky Otherwise we're computing (1ull << CHAR_BIT) * sizeof(...), which is not quite what we wanted. Differential Revision: https://phabricator.services.mozilla.com/D41773
e41c0ed4d4377708478aa7771ee2a1f185c90a5c: Bug 1559489, part 4 - Remote-to-local window transplanting. r=tcampbell,bzbarsky
Andrew McCreight <continuation@gmail.com> - Tue, 13 Aug 2019 19:09:59 +0000 - rev 551502
Push 2165 by ffxbld-merge at Mon, 14 Oct 2019 16:30:58 +0000
Bug 1559489, part 4 - Remote-to-local window transplanting. r=tcampbell,bzbarsky This patch cleans up remote outer window proxies when we navigate back into the process. It adds a flag to mDanglingRemoteOuterProxies that is set in between BrowsingContext::SetDocShell(), where we can tell that the browsing context is going from being remote to being local, to nsGlobalWindowOuter::SetNewDocument(), where the local outer window proxy is actually created. Once the outer window is created, the remote window proxies can be cleaned up in CleanUpDanglingRemoteOuterWindowProxies(). The clean up is done by a process that is similar to object transplanting, except that instead of looking in the cross-compartment wrapper table for each compartment to find objects to be turned into CCWs to the new object, it looks in the remote proxy map for each compartment. SpiderMonkey doesn't know about the proxy maps, so this has to be done by a new callback object CompartmentTransplantCallback. Now that this cleanup is being done, it shouldn't be possible to wrap a remote outer window proxy when the browsing context is local, so MaybeWrapWindowProxy() can be simplified. I had to drop the assert here that the browsing context has a window proxy because during clean up we call wrap on a local outer window proxy before the BC gets the window proxy set on it. I had the assert because my original plan was to implicitly fix remote proxies during wrapping, but that is no longer necessary. Differential Revision: https://phabricator.services.mozilla.com/D38343
fce57acf934848642e939c924ef07c12a9414f05: Bug 1567059 - Add test for CSP and Bookmarklet interaction r=ckerschb,bzbarsky
Sebastian Streich <sstreich@mozilla.com> - Tue, 06 Aug 2019 19:44:05 +0000 - rev 551402
Push 2165 by ffxbld-merge at Mon, 14 Oct 2019 16:30:58 +0000
Bug 1567059 - Add test for CSP and Bookmarklet interaction r=ckerschb,bzbarsky Differential Revision: https://phabricator.services.mozilla.com/D40652
ebfc262470877db1b992ea55032d550dec4f5642: Bug 1499000 - Don't do CORS checks on CSS images with the resource:// scheme. r=bzbarsky
Emilio Cobos Álvarez <emilio@crisal.io> - Fri, 09 Aug 2019 18:09:55 +0000 - rev 550971
Push 2165 by ffxbld-merge at Mon, 14 Oct 2019 16:30:58 +0000
Bug 1499000 - Don't do CORS checks on CSS images with the resource:// scheme. r=bzbarsky CORS only works on http channels, so anything else that tries to do a CORS-enabled request fails catastrophically. resource:// images are useful for extension developers, so don't perform CORS checks on them. We may want to also do file:// and fix bug 1565509, while at it, if we consider it's causing developer pain. Differential Revision: https://phabricator.services.mozilla.com/D40651
a6a7c51f430af1b4362defeb91dcfae2de00b014: Bug 1572405 - Fix Py3 referenced before assignment error r=bzbarsky
Kagami Sascha Rosylight <saschanaz@outlook.com> - Fri, 09 Aug 2019 06:27:36 +0000 - rev 550901
Push 2165 by ffxbld-merge at Mon, 14 Oct 2019 16:30:58 +0000
Bug 1572405 - Fix Py3 referenced before assignment error r=bzbarsky `except Exception as exception` in Python 3 removes the `exception` variable in the outer scope whereas Python 2 does not. This mitigates the error caused by the Py3 behavior. Differential Revision: https://phabricator.services.mozilla.com/D41194
96efe9deb1ed2c3c91494614958c349253e59640: Bug 1523638 - Part 8: Remove unused arguments from nsDocShell::Embed(), r=bzbarsky
Nika Layzell <nika@thelayzells.com> - Thu, 08 Aug 2019 16:07:10 +0000 - rev 550786
Push 2165 by ffxbld-merge at Mon, 14 Oct 2019 16:30:58 +0000
Bug 1523638 - Part 8: Remove unused arguments from nsDocShell::Embed(), r=bzbarsky Differential Revision: https://phabricator.services.mozilla.com/D37655
20c6a0493dd9fa5bd7932715fdaa7dfe1401561c: Bug 1571272: Add missing null check. r=bzbarsky
Kris Maglione <maglione.k@gmail.com> - Tue, 06 Aug 2019 17:36:16 +0000 - rev 550376
Push 2165 by ffxbld-merge at Mon, 14 Oct 2019 16:30:58 +0000
Bug 1571272: Add missing null check. r=bzbarsky Differential Revision: https://phabricator.services.mozilla.com/D40672
c47bc0881be0b192219afd36f2a5c9cbf7f51a9c: Bug 1558915 - Use infallible nsIURI::SchemeIs in uriloader/ r=bzbarsky
Tom Schuster <evilpies@gmail.com> - Mon, 05 Aug 2019 20:08:21 +0000 - rev 550324
Push 2165 by ffxbld-merge at Mon, 14 Oct 2019 16:30:58 +0000
Bug 1558915 - Use infallible nsIURI::SchemeIs in uriloader/ r=bzbarsky Differential Revision: https://phabricator.services.mozilla.com/D40546
5ed17d4710d9b2eb5c0950b36049e267acff56c1: Bug 1571121 - Change Window.print() from using Func to Pref. r=bzbarsky
Andrew McCreight <continuation@gmail.com> - Sat, 03 Aug 2019 02:17:00 +0000 - rev 549970
Push 2165 by ffxbld-merge at Mon, 14 Oct 2019 16:30:58 +0000
Bug 1571121 - Change Window.print() from using Func to Pref. r=bzbarsky This can be done by changing the pref from being enable instead of disable. Differential Revision: https://phabricator.services.mozilla.com/D40522
eb8931554abe7caf4e7d3294aa00431d7059f26e: Bug 1570484 - Nuke Xray waivers for remote outer window proxies. r=bzbarsky,tcampbell,jonco
Andrew McCreight <continuation@gmail.com> - Mon, 05 Aug 2019 16:32:31 +0000 - rev 549955
Push 2165 by ffxbld-merge at Mon, 14 Oct 2019 16:30:58 +0000
Bug 1570484 - Nuke Xray waivers for remote outer window proxies. r=bzbarsky,tcampbell,jonco Remote outer window proxies can't be the target of a CCW, because if you attempt to wrap them we just create a new outer window proxy. Therefore, they can't be the target of an Xray wrapper, so they can't have Xray waivers that do anything useful. However, if we do a navigation from a local iframe to a remote iframe, we'll transplant a remote outer window proxy onto a local outer window proxy, which might have an Xray. This can cause some issues, particularly if we later navigate back to a different local window. To work around this, this patch nukes Xray waivers on navigation to a remote outer window proxy. This makes Xray waiver behavior inconsistent with the non-Fission behavior, but it is safer to leave the non-Fission behavior alone for now, for fear of breaking addons. Differential Revision: https://phabricator.services.mozilla.com/D40116
344a525cddbce9c754de16ca796ba642b4ae6b7b: Bug 1570484 - Nuke Xray waivers for remote outer window proxies. r=bzbarsky,tcampbell,jonco
Andrew McCreight <continuation@gmail.com> - Mon, 05 Aug 2019 14:55:43 +0000 - rev 549940
Push 2165 by ffxbld-merge at Mon, 14 Oct 2019 16:30:58 +0000
Bug 1570484 - Nuke Xray waivers for remote outer window proxies. r=bzbarsky,tcampbell,jonco Remote outer window proxies can't be the target of a CCW, because if you attempt to wrap them we just create a new outer window proxy. Therefore, they can't be the target of an Xray wrapper, so they can't have Xray waivers that do anything useful. However, if we do a navigation from a local iframe to a remote iframe, we'll transplant a remote outer window proxy onto a local outer window proxy, which might have an Xray. This can cause some issues, particularly if we later navigate back to a different local window. To work around this, this patch nukes Xray waivers on navigation to a remote outer window proxy. This makes Xray waiver behavior inconsistent with the non-Fission behavior, but it is safer to leave the non-Fission behavior alone for now, for fear of breaking addons. Differential Revision: https://phabricator.services.mozilla.com/D40116
156072a55a9ad15c70670bb9d2b1a6ad0d569066: Bug 1561015: Part 2 - Return BrowsingContext from openWindow2. r=bzbarsky
Kris Maglione <maglione.k@gmail.com> - Fri, 02 Aug 2019 20:48:40 +0000 - rev 549785
Push 2165 by ffxbld-merge at Mon, 14 Oct 2019 16:30:58 +0000
Bug 1561015: Part 2 - Return BrowsingContext from openWindow2. r=bzbarsky There are some unfortunate aspects of openWindow() and openWindow2() that make this difficult. Namely, they sometimes return top-level chrome windows, and sometimes a single content window from the top-level chrome window that they open, depending on how they're called. There really isn't any reason to return a BrowsingContext rather than a chrome window in the former case, but there also really isn't a way to make the API polymorphic in a way that would allow handling the two cases differently. So at some point, the two cases should ideally be split into separate APIs rather than separate special cases of a single API. In the mean time, I've left openWindow() returning local mozIDOMWindowProxy objects, since it isn't used by the DOM window.open() or openDialog() APIs, and only updated openWindow2(). As a follow-up, we should remove both openWindow() and openWindow2(), and replace them with openChromeWindow() and openContentWindow() (or similar) methods which make it immediately clear what type of window is being returned. Differential Revision: https://phabricator.services.mozilla.com/D35689
36f7623a522be695e4ea589bedf8ce70a5294b58: Bug 1561015: Part 1 - Use BrowsingContext in window provider APIs. r=bzbarsky,mossop
Kris Maglione <maglione.k@gmail.com> - Fri, 02 Aug 2019 20:48:33 +0000 - rev 549784
Push 2165 by ffxbld-merge at Mon, 14 Oct 2019 16:30:58 +0000
Bug 1561015: Part 1 - Use BrowsingContext in window provider APIs. r=bzbarsky,mossop This is the first step in making it possible to return remote WindowProxy objects from window.open() and related APIs. This patch also incidentally fixes a bug where getContentWindowOrOpenURI returned the top-level browser window rather than the new content window when passed OPEN_NEWWINDOW for the `aWhere` parameter. This was not the expected behavior, and was a potentially major footgun for any new users who expected to always get the content window for the URL they were loading, rather than sometimes getting a chrome browser window instead. For now, that case just returns null, which is only a minor footgun, rather than the major one we had before. Differential Revision: https://phabricator.services.mozilla.com/D35688
1417758c17c84cc49f9f9d8161084efc0096e337: Bug 1559975 - convert dom/bindings to python3 r=ahal,bzbarsky
Edwin Gao <egao@mozilla.com> - Fri, 02 Aug 2019 19:45:12 +0000 - rev 549756
Push 2165 by ffxbld-merge at Mon, 14 Oct 2019 16:30:58 +0000
Bug 1559975 - convert dom/bindings to python3 r=ahal,bzbarsky Differential Revision: https://phabricator.services.mozilla.com/D36634
aef1c437643e64d06a222cd290945eda57284250: Bug 1571031 - Change Location::Reload to take an ErroResult, since it's what both callers expect. r=bzbarsky
Emilio Cobos Álvarez <emilio@crisal.io> - Fri, 02 Aug 2019 18:02:11 +0000 - rev 549741
Push 2165 by ffxbld-merge at Mon, 14 Oct 2019 16:30:58 +0000
Bug 1571031 - Change Location::Reload to take an ErroResult, since it's what both callers expect. r=bzbarsky Not sure what you think of the `return aRv.Throw()` pattern, I find it nice, but it seems we don't use it a lot. Also Location.h is inconsistent on aError vs. aRv, if you want me to change to one or the other let me know. Differential Revision: https://phabricator.services.mozilla.com/D40450
c4265d8d03017bd648b243a62a206ccfc3a4e631: Bug 1570566 - Cleanup a bit Location::Reload() and History::Go(0). r=bzbarsky
Emilio Cobos Álvarez <emilio@crisal.io> - Fri, 02 Aug 2019 16:30:49 +0000 - rev 549731
Push 2165 by ffxbld-merge at Mon, 14 Oct 2019 16:30:58 +0000
Bug 1570566 - Cleanup a bit Location::Reload() and History::Go(0). r=bzbarsky This code was jumping through some hoops that seemed unnecessary. Given History::Go(0) already calls Location::Reload(false), seems we can just handle the new pref in one place, and also simplify the code a bit. Differential Revision: https://phabricator.services.mozilla.com/D40431
17ea0740773194cd5a8a172039a905b412f8c707: Bug 1570566 - Don't block reloading during a resize event handler on Android and Nightly. r=bzbarsky
Emilio Cobos Álvarez <emilio@crisal.io> - Fri, 02 Aug 2019 16:30:41 +0000 - rev 549730
Push 2165 by ffxbld-merge at Mon, 14 Oct 2019 16:30:58 +0000
Bug 1570566 - Don't block reloading during a resize event handler on Android and Nightly. r=bzbarsky Differential Revision: https://phabricator.services.mozilla.com/D40430
50177de640c79a804b5829253c686474a353f814: Bug 1570721 - Remove a bit of duplication in nsDocumentViewer.cpp. r=bzbarsky
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 01 Aug 2019 19:21:20 +0200 - rev 549705
Push 2165 by ffxbld-merge at Mon, 14 Oct 2019 16:30:58 +0000
Bug 1570721 - Remove a bit of duplication in nsDocumentViewer.cpp. r=bzbarsky Not happy with all these void pointer stuff, but I think this is slightly nicer to read. Also not happy with what clang-format has done to my code ;) I've removed the comment about zoom because it's not clear to me it is still relevant, but I've preserved the order because, should we have similar stuff going on, it seems slightly better, and I'm moderately sure the rest of the callers don't really care. I think closures coerced to function pointers are nicer (I considered putting this on a template or using std::function, maybe, this was less code specially given some callers of EnumerateExternalResources may or may not be hot...), but if you want me to keep stuff out of line, or move the whole thing to std::function<> or templates let me know. Differential Revision: https://phabricator.services.mozilla.com/D40249
e1f2b7b5737e072e61bbbd12058f5b9dfaf745cc: Bug 1570721 - Make nsDocumentViewer::CallChildren callbacks get an nsDocumentViewer rather than an nsIContentViewer. r=bzbarsky
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 01 Aug 2019 18:13:35 +0200 - rev 549701
Push 2165 by ffxbld-merge at Mon, 14 Oct 2019 16:30:58 +0000
Bug 1570721 - Make nsDocumentViewer::CallChildren callbacks get an nsDocumentViewer rather than an nsIContentViewer. r=bzbarsky It's the only implementation, and this will simplify future patches. Differential Revision: https://phabricator.services.mozilla.com/D40279
66cc044a4df2c4dca4540f9b80a3e71641a3bb8a: Bug 1567623 - Add Event Telemetry for cases where eval is triggered as System Principal r=chutten,bzbarsky,tcampbell
Tom Ritter <tom@mozilla.com> - Thu, 01 Aug 2019 20:45:31 +0000 - rev 549644
Push 2165 by ffxbld-merge at Mon, 14 Oct 2019 16:30:58 +0000
Bug 1567623 - Add Event Telemetry for cases where eval is triggered as System Principal r=chutten,bzbarsky,tcampbell Differential Revision: https://phabricator.services.mozilla.com/D39559
67af85c419976072424def712c414d65ae43aab5: Bug 1568051 - Don't paint during interrupt callbacks if it's not safe to run script. r=bzbarsky
Emilio Cobos Álvarez <emilio@crisal.io> - Wed, 31 Jul 2019 10:29:32 +0000 - rev 549311
Push 2165 by ffxbld-merge at Mon, 14 Oct 2019 16:30:58 +0000
Bug 1568051 - Don't paint during interrupt callbacks if it's not safe to run script. r=bzbarsky So that paint doesn't reenter on layout, or mess with incomplete frame trees, or what not. I just early-returned rather than only skipping the PaintWhileInterruptingJS call because I don't think we should be running untrusted scripts in the first place when IsSafeToRunScript() is false. Differential Revision: https://phabricator.services.mozilla.com/D39913
46208314f5af174efdfa81fb8e57238911246fe5: Bug 1459711: Ensure that navigation.performance.type is 2 when restoring a document from the session history. r=bzbarsky
Will Hawkins <whawkins@mozilla.com> - Mon, 29 Jul 2019 20:28:38 +0000 - rev 548966
Push 2165 by ffxbld-merge at Mon, 14 Oct 2019 16:30:58 +0000
Bug 1459711: Ensure that navigation.performance.type is 2 when restoring a document from the session history. r=bzbarsky Differential Revision: https://phabricator.services.mozilla.com/D39551
55be6c59850ad8c8497eefa1799826a633f60798: Bug 1569677 - Part 2: Move HTMLDocument.userInteractionForTesting to Document; r=bzbarsky
Ehsan Akhgari <ehsan@mozilla.com> - Mon, 29 Jul 2019 19:32:53 +0000 - rev 548938
Push 2165 by ffxbld-merge at Mon, 14 Oct 2019 16:30:58 +0000
Bug 1569677 - Part 2: Move HTMLDocument.userInteractionForTesting to Document; r=bzbarsky Differential Revision: https://phabricator.services.mozilla.com/D39724
13adcd98e2d261c152237b2c4e354123de6a5eb4: Bug 1569677 - Part 1: Move the Safebrowsing helpers from HTMLDocument to Document; r=bzbarsky
Ehsan Akhgari <ehsan@mozilla.com> - Mon, 29 Jul 2019 19:32:51 +0000 - rev 548937
Push 2165 by ffxbld-merge at Mon, 14 Oct 2019 16:30:58 +0000
Bug 1569677 - Part 1: Move the Safebrowsing helpers from HTMLDocument to Document; r=bzbarsky Differential Revision: https://phabricator.services.mozilla.com/D39723
a4c7c6d1e54639d399343807125ed5ee18e4ab25: Bug 1568991 - Ensure marionette event listeners are isolated from content, r=ato,bzbarsky
James Graham <james@hoppipolla.co.uk> - Mon, 29 Jul 2019 08:48:50 +0000 - rev 548892
Push 2165 by ffxbld-merge at Mon, 14 Oct 2019 16:30:58 +0000
Bug 1568991 - Ensure marionette event listeners are isolated from content, r=ato,bzbarsky Internal marionette listeners should neither be visible to content script, nor have their registation affected by changes made in content. The evaluate method was breaking these constraints by creating listeners in a sandbox with Xrays disabled, which is appropriate to the injected script itself but not to the harness-internal parts. Use a different sandbox for the harness code compared to the injected code, and move away from using onunload to using addEventListener for the unload handler. Differential Revision: https://phabricator.services.mozilla.com/D39522
ac548c2a725b66db57c81bb24accca2bbe075931: Bug 1565930, try to make Promise less error prone to compartment mismatches, r=bzbarsky
Olli Pettay <Olli.Pettay@helsinki.fi> - Mon, 29 Jul 2019 14:43:54 +0000 - rev 548885
Push 2165 by ffxbld-merge at Mon, 14 Oct 2019 16:30:58 +0000
Bug 1565930, try to make Promise less error prone to compartment mismatches, r=bzbarsky Differential Revision: https://phabricator.services.mozilla.com/D38762
1604c99e3ad1f8736ee3b92af3a853fef8a1f46a: Bug 1551621 - Downgrade an assertion for now so as to not block people. r=bzbarsky
Emilio Cobos Álvarez <emilio@crisal.io> - Wed, 24 Jul 2019 13:18:21 +0000 - rev 547743
Push 2165 by ffxbld-merge at Mon, 14 Oct 2019 16:30:58 +0000
Bug 1551621 - Downgrade an assertion for now so as to not block people. r=bzbarsky Differential Revision: https://phabricator.services.mozilla.com/D39155
3e4578cbedf1cd1c451b19ee24e86b2615aa3b04: Bug 1568278 followup: fix incorrect 'let' usage on CLOSED TREE. r=bzbarsky
Boris Zbarsky <bzbarsky@mit.edu> - Tue, 23 Jul 2019 22:00:12 -0400 - rev 547696
Push 2165 by ffxbld-merge at Mon, 14 Oct 2019 16:30:58 +0000
Bug 1568278 followup: fix incorrect 'let' usage on CLOSED TREE. r=bzbarsky
9106a2ec4ed501bc573f750a1b1cc8142e6469f3: Bug 1567808 - Remove unused HTMLInputElement::FlushFrames. r=bzbarsky
Cameron McCormack <cam@mcc.id.au> - Mon, 22 Jul 2019 14:44:17 +0000 - rev 547678
Push 2165 by ffxbld-merge at Mon, 14 Oct 2019 16:30:58 +0000
Bug 1567808 - Remove unused HTMLInputElement::FlushFrames. r=bzbarsky Differential Revision: https://phabricator.services.mozilla.com/D38831
96f1ccb955702e29793889d179ad75d6d2e4d9b8: Bug 1523638 - Part 8: Remove unused arguments from nsDocShell::Embed(), r=bzbarsky
Nika Layzell <nika@thelayzells.com> - Thu, 18 Jul 2019 19:38:20 +0000 - rev 547528
Push 2165 by ffxbld-merge at Mon, 14 Oct 2019 16:30:58 +0000
Bug 1523638 - Part 8: Remove unused arguments from nsDocShell::Embed(), r=bzbarsky Differential Revision: https://phabricator.services.mozilla.com/D37655
72f73483711f529f98180c7b9157efba7cf9218b: Bug 1543517 - Enable UTF-8 parsing of external (non-inline) and worker scripts unconditionally. r=bzbarsky
Jeff Walden <jwalden@mit.edu> - Mon, 22 Jul 2019 19:36:24 +0000 - rev 547499
Push 2165 by ffxbld-merge at Mon, 14 Oct 2019 16:30:58 +0000
Bug 1543517 - Enable UTF-8 parsing of external (non-inline) and worker scripts unconditionally. r=bzbarsky Differential Revision: https://phabricator.services.mozilla.com/D38784
4005ac2741701dfb42559375a912e1e5ac48693f: Bug 1559975 - convert dom/bindings to python3 r=ahal,bzbarsky
Edwin Gao <egao@mozilla.com> - Fri, 19 Jul 2019 14:15:00 +0000 - rev 547250
Push 2165 by ffxbld-merge at Mon, 14 Oct 2019 16:30:58 +0000
Bug 1559975 - convert dom/bindings to python3 r=ahal,bzbarsky Differential Revision: https://phabricator.services.mozilla.com/D36634
86db1d535ac582d547c03b7d7049e82da94706c2: Bug 1565942 - Allow the loading of TYPE_FONT from file: URLs, r=bzbarsky
Andrea Marchesini <amarchesini@mozilla.com> - Thu, 18 Jul 2019 20:50:59 +0000 - rev 547167
Push 2165 by ffxbld-merge at Mon, 14 Oct 2019 16:30:58 +0000
Bug 1565942 - Allow the loading of TYPE_FONT from file: URLs, r=bzbarsky Differential Revision: https://phabricator.services.mozilla.com/D38561
880fa31096045fe2c2d5d775028dea7f0967a663: Bug 1555043: Perform CSP check against target document's CSP for javascript: URIs. r=bzbarsky
Christoph Kerschbaumer <ckerschb@christophkerschbaumer.com> - Thu, 18 Jul 2019 16:57:54 +0000 - rev 547111
Push 2165 by ffxbld-merge at Mon, 14 Oct 2019 16:30:58 +0000
Bug 1555043: Perform CSP check against target document's CSP for javascript: URIs. r=bzbarsky Differential Revision: https://phabricator.services.mozilla.com/D38327