searching for reviewer(bryce)
432e429f9663a23a3be48459cc0f0fe8324d4722: Bug 1548959: enable media_codec_used in release r=bryce a=pascalc
Nils Ohlmeier [:drno] <drno@ohlmeier.org> - Tue, 07 May 2019 17:08:46 +0000 - rev 526522
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1548959: enable media_codec_used in release r=bryce a=pascalc Differential Revision: https://phabricator.services.mozilla.com/D29915
a6d52faaa77c3c7be1e3614157eb2bc15d7b488f: Bug 1542097 - Directly downmix to mono. r=bryce a=lizzard
Jean-Yves Avenard <jyavenard@mozilla.com> - Mon, 22 Apr 2019 13:27:42 +0000 - rev 526433
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1542097 - Directly downmix to mono. r=bryce a=lizzard No need to first downmix to stereo and then mono. Differential Revision: https://phabricator.services.mozilla.com/D27216
9d58201430493a7c6328ee32dcea55b3ca98a154: Bug 1545575 - stop RDD process cleanly if linux sandbox fails to init. r=bryce a=pascalc
Michael Froman <mfroman@mozilla.com> - Wed, 24 Apr 2019 16:55:03 +0000 - rev 526395
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1545575 - stop RDD process cleanly if linux sandbox fails to init. r=bryce a=pascalc Differential Revision: https://phabricator.services.mozilla.com/D28663
82662d1130d18f74646dcc3fcc3fba902e443ddc: Bug 1515497 - pt 2 - remove assert, but warn if rddOpened is false. r=bryce a=pascalc
Michael Froman <mfroman@mozilla.com> - Fri, 19 Apr 2019 21:11:33 +0000 - rev 526394
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1515497 - pt 2 - remove assert, but warn if rddOpened is false. r=bryce a=pascalc Depends on D28204 Differential Revision: https://phabricator.services.mozilla.com/D28205
6e4ff735f7bf96ef0c0a5150a8f650a500c79625: Bug 1515497 - pt 1 - eliminate fall back to av1 decoding on content process when RDD enabled. r=bryce a=pascalc
Michael Froman <mfroman@mozilla.com> - Fri, 19 Apr 2019 21:11:25 +0000 - rev 526393
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1515497 - pt 1 - eliminate fall back to av1 decoding on content process when RDD enabled. r=bryce a=pascalc If the RDD process is enabled and fails to start properly for some reason, make sure we cannot accidentally fall back to decoding AV1 on the content process. Differential Revision: https://phabricator.services.mozilla.com/D28204
9d654bcc7cae40a6158827030d6ce179ca2392a9: Bug 1545575 - stop RDD process cleanly if linux sandbox fails to init. r=bryce a=pascalc
Michael Froman <mfroman@mozilla.com> - Wed, 24 Apr 2019 16:55:03 +0000 - rev 526386
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1545575 - stop RDD process cleanly if linux sandbox fails to init. r=bryce a=pascalc Differential Revision: https://phabricator.services.mozilla.com/D28663
fb16f716d2a8a5b9abf3130b03b6c99d4000d1c8: Bug 1515497 - pt 2 - remove assert, but warn if rddOpened is false. r=bryce a=pascalc
Michael Froman <mfroman@mozilla.com> - Fri, 19 Apr 2019 21:11:33 +0000 - rev 526385
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1515497 - pt 2 - remove assert, but warn if rddOpened is false. r=bryce a=pascalc Depends on D28204 Differential Revision: https://phabricator.services.mozilla.com/D28205
ff8a1d36e4416eedc96804bf9f5574972a42298b: Bug 1515497 - pt 1 - eliminate fall back to av1 decoding on content process when RDD enabled. r=bryce a=pascalc
Michael Froman <mfroman@mozilla.com> - Fri, 19 Apr 2019 21:11:25 +0000 - rev 526384
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1515497 - pt 1 - eliminate fall back to av1 decoding on content process when RDD enabled. r=bryce a=pascalc If the RDD process is enabled and fails to start properly for some reason, make sure we cannot accidentally fall back to decoding AV1 on the content process. Differential Revision: https://phabricator.services.mozilla.com/D28204
a6c41b0eebc2d225fe633bc95554c10d233fcc02: Bug 1538508 - P1. Reset mError upon success. r=bryce a=pascalc
Narcis Beleuzu <nbeleuzu@mozilla.com> - Sat, 30 Mar 2019 21:05:53 +0200 - rev 525832
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1538508 - P1. Reset mError upon success. r=bryce a=pascalc Reviewers: bryce Reviewed By: bryce Bug #: 1538508 Differential Revision: https://phabricator.services.mozilla.com/D24869
6ca1d074411757bb68d1cebae1f547313e8c62b2: Bug 1528661 - Refactor CDM host file generation. r=bryce
Chris Pearce <cpearce@mozilla.com> - Mon, 18 Feb 2019 18:13:58 +1300 - rev 522964
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1528661 - Refactor CDM host file generation. r=bryce There's a lot of duplication in the code to generate host files, particularly in the MacOS code. So refactor out the common code into helpers, and make the code higher level and easier to understand. Differential Revision: https://phabricator.services.mozilla.com/D21508
b8397ea9e6b82c9c0ba8bcd02b832d8d131b77a1: Bug 1528661 - Pass paths to i686 xul and plugin-container binaries to CDM in host verification paths. r=bryce
Chris Pearce <cpearce@mozilla.com> - Fri, 15 Feb 2019 21:27:01 +1300 - rev 522963
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1528661 - Pass paths to i686 xul and plugin-container binaries to CDM in host verification paths. r=bryce On Windows on ARM64 we will run the x86 Widevine DLL in an x86 plugin-container.exe with an x86 xul.dll. We therefore should also pass the paths to these binaries to the CDM in the host files instead of the aarch64 plugin-container.exe. We should still pass the aarch64 xul.dll to the CDM, as that's in use by the aarch64 firefox.exe. Differential Revision: https://phabricator.services.mozilla.com/D21507
1712a35cd239049c186f7da80cdc759885ae81ae: Bug 1530835 - Set frame duration to 0 when out of order frames are seen. r=bryce
Jean-Yves Avenard <jyavenard@mozilla.com> - Fri, 01 Mar 2019 18:56:01 +0000 - rev 522907
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1530835 - Set frame duration to 0 when out of order frames are seen. r=bryce WebM specify that timestamp must be monotonically increasing. Unfortunately, this is not always the case. WebM doesn't have a concept of frame duration, the duration is calculated as being the delta between the next frame's time and the current one. So non-monotonically increasing timestamps would have caused negative duration. Differential Revision: https://phabricator.services.mozilla.com/D21687
b6ac1853674e3aeddeddc4ffafbd1521d0d6faa1: Bug 1528661 - Pass paths to i686 xul and plugin-container binaries to CDM in host verification paths. r=bryce
Chris Pearce <cpearce@mozilla.com> - Thu, 28 Feb 2019 22:34:45 +0000 - rev 522707
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1528661 - Pass paths to i686 xul and plugin-container binaries to CDM in host verification paths. r=bryce On Windows on ARM64 we will run the x86 Widevine DLL in an x86 plugin-container.exe with an x86 xul.dll. We therefore should also pass the paths to these binaries to the CDM in the host files instead of the aarch64 plugin-container.exe. We should still pass the aarch64 xul.dll to the CDM, as that's in use by the aarch64 firefox.exe. Differential Revision: https://phabricator.services.mozilla.com/D21507
4e5ac450f2b6dd57e9264fddc97971f6b5d8dc18: Bug 1530234 - P2. Don't recalculate audio sample start time. r=bryce
Jean-Yves Avenard <jyavenard@mozilla.com> - Wed, 27 Feb 2019 14:19:00 +0000 - rev 522432
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1530234 - P2. Don't recalculate audio sample start time. r=bryce The WMF audio decoder recalculated the timestamp of each audio sample according to the number of frames decoded so far. This is incompatible with the trimming mechanism that rely on the timestamps of the audio to be matching what is found in the container. All the other audio decoders do it that way already. Depends on D20969 Differential Revision: https://phabricator.services.mozilla.com/D21305
0bd5d868443675304f64f1d85866338f651f5900: Bug 1530234 - P1. Ignore init segment for audio only buffer if audio content didn't change. r=bryce
Jean-Yves Avenard <jyavenard@mozilla.com> - Wed, 27 Feb 2019 14:34:15 +0000 - rev 522431
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1530234 - P1. Ignore init segment for audio only buffer if audio content didn't change. r=bryce This prevents re-creating a new audio decoder which on Android can take an awful long time. Differential Revision: https://phabricator.services.mozilla.com/D20969
3cbb661802a7496a7045a4ef39f22253a966442a: Bug 1530918 - Use TimeUnit when seeking. r=bryce
Jean-Yves Avenard <jyavenard@mozilla.com> - Wed, 27 Feb 2019 13:12:08 +0000 - rev 522430
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1530918 - Use TimeUnit when seeking. r=bryce Differential Revision: https://phabricator.services.mozilla.com/D21320
754776b7161cd56f78777a531e2e5c344bf6a899: Bug 1222851 - Keep the one dropped frame prior the first one to prime the decoder. r=bryce
Jean-Yves Avenard <jyavenard@mozilla.com> - Fri, 22 Feb 2019 09:58:18 +0000 - rev 521686
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1222851 - Keep the one dropped frame prior the first one to prime the decoder. r=bryce Some audio decoders, such as AAC and Opus have a need for a pre-roll content. As such, in order to be able to fully get the content of the first frame we keep the frame just prior that would have normally been dropped. We set this frame to have a duration of 1us so that it will be dropped later by the decoding pipeline. The starting time of the first frame is adjusted so that we have continuous data, without gap in the buffered range. Differential Revision: https://phabricator.services.mozilla.com/D20322
1b377d3c27c385bd84a9885618102d9937e8176d: Bug 1524890 - P17. Set duration on IMF sample. r=bryce
Jean-Yves Avenard <jyavenard@mozilla.com> - Sat, 23 Feb 2019 09:28:14 +0000 - rev 521685
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1524890 - P17. Set duration on IMF sample. r=bryce We didn't set the duration on the created IMF sample before sending it to the decoder. For audio this isn't a problem as the duration is calculated from the number of frames returned. For video however, the duration appears to have been calculated by WMF as the delta of pts. However, for the last frame, the value returned was set to a value not matching our input. So we set the duration on the IMFSample so it doesn't have to make it up. Setting the duration on the IMFSample isn't sufficient with Windows 7, which still continues to calculate it based on previous samples durations. So we store the last sample duration and set it when draining. Differential Revision: https://phabricator.services.mozilla.com/D20653
fe39e68ee3834076aac3d68c59966c8f896d0cb0: Bug 1524890 - P16. Fix mochitests. r=bryce
Jean-Yves Avenard <jyavenard@mozilla.com> - Fri, 22 Feb 2019 09:21:13 +0000 - rev 521684
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1524890 - P16. Fix mochitests. r=bryce Differential Revision: https://phabricator.services.mozilla.com/D20330
4ff646d086c09aede4450bf13dc5ac14d0e85f34: Bug 1524890 - P15. [MSE] Add extra logging. r=bryce
Jean-Yves Avenard <jyavenard@mozilla.com> - Fri, 22 Feb 2019 09:21:11 +0000 - rev 521683
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1524890 - P15. [MSE] Add extra logging. r=bryce Differential Revision: https://phabricator.services.mozilla.com/D20321
d60fccd7de59934c3f057f2f6149b1edf2b69c68: Bug 1524890 - P14. Add AudioTrimmer wrapper. r=bryce
Jean-Yves Avenard <jyavenard@mozilla.com> - Sun, 24 Feb 2019 10:29:52 +0000 - rev 521682
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1524890 - P14. Add AudioTrimmer wrapper. r=bryce A simplistic decoder wrapper that will take decoded frames and truncate them should the originally compressed frame contained trimming information. Differential Revision: https://phabricator.services.mozilla.com/D20173
c4e8f8c88edf083314a06318f4eaba78f3ecc943: Bug 1524890 - P13. [MSE] Mark frames as truncated when needed. r=bryce
Jean-Yves Avenard <jyavenard@mozilla.com> - Fri, 22 Feb 2019 09:21:05 +0000 - rev 521681
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1524890 - P13. [MSE] Mark frames as truncated when needed. r=bryce There's two cases to handle. 1- A Frame isn't entirely contained between appendWindowStart and appendWindowEnd 2- A new frame is appended which overlaps partially an existing frame. To achieve this we tweak the start time and duration of the sample added (case 1), or the frame about to be partially covered (case 2). We then set a flag that will indicate to the decoder that the decompressed frame will have to be truncated. Differential Revision: https://phabricator.services.mozilla.com/D20172
9b93c2718c181e8f2b7dfc0df6a0032163626300: Bug 1524890 - P11. Remove duration from AudioData construction parameter. r=bryce
Jean-Yves Avenard <jyavenard@mozilla.com> - Fri, 22 Feb 2019 09:19:47 +0000 - rev 521679
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1524890 - P11. Remove duration from AudioData construction parameter. r=bryce It can be determined from the size of the buffer and the number of audio frames. Additionally, it ensures that the duration of the frame is always exactly what the AudioData contains. Differential Revision: https://phabricator.services.mozilla.com/D20170
08fd6ddd88e4750923b58fd8af0643a8c8d7507a: Bug 1524890 - P10. Add AudioData::SetTrimWindow. r=bryce
Jean-Yves Avenard <jyavenard@mozilla.com> - Fri, 22 Feb 2019 09:19:32 +0000 - rev 521678
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1524890 - P10. Add AudioData::SetTrimWindow. r=bryce Don't re-create a new trimmed AudioData when we want to remove some content. This remove the need for some copies. Differential Revision: https://phabricator.services.mozilla.com/D20168
731a0f1e7f215d04e6bf777e9fc3358cb406693c: Bug 1524890 - P8. Rely on buffer length to calculate the number of frames. r=bryce
Jean-Yves Avenard <jyavenard@mozilla.com> - Fri, 22 Feb 2019 09:19:00 +0000 - rev 521676
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1524890 - P8. Rely on buffer length to calculate the number of frames. r=bryce Differential Revision: https://phabricator.services.mozilla.com/D20166
926ec4aa54291ce0a7ba86342c53a246d3e7833b: Bug 1524890 - P7. No longer access AudioData::mFrames directly. r=bryce
Jean-Yves Avenard <jyavenard@mozilla.com> - Fri, 22 Feb 2019 09:18:47 +0000 - rev 521675
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1524890 - P7. No longer access AudioData::mFrames directly. r=bryce This will allow to remove mFrames member and calculate from the size of the content, which will dynamically change depending on a cropping filter. Differential Revision: https://phabricator.services.mozilla.com/D20165
66eb3b2554bdc7646884e7086f9a173c6a03efd4: Bug 1524890 - P6. Remove mFrames member from MediaData. r=bryce
Jean-Yves Avenard <jyavenard@mozilla.com> - Fri, 22 Feb 2019 09:18:33 +0000 - rev 521674
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1524890 - P6. Remove mFrames member from MediaData. r=bryce The number of frames is only meaningful with audio as a VideoData always contain a single frame. So we only have this member in AudioData, which will simplify the logic in a future commit where the number of frames present depends on the trimming filter applied. Differential Revision: https://phabricator.services.mozilla.com/D20164
f5daf84b3b7e9a02cf62f3235a56e217daf6c930: Bug 1524890 - P5. Make MediaData::Type an enum class. r=bryce
Jean-Yves Avenard <jyavenard@mozilla.com> - Fri, 22 Feb 2019 09:18:18 +0000 - rev 521673
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1524890 - P5. Make MediaData::Type an enum class. r=bryce Make its use more explicit and less likely to be incorrect. Differential Revision: https://phabricator.services.mozilla.com/D20163
90c5339325a342c3bba190d08ce3dd4564c48319: Bug 1524890 - P4. Use Span<> with AudioBufferCursor. r=bryce
Jean-Yves Avenard <jyavenard@mozilla.com> - Fri, 22 Feb 2019 09:18:05 +0000 - rev 521672
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1524890 - P4. Use Span<> with AudioBufferCursor. r=bryce And we add some strong assertions that we never read passed the end of the buffer. Differential Revision: https://phabricator.services.mozilla.com/D20162
22d4f90342efbe0893e22f4f32b725b95fcd731a: Bug 1524890 - P3. Add AudioData::Data method that returns a Span. r=bryce
Jean-Yves Avenard <jyavenard@mozilla.com> - Fri, 22 Feb 2019 09:18:04 +0000 - rev 521671
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1524890 - P3. Add AudioData::Data method that returns a Span. r=bryce So that we never access the underlying buffer directly. Differential Revision: https://phabricator.services.mozilla.com/D20161
a00f0fd94fbd070f1ecb5948aa9082526a1ecd68: Bug 1524890 - P1. Remove unused method. r=bryce
Jean-Yves Avenard <jyavenard@mozilla.com> - Fri, 22 Feb 2019 09:18:03 +0000 - rev 521669
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1524890 - P1. Remove unused method. r=bryce Differential Revision: https://phabricator.services.mozilla.com/D20159
28c58b8cd89f93f8758c6ca337fb164e2eefdd03: Bug 1525507 - P1. Don't trust mp4 container to determine if a VP9 frame is a keyframe. r=bryce
Jean-Yves Avenard <jyavenard@mozilla.com> - Wed, 06 Feb 2019 20:34:39 +0000 - rev 519538
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1525507 - P1. Don't trust mp4 container to determine if a VP9 frame is a keyframe. r=bryce Similar to what we do for H264 and for vp9 in webm, we parse the VP9 bytestream and check if a frame is a keyframe there instead. Differential Revision: https://phabricator.services.mozilla.com/D18790
c831a2e318419726ab00ff7662c17e367a192da0: Bug 1525230 - Reset ImageRect when resolution change. r=bryce
Jean-Yves Avenard <jyavenard@mozilla.com> - Thu, 07 Feb 2019 14:56:44 +0000 - rev 518577
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1525230 - Reset ImageRect when resolution change. r=bryce VideoInfo.mImageRect is typically only used for VP8/VP9 content, however the Windows decoder use a common code between H264 and VP8/VP9 decoding and use this data to determine the image size. So we end up with conflicting image size and image rect (which contains cropping data). Differential Revision: https://phabricator.services.mozilla.com/D18976
ea48bec24f70e68b506538a5dd08a46668ebbdab: Bug 1524500 - P2. Simplify logic to break loop early. r=bryce
Jean-Yves Avenard <jyavenard@mozilla.com> - Fri, 01 Feb 2019 17:45:38 +0000 - rev 517421
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1524500 - P2. Simplify logic to break loop early. r=bryce The logic was redundant with the next step that will already remove all until the next keyframe. Depends on D18321 Differential Revision: https://phabricator.services.mozilla.com/D18322
9454695495211a65c315f2bf36e4a1c7ca6d655b: Bug 1524500 - P1. Remove partial frames when the starting time falls within the removal interval. r=bryce
Jean-Yves Avenard <jyavenard@mozilla.com> - Fri, 01 Feb 2019 22:58:08 +0000 - rev 517420
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1524500 - P1. Remove partial frames when the starting time falls within the removal interval. r=bryce Per spec: https://w3c.github.io/media-source/#sourcebuffer-coded-frame-removal Step 3 of the Coded Frame Removal Interval: "Remove all media data, from this track buffer, that contain starting timestamps greater than or equal to start and less than the remove end timestamp. " So to decide if a frame should be removed from a track buffer, its start time is the only information to be used. Differential Revision: https://phabricator.services.mozilla.com/D18321
9f49631d6536a27752469cac43e60ed1f19eed55: Bug 1524119 - Properly get VP9 benchmark value. r=bryce
Jean-Yves Avenard <jyavenard@mozilla.com> - Thu, 31 Jan 2019 17:55:45 +0000 - rev 517207
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1524119 - Properly get VP9 benchmark value. r=bryce And not the threshold which is always 150. Differential Revision: https://phabricator.services.mozilla.com/D18159
daa824c92e14eb1a65c6e387ead711bc7730b630: Bug 1525230 - Reset ImageRect when resolution change. r=bryce a=RyanVM
Jean-Yves Avenard <jyavenard@mozilla.com> - Thu, 07 Feb 2019 14:56:44 +0000 - rev 515837
Push 1953 by ffxbld-merge at Mon, 11 Mar 2019 12:10:20 +0000
Bug 1525230 - Reset ImageRect when resolution change. r=bryce a=RyanVM VideoInfo.mImageRect is typically only used for VP8/VP9 content, however the Windows decoder use a common code between H264 and VP8/VP9 decoding and use this data to determine the image size. So we end up with conflicting image size and image rect (which contains cropping data). Differential Revision: https://phabricator.services.mozilla.com/D18976
f1bf2550b912d8f07c9c36cb5e64fd045405af41: Bug 1524119 - Properly get VP9 benchmark value. r=bryce a=lizzard
Jean-Yves Avenard <jyavenard@mozilla.com> - Thu, 31 Jan 2019 17:55:45 +0000 - rev 515781
Push 1953 by ffxbld-merge at Mon, 11 Mar 2019 12:10:20 +0000
Bug 1524119 - Properly get VP9 benchmark value. r=bryce a=lizzard And not the threshold which is always 150. Differential Revision: https://phabricator.services.mozilla.com/D18159
16b643f92fbf41777ed213d1caab4f343ee581ec: Bug 1524500 - P2. Simplify logic to break loop early. r=bryce a=lizzard
Jean-Yves Avenard <jyavenard@mozilla.com> - Fri, 01 Feb 2019 17:45:38 +0000 - rev 515761
Push 1953 by ffxbld-merge at Mon, 11 Mar 2019 12:10:20 +0000
Bug 1524500 - P2. Simplify logic to break loop early. r=bryce a=lizzard The logic was redundant with the next step that will already remove all until the next keyframe. Depends on D18321 Differential Revision: https://phabricator.services.mozilla.com/D18322
6eb6ad4198dab49f5fdde49055c2b97a4bcaf118: Bug 1524500 - P1. Remove partial frames when the starting time falls within the removal interval. r=bryce a=lizzard
Jean-Yves Avenard <jyavenard@mozilla.com> - Fri, 01 Feb 2019 22:58:08 +0000 - rev 515760
Push 1953 by ffxbld-merge at Mon, 11 Mar 2019 12:10:20 +0000
Bug 1524500 - P1. Remove partial frames when the starting time falls within the removal interval. r=bryce a=lizzard Per spec: https://w3c.github.io/media-source/#sourcebuffer-coded-frame-removal Step 3 of the Coded Frame Removal Interval: "Remove all media data, from this track buffer, that contain starting timestamps greater than or equal to start and less than the remove end timestamp. " So to decide if a frame should be removed from a track buffer, its start time is the only information to be used. Differential Revision: https://phabricator.services.mozilla.com/D18321
240e8dcfe721e056672052cc52bdb9c5e343d274: Bug 1513511 - P2. Ensure all frames are decoded. r=bryce
Jean-Yves Avenard <jyavenard@mozilla.com> - Mon, 17 Dec 2018 20:30:46 +0000 - rev 510981
Push 1953 by ffxbld-merge at Mon, 11 Mar 2019 12:10:20 +0000
Bug 1513511 - P2. Ensure all frames are decoded. r=bryce vp9 streams contains superframes. Ensure they are all properly handled. Differential Revision: https://phabricator.services.mozilla.com/D14699
cc808bf2a954290e3434aba99f88020a8a94e76b: Bug 1513511 - P1. Use new FFmpeg decode API with recent FFmpeg version. r=bryce
Jean-Yves Avenard <jyavenard@mozilla.com> - Mon, 17 Dec 2018 17:29:13 +0000 - rev 510980
Push 1953 by ffxbld-merge at Mon, 11 Mar 2019 12:10:20 +0000
Bug 1513511 - P1. Use new FFmpeg decode API with recent FFmpeg version. r=bryce In libavcodec 58 and later, the old avcodec_decode_video2 is broken and only return the first visible frame found after a VP9 super-frame. This resulted in some YouTube videos for about 10% of the frames to never be returned. Only the new API properly behaves so we upgrade our code to use it. Differential Revision: https://phabricator.services.mozilla.com/D14682
1b42fcc6c2533a18e8eb2a88d6c9843aff8a7934: Bug 1524500 - P2. Simplify logic to break loop early. r=bryce, a=RyanVM
Jean-Yves Avenard <jyavenard@mozilla.com> - Fri, 01 Feb 2019 17:45:38 +0000 - rev 509622
Push 1931 by ryanvm@gmail.com at Fri, 08 Feb 2019 21:14:52 +0000
Bug 1524500 - P2. Simplify logic to break loop early. r=bryce, a=RyanVM The logic was redundant with the next step that will already remove all until the next keyframe. Depends on D18321 Differential Revision: https://phabricator.services.mozilla.com/D18322
f8e028cb3d837d7711b1242adb5a2cbefa7abb50: Bug 1524500 - P1. Remove partial frames when the starting time falls within the removal interval. r=bryce, a=RyanVM
Jean-Yves Avenard <jyavenard@mozilla.com> - Fri, 01 Feb 2019 22:58:08 +0000 - rev 509621
Push 1931 by ryanvm@gmail.com at Fri, 08 Feb 2019 21:14:52 +0000
Bug 1524500 - P1. Remove partial frames when the starting time falls within the removal interval. r=bryce, a=RyanVM Per spec: https://w3c.github.io/media-source/#sourcebuffer-coded-frame-removal Step 3 of the Coded Frame Removal Interval: "Remove all media data, from this track buffer, that contain starting timestamps greater than or equal to start and less than the remove end timestamp. " So to decide if a frame should be removed from a track buffer, its start time is the only information to be used. Differential Revision: https://phabricator.services.mozilla.com/D18321
996a8c00f6f03d7ac94f035133b0a1937a909d3a: Bug 1524119 - Properly get VP9 benchmark value. r=bryce, a=RyanVM
Jean-Yves Avenard <jyavenard@mozilla.com> - Thu, 31 Jan 2019 17:55:45 +0000 - rev 509619
Push 1931 by ryanvm@gmail.com at Fri, 08 Feb 2019 21:14:52 +0000
Bug 1524119 - Properly get VP9 benchmark value. r=bryce, a=RyanVM And not the threshold which is always 150. Differential Revision: https://phabricator.services.mozilla.com/D18159
a475f96d74721bf5bfd62ef33dd2c4b186faea03: Bug 1513511 - P2. Ensure all frames are decoded. r=bryce, a=lizzard
Jean-Yves Avenard <jyavenard@mozilla.com> - Mon, 17 Dec 2018 20:30:46 +0000 - rev 509073
Push 1905 by ffxbld-merge at Mon, 21 Jan 2019 12:33:13 +0000
Bug 1513511 - P2. Ensure all frames are decoded. r=bryce, a=lizzard vp9 streams contains superframes. Ensure they are all properly handled. Differential Revision: https://phabricator.services.mozilla.com/D14699
c94560ceb417fb956ef76b80cf5a993f0273d362: Bug 1513511 - P1. Use new FFmpeg decode API with recent FFmpeg version. r=bryce, a=lizzard
Jean-Yves Avenard <jyavenard@mozilla.com> - Mon, 17 Dec 2018 17:29:13 +0000 - rev 509072
Push 1905 by ffxbld-merge at Mon, 21 Jan 2019 12:33:13 +0000
Bug 1513511 - P1. Use new FFmpeg decode API with recent FFmpeg version. r=bryce, a=lizzard In libavcodec 58 and later, the old avcodec_decode_video2 is broken and only return the first visible frame found after a VP9 super-frame. This resulted in some YouTube videos for about 10% of the frames to never be returned. Only the new API properly behaves so we upgrade our code to use it. Differential Revision: https://phabricator.services.mozilla.com/D14682
e9ba7f2783640f63dd3b931a51243e11e1410367: Bug 1503776 - Add test to verify WR qualified pref default value saved and respected on restart. r=bryce
Chris Pearce <cpearce@mozilla.com> - Thu, 22 Nov 2018 21:36:16 +0000 - rev 506977
Push 1905 by ffxbld-merge at Mon, 21 Jan 2019 12:33:13 +0000
Bug 1503776 - Add test to verify WR qualified pref default value saved and respected on restart. r=bryce Add test that when we restart the browser with a default value set on gfx.webrender.all.qualified, Firefox saves that value and checks respects the saved value when initializing WebRender. Depends on D10527 Differential Revision: https://phabricator.services.mozilla.com/D10528
2d2d1dfd04d491c928eaf2bfc3ceb504204b2cc3: Bug 1503776 - Add test to verify WR qualified pref default value saved and respected on restart. r=bryce
Chris Pearce <cpearce@mozilla.com> - Tue, 20 Nov 2018 03:52:59 +0000 - rev 506560
Push 1905 by ffxbld-merge at Mon, 21 Jan 2019 12:33:13 +0000
Bug 1503776 - Add test to verify WR qualified pref default value saved and respected on restart. r=bryce Add test that when we restart the browser with a default value set on gfx.webrender.all.qualified, Firefox saves that value and checks respects the saved value when initializing WebRender. Depends on D10527 Differential Revision: https://phabricator.services.mozilla.com/D10528
bcb35a8cb22b1d55a357fa592cfbe2418c6ae9ae: Bug 1503776 - Add test to verify WR qualified pref default value saved and respected on restart. r=bryce
Chris Pearce <cpearce@mozilla.com> - Mon, 19 Nov 2018 19:18:23 +0000 - rev 506258
Push 1905 by ffxbld-merge at Mon, 21 Jan 2019 12:33:13 +0000
Bug 1503776 - Add test to verify WR qualified pref default value saved and respected on restart. r=bryce Add test that when we restart the browser with a default value set on gfx.webrender.all.qualified, Firefox saves that value and checks respects the saved value when initializing WebRender. Depends on D10527 Differential Revision: https://phabricator.services.mozilla.com/D10528