searching for reviewer(bradwerth)
bcbd2fb36cb145358d641383eaee2efc4e09248a: Bug 1576817 - Fix a regression from bug 1490974 where we'll fail to find visibility: visible descendants of visibility: hidden nodes. r=bradwerth
Emilio Cobos Álvarez <emilio@crisal.io> - Wed, 28 Aug 2019 15:15:23 +0000 - rev 554179
Push 2165 by ffxbld-merge at Mon, 14 Oct 2019 16:30:58 +0000
Bug 1576817 - Fix a regression from bug 1490974 where we'll fail to find visibility: visible descendants of visibility: hidden nodes. r=bradwerth The split between IsDisplayedNode and IsVisibleNode is pretty intentional, since visibility: visible descendants of visiblity: hidden ancestors are in fact visible. We skip fully-invisible ranges in here instead: https://searchfox.org/mozilla-central/rev/325c1a707819602feff736f129cb36055ba6d94f/toolkit/components/find/nsFind.cpp#776 Differential Revision: https://phabricator.services.mozilla.com/D43745
3192da5a883fa09987d96159f35476351fcbf404: Bug 1576817 - Only allow finding editable anonymous nodes in form controls. r=bradwerth
Emilio Cobos Álvarez <emilio@crisal.io> - Wed, 28 Aug 2019 15:35:48 +0000 - rev 554178
Push 2165 by ffxbld-merge at Mon, 14 Oct 2019 16:30:58 +0000
Bug 1576817 - Only allow finding editable anonymous nodes in form controls. r=bradwerth We want to find the text inside the input that the user types, but not stuff like the placeholder. So check that the anonymous subtree is editable, or skip it otherwise. Differential Revision: https://phabricator.services.mozilla.com/D43744
34b4dcc475d33cdd274177acbdfa593164cef97f: Bug 1576817 - Simplify some code added in bug 1490974. r=bradwerth
Emilio Cobos Álvarez <emilio@crisal.io> - Wed, 28 Aug 2019 15:11:55 +0000 - rev 554177
Push 2165 by ffxbld-merge at Mon, 14 Oct 2019 16:30:58 +0000
Bug 1576817 - Simplify some code added in bug 1490974. r=bradwerth Differential Revision: https://phabricator.services.mozilla.com/D43743
e22f8708f313b72be680291e1c59429f579abbc0: Bug 1576230 - class should be className in UserAgentInput. r=bradwerth
Gabriel Luong <gabriel.luong@gmail.com> - Fri, 23 Aug 2019 17:52:03 +0000 - rev 553384
Push 2165 by ffxbld-merge at Mon, 14 Oct 2019 16:30:58 +0000
Bug 1576230 - class should be className in UserAgentInput. r=bradwerth Differential Revision: https://phabricator.services.mozilla.com/D43274
f5cc355f51aa846cbb998b5d49bafc2ead3bfa53: Bug 1574016. Fix logic error in patch from bug 1547277. r=bradwerth
Timothy Nikkel <tnikkel@gmail.com> - Thu, 15 Aug 2019 01:28:11 +0000 - rev 551924
Push 2165 by ffxbld-merge at Mon, 14 Oct 2019 16:30:58 +0000
Bug 1574016. Fix logic error in patch from bug 1547277. r=bradwerth The fixed still worked because we get another SetBounds call right after with the same bounds. But it does mean we are doing some useless invalidation. Differential Revision: https://phabricator.services.mozilla.com/D42059
cc691c0e8775f8b6c24b9e641a164e8d82afa924: Bug 1523844 Part 5: Add a test case to TestMobileViewportManager. r=bradwerth
Botond Ballo <botond@mozilla.com> - Mon, 12 Aug 2019 22:13:38 +0000 - rev 551439
Push 2165 by ffxbld-merge at Mon, 14 Oct 2019 16:30:58 +0000
Bug 1523844 Part 5: Add a test case to TestMobileViewportManager. r=bradwerth Depends on D41104 Differential Revision: https://phabricator.services.mozilla.com/D41453
5192a77b994c28b71bde857670eb6f1138174ec2: Bug 1572712 - Remove messages ported to fission from tunnel.js r=bradwerth,layely
Michael Ratcliffe <mratcliffe@mozilla.com> - Tue, 13 Aug 2019 10:18:05 +0000 - rev 551381
Push 2165 by ffxbld-merge at Mon, 14 Oct 2019 16:30:58 +0000
Bug 1572712 - Remove messages ported to fission from tunnel.js r=bradwerth,layely This patch removes the following messages from `devtools/client/responsive.html/browser/tunnel.js`: - Browser:Reload - Forms:MouseOut - Forms:MouseOver - FullZoom - contextmenu - ContextMenu: - Findbar: - InlineSpellChecker: - ViewSource: These features all work just fine inside RDM without being included in `devtools/client/responsive.html/browser/tunnel.js`. Differential Revision: https://phabricator.services.mozilla.com/D41386
81d748db6e07fe475edceb6bd95a689097db2ad4: Bug 1569570 - Select elements fail to display dropdown in RDM r=bradwerth,layely
Michael Ratcliffe <mratcliffe@mozilla.com> - Fri, 09 Aug 2019 15:23:33 +0000 - rev 551181
Push 2165 by ffxbld-merge at Mon, 14 Oct 2019 16:30:58 +0000
Bug 1569570 - Select elements fail to display dropdown in RDM r=bradwerth,layely The `xul:menulist` appears a little offset but this is the same as it was prior to the fission patch that completely broke it. If you have an alternate approach or a way to get the correct position for the `xul:menulist` I am all ears. Differential Revision: https://phabricator.services.mozilla.com/D40805
dbefb0308ad7e70f4037aa37db869efb8d1eebc3: Bug 1572114 - Don't bother blocking onload for already-complete shape images. r=bradwerth
Emilio Cobos Álvarez <emilio@crisal.io> - Wed, 07 Aug 2019 17:17:05 +0000 - rev 550531
Push 2165 by ffxbld-merge at Mon, 14 Oct 2019 16:30:58 +0000
Bug 1572114 - Don't bother blocking onload for already-complete shape images. r=bradwerth That way we don't need to re-request a reflow. This code can run from reflow itself, so requesting a reflow from here can break invariants. There's the question of whether this code should be running at all for continuations, but this patch fixes a bug regardless of whether we do that or not. Differential Revision: https://phabricator.services.mozilla.com/D41021
3749ea604ad9274259291efdc86eddd4a8b8192b: Bug 1574016. Fix logic error in patch from bug 1547277. r=bradwerth, a=RyanVM
Timothy Nikkel <tnikkel@gmail.com> - Thu, 15 Aug 2019 01:28:11 +0000 - rev 545230
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1574016. Fix logic error in patch from bug 1547277. r=bradwerth, a=RyanVM The fixed still worked because we get another SetBounds call right after with the same bounds. But it does mean we are doing some useless invalidation. Differential Revision: https://phabricator.services.mozilla.com/D42059
408c173a1316d89d2532ced63f6f37f7854b66cb: Bug 1569570 - Select elements fail to display dropdown in RDM. r=bradwerth,layely, a=RyanVM
Michael Ratcliffe <mratcliffe@mozilla.com> - Fri, 09 Aug 2019 15:23:33 +0000 - rev 545094
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1569570 - Select elements fail to display dropdown in RDM. r=bradwerth,layely, a=RyanVM The `xul:menulist` appears a little offset but this is the same as it was prior to the fission patch that completely broke it. If you have an alternate approach or a way to get the correct position for the `xul:menulist` I am all ears. Differential Revision: https://phabricator.services.mozilla.com/D40805
6cd1a545ba83a30f3429c0d37005fef5ccae2e5a: Bug 1556131 - P2. Don't attempt to needlessly change preference during test. r=bradwerth
Jean-Yves Avenard <jyavenard@mozilla.com> - Thu, 13 Jun 2019 15:55:48 +0000 - rev 541674
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1556131 - P2. Don't attempt to needlessly change preference during test. r=bradwerth In an attempt to reduce intermittent failures, the pref apz.keyboard.enabled is set to false. However, this preference is only ever read once, on startup before any JS test has a chance to run and modify the pref.. It doesn't do what it was thought to do. Differential Revision: https://phabricator.services.mozilla.com/D34860
1949d95ea16d7dc20f19f28ad648c325f3c0d233: Bug 1351487 - Part 2: Add tests for ensuring that window screen sizing values reported in RDM are correct. r=bradwerth
Micah Tigley <mtigley@mozilla.com> - Wed, 05 Jun 2019 00:29:36 +0000 - rev 539824
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1351487 - Part 2: Add tests for ensuring that window screen sizing values reported in RDM are correct. r=bradwerth Depends on D32410 Differential Revision: https://phabricator.services.mozilla.com/D33678
4325a177cf16078bde91d9968e4e395edcccc01a: Bug 1351487 - Part 1: In RDM, return the window's inner rect size as the screen's availWidth/availHeight and width/height values. r=Ehsan,bradwerth
Micah Tigley <mtigley@mozilla.com> - Wed, 05 Jun 2019 15:44:04 +0000 - rev 539823
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1351487 - Part 1: In RDM, return the window's inner rect size as the screen's availWidth/availHeight and width/height values. r=Ehsan,bradwerth Differential Revision: https://phabricator.services.mozilla.com/D32410
9700d8ac7dad743f10ced61f1209264c9235be14: Bug 1107456 - Part 2: Test that RDM's viewport's outer size values remain unaffected at different zoom levels. r=bradwerth
Micah Tigley <mtigley@mozilla.com> - Fri, 31 May 2019 17:45:21 +0000 - rev 539314
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1107456 - Part 2: Test that RDM's viewport's outer size values remain unaffected at different zoom levels. r=bradwerth Depends on D32778 Differential Revision: https://phabricator.services.mozilla.com/D33239
1a8ef8583a0bb15ef763484d52af06427ef2a118: Bug 1107456 - Part 1: While in RDM, scale the inner size values of the viewport using the device's full zoom to find its outer size. r=bradwerth,Ehsan
Micah Tigley <mtigley@mozilla.com> - Thu, 30 May 2019 23:37:14 +0000 - rev 539313
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1107456 - Part 1: While in RDM, scale the inner size values of the viewport using the device's full zoom to find its outer size. r=bradwerth,Ehsan We want to ensure the RDM browser's outer window sizes are not affected as the page is zoomed in or out. In the context of RDM, the size of the browser window will be the same as the viewport so I believe it's safe to assume that the window's outer size will be equal to its inner size when the zoom level is set to 100%. I found we can get this value by using the presentation context's `GetDeviceZullZoom` method and applying it to the inner sizes of the RDM viewport. Differential Revision: https://phabricator.services.mozilla.com/D32778
a3edc47a8b676ee9bc1707c9a01e303e2360ec84: Bug 1352070 - Part 2: RDM tests for ensuring that the values for the selected device's outerHeight/outerWidth properties are correct. r=bradwerth
Micah Tigley <mtigley@mozilla.com> - Fri, 24 May 2019 16:58:53 +0000 - rev 538293
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1352070 - Part 2: RDM tests for ensuring that the values for the selected device's outerHeight/outerWidth properties are correct. r=bradwerth Depends on D32253 Differential Revision: https://phabricator.services.mozilla.com/D32352
e61809618043028020fccde2731fb499fc2c4110: Bug 1526975: Filter out implicit grid line names in text-property-editor's autocomplete. r=gl,bradwerth
Micah Tigley <mtigley@mozilla.com> - Tue, 21 May 2019 21:29:02 +0000 - rev 537689
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1526975: Filter out implicit grid line names in text-property-editor's autocomplete. r=gl,bradwerth Differential Revision: https://phabricator.services.mozilla.com/D21308
1256739720ca8dca77a035c72d8e62977d90a990: Bug 1357774 - Part 1: Add a 'SetCurrentRDMPaneOrientation' WebIDL extension on the Document r=bradwerth,smaug
Micah Tigley <mtigley@mozilla.com> - Thu, 16 May 2019 20:31:13 +0000 - rev 536117
Push 2082 by ffxbld-merge at Mon, 01 Jul 2019 08:34:18 +0000
Bug 1357774 - Part 1: Add a 'SetCurrentRDMPaneOrientation' WebIDL extension on the Document r=bradwerth,smaug Differential Revision: https://phabricator.services.mozilla.com/D29455
90ff166702b5dd7e9848eef62746457b11d8fe92: Bug 1357774 - Part 1: Add a 'SetCurrentRDMPaneOrientation' WebIDL extension on the Document r=bradwerth,smaug
Micah Tigley <mtigley@mozilla.com> - Tue, 14 May 2019 23:42:30 +0000 - rev 535770
Push 2082 by ffxbld-merge at Mon, 01 Jul 2019 08:34:18 +0000
Bug 1357774 - Part 1: Add a 'SetCurrentRDMPaneOrientation' WebIDL extension on the Document r=bradwerth,smaug Differential Revision: https://phabricator.services.mozilla.com/D29455
f6e53afcd5ebe2324f4b4b04c4d108bcbd3195a5: Bug 1531982 Part 2: Update test expectations to check that implicit line names from implicit named areas are assigned to lines. r=bradwerth
Micah Tigley <mtigley@mozilla.com> - Wed, 17 Apr 2019 17:19:09 +0000 - rev 531803
Push 2082 by ffxbld-merge at Mon, 01 Jul 2019 08:34:18 +0000
Bug 1531982 Part 2: Update test expectations to check that implicit line names from implicit named areas are assigned to lines. r=bradwerth Differential Revision: https://phabricator.services.mozilla.com/D21298
89590e4e8dac12c2ee9c4a2aaaee845fc44f26d1: Bug 1531982 Part 1: Assign correct line names to reversed implicit areas r=bradwerth
Micah Tigley <mtigley@mozilla.com> - Wed, 17 Apr 2019 17:19:01 +0000 - rev 531802
Push 2082 by ffxbld-merge at Mon, 01 Jul 2019 08:34:18 +0000
Bug 1531982 Part 1: Assign correct line names to reversed implicit areas r=bradwerth Differential Revision: https://phabricator.services.mozilla.com/D21297
e6333b7c1331dd7c04d27cbf51c8e25eb201d8b3: Bug 1530462: Adjust reftest 'float-retry-push-image.html' to allow for rounding error on linear-gradient edge. r=bradwerth
Daniel Holbert <dholbert@cs.stanford.edu> - Tue, 26 Feb 2019 16:50:08 +0000 - rev 522079
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1530462: Adjust reftest 'float-retry-push-image.html' to allow for rounding error on linear-gradient edge. r=bradwerth And while we're at it, update the reference case to have "Reference" in its title, so that the reference case and testcases are easier to distinguish when viewing them side-by-side in several tabs. Differential Revision: https://phabricator.services.mozilla.com/D21045
7a5bfc35d78933c87fe71f4cba89ce641cff5b27: Bug 1512665 - Clear changes only when parent document navigates, not iframes; r=bradwerth
Razvan Caliman <rcaliman@mozilla.com> - Thu, 13 Dec 2018 16:19:08 +0000 - rev 510402
Push 1953 by ffxbld-merge at Mon, 11 Mar 2019 12:10:20 +0000
Bug 1512665 - Clear changes only when parent document navigates, not iframes; r=bradwerth Differential Revision: https://phabricator.services.mozilla.com/D14460
23693d234e3707f419b60eac254633031ef94dd5: Bug 1512665 - Clear changes only when parent document navigates, not iframes; r=bradwerth, a=RyanVM
Razvan Caliman <rcaliman@mozilla.com> - Thu, 13 Dec 2018 16:19:08 +0000 - rev 509006
Push 1905 by ffxbld-merge at Mon, 21 Jan 2019 12:33:13 +0000
Bug 1512665 - Clear changes only when parent document navigates, not iframes; r=bradwerth, a=RyanVM Differential Revision: https://phabricator.services.mozilla.com/D14460
0f02ec66af19136b49ecbcb4a21596b8330b1f1c: Bug 1506170 - Clear the changes stored on the actor upon page refresh/navigate; r=bradwerth
Razvan Caliman <rcaliman@mozilla.com> - Mon, 03 Dec 2018 20:13:46 +0000 - rev 508488
Push 1905 by ffxbld-merge at Mon, 21 Jan 2019 12:33:13 +0000
Bug 1506170 - Clear the changes stored on the actor upon page refresh/navigate; r=bradwerth Until we implement intentional persistence of changes between page refreshes, the Changes actor should clear its stack of changes to avoid polluting the next DevTools session. Differential Revision: https://phabricator.services.mozilla.com/D13618
7ac08d9d34640922c7b9593eb9ca3d12f56432b7: Bug 1508293 - Update comment for TRACK_CHANGE event in Changes reducer; r=bradwerth
Razvan Caliman <rcaliman@mozilla.com> - Mon, 26 Nov 2018 15:55:36 +0000 - rev 507552
Push 1905 by ffxbld-merge at Mon, 21 Jan 2019 12:33:13 +0000
Bug 1508293 - Update comment for TRACK_CHANGE event in Changes reducer; r=bradwerth Differential Revision: https://phabricator.services.mozilla.com/D12768
4d64c04547950e8dc8d45a3278db998b230f70b1: Bug 1506916 - Remove obsolete ChangesManager; r=bradwerth
Razvan Caliman <rcaliman@mozilla.com> - Tue, 13 Nov 2018 21:27:20 +0000 - rev 505391
Push 1905 by ffxbld-merge at Mon, 21 Jan 2019 12:33:13 +0000
Bug 1506916 - Remove obsolete ChangesManager; r=bradwerth The ChangesManager has been made obsolete by the use of the Changes front. Differential Revision: https://phabricator.services.mozilla.com/D11801
50586a989dc409ddb1dd16b7cbc99381b45cd259: Bug 1503871 Change all of the debugger.css SVG mask URLs to use resource scheme. r=bradwerth
Brad Werth <bwerth@mozilla.com> - Thu, 08 Nov 2018 13:37:34 -0500 - rev 504745
Push 1905 by ffxbld-merge at Mon, 21 Jan 2019 12:33:13 +0000
Bug 1503871 Change all of the debugger.css SVG mask URLs to use resource scheme. r=bradwerth Bug #: 1503871 Differential Revision: https://phabricator.services.mozilla.com/D11101
6e528251fad42087432100835b1e3fe8c59f5fec: Bug 1504387 - Remove preference "layout.css.shape-outside.enabled". r=bradwerth,xidorn
Ting-Yu Lin <tlin@mozilla.com> - Mon, 05 Nov 2018 15:27:36 +0000 - rev 503680
Push 1905 by ffxbld-merge at Mon, 21 Jan 2019 12:33:13 +0000
Bug 1504387 - Remove preference "layout.css.shape-outside.enabled". r=bradwerth,xidorn shape-outside, shape-margin, shape-image-threshold have been shipped in Firefox 62. We can remove the preference. The change in devtools/shared/css/generated/properties-db.js is generated by "./mach devtools-css-db" The actual shape-image CORS mode tests in file_shape_outside_CORS.html are moved into test_shape_outside_CORS.html because we don't need the <iframe> trick to enable the feature. Differential Revision: https://phabricator.services.mozilla.com/D10804
d34c32dab9c91e636c11e2192d449c535f6ed2bd: Bug 1504078 - Use references in the shapes code. r=bradwerth,TYLin
Emilio Cobos Álvarez <emilio@crisal.io> - Fri, 02 Nov 2018 18:19:06 +0000 - rev 503421
Push 1905 by ffxbld-merge at Mon, 21 Jan 2019 12:33:13 +0000
Bug 1504078 - Use references in the shapes code. r=bradwerth,TYLin It doesn't make much sense to return const UniquePtr<Foo>& for something that can't be null, it's just confusing. Also make more stuff actually const. Differential Revision: https://phabricator.services.mozilla.com/D10647
6e831cc55b0c32636e299c959e7a63470ac96ddc: Bug 1488762: Soften an assertion about sign of free space in flex layout, since absurdly large sizes can cause it to fail. r=bradwerth
Daniel Holbert <dholbert@cs.stanford.edu> - Fri, 26 Oct 2018 00:58:40 +0000 - rev 502300
Push 1905 by ffxbld-merge at Mon, 21 Jan 2019 12:33:13 +0000
Bug 1488762: Soften an assertion about sign of free space in flex layout, since absurdly large sizes can cause it to fail. r=bradwerth Differential Revision: https://phabricator.services.mozilla.com/D9876
57f9b3c8803318d2783a38b4bf14287613b96891: Backout bug 1418470 in beta. r=bradwerth, a=jcristau
Emilio Cobos Álvarez <emilio@crisal.io> - Fri, 09 Nov 2018 16:35:04 +0100 - rev 501133
Push 1864 by ffxbld-merge at Mon, 03 Dec 2018 15:51:40 +0000
Backout bug 1418470 in beta. r=bradwerth, a=jcristau
9217bce3d56119840999271a3627f8a4b55b9d9d: Bug 1500608: Don't skip the flex-item early-freeze for devtools after all. r=bradwerth
Daniel Holbert <dholbert@cs.stanford.edu> - Fri, 19 Oct 2018 22:05:46 +0000 - rev 500720
Push 1864 by ffxbld-merge at Mon, 03 Dec 2018 15:51:40 +0000
Bug 1500608: Don't skip the flex-item early-freeze for devtools after all. r=bradwerth This patch basically reverts the functional part of changeset 52bd865d757c. I'd optimistically hoped we could skip this early-freeze in order to compute & report a bit more "potential flexing" information via devtools. Bbut it turns out that breaks assertions & produces bogus information for flex items whose base size vs. min/max-clamped "hypothetical" sizes are very different. (Specifically: it produces nonsense for flex items whose base sizes, if unclamped, would reverse the directionality of flexing.) Differential Revision: https://phabricator.services.mozilla.com/D9304
c13ad6a94911842a64575de9085c421ef667e8fd: Bug 1499875 part 2: Give mochitest test_flex_items.html some tests for a flex container that has multiple passes of flex-grow + clamping. r=bradwerth
Daniel Holbert <dholbert@cs.stanford.edu> - Fri, 19 Oct 2018 06:04:26 +0000 - rev 500527
Push 1864 by ffxbld-merge at Mon, 03 Dec 2018 15:51:40 +0000
Bug 1499875 part 2: Give mochitest test_flex_items.html some tests for a flex container that has multiple passes of flex-grow + clamping. r=bradwerth Depends on D9152 Differential Revision: https://phabricator.services.mozilla.com/D9169
18152a7b3fa5e5145b87629c4adf38bfbaf11194: Bug 1499875 part 1: Adjust existing tests/content in test_flex_items.html to prepare for additional flex containers to be added. r=bradwerth
Daniel Holbert <dholbert@cs.stanford.edu> - Thu, 18 Oct 2018 23:47:47 +0000 - rev 500526
Push 1864 by ffxbld-merge at Mon, 03 Dec 2018 15:51:40 +0000
Bug 1499875 part 1: Adjust existing tests/content in test_flex_items.html to prepare for additional flex containers to be added. r=bradwerth Differential Revision: https://phabricator.services.mozilla.com/D9152
48155e26a841cdf691af533a74c958e566c6e2b5: Bug 1498281: Make flexbox devtools API report actual flex base size (not its min/max-clamped version). r=bradwerth
Daniel Holbert <dholbert@cs.stanford.edu> - Thu, 18 Oct 2018 23:45:51 +0000 - rev 500515
Push 1864 by ffxbld-merge at Mon, 03 Dec 2018 15:51:40 +0000
Bug 1498281: Make flexbox devtools API report actual flex base size (not its min/max-clamped version). r=bradwerth This patch also updates the expectations in the mochitest test_flex_items.html. Before this commit, the test (incorrectly) expected the mainBaseSize API to return some items' *final sizes*, because that's what our implementation did return, up until now. As of this patch, that API will now return the item's actual flex base size, which means the text expectations need to change. I'm also adding a new flex item to the test, to exercise a formerly-untested scenario. And to accommodate this new item, I'm also doubling the width of the flex container to be sure there's plenty of space. Differential Revision: https://phabricator.services.mozilla.com/D8476
2ce0ac92bee586c4e67a302929e1532ec8831505: Bug 1499542 part 3: Give test_flex_items.html an item that's trivially clamped to small max-size. r=bradwerth
Daniel Holbert <dholbert@cs.stanford.edu> - Wed, 17 Oct 2018 19:15:15 +0000 - rev 500473
Push 1864 by ffxbld-merge at Mon, 03 Dec 2018 15:51:40 +0000
Bug 1499542 part 3: Give test_flex_items.html an item that's trivially clamped to small max-size. r=bradwerth Depends on D9018 Differential Revision: https://phabricator.services.mozilla.com/D9019
3ea646bde4de4772a439a31798406287d2be685e: Bug 1499542 part 2: Skip frozen flex items when recording grow-vs-shrink state and deltas. r=bradwerth
Daniel Holbert <dholbert@cs.stanford.edu> - Wed, 17 Oct 2018 18:52:33 +0000 - rev 500472
Push 1864 by ffxbld-merge at Mon, 03 Dec 2018 15:51:40 +0000
Bug 1499542 part 2: Skip frozen flex items when recording grow-vs-shrink state and deltas. r=bradwerth Frozen flex items have already been clamped to their min/max sizes, so their size-change isn't a "how much we want to flex" measurement, and it's not useful for determining whether the rest of the line is shrinking. This patch is just adding a `if (!item->IsFrozen())` check around some code, and reindenting that code, and adjusting a few comments. This change is necessary to avoid failing the "GrowthState" assertions, because (for example) a flex item that's clamped to a small max-width could fool us into thinking we're in a "shrinking" state (since its final size is smaller than its base size), even though really we're in a "growth" state and the item was simply clamped. We avoid this problem by skipping (potentially-clamped) frozen items when determining the line's GrowthState. Depends on D8922 Differential Revision: https://phabricator.services.mozilla.com/D9018
52bd865d757c2787845e1bb79ed3936484d6ce3b: Bug 1499542 part 1: Don't do early-freeze of flexible-but-doomed-to-be-clamped flex items, if devtools are active. r=bradwerth
Daniel Holbert <dholbert@cs.stanford.edu> - Thu, 18 Oct 2018 23:44:42 +0000 - rev 500471
Push 1864 by ffxbld-merge at Mon, 03 Dec 2018 15:51:40 +0000
Bug 1499542 part 1: Don't do early-freeze of flexible-but-doomed-to-be-clamped flex items, if devtools are active. r=bradwerth We'd like to be able to record the "desired" (pre-clamped) delta size from tentatively flexing for these items. That size would be computed during a loop of the flex layout algorithm -- but we can't do that if we freeze them before we start flexing. So let's bypass this early freeze so they get a chance to compute this tentative size, even though they can never have it. Differential Revision: https://phabricator.services.mozilla.com/D8922
f6642653fb17ce9626fdc8afdba6208fcbe0e7fb: Bug 1499569: Rewrite test_flex_items.html to be simpler & easier to extend. r=bradwerth
Daniel Holbert <dholbert@cs.stanford.edu> - Wed, 17 Oct 2018 21:42:54 +0000 - rev 500306
Push 1864 by ffxbld-merge at Mon, 03 Dec 2018 15:51:40 +0000
Bug 1499569: Rewrite test_flex_items.html to be simpler & easier to extend. r=bradwerth Primary changes: - Rewrap some lines that are too long. - Adjust some failure-messages with s/has/should have/ etc. - Replace 'nearlyEqual' function with the standard mochitest 'isfuzzy()' API (which is like 'is()' with an extra epsilon arg) - Remove dependence on hardcoded element IDs, and simply walk over the flex container's children in order instead (still noting each child node and making sure it matches the node in the flex API). Differential Revision: https://phabricator.services.mozilla.com/D8933
daf3e491e6fff54278e1564b7b7c25f115076e1c: Bug 1499569: Rewrite test_flex_items.html to be simpler & easier to extend. r=bradwerth
Daniel Holbert <dholbert@cs.stanford.edu> - Wed, 17 Oct 2018 03:14:10 +0000 - rev 500039
Push 1864 by ffxbld-merge at Mon, 03 Dec 2018 15:51:40 +0000
Bug 1499569: Rewrite test_flex_items.html to be simpler & easier to extend. r=bradwerth Primary changes: - Rewrap some lines that are too long. - Adjust some failure-messages with s/has/should have/ etc. - Replace 'nearlyEqual' function with the standard mochitest 'isfuzzy()' API (which is like 'is()' with an extra epsilon arg) - Remove dependence on hardcoded element IDs, and simply walk over the flex container's children in order instead (still noting each child node and making sure it matches the node in the flex API). Differential Revision: https://phabricator.services.mozilla.com/D8933
7b79b0c12ac040ae9fae2d0483b7a9831cc3761b: Bug 1487537: Add reftest to exercise a scenario where presence of scrollbars influences the need for scrollbars. r=bradwerth
Daniel Holbert <dholbert@cs.stanford.edu> - Tue, 25 Sep 2018 11:30:45 -0700 - rev 496707
Push 1864 by ffxbld-merge at Mon, 03 Dec 2018 15:51:40 +0000
Bug 1487537: Add reftest to exercise a scenario where presence of scrollbars influences the need for scrollbars. r=bradwerth
d119ab830e82a8548e275a47ef2f8f568ac69857: Bug 1480254: Fix typo in nsLayoutUtils::MinSizeContributionForAxis to actually check the specified axis (rather than checking enum value for truthiness). r=bradwerth
Daniel Holbert <dholbert@cs.stanford.edu> - Wed, 01 Aug 2018 22:56:26 +0000 - rev 487559
Push 1815 by ffxbld-merge at Mon, 15 Oct 2018 10:40:45 +0000
Bug 1480254: Fix typo in nsLayoutUtils::MinSizeContributionForAxis to actually check the specified axis (rather than checking enum value for truthiness). r=bradwerth Differential Revision: https://phabricator.services.mozilla.com/D2634
33ff92501b9b1c81c60803130d66aa1dc0467662: Bug 1477856: In flexbox devtools API, report max-width:none as +infinity. r=bradwerth
Daniel Holbert <dholbert@cs.stanford.edu> - Fri, 27 Jul 2018 21:38:46 +0000 - rev 486592
Push 1815 by ffxbld-merge at Mon, 15 Oct 2018 10:40:45 +0000
Bug 1477856: In flexbox devtools API, report max-width:none as +infinity. r=bradwerth Previously we were just directly converting this nscoord sentinel-value representation (NS_UNCONSTRAINEDSIZE) into CSS pixels and producing a particular bogus number of pixels. Differential Revision: https://phabricator.services.mozilla.com/D2432
fd4e874f6c6fd0a64d3119e1d5949f88a6d0c411: bug 1455177 do not resize but only hide window when bounds make the window empty r=bradwerth
Karl Tomlinson <karlt+@karlt.net> - Thu, 19 Apr 2018 13:37:50 +1200 - rev 471319
Push 1728 by jlund@mozilla.com at Mon, 18 Jun 2018 21:12:27 +0000
bug 1455177 do not resize but only hide window when bounds make the window empty r=bradwerth This restores behavior to that prior to https://hg.mozilla.org/mozilla-central/rev/cb0eda54dfab#l1.139 MozReview-Commit-ID: Kf8TCl7Xsg3
850a68535455e5eedc65ac441c3451417d3f0cf0: Bug 1437655: Remove unreachable "return" statement in nsRuleNode::SetDefaultOnRoot. r=bradwerth
Daniel Holbert <dholbert@cs.stanford.edu> - Mon, 12 Feb 2018 12:29:18 -0800 - rev 458496
Push 1683 by sfraser@mozilla.com at Thu, 26 Apr 2018 16:43:40 +0000
Bug 1437655: Remove unreachable "return" statement in nsRuleNode::SetDefaultOnRoot. r=bradwerth MozReview-Commit-ID: FNph063E3HU
a8e1fa44ff6498e36a8ec3c2d5f43ea0c0830695: Bug 1437599: Remove unreachable 'return' statement from nsIFrame::GetShapeBoxBorderRadii. r=bradwerth
Daniel Holbert <dholbert@cs.stanford.edu> - Mon, 12 Feb 2018 09:43:39 -0800 - rev 458416
Push 1683 by sfraser@mozilla.com at Thu, 26 Apr 2018 16:43:40 +0000
Bug 1437599: Remove unreachable 'return' statement from nsIFrame::GetShapeBoxBorderRadii. r=bradwerth MozReview-Commit-ID: ARNoCSShQVf
39ec8e1d686a8a80269229322d307a2c6c8ab7a1: Bug 1434658: Simplify getComputedStyle behavior for "min-{width,height}:auto" to *always* return "auto" for flex/grid items, per CSSWG resolution. r=bradwerth
Daniel Holbert <dholbert@cs.stanford.edu> - Wed, 31 Jan 2018 13:45:11 -0500 - rev 457115
Push 1683 by sfraser@mozilla.com at Thu, 26 Apr 2018 16:43:40 +0000
Bug 1434658: Simplify getComputedStyle behavior for "min-{width,height}:auto" to *always* return "auto" for flex/grid items, per CSSWG resolution. r=bradwerth This change is in response to this CSSWG resolution: "RESOLVED: compute min-width/min-height: auto to auto" https://github.com/w3c/csswg-drafts/issues/2230#issuecomment-362009042 ...which was later clarified as only being applicable to grid/flex items (in both axes). Other layout modes may get further min-width/min-height clarification, but for now we'll leave that behavior the same (returning 0 from getComputedStyle). MozReview-Commit-ID: 2wLYDAOj9I6
39df8f124f56562ec4d0d8295934c95b5c455441: Bug 1423378 Part 2: Update tests to check line names around empty auto-fit grids. r=bradwerth
Mats Palmgren <mats@mozilla.com> - Sat, 16 Dec 2017 14:56:00 +0200 - rev 452411
Push 1648 by mtabara@mozilla.com at Thu, 01 Mar 2018 12:45:47 +0000
Bug 1423378 Part 2: Update tests to check line names around empty auto-fit grids. r=bradwerth