searching for reviewer(botond)
d1397dcc127d154e794327a9df9d1263892cf060: Bug 1647735 - In RDM, ICB fallback width should be the simulated device's width if larger than the desktop viewport default. r=botond, a=RyanVM
Micah Tigley <mtigley@mozilla.com> - Fri, 10 Jul 2020 18:26:31 +0000 - rev 605738
Push 2380 by ffxbld-merge at Mon, 20 Jul 2020 19:35:47 +0000
Bug 1647735 - In RDM, ICB fallback width should be the simulated device's width if larger than the desktop viewport default. r=botond, a=RyanVM Differential Revision: https://phabricator.services.mozilla.com/D82311
69016cdd3f2e60c68b6aed82110cd35f84bb540c: Bug 1643884 - Don't run APZCCallbackHelper::NotifyPinchGesture synchronously to avoid re-entrancy in InputQueue::ProcessQueue. r=botond
Kartikaya Gupta <kgupta@mozilla.com> - Fri, 12 Jun 2020 16:45:28 +0000 - rev 603264
Push 2380 by ffxbld-merge at Mon, 20 Jul 2020 19:35:47 +0000
Bug 1643884 - Don't run APZCCallbackHelper::NotifyPinchGesture synchronously to avoid re-entrancy in InputQueue::ProcessQueue. r=botond Differential Revision: https://phabricator.services.mozilla.com/D79459
5fc6a75cec34d46302d538e8aa2ac6812ab68d73: Bug 1644829 - Avoid using SimpleTest.is etc. in helper subtests run by runSubtestsSeriallyInFreshWindows. r=botond
Kartikaya Gupta <kgupta@mozilla.com> - Wed, 10 Jun 2020 19:35:48 +0000 - rev 602710
Push 2380 by ffxbld-merge at Mon, 20 Jul 2020 19:35:47 +0000
Bug 1644829 - Avoid using SimpleTest.is etc. in helper subtests run by runSubtestsSeriallyInFreshWindows. r=botond Using `SimpleTest.is` directly instead of the "global" `is` installed by runSubtestsSeriallyInFreshWindows means that the helper test filename doesn't get emitted in the assertions, which is a nice thing to have. (Ditto for `ok` and friends). Problematic tests identified using: for helper in helper_*.html; do if [[ $(grep "$helper" test_group*) ]]; then echo $helper; grep -e 'SimpleTest.\(is\|ok\)' "$helper"; fi; done While it would be nice to catch this sort of thing directly in the code, it's a bit tricky to do because SimpleTest.(ok|is) do get used legitimately by helper methods that are used by group subtests and top-level tests. Depends on D79171 Differential Revision: https://phabricator.services.mozilla.com/D79172
affabc9da77a85deb1537dc714d5edcb15ec012a: Bug 1644829 - Add an `isnot` reflection to the subtest window as well. r=botond
Kartikaya Gupta <kgupta@mozilla.com> - Wed, 10 Jun 2020 19:35:45 +0000 - rev 602709
Push 2380 by ffxbld-merge at Mon, 20 Jul 2020 19:35:47 +0000
Bug 1644829 - Add an `isnot` reflection to the subtest window as well. r=botond Depends on D79170 Differential Revision: https://phabricator.services.mozilla.com/D79171
7adac05ff314cd6ba936fb20c06d83cbdc618630: Bug 1644829 - For consistency ensure all tests that use runSubtestsSeriallyInFreshWindows have a _group in the name. r=botond
Kartikaya Gupta <kgupta@mozilla.com> - Wed, 10 Jun 2020 19:34:47 +0000 - rev 602708
Push 2380 by ffxbld-merge at Mon, 20 Jul 2020 19:35:47 +0000
Bug 1644829 - For consistency ensure all tests that use runSubtestsSeriallyInFreshWindows have a _group in the name. r=botond Differential Revision: https://phabricator.services.mozilla.com/D79170
4e8f6c10f0cb78564a585f17d2d96a7ede71f388: Bug 1643459 - Remove APZ:TransformEnd observer after subtest is done. r=botond
Kartikaya Gupta <kgupta@mozilla.com> - Wed, 10 Jun 2020 19:27:51 +0000 - rev 602695
Push 2380 by ffxbld-merge at Mon, 20 Jul 2020 19:35:47 +0000
Bug 1643459 - Remove APZ:TransformEnd observer after subtest is done. r=botond Differential Revision: https://phabricator.services.mozilla.com/D79173
e97e16b4d3ebae8c30bb8121b9ac57b14afb4005: Bug 1644512 - Reduce headers included in nsLayoutUtils.h. r=botond
Kartikaya Gupta <kgupta@mozilla.com> - Tue, 09 Jun 2020 19:34:36 +0000 - rev 602501
Push 2380 by ffxbld-merge at Mon, 20 Jul 2020 19:35:47 +0000
Bug 1644512 - Reduce headers included in nsLayoutUtils.h. r=botond Differential Revision: https://phabricator.services.mozilla.com/D78954
3346f60d3fa72741bdde67feb985bdfb211134ad: Bug 1644180 - Don't make an async zoom container of a layer that isn't async scrollable. r=botond
Kartikaya Gupta <kgupta@mozilla.com> - Tue, 09 Jun 2020 04:35:45 +0000 - rev 602350
Push 2380 by ffxbld-merge at Mon, 20 Jul 2020 19:35:47 +0000
Bug 1644180 - Don't make an async zoom container of a layer that isn't async scrollable. r=botond Differential Revision: https://phabricator.services.mozilla.com/D78840
76279f0a6d33d6fe128a9f3aabe5393e52181818: Bug 1536833 - Fix overscroll effect on Android r=botond,geckoview-reviewers,agi
James Willcox <snorp@snorp.net> - Mon, 08 Jun 2020 17:13:28 +0000 - rev 602196
Push 2380 by ffxbld-merge at Mon, 20 Jul 2020 19:35:47 +0000
Bug 1536833 - Fix overscroll effect on Android r=botond,geckoview-reviewers,agi Differential Revision: https://phabricator.services.mozilla.com/D78130
6a37740e8d2ee05ce14470568578f44e260e3421: Bug 1632268. Take into account resolution when position select drop downs and form autocomplete. r=botond
Timothy Nikkel <tnikkel@gmail.com> - Mon, 08 Jun 2020 05:45:47 +0000 - rev 602082
Push 2380 by ffxbld-merge at Mon, 20 Jul 2020 19:35:47 +0000
Bug 1632268. Take into account resolution when position select drop downs and form autocomplete. r=botond One note about this solution: it includes the apz callback transform for the root scroll frame of the root content document, but no other apz callback transform that might be on an ancestor of the select element. Differential Revision: https://phabricator.services.mozilla.com/D78026
de41c0019f5348e29858d5600b447ed0b3b5ab55: Bug 1632268. Add browser chrome test for select dropdown position with pinch (apz) zooming. r=botond
Timothy Nikkel <tnikkel@gmail.com> - Mon, 08 Jun 2020 05:45:34 +0000 - rev 602081
Push 2380 by ffxbld-merge at Mon, 20 Jul 2020 19:35:47 +0000
Bug 1632268. Add browser chrome test for select dropdown position with pinch (apz) zooming. r=botond Differential Revision: https://phabricator.services.mozilla.com/D78025
6237102f005d965efebc464ce3f93dec32b10268: Bug 1619169 - Expand the given size with the ratio of the dynamic toolbar max height to the display size in ExpandHeightForDynamicToolbar. r=botond
Hiroyuki Ikezoe <hikezoe.birchill@mozilla.com> - Sat, 06 Jun 2020 04:45:02 +0000 - rev 601996
Push 2380 by ffxbld-merge at Mon, 20 Jul 2020 19:35:47 +0000
Bug 1619169 - Expand the given size with the ratio of the dynamic toolbar max height to the display size in ExpandHeightForDynamicToolbar. r=botond In some cases the visible area has been already scaled to a certain scale _visually_ to fit the content to the display, whereas we apply the max height of the dynamic toolbar to the visible area as it is [1], which means the resolution of the each value mismatches. Ideally this mismatch should be fixed by factoring the resolution differece, but there are some edge cases we can't simply fix it as I described in bug 1641166. So, here we take a different approach which is not affected by the content visible area's resolution value. [1] https://searchfox.org/mozilla-central/rev/598e50d2c3cd81cd616654f16af811adceb08f9f/layout/base/nsPresContext.cpp#2527 [2] https://bugzilla.mozilla.org/show_bug.cgi?id=1641166 Differential Revision: https://phabricator.services.mozilla.com/D78441
b2e402b376f92c8df865b481ca48ba55db5bacbb: Bug 1619169 - Duplicate ExpandHeightForViewportUnits to ExpandHeightForDynamicToolbar. r=botond
Hiroyuki Ikezoe <hikezoe.birchill@mozilla.com> - Sat, 06 Jun 2020 04:44:54 +0000 - rev 601995
Push 2380 by ffxbld-merge at Mon, 20 Jul 2020 19:35:47 +0000
Bug 1619169 - Duplicate ExpandHeightForViewportUnits to ExpandHeightForDynamicToolbar. r=botond And use the duplicated one at the places where we need the expanded size for interactions with the dynamic toolbar on the compositor. The new function will be modified in the next commit. Note that the only one remaining call site of ExpandHeightForViewportUnits is for window.inner{Width,Height}. For window.inner{Width,Height} we don't yet return the layout viewport (which might be expanded by the minimum-scale), it's going to be fixed in bug 1598487 [1], but it's not ready to fix because there also need fixes in comm-central (see dependencies in the bug). So for now, we should keep the current behavior for window.inner{Width,Height}. Also note that it's not yet clear whether we will eventually replace the last call site of ExpandHeightForViewportUnits with ExpandHeightForDynamicToolbar since the value corresponding to the dynamic toolbar might _NOT_ be affected by the minimum-scale in some cases. See bug 1641166 for details. [1] https://bugzilla.mozilla.org/show_bug.cgi?id=1598487 [2] https://bugzilla.mozilla.org/show_bug.cgi?id=1641166 Differential Revision: https://phabricator.services.mozilla.com/D78440
b830bc407224b171a91ed3e9e128030c020b7fdd: Bug 1627708 - Record pinch source in a telemetry histogram. r=botond
Kartikaya Gupta <kgupta@mozilla.com> - Sat, 06 Jun 2020 00:32:26 +0000 - rev 601991
Push 2380 by ffxbld-merge at Mon, 20 Jul 2020 19:35:47 +0000
Bug 1627708 - Record pinch source in a telemetry histogram. r=botond Differential Revision: https://phabricator.services.mozilla.com/D77829
7b356f85d775897e81541c48e3aeec1b48e345ba: Bug 1627708 - Add a PinchGestureSource enum that indicates the source of a PinchGestureInput event. r=botond
Kartikaya Gupta <kgupta@mozilla.com> - Sat, 06 Jun 2020 00:32:19 +0000 - rev 601990
Push 2380 by ffxbld-merge at Mon, 20 Jul 2020 19:35:47 +0000
Bug 1627708 - Add a PinchGestureSource enum that indicates the source of a PinchGestureInput event. r=botond Differential Revision: https://phabricator.services.mozilla.com/D77828
82f34f32a892ed53e861e338abbaa58610b4cd2c: Bug 1640783. Should only call ClearPendingVisualScrollUpdate if we painted to the widget. r=botond
Timothy Nikkel <tnikkel@gmail.com> - Wed, 03 Jun 2020 07:50:16 +0000 - rev 601418
Push 2380 by ffxbld-merge at Mon, 20 Jul 2020 19:35:47 +0000
Bug 1640783. Should only call ClearPendingVisualScrollUpdate if we painted to the widget. r=botond If we called PaintFrame for drawWindow or something other than painting to the widget the visual scroll update won't make it to the compositor, so don't clear it. This doesn't fix anything specifically, just noticed it while reading code. Differential Revision: https://phabricator.services.mozilla.com/D76781
432c1dcd0c220d79fb0ce9f20146c020e07e6c78: Bug 1254030 - Fix size of drag image outline when nglayout.enable_drag_images=false. r=botond
Kartikaya Gupta <kgupta@mozilla.com> - Mon, 01 Jun 2020 21:40:34 +0000 - rev 601137
Push 2380 by ffxbld-merge at Mon, 20 Jul 2020 19:35:47 +0000
Bug 1254030 - Fix size of drag image outline when nglayout.enable_drag_images=false. r=botond The positioning isn't right, but it's not right even without APZ zooming, so this patch doesn't mess with it. Differential Revision: https://phabricator.services.mozilla.com/D77437
9a2d13756c44a60d244c9e95071ba8aed925c02c: Bug 1254030 - Fix positioning of drag images with APZ zoom applied. r=botond
Kartikaya Gupta <kgupta@mozilla.com> - Mon, 01 Jun 2020 21:42:19 +0000 - rev 601136
Push 2380 by ffxbld-merge at Mon, 20 Jul 2020 19:35:47 +0000
Bug 1254030 - Fix positioning of drag images with APZ zoom applied. r=botond This adjusts the position at which the drag images appear when doing drag actions, so that they appear where you would expect when APZ zoom is applied. There doesn't seem to be a good way to test this, but I did a bunch of manual testing, with all the possible expansions of this sentence: Dragging {a small image,a large image,some text} in {an iframe,the root content document}, with {,no }zooming applied. In all cases, the drag image/text should appear such that the part under the cursor is the same as what was under the cursor on the original rendering of the page. Differential Revision: https://phabricator.services.mozilla.com/D77436
145c05a9fdf0f7382a17553f224252353587e1c7: Bug 1254030 - Scale drag image by APZ zoom. r=botond
Kartikaya Gupta <kgupta@mozilla.com> - Mon, 01 Jun 2020 21:40:39 +0000 - rev 601135
Push 2380 by ffxbld-merge at Mon, 20 Jul 2020 19:35:47 +0000
Bug 1254030 - Scale drag image by APZ zoom. r=botond When rasterizing the drag image, we pick up the resolution from ancestor presShells and ensure that the drag image is rasterized at that resolution, with appropriate limits for memory usage. Differential Revision: https://phabricator.services.mozilla.com/D77435
a6eed456d959bc518a155bd1673eede04e26bd8b: Bug 1621781 - Have APZ ignore mouse events when RDM is active. r=botond
Micah Tigley <mtigley@mozilla.com> - Mon, 01 Jun 2020 16:10:08 +0000 - rev 601086
Push 2380 by ffxbld-merge at Mon, 20 Jul 2020 19:35:47 +0000
Bug 1621781 - Have APZ ignore mouse events when RDM is active. r=botond Depends on D77395 Differential Revision: https://phabricator.services.mozilla.com/D77396
4cbcf8cdb97d96c8fef28406f571935896c2e69d: Bug 1621781 - Add an "IsRDMTouchSimulationActive" field to ScrollMetadata. r=botond
Micah Tigley <mtigley@mozilla.com> - Sat, 30 May 2020 03:15:22 +0000 - rev 601085
Push 2380 by ffxbld-merge at Mon, 20 Jul 2020 19:35:47 +0000
Bug 1621781 - Add an "IsRDMTouchSimulationActive" field to ScrollMetadata. r=botond Differential Revision: https://phabricator.services.mozilla.com/D77395
470e06a5696e2a1c57fe955f58e0ad35b7c489f2: Bug 1643884 - Don't run APZCCallbackHelper::NotifyPinchGesture synchronously to avoid re-entrancy in InputQueue::ProcessQueue. r=botond, a=jcristau
Kartikaya Gupta <kgupta@mozilla.com> - Fri, 12 Jun 2020 16:45:28 +0000 - rev 600758
Push 2357 by ffxbld-merge at Mon, 22 Jun 2020 15:16:15 +0000
Bug 1643884 - Don't run APZCCallbackHelper::NotifyPinchGesture synchronously to avoid re-entrancy in InputQueue::ProcessQueue. r=botond, a=jcristau Differential Revision: https://phabricator.services.mozilla.com/D79459
a5fe71693070d3fea7a60d09eef4452fddbb5704: Bug 1621781 - Have APZ ignore mouse events when RDM is active. r=botond
Micah Tigley <mtigley@mozilla.com> - Fri, 29 May 2020 21:38:07 +0000 - rev 600457
Push 2357 by ffxbld-merge at Mon, 22 Jun 2020 15:16:15 +0000
Bug 1621781 - Have APZ ignore mouse events when RDM is active. r=botond Depends on D77395 Differential Revision: https://phabricator.services.mozilla.com/D77396
58a9b7f50a4b25c8ec8205e8d79d608abff017d1: Bug 1621781 - Add an "IsRDMTouchSimulationActive" field to ScrollMetadata. r=botond
Micah Tigley <mtigley@mozilla.com> - Fri, 29 May 2020 21:03:06 +0000 - rev 600456
Push 2357 by ffxbld-merge at Mon, 22 Jun 2020 15:16:15 +0000
Bug 1621781 - Add an "IsRDMTouchSimulationActive" field to ScrollMetadata. r=botond Differential Revision: https://phabricator.services.mozilla.com/D77395
bc9732b590eb4c99c2aa1a76d0b2b91445069c69: Bug 1640223 - Expand the given size in ExpandHeightForViewportUnits by multiplying the 'vh value / visible area height'. r=botond
Hiroyuki Ikezoe <hikezoe.birchill@mozilla.com> - Fri, 29 May 2020 17:18:21 +0000 - rev 600442
Push 2357 by ffxbld-merge at Mon, 22 Jun 2020 15:16:15 +0000
Bug 1640223 - Expand the given size in ExpandHeightForViewportUnits by multiplying the 'vh value / visible area height'. r=botond The viewport units size doesn't match the aspect ratio of the screen size in some cases. For example, in the case of the reftest in this commit, the meta viewport is "width=1600, height=device-height" and the screen size during reftest is "800x1000". Thus the viewport units size will be "1600x1000". In such cases with the old way ExpandHeightForViewportUnits shrinks the given size "1600x1800" to "1600x1000" with 100px dynamic toolbar max height (and the MOZ_ASSERT in the function happens on debug builds). Differential Revision: https://phabricator.services.mozilla.com/D77176
7042555d785f37e984e9be94a2737712997c04f4: Bug 1627012 - Add a mochitest. r=botond
Kartikaya Gupta <kgupta@mozilla.com> - Wed, 27 May 2020 22:11:20 +0000 - rev 600044
Push 2357 by ffxbld-merge at Mon, 22 Jun 2020 15:16:15 +0000
Bug 1627012 - Add a mochitest. r=botond Depends on D76815 Differential Revision: https://phabricator.services.mozilla.com/D76816
cae3fa76f1226163c1cc4225a8d7ad2dff798232: Bug 1627012 - Move promiseOneEvent to apz_test_utils.js and generalize it slightly. r=botond
Kartikaya Gupta <kgupta@mozilla.com> - Thu, 28 May 2020 01:55:48 +0000 - rev 600043
Push 2357 by ffxbld-merge at Mon, 22 Jun 2020 15:16:15 +0000
Bug 1627012 - Move promiseOneEvent to apz_test_utils.js and generalize it slightly. r=botond This is a useful function for non-fission tests too. Depends on D76814 Differential Revision: https://phabricator.services.mozilla.com/D76815
9bd88bca864409c3901d386c0df64c0608dd1174: Bug 1627012 - Make pinchZoomInWithTouch an async function. r=botond
Kartikaya Gupta <kgupta@mozilla.com> - Wed, 27 May 2020 21:59:59 +0000 - rev 600042
Push 2357 by ffxbld-merge at Mon, 22 Jun 2020 15:16:15 +0000
Bug 1627012 - Make pinchZoomInWithTouch an async function. r=botond This is specifically needed because the new test I'm adding uses both pinchZoomInWithTouch and forceLayerTreeToCompositor, and it seems hard/impossible to make that work unless both are async functions or both are non-async generator functions. And in general I think we want to move away from the generator-style tests and towards async-style tests as they are cleaner and more flexible. So this migrates helper_basic_zoom along with turning pinchZoomInWithTouch into an async function. Depends on D76813 Differential Revision: https://phabricator.services.mozilla.com/D76814
d829a9b89a5ebcdd53beaa1c30ff52d9b6fb8318: Bug 1627012 - Extract a couple of helper methods to make pinch-zooming easier in tests. r=botond
Kartikaya Gupta <kgupta@mozilla.com> - Thu, 28 May 2020 01:53:21 +0000 - rev 600041
Push 2357 by ffxbld-merge at Mon, 22 Jun 2020 15:16:15 +0000
Bug 1627012 - Extract a couple of helper methods to make pinch-zooming easier in tests. r=botond Depends on D76812 Differential Revision: https://phabricator.services.mozilla.com/D76813
47328d6c1b40f32d45d266acb93c31ac9deb0041: Bug 1627012 - Update the APZC scroll offset to the main thread's visual scroll offset for new APZCs. r=botond
Kartikaya Gupta <kgupta@mozilla.com> - Thu, 28 May 2020 01:56:43 +0000 - rev 600040
Push 2357 by ffxbld-merge at Mon, 22 Jun 2020 15:16:15 +0000
Bug 1627012 - Update the APZC scroll offset to the main thread's visual scroll offset for new APZCs. r=botond This is the main fix for the bug. When APZ is getting metrics from the main thread "for the first time" it should accept the visual scroll offset in the main thread metrics. Normally one would expect the isFirstPaint flag to be set on this call to NotifyLayersUpdated, but that seems to only ever be set on the very first paint of a presShell. In particular it is not set after a tabswitch because the brower's async tab switching mechanism means that the layer tree is already cached in the compositor. Differential Revision: https://phabricator.services.mozilla.com/D76812
76db5106df729a063326eb9d810426a6a97037fe: Bug 1627012 - Ensure NotifyLayersUpdated doesn't get called with bogus scrollable rects. r=botond
Kartikaya Gupta <kgupta@mozilla.com> - Wed, 27 May 2020 21:28:17 +0000 - rev 600039
Push 2357 by ffxbld-merge at Mon, 22 Jun 2020 15:16:15 +0000
Bug 1627012 - Ensure NotifyLayersUpdated doesn't get called with bogus scrollable rects. r=botond SetScrollableFrameMetrics uses a bogus scrollable rect (-1, -1, -1, -1) if none is provided. With the next patch, we start using this bogus rect for clamping the scroll offset on some calls to NotifyLayersUpdated, and causes the gtest to fail. If we provide some sane rect it all works fine. Depends on D76810 Differential Revision: https://phabricator.services.mozilla.com/D76811
d8421ae6242ef5d1c66440f1e3531c471c7c0c19: Bug 1627012 - Add/improve logging around visual scroll offset. r=botond
Kartikaya Gupta <kgupta@mozilla.com> - Thu, 28 May 2020 01:55:52 +0000 - rev 600038
Push 2357 by ffxbld-merge at Mon, 22 Jun 2020 15:16:15 +0000
Bug 1627012 - Add/improve logging around visual scroll offset. r=botond Differential Revision: https://phabricator.services.mozilla.com/D76810
dff341c51c450decf60f7d8f2a34c73e8fa7383b: Bug 1641246 - Remove nsDisplayResolution. r=botond
Kartikaya Gupta <kgupta@mozilla.com> - Wed, 27 May 2020 22:17:09 +0000 - rev 600023
Push 2357 by ffxbld-merge at Mon, 22 Jun 2020 15:16:15 +0000
Bug 1641246 - Remove nsDisplayResolution. r=botond Differential Revision: https://phabricator.services.mozilla.com/D77111
5cf3ae77ccb3d6eb8604c74a0413b5c5384439bb: Bug 1640387 - Only set HitResult::mTargetIsRoot for confirmed-root targets. r=snorp,botond
Kartikaya Gupta <kgupta@mozilla.com> - Tue, 26 May 2020 16:30:12 +0000 - rev 599571
Push 2357 by ffxbld-merge at Mon, 22 Jun 2020 15:16:15 +0000
Bug 1640387 - Only set HitResult::mTargetIsRoot for confirmed-root targets. r=snorp,botond Differential Revision: https://phabricator.services.mozilla.com/D76594
9d73ccaaccd2d35dae362391e8cdd44cd3f9c9d2: Bug 1640387 - Combine a few loose fields in APZCTreeManager into a HitTestResult. r=botond
Kartikaya Gupta <kgupta@mozilla.com> - Mon, 25 May 2020 17:22:46 +0000 - rev 599570
Push 2357 by ffxbld-merge at Mon, 22 Jun 2020 15:16:15 +0000
Bug 1640387 - Combine a few loose fields in APZCTreeManager into a HitTestResult. r=botond Differential Revision: https://phabricator.services.mozilla.com/D76593
f5409e1328456446d77187dbfcf7cfe824985ab8: Bug 1640381. Make ViewportUtils::IsZoomedContentRoot handle print preview documents. r=botond
Timothy Nikkel <tnikkel@gmail.com> - Mon, 25 May 2020 17:33:47 +0000 - rev 599446
Push 2357 by ffxbld-merge at Mon, 22 Jun 2020 15:16:15 +0000
Bug 1640381. Make ViewportUtils::IsZoomedContentRoot handle print preview documents. r=botond In print preview documents the child of the root scroll frame is a page sequence frame. I did a basic test of pinch zooming and panning (in a debug build and in an opt build) around on a print preview document and it seemed to work fine. Differential Revision: https://phabricator.services.mozilla.com/D76591
d355173a6259a44a9a9df4206bfb9de5b660d1d0: Bug 1467380 - Default to sticky axis-lock. r=botond
wesj <we.j@live.com> - Mon, 25 May 2020 18:11:14 +0000 - rev 599420
Push 2357 by ffxbld-merge at Mon, 22 Jun 2020 15:16:15 +0000
Bug 1467380 - Default to sticky axis-lock. r=botond Differential Revision: https://phabricator.services.mozilla.com/D76174
6191dcf6f130dd30fe25b93836231b0d122bc3e9: Bug 1636273. Fix calculation of scroll position in AsyncPanZoomController::HandleDragEvent. r=kats,botond
Timothy Nikkel <tnikkel@gmail.com> - Thu, 21 May 2020 02:41:41 +0000 - rev 599161
Push 2357 by ffxbld-merge at Mon, 22 Jun 2020 15:16:15 +0000
Bug 1636273. Fix calculation of scroll position in AsyncPanZoomController::HandleDragEvent. r=kats,botond The scroll position and scrollable rect are inside the zoom boundary so we need to use the composisted size inside the zoom boundary as well. Differential Revision: https://phabricator.services.mozilla.com/D76089
cf2455791acb8fb01373cf82109e39f9aafafc03: Bug 1624495 - Support move only arguments such as UniquePtr in FunctionRef. r=botond
Chris Fronk <fronkc1@gmail.com> - Thu, 21 May 2020 01:56:57 +0000 - rev 598735
Push 2357 by ffxbld-merge at Mon, 22 Jun 2020 15:16:15 +0000
Bug 1624495 - Support move only arguments such as UniquePtr in FunctionRef. r=botond Differential Revision: https://phabricator.services.mozilla.com/D68707
e450d28d57a072882cb4846aa1ed082317a24f39: Bug 1634595 - Move the element out of pendingScrollPayload before recording r=botond
sefeng <sefeng@mozilla.com> - Wed, 20 May 2020 19:35:30 +0000 - rev 598670
Push 2357 by ffxbld-merge at Mon, 22 Jun 2020 15:16:15 +0000
Bug 1634595 - Move the element out of pendingScrollPayload before recording r=botond The lock we added in `GetPendingScrollPayload` and `RemovePendingScrollPayload` are released at the end of the function, not at when we finish using the underlying data, thus we may still end up recording a payload that has been deleted. To fix this, we introduce a new method to move the data from the hashtable into the array argument while the lock is held, then the caller can iterate over the array safely. Differential Revision: https://phabricator.services.mozilla.com/D76052
96c90df47bdab0cebeed56e31dbaf2d9ed5b97f6: Bug 1632789. Teach PresShell::ProcessSynthMouseMoveEvent to understand desktop zooming. r=botond
Timothy Nikkel <tnikkel@gmail.com> - Thu, 30 Apr 2020 01:35:40 +0000 - rev 598101
Push 2357 by ffxbld-merge at Mon, 22 Jun 2020 15:16:15 +0000
Bug 1632789. Teach PresShell::ProcessSynthMouseMoveEvent to understand desktop zooming. r=botond Basically, we use nsLayoutUtils::TransformPoint (which understands desktop zooming) instead of nsView::ConvertFromParentCoords (which doesn't). Differential Revision: https://phabricator.services.mozilla.com/D72340
1256cc14812b94ec6988e64dd6e8e65504230853: Bug 1634616 - Calculate a perfect square based on the viewport size and rotate it to adjust the partial prerender area for rotation transforms. r=botond
Hiroyuki Ikezoe <hikezoe.birchill@mozilla.com> - Tue, 12 May 2020 21:24:40 +0000 - rev 596831
Push 2357 by ffxbld-merge at Mon, 22 Jun 2020 15:16:15 +0000
Bug 1634616 - Calculate a perfect square based on the viewport size and rotate it to adjust the partial prerender area for rotation transforms. r=botond Differential Revision: https://phabricator.services.mozilla.com/D74521
f17da81e3e57d49388b5d4027fc403f336db1de9: Bug 1634616 - Use un-transformed dirty rect to compute partial prerender area. r=botond
Hiroyuki Ikezoe <hikezoe.birchill@mozilla.com> - Tue, 12 May 2020 20:58:27 +0000 - rev 596830
Push 2357 by ffxbld-merge at Mon, 22 Jun 2020 15:16:15 +0000
Bug 1634616 - Use un-transformed dirty rect to compute partial prerender area. r=botond Differential Revision: https://phabricator.services.mozilla.com/D73404
ca2b5b79e4884881b08b2b9e9dace1adb54b2078: Bug 1634616 - Unscale pre-render area for transform animations too. r=botond
Hiroyuki Ikezoe <hikezoe.birchill@mozilla.com> - Tue, 12 May 2020 20:58:09 +0000 - rev 596829
Push 2357 by ffxbld-merge at Mon, 22 Jun 2020 15:16:15 +0000
Bug 1634616 - Unscale pre-render area for transform animations too. r=botond Differential Revision: https://phabricator.services.mozilla.com/D74520
53da1ae188f45a78d759445b2d6eaab9fe4d4919: Bug 1634616 - Calculate a perfect square based on the viewport size and rotate it to adjust the partial prerender area for rotation transforms. r=botond
Hiroyuki Ikezoe <hikezoe.birchill@mozilla.com> - Tue, 12 May 2020 08:32:45 +0000 - rev 596662
Push 2357 by ffxbld-merge at Mon, 22 Jun 2020 15:16:15 +0000
Bug 1634616 - Calculate a perfect square based on the viewport size and rotate it to adjust the partial prerender area for rotation transforms. r=botond Differential Revision: https://phabricator.services.mozilla.com/D74521
60271de42eb86630d00d83cd66c1342c02341584: Bug 1634616 - Use un-transformed dirty rect to compute partial prerender area. r=botond
Hiroyuki Ikezoe <hikezoe.birchill@mozilla.com> - Tue, 12 May 2020 08:32:33 +0000 - rev 596661
Push 2357 by ffxbld-merge at Mon, 22 Jun 2020 15:16:15 +0000
Bug 1634616 - Use un-transformed dirty rect to compute partial prerender area. r=botond Differential Revision: https://phabricator.services.mozilla.com/D73404
4279b1647e47b3e042eed1c0675814c1de7c0967: Bug 1634616 - Unscale pre-render area for transform animations too. r=botond
Hiroyuki Ikezoe <hikezoe.birchill@mozilla.com> - Tue, 12 May 2020 08:32:15 +0000 - rev 596660
Push 2357 by ffxbld-merge at Mon, 22 Jun 2020 15:16:15 +0000
Bug 1634616 - Unscale pre-render area for transform animations too. r=botond Differential Revision: https://phabricator.services.mozilla.com/D74520
715ea15fc504bac27714c4c1a7ca4cd181e45f27: Bug 1557160. Stop Event::GetScreenCoords from converting from visual to layout coords. r=botond
Timothy Nikkel <tnikkel@gmail.com> - Tue, 12 May 2020 04:53:37 +0000 - rev 596640
Push 2357 by ffxbld-merge at Mon, 22 Jun 2020 15:16:15 +0000
Bug 1557160. Stop Event::GetScreenCoords from converting from visual to layout coords. r=botond Screen coords are not layout coords. Differential Revision: https://phabricator.services.mozilla.com/D74788
9e0ab86e29e39c3223f2adc07cf24920c4ad3e07: Bug 1622360 - Remove remaining render root stuff in APZ. r=botond
Kartikaya Gupta <kgupta@mozilla.com> - Mon, 11 May 2020 20:08:16 +0000 - rev 596576
Push 2357 by ffxbld-merge at Mon, 22 Jun 2020 15:16:15 +0000
Bug 1622360 - Remove remaining render root stuff in APZ. r=botond Differential Revision: https://phabricator.services.mozilla.com/D74406
df64720ecc0d888133b5795e7ee6add95d988ff5: Bug 1622360 - Remove render roots from APZ sampling codepath. r=botond
Kartikaya Gupta <kgupta@mozilla.com> - Mon, 11 May 2020 20:08:15 +0000 - rev 596575
Push 2357 by ffxbld-merge at Mon, 22 Jun 2020 15:16:15 +0000
Bug 1622360 - Remove render roots from APZ sampling codepath. r=botond Differential Revision: https://phabricator.services.mozilla.com/D74405