searching for reviewer(birtles)
9f687685a13cb1b0015cfb2f98821e624b42754a: Bug 1534884 - Add new animation warning for animations overridden by important rules. r=birtles
Boris Chiou <boris.chiou@gmail.com> - Fri, 28 Jun 2019 18:18:08 +0000 - rev 543439
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1534884 - Add new animation warning for animations overridden by important rules. r=birtles We move the check of important rule and animation level into KeyframeEffect::ShouldBlockAsyncTransformAnimations(), and add a new warning for it. Note: 1. ShouldBlockAsyncTransformAnimations() only cares about transforms. And for other compositor animation properties, we count on HasEffectiveAnimationOfPropertySet() (in IsMatchForCompositor()). 2. If we check the important rules in both EffectCompositor::HasAnimationsForCompositor() and ActiveLayerTracker::IsTransformMaybeAnimated(), we may get the incorrect animation warnings (i.e. TransformFrameInactive). In most cases, we check these two functions together, so perhaps move the check of important rules outside HasEffectiveAnimationOfPropertySet() is fine. Besides, ActiveLayerTracker just tracks if there is a style change on this property (or display item) on the active layers, so should be OK to not check important rules in it. So IsMatchForCompositor() should check all transform-like properties, instead of each one, to get the correct result. (That's why we have to refactor KeyframeEffect::GetPropertiesForCompositor() as well.) Differential Revision: https://phabricator.services.mozilla.com/D34432
25ed16786ef943e467c94bff2189a5dc25b0b38e: Bug 1560704 - Revert the change `transform-style: inherit` added to ::-moz-table-wrapper in ua.css. r=birtles
Hiroyuki Ikezoe <hikezoe@mozilla.com> - Wed, 26 Jun 2019 10:29:37 +0000 - rev 542985
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1560704 - Revert the change `transform-style: inherit` added to ::-moz-table-wrapper in ua.css. r=birtles It caused rendering issues just like a reftest in this commit. We don't know the reason but fixing it will be some amount of work which couldn't be uplifted to 68. So we just revert the change here now. Probably we should revisit the problem once we got a bug report that the lack of the `transform-style: inherit` causes rendering issues. Differential Revision: https://phabricator.services.mozilla.com/D35946
0e84cf2872e7002304a700246ae709a8a3a6d9da: Bug 1557563 - Add computed value ZeroToOneNumber r=emilio,birtles
violet <violet.bugreport@gmail.com> - Sun, 23 Jun 2019 23:01:47 +0000 - rev 542742
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1557563 - Add computed value ZeroToOneNumber r=emilio,birtles Correctly handle clamping to 1 behavior of grayscale(), invert(), opacity() and sepia(). Differential Revision: https://phabricator.services.mozilla.com/D35509
17869bc540e5fde8961a19497c3cbb4a4de631f3: Bug 1557793 part 1. Fix incorrect template arguments in AnimationPerformanceWarning. r=birtles
Boris Zbarsky <bzbarsky@mit.edu> - Sun, 09 Jun 2019 22:00:41 +0000 - rev 541091
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1557793 part 1. Fix incorrect template arguments in AnimationPerformanceWarning. r=birtles It looks like bug 1321412 changed the number of params but didn't update the template parameter, and then bug 1364221 followed its example of not matching the template parameter to the actual number of params. As a result we're passing an array with one garbage pointer to the callee, and it just happens that the callee doesn't examine that pointer. But that's about to change. Differential Revision: https://phabricator.services.mozilla.com/D34234
3fe6750f57d7492bcc3620e4976d19b71d98f872: Bug 1554488 - Add WPT test for baseVal behavior inside symbol/display:none r=birtles
violet <violet.bugreport@gmail.com> - Tue, 04 Jun 2019 11:59:55 +0000 - rev 539599
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1554488 - Add WPT test for baseVal behavior inside symbol/display:none r=birtles This test is for baseVal behavior interacting with <symbol>, display:none and font-size. Differential Revision: https://phabricator.services.mozilla.com/D32624
eb7d78fdd5d86d713b8ae88f50413d8c23e9d8f9: Bug 1429303 - Add a missing reftest for offset-distance interpolation. r=birtles
Boris Chiou <boris.chiou@gmail.com> - Tue, 28 May 2019 18:31:50 +0000 - rev 538807
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1429303 - Add a missing reftest for offset-distance interpolation. r=birtles Differential Revision: https://phabricator.services.mozilla.com/D32537
c62c252bb59dac33a79883bc2fcd3e052e713637: Bug 1429303 - Animate offset-rotate. r=birtles
Boris Chiou <boris.chiou@gmail.com> - Tue, 28 May 2019 18:31:48 +0000 - rev 538806
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1429303 - Animate offset-rotate. r=birtles Differential Revision: https://phabricator.services.mozilla.com/D32237
33a7cec553b2b79b4067416fab3191d19243c3bf: Bug 1554457 - Obtain style from frame rather than GetComputedStyleNoFlush r=emilio,longsonr,birtles
violet <violet.bugreport@gmail.com> - Mon, 27 May 2019 05:06:47 +0000 - rev 538530
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1554457 - Obtain style from frame rather than GetComputedStyleNoFlush r=emilio,longsonr,birtles These usecases are almost the same as the geometry property stuff. It'd be better to use `GetPrimaryFrame()->Style()` consistently rather than using `GetComputedStyleNoFlush()` here. Differential Revision: https://phabricator.services.mozilla.com/D32613
f4260d7b6296c069b410d7a85decfb58cdf9c0eb: Bug 1552345 - Should not assume en is always an accepted language r=birtles
violet <violet.bugreport@gmail.com> - Mon, 27 May 2019 00:17:13 +0000 - rev 538487
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1552345 - Should not assume en is always an accepted language r=birtles The test assumes "en" is always an accepted language, it's not correct. This assumption isn't what is being tested here anyway. We should set language preference at the beginning before testing to avoid irrelevant failure. Differential Revision: https://phabricator.services.mozilla.com/D32628
7d73f17d3c58fcadca4d41674973f254ba5f6a6b: Bug 1553154 - enable animation preferences for test_animation_observers_async.html. r=birtles
Sebastian Hengst <archaeopteryx@coole-files.de> - Wed, 22 May 2019 23:51:19 +0000 - rev 538125
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1553154 - enable animation preferences for test_animation_observers_async.html. r=birtles Differential Revision: https://phabricator.services.mozilla.com/D32035
5514f80c4f48f8dca61cdfc88e2225244c236d19: Bug 1383650 - Notify style system when SMIL animation changes length r=birtles,longsonr
violet <violet.bugreport@gmail.com> - Thu, 16 May 2019 13:21:20 +0000 - rev 537542
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1383650 - Notify style system when SMIL animation changes length r=birtles,longsonr When animating geometry attribute, we need to notify style system about the change of SMIL override style. Differential Revision: https://phabricator.services.mozilla.com/D30361
e6343b742e91be084079764c242a4cca569423d1: Bug 1429299 - Part 3: Layout update for offset-distance. r=birtles
Boris Chiou <boris.chiou@gmail.com> - Mon, 20 May 2019 23:42:54 +0000 - rev 537480
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1429299 - Part 3: Layout update for offset-distance. r=birtles Just need to take offset-distance into account to get the final matrix. Differential Revision: https://phabricator.services.mozilla.com/D30583
d763b1f288a37f783de546ebeb4ce396a9a64cbd: Bug 1560704 - Revert the change `transform-style: inherit` added to ::-moz-table-wrapper in ua.css. r=birtles a=jcristau
Hiroyuki Ikezoe <hikezoe@mozilla.com> - Wed, 26 Jun 2019 10:29:37 +0000 - rev 537114
Push 2082 by ffxbld-merge at Mon, 01 Jul 2019 08:34:18 +0000
Bug 1560704 - Revert the change `transform-style: inherit` added to ::-moz-table-wrapper in ua.css. r=birtles a=jcristau It caused rendering issues just like a reftest in this commit. We don't know the reason but fixing it will be some amount of work which couldn't be uplifted to 68. So we just revert the change here now. Probably we should revisit the problem once we got a bug report that the lack of the `transform-style: inherit` causes rendering issues. Differential Revision: https://phabricator.services.mozilla.com/D35946
a7b8e6460fb8b1245507e9e15deadc1e62674102: Bug 1383650 - Notify style system when SMIL animation changes length r=birtles,longsonr
violet <violet.bugreport@gmail.com> - Thu, 16 May 2019 00:58:56 +0000 - rev 535917
Push 2082 by ffxbld-merge at Mon, 01 Jul 2019 08:34:18 +0000
Bug 1383650 - Notify style system when SMIL animation changes length r=birtles,longsonr When animating geometry attribute, we need to notify style system about the change of SMIL override style. Differential Revision: https://phabricator.services.mozilla.com/D30361
2a2a6da7e8990127f5dfa5a2e12d30bb627357a9: Bug 1544216 Part 6 - Make function declaration and definition parameter names match r=birtles
longsonr <longsonr@gmail.com> - Sat, 27 Apr 2019 08:57:46 +0100 - rev 533539
Push 2082 by ffxbld-merge at Mon, 01 Jul 2019 08:34:18 +0000
Bug 1544216 Part 6 - Make function declaration and definition parameter names match r=birtles
2d2c69004a2958bb798a558fe86b3afc07a69e73: Bug 1544216 Part 5 - add noexcept to move constructors and reassignment operators r=birtles
longsonr <longsonr@gmail.com> - Wed, 24 Apr 2019 21:39:47 +0100 - rev 533155
Push 2082 by ffxbld-merge at Mon, 01 Jul 2019 08:34:18 +0000
Bug 1544216 Part 5 - add noexcept to move constructors and reassignment operators r=birtles
9d57a72036d3ce614762bdb48bdcd1311bc72f12: Bug 1544216 Part 5 - add noexcept to move constructors and reassignment operators r=birtles
longsonr <longsonr@gmail.com> - Wed, 24 Apr 2019 21:39:47 +0100 - rev 533151
Push 2082 by ffxbld-merge at Mon, 01 Jul 2019 08:34:18 +0000
Bug 1544216 Part 5 - add noexcept to move constructors and reassignment operators r=birtles
fb417cb3679079f3b0b64a26b36a8313991f6752: Bug 1544216 Part 4 - use modern looping r=birtles
longsonr <longsonr@gmail.com> - Wed, 17 Apr 2019 23:32:46 +0100 - rev 531921
Push 2082 by ffxbld-merge at Mon, 01 Jul 2019 08:34:18 +0000
Bug 1544216 Part 4 - use modern looping r=birtles
6c81fd084c4f8f6c25539cbca70fb911859218cb: Bug 1544216 Part 3 - simplify boolean logic r=birtles
longsonr <longsonr@gmail.com> - Wed, 17 Apr 2019 23:32:42 +0100 - rev 531920
Push 2082 by ffxbld-merge at Mon, 01 Jul 2019 08:34:18 +0000
Bug 1544216 Part 3 - simplify boolean logic r=birtles
d886995a0251f42c2ae25b1ee4d341e217f3fdbe: Bug 1544216 Part 2 - no else after return r=birtles
longsonr <longsonr@gmail.com> - Wed, 17 Apr 2019 23:32:38 +0100 - rev 531919
Push 2082 by ffxbld-merge at Mon, 01 Jul 2019 08:34:18 +0000
Bug 1544216 Part 2 - no else after return r=birtles
18169336baefc8485fd3536d91f82c0c9615708b: Bug 1544216 Part 1 - use default keyword instead of empty constructors and destructors r=birtles
longsonr <longsonr@gmail.com> - Wed, 17 Apr 2019 23:04:53 +0100 - rev 531918
Push 2082 by ffxbld-merge at Mon, 01 Jul 2019 08:34:18 +0000
Bug 1544216 Part 1 - use default keyword instead of empty constructors and destructors r=birtles
9fe743aa6c94f49346902934f40f8f55663bc54d: Bug 1425837 - Part 8: Test that individual transforms run on the compositor thread. r=hiro,birtles
Boris Chiou <boris.chiou@gmail.com> - Mon, 18 Mar 2019 18:05:04 +0000 - rev 526814
Push 2082 by ffxbld-merge at Mon, 01 Jul 2019 08:34:18 +0000
Bug 1425837 - Part 8: Test that individual transforms run on the compositor thread. r=hiro,birtles This also adds the missing preference in test_transition_per_property.html. Depends on D22567 Differential Revision: https://phabricator.services.mozilla.com/D22568
af39dc228d19a34892e32faab8fb105352708099: Bug 1425837 - Part 7: Drop the hard-code disabling compositor animations on individual transforms. r=hiro,birtles
Boris Chiou <boris.chiou@gmail.com> - Mon, 18 Mar 2019 18:05:02 +0000 - rev 526813
Push 2082 by ffxbld-merge at Mon, 01 Jul 2019 08:34:18 +0000
Bug 1425837 - Part 7: Drop the hard-code disabling compositor animations on individual transforms. r=hiro,birtles Drop the hack which prevents individual transform running on the compositor thread. Depends on D22566 Differential Revision: https://phabricator.services.mozilla.com/D22567
b27d18cccc623d49dfcd89aa07890ab940d859f5: Bug 1425837 - Part 4: Implement compositor animations on translate/rotate/scale. r=hiro,birtles
Boris Chiou <boris.chiou@gmail.com> - Mon, 18 Mar 2019 18:04:50 +0000 - rev 526810
Push 2082 by ffxbld-merge at Mon, 01 Jul 2019 08:34:18 +0000
Bug 1425837 - Part 4: Implement compositor animations on translate/rotate/scale. r=hiro,birtles On the sender side of transactions, we have to convert the individual transforms to the proper types in layers::Animations, and this includes SetAnimatable and the definition in LayersMessages. On the compositor side (i.e. received side of transactions). Basically, we convert the list of layers::Animation into a list of `PropertyAnimationGroup`, which is an intermediate value. And then use this list to do interpolation for each property in `SampleAnimationForEachNode`, which will return a list of `RefPtr<RawServoAnimationValue>`. Depends on D23062 Differential Revision: https://phabricator.services.mozilla.com/D22565
6c55b82deb9ba9b5924ef6bfdecdffaf9f42307a: Bug 1425837 - Part 3: Don't store AnimationArray (a.k.a. AnimationInfo::mAnimations) on the compositor thread. r=birtles
Boris Chiou <boris.chiou@gmail.com> - Mon, 18 Mar 2019 18:04:48 +0000 - rev 526809
Push 2082 by ffxbld-merge at Mon, 01 Jul 2019 08:34:18 +0000
Bug 1425837 - Part 3: Don't store AnimationArray (a.k.a. AnimationInfo::mAnimations) on the compositor thread. r=birtles The original implementation about "setting animations" is a little bit hard to read. In `SetAnimations()`, we create a new intermediate data, `AnimData`, and we mutate the original animations. And then iterate this mutated animations & intermediate data for sampling. In this bug, we are planning to group the AnimData as a useful data structure for supporting multiple properties transform-like animations, so it seems the structure of original animations may be hard to use after that. Therefore, we decide to do some reworks on this: First, we do renames, 1. InfalliableTArray to nsTArray. (They are the same.) 2. AnimData to PropertyAnimation. 3. SetAnimations() to ExtractAnimations(), which returns nsTArray<PropertyAnimationGroup>. Each entry in the array is for one property. In this patch, there is only one entry. We will extend this to multiple entries in the next patch. And then rework `ExtractAnimations()`, which stores all the necessary data in `PropertyAnimationGroup`. For WR, we store this in `CompositorAnimationStorage`. For non-WR, we store it in `AnimationInfo`. So we can just use this organized data structure for supporting multiple properties animations. (See the next patch.) Depends on D22563 Differential Revision: https://phabricator.services.mozilla.com/D23062
a9a91a32262e099d6366cb2c7500db10f551bf13: Bug 1413319 - Correctly check a double is within long's limit r=birtles
violet <violet.bugreport@gmail.com> - Sun, 17 Mar 2019 23:34:02 +0000 - rev 525613
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1413319 - Correctly check a double is within long's limit r=birtles When close to int64_t's limit, the int64 can't be precisely converted to double because of rounding error, rounding-up is also allowed. To ensure a double `d` is within int64's limit, we should check `d < std::numeric_limits<int64_t>::max()`, instead of `<=`. Because `std::numeric_limits<int64_t>::max()` might be converted to a larger double, when they are equal, we can't be sure if `d` is indeed within the actual int64 limit. Differential Revision: https://phabricator.services.mozilla.com/D23680
a7d81b7bc493094223744d4010c87789cdf2977e: Bug 1532205 - Intermittent TEST-UNEXPECTED-TIMEOUT in Event-dispatch-on-disabled-elements.html r=birtles
Marcos Cáceres <mcaceres@mozilla.com> - Fri, 15 Mar 2019 05:49:25 +0000 - rev 525016
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1532205 - Intermittent TEST-UNEXPECTED-TIMEOUT in Event-dispatch-on-disabled-elements.html r=birtles try to extend the animation time. I tested this locally on repeat 50 times. Differential Revision: https://phabricator.services.mozilla.com/D23498
5849b867ecf7c485b71ca694167f5a63b2d6c6ca: Bug 1322770: Remove bogus assertion from SMIL motion code. r=birtles
Daniel Holbert <dholbert@cs.stanford.edu> - Thu, 14 Mar 2019 00:55:31 +0000 - rev 524806
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1322770: Remove bogus assertion from SMIL motion code. r=birtles We had an assertion here that assumed progression along a motion path must be positive, but that's not the case when we have decreasing values of the `keyPoints` attribute. The assertion wasn't justified and nothing depended on it being valid, so let's just remove it. Differential Revision: https://phabricator.services.mozilla.com/D23354
1ae26ce1cf090db6b0b19ea7d7eccd42373dd5fa: Bug 1215878 - Implement CSS revert keyword. r=heycam,birtles
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 07 Mar 2019 11:59:36 +0000 - rev 523748
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1215878 - Implement CSS revert keyword. r=heycam,birtles The only fishy bit is the animation stuff. In particular, there are two places where we just mint the revert behavior: * When serializing web-animations keyframes (the custom properties stuff in declaration_block.rs). That codepath is already not sound and I wanted to get rid of it in bug 1501530, but what do I know. * When getting an animation value from a property declaration. At that point we no longer have the CSS rules that apply to the element to compute the right revert value handy. It'd also use the wrong style anyway, I think, given the way StyleBuilder::for_animation works. We _could_ probably get them out of somewhere, but it seems like a whole lot of code reinventing the wheel which is probably not useful, and that Blink and WebKit just cannot implement either since they don't have a rule tree, so it just doesn't seem worth the churn. The custom properties code looks a bit different in order to minimize hash lookups in the common case. FWIW, `revert` for custom properties doesn't seem very useful either, but oh well. Differential Revision: https://phabricator.services.mozilla.com/D21877
1d56a0d3a3236253b297d9928083175c2d1b403e: Bug 1531567 - fix intermittent in Event-dispatch-on-disabled-elements.html r=birtles
Marcos Cáceres <mcaceres@mozilla.com> - Thu, 07 Mar 2019 05:18:46 +0000 - rev 523704
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1531567 - fix intermittent in Event-dispatch-on-disabled-elements.html r=birtles change how transitions are triggered and extend the animation/transition time. Differential Revision: https://phabricator.services.mozilla.com/D22251
dcabcaa944f5130b4ddb5bccc6076ec50d46f2ca: Bug 1443320 - Drop |aNotify| argument from Element::SetSMILOverrideStyleDeclaration. r=birtles
Hiroyuki Ikezoe <hikezoe@mozilla.com> - Wed, 13 Feb 2019 04:44:34 +0000 - rev 519722
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1443320 - Drop |aNotify| argument from Element::SetSMILOverrideStyleDeclaration. r=birtles The other call site was removed in https://hg.mozilla.org/mozilla-central/rev/e8c0ffefb34f Depends on D19570 Differential Revision: https://phabricator.services.mozilla.com/D19571
fc540ce0e4298b98f8961ecbc4b58733e35df0e0: Bug 1443320 - Wait for an additional frame if the vsync tick happened within 1ms and check the observed result with tolerance. r=birtles
Hiroyuki Ikezoe <hikezoe@mozilla.com> - Wed, 13 Feb 2019 04:46:31 +0000 - rev 519721
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1443320 - Wait for an additional frame if the vsync tick happened within 1ms and check the observed result with tolerance. r=birtles SMILTime is clamped to milliseconds in SMILAnimationController::GetParentTime[1]. Unfortunately our software based vsync timer is no accurate, it ticks sometimes within 1ms. In such frames, it's possible that the SMILTime is not advanced due to the clamping. It's hard to precisely predict when the clamping happens, so we wait for an additinal frame in the case where the frame is ticked within 1ms and allow redundant restyling count for the case. [1] https://searchfox.org/mozilla-central/rev/00c0d068ece99717bea7475f7dc07e61f7f35984/dom/smil/SMILAnimationController.cpp#103 Depends on D19568 Differential Revision: https://phabricator.services.mozilla.com/D19570
6ff72e58273bb587b53f9917aac4e16c4eaa3e63: Bug 1273876 - Use 'transitionstart' event to detect the target transition has been started instead of using setTimeout. r=birtles
Hiroyuki Ikezoe <hikezoe@mozilla.com> - Tue, 29 Jan 2019 09:20:44 +0000 - rev 516727
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1273876 - Use 'transitionstart' event to detect the target transition has been started instead of using setTimeout. r=birtles And stop the transitions inside the event callbacks. Also in this commit, `did_stop` flag was split into two dedicated flags for `five' and `six` elements respectively to avoid success accidentally. And flip the flag usage, e.g. true if the transition finished at the same time of the transitionstart event. MozReview-Commit-ID: DttQ2nLVYWU Depends on D17911 Differential Revision: https://phabricator.services.mozilla.com/D17912
4ae308f1f64bff4bb51072c95e38d68e93061577: Bug 1273876 - Check the computed style _color_. r=birtles
Hiroyuki Ikezoe <hikezoe@mozilla.com> - Tue, 29 Jan 2019 09:20:32 +0000 - rev 516726
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1273876 - Check the computed style _color_. r=birtles Differential Revision: https://phabricator.services.mozilla.com/D17911
7feeb976784f6ae4132ca9fa7f6494ec36cf5365: Bug 1507166 - Make test_omta_animations.html work under GeckoView r=birtles
James Willcox <snorp@snorp.net> - Sun, 27 Jan 2019 04:14:25 +0000 - rev 516510
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1507166 - Make test_omta_animations.html work under GeckoView r=birtles The GeckoView test app doesn't handle visited link history, so disable a couple tests that rely on that. Differential Revision: https://phabricator.services.mozilla.com/D17698
767ca8e22c4d1b9169f43c4f282495fd53a23dde: Bug 1273876 - Use 'transitionstart' event to detect the target transition has been started instead of using setTimeout. r=birtles, a=test-only
Hiroyuki Ikezoe <hikezoe@mozilla.com> - Tue, 29 Jan 2019 09:20:44 +0000 - rev 515630
Push 1953 by ffxbld-merge at Mon, 11 Mar 2019 12:10:20 +0000
Bug 1273876 - Use 'transitionstart' event to detect the target transition has been started instead of using setTimeout. r=birtles, a=test-only And stop the transitions inside the event callbacks. Also in this commit, `did_stop` flag was split into two dedicated flags for `five' and `six` elements respectively to avoid success accidentally. And flip the flag usage, e.g. true if the transition finished at the same time of the transitionstart event. MozReview-Commit-ID: DttQ2nLVYWU Depends on D17911 Differential Revision: https://phabricator.services.mozilla.com/D17912
aea1f9d170ef4f6085c0d6065f5f3b5d63218136: Bug 1273876 - Check the computed style _color_. r=birtles, a=test-only
Hiroyuki Ikezoe <hikezoe@mozilla.com> - Tue, 29 Jan 2019 09:20:32 +0000 - rev 515629
Push 1953 by ffxbld-merge at Mon, 11 Mar 2019 12:10:20 +0000
Bug 1273876 - Check the computed style _color_. r=birtles, a=test-only Differential Revision: https://phabricator.services.mozilla.com/D17911
0d747e05337bdedc46a153a7ae710cda95913c62: Bug 1522749 - Fix SMIL include guard naming. r=birtles
longsonr <longsonr@gmail.com> - Fri, 25 Jan 2019 08:16:09 +0000 - rev 515413
Push 1953 by ffxbld-merge at Mon, 11 Mar 2019 12:10:20 +0000
Bug 1522749 - Fix SMIL include guard naming. r=birtles
c00ab2984f8a48fdf89f3793e8fe00da5520014c: Bug 1522744 - Use DebugOnly where we can and remove a couple of useless ifdef DEBUG statements around MOZ_ASSERT statements. r=birtles
longsonr <longsonr@gmail.com> - Fri, 25 Jan 2019 03:47:16 +0000 - rev 515411
Push 1953 by ffxbld-merge at Mon, 11 Mar 2019 12:10:20 +0000
Bug 1522744 - Use DebugOnly where we can and remove a couple of useless ifdef DEBUG statements around MOZ_ASSERT statements. r=birtles
9c985b12ab62c7b671e478f9c5b473e6c89ebe2e: Bug 1522650 - Rename all remaining nsSMIL classes and types as SMIL and ensure they are in the mozilla namespace. r=birtles
longsonr <longsonr@gmail.com> - Fri, 25 Jan 2019 03:24:01 +0000 - rev 515410
Push 1953 by ffxbld-merge at Mon, 11 Mar 2019 12:10:20 +0000
Bug 1522650 - Rename all remaining nsSMIL classes and types as SMIL and ensure they are in the mozilla namespace. r=birtles
551abefb4933ba447468a385bd9f7f9478592173: Bug 1521946 - Move nsSMILTypes and nsSMILValue to the mozilla namespace r=birtles
longsonr <longsonr@gmail.com> - Wed, 23 Jan 2019 13:48:08 +0000 - rev 515122
Push 1953 by ffxbld-merge at Mon, 11 Mar 2019 12:10:20 +0000
Bug 1521946 - Move nsSMILTypes and nsSMILValue to the mozilla namespace r=birtles
d358a9083413cb023f6875a8432ead7bafa1f1d2: Bug 1521575 - Move nsSMILTimeValue classes and nsSMILInstanceTime to the mozilla namespace r=birtles
longsonr <longsonr@gmail.com> - Tue, 22 Jan 2019 07:28:40 +0000 - rev 514814
Push 1953 by ffxbld-merge at Mon, 11 Mar 2019 12:10:20 +0000
Bug 1521575 - Move nsSMILTimeValue classes and nsSMILInstanceTime to the mozilla namespace r=birtles
2668f097f56dff2258bfc62de51715d3627ae4d2: Bug 1519253 - Move nsSMILInterval and nsSMILRepeatCount to the mozilla namespace r=birtles
longsonr <longsonr@gmail.com> - Mon, 21 Jan 2019 13:08:12 +0000 - rev 514711
Push 1953 by ffxbld-merge at Mon, 11 Mar 2019 12:10:20 +0000
Bug 1519253 - Move nsSMILInterval and nsSMILRepeatCount to the mozilla namespace r=birtles
f358ebdec0b4996d41f43da7493cbb055b3cbe42: Bug 1518646 - Export things from dom/smil in the mozilla namespace properly r=birtles
longsonr <longsonr@gmail.com> - Wed, 09 Jan 2019 00:34:14 +0000 - rev 512990
Push 1953 by ffxbld-merge at Mon, 11 Mar 2019 12:10:20 +0000
Bug 1518646 - Export things from dom/smil in the mozilla namespace properly r=birtles
04943bb8dcdcbb78870d89246939248d3f0f6a56: Bug 1516411 - Move nsSMILAnimationController into the mozilla namespace and rename it as SMILAnimationController r=birtles
longsonr <longsonr@gmail.com> - Fri, 28 Dec 2018 11:47:58 +0000 - rev 512027
Push 1953 by ffxbld-merge at Mon, 11 Mar 2019 12:10:20 +0000
Bug 1516411 - Move nsSMILAnimationController into the mozilla namespace and rename it as SMILAnimationController r=birtles
5f85f8fe9a58cf56fc3dc2e56f9717c70ba6ff7d: Bug 1516175 - Move nsSMILFloatType into the mozilla namespace r=birtles
longsonr <longsonr@gmail.com> - Mon, 24 Dec 2018 19:24:45 +0000 - rev 511887
Push 1953 by ffxbld-merge at Mon, 11 Mar 2019 12:10:20 +0000
Bug 1516175 - Move nsSMILFloatType into the mozilla namespace r=birtles
84931341bac16f5c047f137fffd9c69bb05a7a77: Bug 1515800 - Rename some more GetCurrentTime methods to avoid winbase.h bustage r=birtles,bzbarsky
Cameron McCormack <cam@mcc.id.au> - Fri, 21 Dec 2018 05:37:58 +0000 - rev 511599
Push 1953 by ffxbld-merge at Mon, 11 Mar 2019 12:10:20 +0000
Bug 1515800 - Rename some more GetCurrentTime methods to avoid winbase.h bustage r=birtles,bzbarsky Differential Revision: https://phabricator.services.mozilla.com/D15167
c1b46f5fc73bf34193b70d8aba86a1d6f3597357: Bug 1512883 - Part 2: Tests. r=birtles
Boris Chiou <boris.chiou@gmail.com> - Wed, 19 Dec 2018 19:08:10 +0000 - rev 511379
Push 1953 by ffxbld-merge at Mon, 11 Mar 2019 12:10:20 +0000
Bug 1512883 - Part 2: Tests. r=birtles Add some tests to make sure we clamp the interpolated result with negative easing function on circle(), ellipse(), and inset(). Depends on D14654 Differential Revision: https://phabricator.services.mozilla.com/D14655
70912a8087d7ddf36dec65b83e07a2e703f3dd44: Bug 1512883 - Part 1: Clamp to non-negative value after doing interpolation for circle(), ellipse(), and inset(). r=emilio,birtles
Boris Chiou <boris.chiou@gmail.com> - Wed, 19 Dec 2018 19:08:08 +0000 - rev 511378
Push 1953 by ffxbld-merge at Mon, 11 Mar 2019 12:10:20 +0000
Bug 1512883 - Part 1: Clamp to non-negative value after doing interpolation for circle(), ellipse(), and inset(). r=emilio,birtles Replace LengthOrPercentage with NonNegativeLengthOrPercentage on ShapeRadius, Circle, Ellipse. And derive ToAnimatedValue for ShapeSource and its related types, so we clamp its interpolated results into non-negative values. (i.e. The radius of circle()/ellipse() and the border-radius of inset().) Note: We may get negative values when using a negative easing function, so the clamp is necessary to avoid the incorrect result or any undefined behavior. Differential Revision: https://phabricator.services.mozilla.com/D14654
4a2e65b750282683982627bbaf8f07a7de855d7a: Bug 1513750 - Add BUG_COMPONENT "Core :: CSS Transitions and Animations" component for css-animations/ and css-transitions/. r=birtles
Hiroyuki Ikezoe <hikezoe@mozilla.com> - Thu, 13 Dec 2018 07:13:39 +0000 - rev 510366
Push 1953 by ffxbld-merge at Mon, 11 Mar 2019 12:10:20 +0000
Bug 1513750 - Add BUG_COMPONENT "Core :: CSS Transitions and Animations" component for css-animations/ and css-transitions/. r=birtles Also the css-easing/ entry is moved to the position by alphabetical order. Differential Revision: https://phabricator.services.mozilla.com/D14354