searching for reviewer(birtles)
7f18ac417ddb4a93014f8aba3621ca59cbea132b: Bug 1698600 - CSS animation profiler markers should also be added for animations that run to completion, r=birtles.
Florian Quèze <florian@queze.net> - Tue, 16 Mar 2021 12:04:01 +0000 - rev 642731
Push 2548 by ffxbld-merge at Mon, 12 Apr 2021 17:52:51 +0000
Bug 1698600 - CSS animation profiler markers should also be added for animations that run to completion, r=birtles. Differential Revision: https://phabricator.services.mozilla.com/D108493
37df35e82902bccd9c0afff8a8df0eb48f2e52a9: Bug 1676608 - correct wpt tests for invalid values r=birtles
longsonr <longsonr@gmail.com> - Wed, 11 Nov 2020 23:47:04 +0000 - rev 627005
Push 2472 by ffxbld-merge at Mon, 07 Dec 2020 19:30:50 +0000
Bug 1676608 - correct wpt tests for invalid values r=birtles Differential Revision: https://phabricator.services.mozilla.com/D96695
9c9602e64e194e376d9849828ce71616ef659272: Bug 1667629 - support mpath pointing to shapes r=birtles,emilio
longsonr <longsonr@gmail.com> - Thu, 01 Oct 2020 16:19:37 +0000 - rev 620753
Push 2452 by ffxbld-merge at Mon, 09 Nov 2020 13:49:41 +0000
Bug 1667629 - support mpath pointing to shapes r=birtles,emilio Differential Revision: https://phabricator.services.mozilla.com/D91510
508b69014dd808b227c4b15d45483d4119432ff7: Bug 1661315 - Set [Animation interface: attribute timeline] to fail on non-nightly builds. r=birtles DONTBUILD
Cosmin Sabou <csabou@mozilla.com> - Sat, 29 Aug 2020 08:50:24 +0000 - rev 615990
Push 2429 by ffxbld-merge at Mon, 12 Oct 2020 13:13:51 +0000
Bug 1661315 - Set [Animation interface: attribute timeline] to fail on non-nightly builds. r=birtles DONTBUILD Differential Revision: https://phabricator.services.mozilla.com/D88710
c0fed15df545ed4bb6c8ce99db466a3815d52604: Bug 1642157 - mark 2 svg animation tests as backlog (tier-2) due to not supported. r=birtles
Joel Maher <jmaher@mozilla.com> - Wed, 17 Jun 2020 23:39:23 +0000 - rev 604014
Push 2380 by ffxbld-merge at Mon, 20 Jul 2020 19:35:47 +0000
Bug 1642157 - mark 2 svg animation tests as backlog (tier-2) due to not supported. r=birtles mark 2 svg animation tests as backlog (tier-2) due to not supported Differential Revision: https://phabricator.services.mozilla.com/D79824
1d033efd9ea6b0a2c4fed687695d2501f817f426: Bug 1626532 - Make `dom/animation` buildable outside of `unified-build` environment. r=birtles
Andi-Bogdan Postelnicu <bpostelnicu@mozilla.com> - Tue, 02 Jun 2020 10:31:46 +0000 - rev 601591
Push 2380 by ffxbld-merge at Mon, 20 Jul 2020 19:35:47 +0000
Bug 1626532 - Make `dom/animation` buildable outside of `unified-build` environment. r=birtles Differential Revision: https://phabricator.services.mozilla.com/D69161
7a510d21948fc0d331527534ca188bfed0f9aa3a: Bug 1626570 - Improve handling of copying arrays in dom/smil/. r=birtles
Simon Giesecke <sgiesecke@mozilla.com> - Tue, 05 May 2020 13:00:31 +0000 - rev 595487
Push 2357 by ffxbld-merge at Mon, 22 Jun 2020 15:16:15 +0000
Bug 1626570 - Improve handling of copying arrays in dom/smil/. r=birtles Differential Revision: https://phabricator.services.mozilla.com/D73630
404f1295f4bc2e9ce2641efb33032a3cbcf77d82: Bug 1626133 - Separate the portion of Element::GetAnimation which needs script from the part that doesn't. r=birtles
Emily McDonough <emcdonough@mozilla.com> - Tue, 31 Mar 2020 01:45:08 +0000 - rev 587988
Push 2321 by ffxbld-merge at Mon, 27 Apr 2020 16:26:39 +0000
Bug 1626133 - Separate the portion of Element::GetAnimation which needs script from the part that doesn't. r=birtles Also update the existing caller which doesn't need the flush that was causing the script requirement. Differential Revision: https://phabricator.services.mozilla.com/D68944
3163f1561bc060b89452ee44956266efe29b8c98: Bug 1625608 - Improve some web-animations error messages. r=birtles
Emilio Cobos Álvarez <emilio@crisal.io> - Mon, 30 Mar 2020 09:48:06 +0000 - rev 587813
Push 2321 by ffxbld-merge at Mon, 27 Apr 2020 16:26:39 +0000
Bug 1625608 - Improve some web-animations error messages. r=birtles Differential Revision: https://phabricator.services.mozilla.com/D68695
254999e1d7614bfcc52a572b1364c6be31a3b09b: Bug 1622369 - Await the async function to make sure any async steps inside the function will be blocked. r=birtles
Boris Chiou <boris.chiou@gmail.com> - Fri, 27 Mar 2020 19:00:02 +0000 - rev 587587
Push 2321 by ffxbld-merge at Mon, 27 Apr 2020 16:26:39 +0000
Bug 1622369 - Await the async function to make sure any async steps inside the function will be blocked. r=birtles It's easy to get time out on mac if we don't await the async function. The async functions return an implicit Promise. If the caller doesn't await it, any async steps inside the function will not be blocked. Differential Revision: https://phabricator.services.mozilla.com/D68448
bdf66b9a75e61aa0d529b8d9813db33be9b76fea: Bug 1621174 - Fix error handling for setting KeyframeEffect.pseudoElement. r=birtles,smaug
Boris Chiou <boris.chiou@gmail.com> - Thu, 12 Mar 2020 00:34:46 +0000 - rev 585088
Push 2321 by ffxbld-merge at Mon, 27 Apr 2020 16:26:39 +0000
Bug 1621174 - Fix error handling for setting KeyframeEffect.pseudoElement. r=birtles,smaug We should throw a DOMException SyntaxError when setting pseudoElement a syntactically invalid string or an unsupported pseudo. Differential Revision: https://phabricator.services.mozilla.com/D66321
96d3f71da2ddffd32856f365cf86a65cfa21a590: Bug 1621174 - Fix error handling for setting KeyframeEffect.pseudoElement. r=birtles,smaug a=jcristau
Boris Chiou <boris.chiou@gmail.com> - Thu, 12 Mar 2020 00:34:46 +0000 - rev 584023
Push 2292 by ffxbld-merge at Mon, 30 Mar 2020 09:22:45 +0000
Bug 1621174 - Fix error handling for setting KeyframeEffect.pseudoElement. r=birtles,smaug a=jcristau We should throw a DOMException SyntaxError when setting pseudoElement a syntactically invalid string or an unsupported pseudo. Differential Revision: https://phabricator.services.mozilla.com/D66321
5811bf461e5e0c3a7ca0ba198da83d145b28bc36: Bug 1619276 - Fix the order of the setting of Keyframe options. r=smaug,birtles
Boris Chiou <boris.chiou@gmail.com> - Thu, 05 Mar 2020 09:42:55 +0000 - rev 583554
Push 2292 by ffxbld-merge at Mon, 30 Mar 2020 09:22:45 +0000
Bug 1619276 - Fix the order of the setting of Keyframe options. r=smaug,birtles Besides, we add the pref setup in the webidl, so if we turn it off, iterationComposite and composite will always be the default values. Differential Revision: https://phabricator.services.mozilla.com/D65437
9aad6bdfb58c6e4306349ca5a16d024652678d0f: Bug 1612891 - Suppress parsing easing error in early returns of ConvertKeyframeSequence. r=birtles
Boris Chiou <boris.chiou@gmail.com> - Wed, 04 Mar 2020 01:03:16 +0000 - rev 583355
Push 2292 by ffxbld-merge at Mon, 30 Mar 2020 09:22:45 +0000
Bug 1612891 - Suppress parsing easing error in early returns of ConvertKeyframeSequence. r=birtles We add a stack based class and supress the exception of parsing easing in the destructor, to avoid hitting the potential assertions. Differential Revision: https://phabricator.services.mozilla.com/D64268
096dfc972a04277ee4f5ed8426e207e2c9c0f9de: Bug 1611847 - Update relevance and its effect set in the early return of UpdatePlaybackRate(). r=birtles
Boris Chiou <boris.chiou@gmail.com> - Tue, 25 Feb 2020 19:41:14 +0000 - rev 581969
Push 2292 by ffxbld-merge at Mon, 30 Mar 2020 09:22:45 +0000
Bug 1611847 - Update relevance and its effect set in the early return of UpdatePlaybackRate(). r=birtles To avoid hitting the assertion because of out-of-dated relevance. Differential Revision: https://phabricator.services.mozilla.com/D63582
922d1a0e30901695cfc6efff2d47ff1d787e3b84: Bug 1612106 - Use NIGHTLY build flag to distinguish the writable/readonly Animation.timeline. r=birtles,bzbarsky
Boris Chiou <boris.chiou@gmail.com> - Mon, 24 Feb 2020 23:07:09 +0000 - rev 581964
Push 2292 by ffxbld-merge at Mon, 30 Mar 2020 09:22:45 +0000
Bug 1612106 - Use NIGHTLY build flag to distinguish the writable/readonly Animation.timeline. r=birtles,bzbarsky We only support writable Animation.timeline attribute on nightly build, so use nightly build flag in WebIDL and Animation.h/cpp. For the test expectations, we also use this build flag to skip them or mark them as expected fail if necessary. Differential Revision: https://phabricator.services.mozilla.com/D63432
4f19c1102c42b884a5a301d489cbccd96ee02dcb: Bug 1616443 - Hide composite memeber from the result of getKeyframes(). r=birtles,bzbarsky
Boris Chiou <boris.chiou@gmail.com> - Thu, 20 Feb 2020 19:09:34 +0000 - rev 581335
Push 2292 by ffxbld-merge at Mon, 30 Mar 2020 09:22:45 +0000
Bug 1616443 - Hide composite memeber from the result of getKeyframes(). r=birtles,bzbarsky If dom.animations-api.compositing.enabled is false, we have to hide composite member from getKeyframes. Differential Revision: https://phabricator.services.mozilla.com/D63388
ebfed5eb1869b1bdcb566ae805e6ee742e0a4323: Bug 1610981 - Eliminate usage of CSSPseudoElement from KeyframeEffect. r=birtles,smaug
Boris Chiou <boris.chiou@gmail.com> - Tue, 18 Feb 2020 20:44:14 +0000 - rev 580996
Push 2292 by ffxbld-merge at Mon, 30 Mar 2020 09:22:45 +0000
Bug 1610981 - Eliminate usage of CSSPseudoElement from KeyframeEffect. r=birtles,smaug Replace ElementOrCSSPseudoElement with Element and add PseudoElement (which is a DOMString) into KeyframeAnimationOptions and KeyframeEffect. Differential Revision: https://phabricator.services.mozilla.com/D62667
0544d8d971067235d3a1da242cd88000f666464a: Bug 1610981 - Drop Maybe<> from KeyframeEffect::mTarget. r=birtles
Boris Chiou <boris.chiou@gmail.com> - Tue, 18 Feb 2020 20:44:12 +0000 - rev 580995
Push 2292 by ffxbld-merge at Mon, 30 Mar 2020 09:22:45 +0000
Bug 1610981 - Drop Maybe<> from KeyframeEffect::mTarget. r=birtles In order to store the different combinations of (Element, PsuedoStyleType) pairs, including (nullptr, ::before/::after), we drop Maybe<> and use OwningAnimationTarget directly. Differential Revision: https://phabricator.services.mozilla.com/D62666
dff38d5e834ad654a3109a6512ead06b95ba9ad6: Use %g, not %f, for our error reporting so unnecessary trailing zeros are not output. No bug. r=birtles
Boris Zbarsky <bzbarsky@mit.edu> - Mon, 10 Feb 2020 01:35:00 +0000 - rev 579119
Push 2274 by ffxbld-merge at Mon, 02 Mar 2020 18:46:08 +0000
Use %g, not %f, for our error reporting so unnecessary trailing zeros are not output. No bug. r=birtles Differential Revision: https://phabricator.services.mozilla.com/D62062
5e39f4f870b079fa23fbed1fb5f4352f2e79b965: Bug 1601322 - Updated animations/reverse-running-animation.html expectations r=birtles
Andreea Pavel <apavel@mozilla.com> - Thu, 26 Dec 2019 00:34:54 +0000 - rev 573954
Push 2247 by ffxbld-merge at Mon, 03 Feb 2020 09:19:36 +0000
Bug 1601322 - Updated animations/reverse-running-animation.html expectations r=birtles Differential Revision: https://phabricator.services.mozilla.com/D58088
9d653dc355d3fec5c9870edd49f739d21be734e9: Bug 1601609: Set dom.animations-api.implicit-keyframes.enabled pref in __dir__.ini file. r=birtles
Daisuke Akatsuka <daisuke@birchill.co.jp> - Mon, 16 Dec 2019 01:05:20 +0000 - rev 572618
Push 2247 by ffxbld-merge at Mon, 03 Feb 2020 09:19:36 +0000
Bug 1601609: Set dom.animations-api.implicit-keyframes.enabled pref in __dir__.ini file. r=birtles Differential Revision: https://phabricator.services.mozilla.com/D56846
3779e7b766fd91688914046f1efee1a3812f69b0: Bug 1506746 - Update expectation for rotate property for extrapolation in wpt. r=birtles
Boris Chiou <boris.chiou@gmail.com> - Mon, 18 Nov 2019 22:56:43 +0000 - rev 567717
Push 2218 by ffxbld-merge at Mon, 30 Dec 2019 12:35:14 +0000
Bug 1506746 - Update expectation for rotate property for extrapolation in wpt. r=birtles Differential Revision: https://phabricator.services.mozilla.com/D52945
3c5118f00c7caf321cfbee83e3abe5aa9b75e80c: Bug 1506746 - Update the expected direction vector of rotate property in wpt. r=birtles
Boris Chiou <boris.chiou@gmail.com> - Mon, 18 Nov 2019 20:47:01 +0000 - rev 567716
Push 2218 by ffxbld-merge at Mon, 30 Dec 2019 12:35:14 +0000
Bug 1506746 - Update the expected direction vector of rotate property in wpt. r=birtles For interpolations with the primitive rotate3d(), the direction vectors of the transform functions get normalized first. This should also be applied to rotate property. https://drafts.csswg.org/css-transforms-2/#interpolation-of-transform-functions Differential Revision: https://phabricator.services.mozilla.com/D52944
dfb29951d8b0be208d83f5c3e81b5cff84549cc6: Bug 1506746 - Update the expected value at 0% and 100% for individual transforms. r=birtles
Boris Chiou <boris.chiou@gmail.com> - Mon, 18 Nov 2019 20:46:59 +0000 - rev 567715
Push 2218 by ffxbld-merge at Mon, 30 Dec 2019 12:35:14 +0000
Bug 1506746 - Update the expected value at 0% and 100% for individual transforms. r=birtles Differential Revision: https://phabricator.services.mozilla.com/D52943
c38b3c03d21feedfbce28e0ca1bff0269c35c5e6: Bug 1585589 - Do not reduce the precision of the requestAnimationFrame timestamp if we are in the System Principal Context r=birtles
Tom Ritter <tom@mozilla.com> - Thu, 03 Oct 2019 22:53:28 +0000 - rev 560922
Push 2195 by ffxbld-merge at Mon, 25 Nov 2019 12:02:33 +0000
Bug 1585589 - Do not reduce the precision of the requestAnimationFrame timestamp if we are in the System Principal Context r=birtles Differential Revision: https://phabricator.services.mozilla.com/D48118
dcf8bb9eb0db981075bc8864e0a0115b21980d89: Bug 1567330 - Add offset shorthand. r=emilio,birtles
Boris Chiou <boris.chiou@gmail.com> - Mon, 23 Sep 2019 19:56:33 +0000 - rev 559280
Push 2195 by ffxbld-merge at Mon, 25 Nov 2019 12:02:33 +0000
Bug 1567330 - Add offset shorthand. r=emilio,birtles Also, update the serialization by the shorter perference because this is a new feature and using older syntax doesn't make sense. Besides, use `cssOffset` for web animation IDL attribute name. Differential Revision: https://phabricator.services.mozilla.com/D45607
6d6be499b8323bf1e13b045ad9893e7eb3d2a37d: Bug 1480665 - Implement the contain flag for ray() function. r=birtles
Boris Chiou <boris.chiou@gmail.com> - Mon, 16 Sep 2019 23:24:50 +0000 - rev 558303
Push 2195 by ffxbld-merge at Mon, 25 Nov 2019 12:02:33 +0000
Bug 1480665 - Implement the contain flag for ray() function. r=birtles Basically, the math calculation logic is from the github repo of the spec author, Eric: https://github.com/ewilligers/petrogale-purpureicollis/blob/20b7403d85d664eb943232e2a34bc95b6f4a8b62/ray.py#L311-L363 Differential Revision: https://phabricator.services.mozilla.com/D42722
6db0fd0a2252fa3b7a65be0cb054853d2a8837f2: Bug 1480665 - Support ray() in offset-path and make it animatable. r=emilio,birtles
Boris Chiou <boris.chiou@gmail.com> - Mon, 16 Sep 2019 23:24:48 +0000 - rev 558302
Push 2195 by ffxbld-merge at Mon, 25 Nov 2019 12:02:33 +0000
Bug 1480665 - Support ray() in offset-path and make it animatable. r=emilio,birtles 1. Add `generics::motion::OffsetPath`, and use specified `Angle` and computed `Angle` to define specified `OffsetPath` and computed `OffsetPath`. 2. Add `ray` function into `OffsetPath`. We also tweak the degree from 150deg to 135deg in wpt (e.g. offset-path-ray-001.html and others) to avoid floating point precision issues. For example: ``` // offset-path: ray(150deg ...); // offset-distance: 20px; matrix: { {0.500000 0.866025 0.000000 0.000000}, {-0.866025 0.500000 0.000000 0.000000}, {0.000000 0.000000 1.000000 0.000000}, {10.000000 17.320509 0.000000 1.000000} } // rotate(60deg) translate(20px) matrix: { {0.500000 0.866025 0.000000 0.000000}, {-0.866025 0.500000 0.000000 0.000000}, {0.000000 0.000000 1.000000 0.000000}, {10.000000 17.320507 0.000000 1.000000} } ``` Their translate parts, 17.320509 vs 17.320507, are almost the same (only tiny difference), which may cause the reftest failed. Differential Revision: https://phabricator.services.mozilla.com/D42721
62f5b57b9a03cad3963519d01d00c38e62525d26: Bug 1579062: Turn on dom.animations-api.implicit-keyframes.enabled for css-multicol tests. r=birtles
Daisuke Akatsuka <daisuke@birchill.co.jp> - Fri, 06 Sep 2019 04:29:12 +0000 - rev 556618
Push 2195 by ffxbld-merge at Mon, 25 Nov 2019 12:02:33 +0000
Bug 1579062: Turn on dom.animations-api.implicit-keyframes.enabled for css-multicol tests. r=birtles Depends on D44940 Differential Revision: https://phabricator.services.mozilla.com/D44941
2d92a2fa764ab55309211ad2576392a0504188aa: Bug 1579062: Turn on dom.animations-api.implicit-keyframes.enabled for css-transforms tests. r=birtles
Daisuke Akatsuka <daisuke@birchill.co.jp> - Fri, 06 Sep 2019 04:29:03 +0000 - rev 556617
Push 2195 by ffxbld-merge at Mon, 25 Nov 2019 12:02:33 +0000
Bug 1579062: Turn on dom.animations-api.implicit-keyframes.enabled for css-transforms tests. r=birtles Depends on D44939 Differential Revision: https://phabricator.services.mozilla.com/D44940
58011a2d3dbc75ca51a3d39819979a88f6663828: Bug 1579062: Turn on dom.animations-api.implicit-keyframes.enabled for css-backgrounds tests. r=birtles
Daisuke Akatsuka <daisuke@birchill.co.jp> - Fri, 06 Sep 2019 04:29:10 +0000 - rev 556616
Push 2195 by ffxbld-merge at Mon, 25 Nov 2019 12:02:33 +0000
Bug 1579062: Turn on dom.animations-api.implicit-keyframes.enabled for css-backgrounds tests. r=birtles Depends on D44938 Differential Revision: https://phabricator.services.mozilla.com/D44939
cc83d7fe35d8270ed04318c4c8ad1f6a376e8b37: Bug 1579062: Turn on dom.animations-api.implicit-keyframes.enabled for css-box tests. r=birtles
Daisuke Akatsuka <daisuke@birchill.co.jp> - Fri, 06 Sep 2019 04:29:01 +0000 - rev 556615
Push 2195 by ffxbld-merge at Mon, 25 Nov 2019 12:02:33 +0000
Bug 1579062: Turn on dom.animations-api.implicit-keyframes.enabled for css-box tests. r=birtles Differential Revision: https://phabricator.services.mozilla.com/D44938
6f1d654fcf37282daab20dd67806946187c66843: Bug 1578728: Turn on dom.animations-api.implicit-keyframes.enabled for css-shapes tests. r=birtles
Daisuke Akatsuka <daisuke@birchill.co.jp> - Thu, 05 Sep 2019 06:15:36 +0000 - rev 556471
Push 2195 by ffxbld-merge at Mon, 25 Nov 2019 12:02:33 +0000
Bug 1578728: Turn on dom.animations-api.implicit-keyframes.enabled for css-shapes tests. r=birtles Differential Revision: https://phabricator.services.mozilla.com/D44767
a45c5b31080b2b88b9a287e9b3c35a3f0d2817c7: Bug 1577642 - Move the timestamp rounding outside of the loop so it's only reduced once r=birtles
Tom Ritter <tom@mozilla.com> - Tue, 03 Sep 2019 22:38:45 +0000 - rev 556336
Push 2195 by ffxbld-merge at Mon, 25 Nov 2019 12:02:33 +0000
Bug 1577642 - Move the timestamp rounding outside of the loop so it's only reduced once r=birtles When we had it in the loop, we would continually reduce it, which held the possibility of bumping it down an epoch due to double imprecision. Now we only reduce it once, using all rAF callbacks get the same timestamp. Differential Revision: https://phabricator.services.mozilla.com/D44526
7cbf56646abc48796c70db8e93823db3e4ede0df: Bug 1577642 - Move the timestamp rounding outside of the loop so it's only reduced once r=birtles a=lizzard
Tom Ritter <tom@mozilla.com> - Tue, 03 Sep 2019 22:38:45 +0000 - rev 554928
Push 2165 by ffxbld-merge at Mon, 14 Oct 2019 16:30:58 +0000
Bug 1577642 - Move the timestamp rounding outside of the loop so it's only reduced once r=birtles a=lizzard When we had it in the loop, we would continually reduce it, which held the possibility of bumping it down an epoch due to double imprecision. Now we only reduce it once, using all rAF callbacks get the same timestamp. Differential Revision: https://phabricator.services.mozilla.com/D44526
725115d70e4f7c4fbd18ff7be5b181a86ba46e3f: Bug 1576892: Turn on dom.animations-api.implicit-keyframes.enabled for css-text tests. r=birtles
Daisuke Akatsuka <daisuke@birchill.co.jp> - Fri, 30 Aug 2019 05:01:51 +0000 - rev 554576
Push 2165 by ffxbld-merge at Mon, 14 Oct 2019 16:30:58 +0000
Bug 1576892: Turn on dom.animations-api.implicit-keyframes.enabled for css-text tests. r=birtles Depends on D44100 Differential Revision: https://phabricator.services.mozilla.com/D44101
a674f8e0369dabb45b976e205e9f87ef862abb30: Bug 1576892: Turn on dom.animations-api.implicit-keyframes.enabled for css-position tests. r=birtles
Daisuke Akatsuka <daisuke@birchill.co.jp> - Fri, 30 Aug 2019 05:01:53 +0000 - rev 554575
Push 2165 by ffxbld-merge at Mon, 14 Oct 2019 16:30:58 +0000
Bug 1576892: Turn on dom.animations-api.implicit-keyframes.enabled for css-position tests. r=birtles Depends on D44099 Differential Revision: https://phabricator.services.mozilla.com/D44100
e0978ab17d5de76c867628599269621e5dd36b59: Bug 1576892: Turn on dom.animations-api.implicit-keyframes.enabled for css-fonts tests. r=birtles
Daisuke Akatsuka <daisuke@birchill.co.jp> - Fri, 30 Aug 2019 05:06:16 +0000 - rev 554574
Push 2165 by ffxbld-merge at Mon, 14 Oct 2019 16:30:58 +0000
Bug 1576892: Turn on dom.animations-api.implicit-keyframes.enabled for css-fonts tests. r=birtles Differential Revision: https://phabricator.services.mozilla.com/D44099
02bfa4baa2edd2d1c9417018c4cbd85e99d15aa8: Bug 1577243 - Backed out changeset cae99e27ccdd, restoring document.timeline and rAF timestamp comparisons r=birtles
Tom Ritter <tom@mozilla.com> - Wed, 28 Aug 2019 23:44:14 +0000 - rev 554396
Push 2165 by ffxbld-merge at Mon, 14 Oct 2019 16:30:58 +0000
Bug 1577243 - Backed out changeset cae99e27ccdd, restoring document.timeline and rAF timestamp comparisons r=birtles Depends on D43788 Differential Revision: https://phabricator.services.mozilla.com/D43789
565a897065e0deb97864b7635bfb0185e88c4048: Bug 1577243 - Unconditionally clamp the requestAnimationFrame timestamp (and clamp/jitter it in RFP mode) r=birtles
Tom Ritter <tom@mozilla.com> - Wed, 28 Aug 2019 23:44:07 +0000 - rev 554395
Push 2165 by ffxbld-merge at Mon, 14 Oct 2019 16:30:58 +0000
Bug 1577243 - Unconditionally clamp the requestAnimationFrame timestamp (and clamp/jitter it in RFP mode) r=birtles In Bug 1387894 we created a mode for Firefox where it unconditionally clamps all timestamps to 20 microseconds. This happens if you disable privacy.reduceTimerPrecision (which is on by default) and is so we don't inadvertently leak super-high-resolution (nanosec) timestamps. As part of that patch, we started clamping animation timestamps - which are exempted from privacy.reduceTimerPrecision because it was too difficult to get them working at the time. (We should still fix that though.) This caused new test failures, and one of those was a comparison between document timelines and the timestamp in requestAnimationFrame. we were not clamping the timestamp in requestAnimationFrame under the logic that it fires in predictable intervals. However discussions about the WPT change we made to 'fix' the now-broken comparison https://github.com/web-platform-tests/wpt/pull/18172 and https://github.com/web-platform-tests/wpt/pull/18357 showed me that document.timeline is supposed to be slaved to the requestAnimationFrame timestamp (or vice versa.) The correct fix is therefore to unconditionally clamp the requestAnimationFrame timestamp AND the document.timeline timestamp. In doing so we also start clamping/jittering the requestAnimationFrame timestamp in Resist Fingerprinting mode, so that might cause some new/unexpected behaviors for that mode we should watch out for. Differential Revision: https://phabricator.services.mozilla.com/D43788
d4b4d46545b3f0c05b8ce7cb5b0e766aa304f9ab: Bug 1577236 - clang-10: Fix -Wimplicit-int-float-conversion warnings in dom/smil r=birtles
Sylvestre Ledru <sledru@mozilla.com> - Thu, 29 Aug 2019 06:37:38 +0000 - rev 554336
Push 2165 by ffxbld-merge at Mon, 14 Oct 2019 16:30:58 +0000
Bug 1577236 - clang-10: Fix -Wimplicit-int-float-conversion warnings in dom/smil r=birtles Depends on D43778 Differential Revision: https://phabricator.services.mozilla.com/D43779
c5ef2fb8522499d82d2805a2f77b1739bfafccbc: Bug 1576892: Turn on dom.animations-api.implicit-keyframes.enabled pref. r=birtles
Daisuke Akatsuka <daisuke@birchill.co.jp> - Thu, 29 Aug 2019 01:45:18 +0000 - rev 554291
Push 2165 by ffxbld-merge at Mon, 14 Oct 2019 16:30:58 +0000
Bug 1576892: Turn on dom.animations-api.implicit-keyframes.enabled pref. r=birtles Differential Revision: https://phabricator.services.mozilla.com/D43886
38bd63ec76c797c4d04cc158330af0d45533cd8d: Bug 1577156: Turn on dom.animations-api.implicit-keyframes.enabled pref. r=birtles
Daisuke Akatsuka <daisuke@birchill.co.jp> - Thu, 29 Aug 2019 01:34:30 +0000 - rev 554290
Push 2165 by ffxbld-merge at Mon, 14 Oct 2019 16:30:58 +0000
Bug 1577156: Turn on dom.animations-api.implicit-keyframes.enabled pref. r=birtles Depends on D43886 Differential Revision: https://phabricator.services.mozilla.com/D43887
270abd593fa43bf48038326f8e66a3bb2f2e8276: Bug 1577163: Turn on dom.animations-api.implicit-keyframes.enabled pref. r=birtles
Daisuke Akatsuka <daisuke@birchill.co.jp> - Thu, 29 Aug 2019 01:34:37 +0000 - rev 554289
Push 2165 by ffxbld-merge at Mon, 14 Oct 2019 16:30:58 +0000
Bug 1577163: Turn on dom.animations-api.implicit-keyframes.enabled pref. r=birtles Depends on D43887 Differential Revision: https://phabricator.services.mozilla.com/D43888
1d9715fd32fc3757e7d37d578f9581901c0c6e24: Bug 1571038 - Copy test logic for scrolled out element to out of view element r=birtles
Tom Ritter <tom@mozilla.com> - Mon, 05 Aug 2019 23:16:14 +0000 - rev 550209
Push 2165 by ffxbld-merge at Mon, 14 Oct 2019 16:30:58 +0000
Bug 1571038 - Copy test logic for scrolled out element to out of view element r=birtles Differential Revision: https://phabricator.services.mozilla.com/D40664
1c82a9581ad6708dce653bcbe4857b095b64f02a: Bug 1571227 - Fix test_restyles to account for double imprecision r=birtles
Tom Ritter <tom@mozilla.com> - Mon, 05 Aug 2019 22:45:48 +0000 - rev 550208
Push 2165 by ffxbld-merge at Mon, 14 Oct 2019 16:30:58 +0000
Bug 1571227 - Fix test_restyles to account for double imprecision r=birtles Differential Revision: https://phabricator.services.mozilla.com/D40663
7c6c3ac5f8fd987fd47e473e4457266498e48f1f: Bug 1559231 - Make offset-anchor animatable. r=birtles
Boris Chiou <boris.chiou@gmail.com> - Fri, 02 Aug 2019 20:12:40 +0000 - rev 549795
Push 2165 by ffxbld-merge at Mon, 14 Oct 2019 16:30:58 +0000
Bug 1559231 - Make offset-anchor animatable. r=birtles Per the spec issue, https://github.com/w3c/csswg-drafts/issues/3482, we update the wpt to keep the percentage in `calc()` for `offset-anchor`. Differential Revision: https://phabricator.services.mozilla.com/D39552
d47d9f4bf9a9ea8b816534916292ca446c7543ce: Bug 1559231 - Make offset-anchor animatable. r=birtles
Boris Chiou <boris.chiou@gmail.com> - Fri, 02 Aug 2019 00:47:09 +0000 - rev 549747
Push 2165 by ffxbld-merge at Mon, 14 Oct 2019 16:30:58 +0000
Bug 1559231 - Make offset-anchor animatable. r=birtles Per the spec issue, https://github.com/w3c/csswg-drafts/issues/3482, we update the wpt to keep the percentage in `calc()` for `offset-anchor`. Differential Revision: https://phabricator.services.mozilla.com/D39552
38e17f634ce4e77bfbf665fe920094012c349bb6: Bug 1387894 - Disable unconditional clamping for two CSS tests. r=birtles
Tom Ritter <tom@mozilla.com> - Fri, 02 Aug 2019 07:36:59 +0200 - rev 549662
Push 2165 by ffxbld-merge at Mon, 14 Oct 2019 16:30:58 +0000
Bug 1387894 - Disable unconditional clamping for two CSS tests. r=birtles We're hitting double imprecision here. Example: Given 86.68392200000000 and 86.67999999999999 we want to see if they're equal with two significant digits. (They are, they're 86.68) However, when we reduce them, 86.68 (which is represented as an epislon lower) gets reduced to 86.66 and they no longer match. We disable unconditional clamping on these tests to confirm they behave the way they shoud... excepting the clamping which may introduce imprecision. Differential Revision: https://phabricator.services.mozilla.com/D38812 Depends on D38811