searching for reviewer(aosmond)
e635e759e439d595ef59d3aa9befbbe8da0fcfb6: Bug 1565542. We need to check to resolve image decode promises when we get the frame update notification too. r=aosmond a=jcristau
Timothy Nikkel <tnikkel@gmail.com> - Mon, 29 Jul 2019 13:05:14 +0000 - rev 537281
Push 2122 by archaeopteryx@coole-files.de at Wed, 07 Aug 2019 14:22:14 +0000
Bug 1565542. We need to check to resolve image decode promises when we get the frame update notification too. r=aosmond a=jcristau When we reload the document the destruction of the old document triggers a discard request for the image. If timing is right we haven't locked the image in the new document yet so it discards. We call LoadImage on the image, it returns the existing entry from the image cache, but it needs to validate. When it validates we send out all the progress in the progress tracker already. This includes frame complete and decode complete even though we have no decoded surfaces for this image right now. The RequestDecodeForSize call in nsImageLoadingContent::MaybeResolveDecodePromises triggers a decode. When the decode finishes we send a frame update notification but we never send frame complete or decode complete because those are permanent once they happen. Differential Revision: https://phabricator.services.mozilla.com/D39585
3b9d6043de6a954f0ae0111477c1cf3d6af4d9a0: Bug 1563854 - Restrict Nvidia blocklist entry to the proprietary driver. r=aosmond a=RyanVM
Jan Andre Ikenmeyer <jan@ikenmeyer.eu> - Tue, 16 Jul 2019 03:56:49 +0200 - rev 537268
Push 2118 by archaeopteryx@coole-files.de at Thu, 01 Aug 2019 11:01:26 +0000
Bug 1563854 - Restrict Nvidia blocklist entry to the proprietary driver. r=aosmond a=RyanVM Differential Revision: https://phabricator.services.mozilla.com//D38155
e56d843335ef048ff651a89d64257baea6271a20: Bug 1550437: Make sure that About dialog animates the throbber. r=aosmond r=jcristau
Will Hawkins <whawkins@mozilla.com> - Tue, 11 Jun 2019 14:19:43 +0000 - rev 536966
Push 2082 by ffxbld-merge at Mon, 01 Jul 2019 08:34:18 +0000
Bug 1550437: Make sure that About dialog animates the throbber. r=aosmond r=jcristau Differential Revision: https://phabricator.services.mozilla.com/D34429
223180843523d3463d030bf81603b1f0125424a7: Bug 1556076. Restore checking the return value of MakeInputStream in nsIconChannel on mac. r=aosmond a=jcristau
Timothy Nikkel <tnikkel@gmail.com> - Thu, 06 Jun 2019 12:33:00 +0300 - rev 536721
Push 2082 by ffxbld-merge at Mon, 01 Jul 2019 08:34:18 +0000
Bug 1556076. Restore checking the return value of MakeInputStream in nsIconChannel on mac. r=aosmond a=jcristau Summary: Bug 1520868 accidentally removed this check. Reviewers: aosmond Reviewed By: aosmond Bug #: 1556076 Differential Revision: https://phabricator.services.mozilla.com/D33892
d9e4be41b43a2808bb6911953080212c92e88038: Bug 1554540 - Follow up to fix broken browser chrome tests. r=aosmond a=jcristau
Andrew Osmond <aosmond@mozilla.com> - Tue, 28 May 2019 08:02:01 -0400 - rev 536609
Push 2082 by ffxbld-merge at Mon, 01 Jul 2019 08:34:18 +0000
Bug 1554540 - Follow up to fix broken browser chrome tests. r=aosmond a=jcristau
38242d8c9a083f03649a4a0cfc6d4fd42b164f2f: Bug 1551257. Enable WebRender by default on Broadwell GT2+. r=aosmond
Jeff Muizelaar <jrmuizel@gmail.com> - Mon, 13 May 2019 16:43:52 +0000 - rev 535511
Push 2082 by ffxbld-merge at Mon, 01 Jul 2019 08:34:18 +0000
Bug 1551257. Enable WebRender by default on Broadwell GT2+. r=aosmond I think we just accidentally forgot these ids when we added more mobile chips. Differential Revision: https://phabricator.services.mozilla.com/D30940
c477a96a488995459baab0948a10cb7231d7cbe3: Bug 1548349 - Make sure the image cache for third-party tracking subresources is keyed to the top-level document's eTLD+1; r=baku,aosmond
Ehsan Akhgari <ehsan@mozilla.com> - Thu, 02 May 2019 12:27:07 +0000 - rev 534194
Push 2082 by ffxbld-merge at Mon, 01 Jul 2019 08:34:18 +0000
Bug 1548349 - Make sure the image cache for third-party tracking subresources is keyed to the top-level document's eTLD+1; r=baku,aosmond Differential Revision: https://phabricator.services.mozilla.com/D29546
5acce9aaceb96cd5b8c0c9fde26286752e8cae29: Bug 1377457. Only apply locks to the image if SetHasImage has been called. r=aosmond
Timothy Nikkel <tnikkel@gmail.com> - Wed, 01 May 2019 23:05:47 +0000 - rev 534080
Push 2082 by ffxbld-merge at Mon, 01 Jul 2019 08:34:18 +0000
Bug 1377457. Only apply locks to the image if SetHasImage has been called. r=aosmond This was observed in an intermittent failure of image/test/mochitest/test_discardAnimatedImage.html. What happened was: 1) Document::MaybePreLoadImage was called for the images in the test. 2) imgRequest::OnDataAvailable is called on at least one of the images. This creates the RasterImage, so any proxy for this imgRequest will now return the image via GetImage(). imgRequest::OnDataAvailable also queues the FinishPreparingForNewPartRunnable back to the main thread to call OnImageAvailable on the progress tracker on the main thread. 3) We get the actual LoadImage calls for the images of the document. We create new proxies for the existing imgRequests. imgRequestProxy::Init calls mBehaviour->SetOwner(aOwner), which sets mOwnerHasImage to true because the progress tracker has an mImage (the one we created above). 4) We get a call to LockImage, this gets forwarded to the RasterImage because mOwnerHasImage is true and we can access the image. 5) The FinishPreparingForNewPartRunnable finally runs on the main thread. The OnImageAvailable notification from the progress tracker ends up in imgRequestProxy::SetHasImage. imgRequestProxy::SetHasImage applies our local count mLockCount to the RasterImage, even though we've already forwarded one of those LockImage calls to the image. LockImage calls are now unbalanced and the image will always remain locked. The fix is simple. Only apply the Lock/Unlock calls if the FinishPreparingForNewPartRunnable has hit the main thread (ie ignore an image we can access until this happens). Differential Revision: https://phabricator.services.mozilla.com/D29326
a14cf357555a477bc2fcfbe746a3d9d33ffee171: Bug 1547702 - Allow WebRender on more qualified Intel hardware. r=aosmond
Jeff Muizelaar <jmuizelaar@mozilla.com> - Mon, 29 Apr 2019 09:30:32 -0400 - rev 533622
Push 2082 by ffxbld-merge at Mon, 01 Jul 2019 08:34:18 +0000
Bug 1547702 - Allow WebRender on more qualified Intel hardware. r=aosmond
179c0370dfa12b59d2214509d41a8356962f5df7: Bug 1513236 - Update libpng to version 1.6.37. r=aosmond
Ryan VanderMeulen <ryanvm@gmail.com> - Tue, 23 Apr 2019 22:04:35 +0000 - rev 532453
Push 2082 by ffxbld-merge at Mon, 01 Jul 2019 08:34:18 +0000
Bug 1513236 - Update libpng to version 1.6.37. r=aosmond Differential Revision: https://phabricator.services.mozilla.com/D15239
081b83f886c2307bac0b0ee189d5faa6efe80b64: Bug 1544668. Register/Deregister for activity observer in nsImageLoadingContent as an Element. r=aosmond
Timothy Nikkel <tnikkel@gmail.com> - Thu, 18 Apr 2019 17:31:10 +0000 - rev 532127
Push 2082 by ffxbld-merge at Mon, 01 Jul 2019 08:34:18 +0000
Bug 1544668. Register/Deregister for activity observer in nsImageLoadingContent as an Element. r=aosmond When an imageloadingcontent is moved between documents, nsNodeUtils::CloneAndAdopt looks for it as an element in the list of activity observers, and so it doesn't find it to remove and add to the new doc. Differential Revision: https://phabricator.services.mozilla.com/D28002
3fd42eb67a3f9f2502e4c299b20112c53bb9dbff: Bug 1540221 - Setting fillStyle to a pattern of an unclean canvas makes the canvas origin-unclean, r=aosmond
Andrea Marchesini <amarchesini@mozilla.com> - Tue, 16 Apr 2019 06:58:29 +0000 - rev 531513
Push 2082 by ffxbld-merge at Mon, 01 Jul 2019 08:34:18 +0000
Bug 1540221 - Setting fillStyle to a pattern of an unclean canvas makes the canvas origin-unclean, r=aosmond Differential Revision: https://phabricator.services.mozilla.com/D25773
aa0feb50773a391760802da8121742653321d1ce: Bug 1540221 - Setting fillStyle to a pattern of an unclean canvas makes the canvas origin-unclean, r=aosmond
Andrea Marchesini <amarchesini@mozilla.com> - Tue, 09 Apr 2019 20:10:03 +0000 - rev 530788
Push 2082 by ffxbld-merge at Mon, 01 Jul 2019 08:34:18 +0000
Bug 1540221 - Setting fillStyle to a pattern of an unclean canvas makes the canvas origin-unclean, r=aosmond Differential Revision: https://phabricator.services.mozilla.com/D25773
ffaff6fb1fe3b38604abea4d980401f319aad43e: Bug 1542829 - Backport an upstream libpng patch. r=aosmond
Ryan VanderMeulen <ryanvm@gmail.com> - Mon, 08 Apr 2019 19:00:31 +0000 - rev 530344
Push 2082 by ffxbld-merge at Mon, 01 Jul 2019 08:34:18 +0000
Bug 1542829 - Backport an upstream libpng patch. r=aosmond Differential Revision: https://phabricator.services.mozilla.com/D26575
fef6d0da61e33f8fd225fb002d07f048165cd988: Bug 1540492. Fix some bugs in test_discardAnimatedImage.html. r=aosmond
Timothy Nikkel <tnikkel@gmail.com> - Mon, 01 Apr 2019 10:56:14 +0000 - rev 529312
Push 2082 by ffxbld-merge at Mon, 01 Jul 2019 08:34:18 +0000
Bug 1540492. Fix some bugs in test_discardAnimatedImage.html. r=aosmond Bug 1503653 added webp images to this test but didn't update everywhere necessary in the test file. This doesn't fix any intermittents with this test as far as I know. Differential Revision: https://phabricator.services.mozilla.com/D25527
f5dd833c3b60b3365d2c49d930748e33a22651b6: Bug 1354913: Fix nsDeckFrame, nsImageBoxFrame and nsImageFrame so that nsDeckFrame does not tick the refresh driver when its child images are animated and hidden. r=aosmond
Will Hawkins <whawkins@mozilla.com> - Mon, 25 Mar 2019 19:11:22 +0000 - rev 527890
Push 2082 by ffxbld-merge at Mon, 01 Jul 2019 08:34:18 +0000
Bug 1354913: Fix nsDeckFrame, nsImageBoxFrame and nsImageFrame so that nsDeckFrame does not tick the refresh driver when its child images are animated and hidden. r=aosmond Differential Revision: https://phabricator.services.mozilla.com/D24598
1a95e4b8b2d28e76ef63335f96f2b4cc151497f9: Bug 1556076. Restore checking the return value of MakeInputStream in nsIconChannel on mac. r=aosmond a=pascalc FENNEC_67_0_2_BUILD1 FENNEC_67_0_2_RELEASE FIREFOX_67_0_2_BUILD2 FIREFOX_67_0_2_RELEASE
Timothy Nikkel <tnikkel@gmail.com> - Thu, 06 Jun 2019 12:33:00 +0300 - rev 526589
Push 2063 by archaeopteryx@coole-files.de at Fri, 07 Jun 2019 20:48:18 +0000
Bug 1556076. Restore checking the return value of MakeInputStream in nsIconChannel on mac. r=aosmond a=pascalc Differential Revision: https://phabricator.services.mozilla.com/D33892
3a1b53518d5ff472eb17f214bb02fc82b1675890: Bug 1540221 - Setting fillStyle to a pattern of an unclean canvas makes the canvas origin-unclean, r=aosmond a=pascalc
Andrea Marchesini <amarchesini@mozilla.com> - Tue, 16 Apr 2019 06:58:29 +0000 - rev 526303
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1540221 - Setting fillStyle to a pattern of an unclean canvas makes the canvas origin-unclean, r=aosmond a=pascalc Differential Revision: https://phabricator.services.mozilla.com/D25773
e52e74683afcfd9434253927cc54c9081b28a187: Bug 1542829 - Backport an upstream libpng patch. r=aosmond a=pascalc
Ryan VanderMeulen <ryanvm@gmail.com> - Mon, 08 Apr 2019 19:00:31 +0000 - rev 526105
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1542829 - Backport an upstream libpng patch. r=aosmond a=pascalc Differential Revision: https://phabricator.services.mozilla.com/D26575
355c9ff9b89581cf5b2ff03f3df9df05939f89c3: Bug 1526717. Guard against libpng calling the info callback more than once. r=aosmond
Timothy Nikkel <tnikkel@gmail.com> - Thu, 14 Mar 2019 14:32:37 -0500 - rev 524998
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1526717. Guard against libpng calling the info callback more than once. r=aosmond libpng uses the first IDAT chunk it encounters as a signal that it has read all header chunks and to send the info callback. The testcase png has an IDAT chunk, then a z chunk (not a known chunk type), and then another IDAT chunk. libpng tracks if we are in an "after idat" state, and throws a benign error if it encounters another IDAT chunk in "after idat" mode, but it just continues normally, processing the idat chunk as if it were the first and therefore sends the info callback again. This seems silly. https://searchfox.org/mozilla-central/rev/f1c7ba91fad60bfea184006f3728dd6ac48c8e56/media/libpng/pngpread.c#307
240e874ed11862376247ea177a88ddf00924e0da: Bug 1523969 part 10 - Move method definition inline comments to new line in 'image/'. r=aosmond
Ryan Hunt <rhunt@eqrion.net> - Mon, 25 Feb 2019 16:07:58 -0600 - rev 522771
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1523969 part 10 - Move method definition inline comments to new line in 'image/'. r=aosmond Differential Revision: https://phabricator.services.mozilla.com/D21110
deda484b0623a4ab81833df97e01ddc6bafc967a: Bug 1529056 - Improve createImageBitmap and origin-clean tests, r=aosmond
Andrea Marchesini <amarchesini@mozilla.com> - Mon, 25 Feb 2019 17:56:40 +0000 - rev 521823
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1529056 - Improve createImageBitmap and origin-clean tests, r=aosmond Differential Revision: https://phabricator.services.mozilla.com/D20380
4a01452528cd75f9f41822da71ab011389502150: Bug 1515823. Disable Direct2D on Qualcomm devices. r=aosmond
Jeff Muizelaar <jrmuizel@gmail.com> - Thu, 21 Feb 2019 13:27:04 -0500 - rev 521197
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1515823. Disable Direct2D on Qualcomm devices. r=aosmond There seem to be a number of problems with Direct2D on the Qualcomm devices. This includes visual corruption from bug 1515823 and crashes in CHwRasterizer::RasterizeEdges from 1515387.
b551452756283b283d54705d41ff30518ed2f2d5: Bug 1528909 - cross-origin checks in CanvasRenderingContext2D::DrawImage, r=aosmond
Andrea Marchesini <amarchesini@mozilla.com> - Wed, 20 Feb 2019 22:54:04 +0000 - rev 521110
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1528909 - cross-origin checks in CanvasRenderingContext2D::DrawImage, r=aosmond Differential Revision: https://phabricator.services.mozilla.com/D20350
de5c7c2699c423e7d79f8e3f3c0e876128750328: Bug 1506376 - Make PCompositorBridge::DidComposite high priority message, r=aosmond
Olli Pettay <Olli.Pettay@helsinki.fi> - Fri, 08 Feb 2019 14:46:56 +0200 - rev 519601
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1506376 - Make PCompositorBridge::DidComposite high priority message, r=aosmond
473bed49a2fd6d7a128ef11e778366b5beec897f: Bug 1500257 part 8 - Remove dependency on RenderFrame from nsDisplayRemote. r=aosmond
Ryan Hunt <rhunt@eqrion.net> - Wed, 23 Jan 2019 11:07:57 -0600 - rev 519505
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1500257 part 8 - Remove dependency on RenderFrame from nsDisplayRemote. r=aosmond This commit removes the dependency on RenderFrame from nsDisplayRemote so that it can work in child processes with remote subframes. Instead nsDisplayRemote now works with an nsFrameLoader, which will return the LayerId from either the RenderFrame (for top-level remote browsers), or from RemoteFrameChild (for remote subframes). Differential Revision: https://phabricator.services.mozilla.com/D17448
0d0e20cf0c2e93e2183209b2f49b61414cd8d702: Bug 1500257 part 7 - Modify RenderFrame to hold onto TabParent instead of nsFrameLoader. r=aosmond
Ryan Hunt <rhunt@eqrion.net> - Wed, 23 Jan 2019 09:52:30 -0600 - rev 519504
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1500257 part 7 - Modify RenderFrame to hold onto TabParent instead of nsFrameLoader. r=aosmond A TabParent for a remote subframe will have the same owner content as the top-level remote browser. This means that 'TabParent::GetFrameLoader()' will return the frame loader of the top-level remote browser. This is fine for getting the layer manager and compositor for connecting layer trees, but the frame loader is also used to acquire a TabParent for its process ID. This is incorrect in the remote subframe case, and will lead to the compositor rejecting layer transactions for the remote subframe because it will only accept them from the top-level remote browser's process. This commit switches RenderFrame to just hold on to TabParent, and acquire the nsFrameLoader as necessary. Another change is to RenderFrame::SetOwnerContent. Previously this method would take the new owner content and check an assertion. I don't see much value in the assertion, so I've removed it. Additionally, now that we acquire the owner content, and therefore the layer manager, from TabParent, we need to ensure that RenderFrame::SetOwnerContent is ran after the TabParent has had it's owner content updated. So the callsite has been moved into TabParent. This resolved a test failure with frame loader swapping. Differential Revision: https://phabricator.services.mozilla.com/D17447
fa01a3a883af0adfd9455a154852f4c8b54c9855: Bug 1500257 part 6 - Update documentation for RenderFrame and nsDisplayRemote. r=aosmond
Ryan Hunt <rhunt@eqrion.net> - Wed, 23 Jan 2019 09:34:29 -0600 - rev 519503
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1500257 part 6 - Update documentation for RenderFrame and nsDisplayRemote. r=aosmond The documentation for these pieces are a bit out of date. Differential Revision: https://phabricator.services.mozilla.com/D17446
1dc5c6572cf1eca5c283741ba043a9ecf2f7ac39: Bug 1526218 - transferFromImageBitmap() should propage the origin-clean state to the canvas element, r=aosmond
Andrea Marchesini <amarchesini@mozilla.com> - Mon, 11 Feb 2019 16:54:05 +0000 - rev 519404
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1526218 - transferFromImageBitmap() should propage the origin-clean state to the canvas element, r=aosmond Differential Revision: https://phabricator.services.mozilla.com/D19371
a62c029510315d109faa9edb31216014e7c70367: Bug 1500257 part 8 - Remove dependency on RenderFrame from nsDisplayRemote. r=aosmond
Ryan Hunt <rhunt@eqrion.net> - Wed, 23 Jan 2019 11:07:57 -0600 - rev 519310
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1500257 part 8 - Remove dependency on RenderFrame from nsDisplayRemote. r=aosmond This commit removes the dependency on RenderFrame from nsDisplayRemote so that it can work in child processes with remote subframes. Instead nsDisplayRemote now works with an nsFrameLoader, which will return the LayerId from either the RenderFrame (for top-level remote browsers), or from RemoteFrameChild (for remote subframes). Differential Revision: https://phabricator.services.mozilla.com/D17448
62ad54fb95eb76f88865f43da1a5d556421e7884: Bug 1500257 part 7 - Modify RenderFrame to hold onto TabParent instead of nsFrameLoader. r=aosmond
Ryan Hunt <rhunt@eqrion.net> - Wed, 23 Jan 2019 09:52:30 -0600 - rev 519309
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1500257 part 7 - Modify RenderFrame to hold onto TabParent instead of nsFrameLoader. r=aosmond A TabParent for a remote subframe will have the same owner content as the top-level remote browser. This means that 'TabParent::GetFrameLoader()' will return the frame loader of the top-level remote browser. This is fine for getting the layer manager and compositor for connecting layer trees, but the frame loader is also used to acquire a TabParent for its process ID. This is incorrect in the remote subframe case, and will lead to the compositor rejecting layer transactions for the remote subframe because it will only accept them from the top-level remote browser's process. This commit switches RenderFrame to just hold on to TabParent, and acquire the nsFrameLoader as necessary. Another change is to RenderFrame::SetOwnerContent. Previously this method would take the new owner content and check an assertion. I don't see much value in the assertion, so I've removed it. Additionally, now that we acquire the owner content, and therefore the layer manager, from TabParent, we need to ensure that RenderFrame::SetOwnerContent is ran after the TabParent has had it's owner content updated. So the callsite has been moved into TabParent. This resolved a test failure with frame loader swapping. Differential Revision: https://phabricator.services.mozilla.com/D17447
caafb04b7dd44d607adfa1f5f5cabcd42e367cf4: Bug 1500257 part 6 - Update documentation for RenderFrame and nsDisplayRemote. r=aosmond
Ryan Hunt <rhunt@eqrion.net> - Wed, 23 Jan 2019 09:34:29 -0600 - rev 519308
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1500257 part 6 - Update documentation for RenderFrame and nsDisplayRemote. r=aosmond The documentation for these pieces are a bit out of date. Differential Revision: https://phabricator.services.mozilla.com/D17446
1e1b5cd23412a85fad19ab8ec5aacf31b3a9c9b6: Bug 1500257 part 8 - Remove dependency on RenderFrame from nsDisplayRemote. r=aosmond
Ryan Hunt <rhunt@eqrion.net> - Wed, 23 Jan 2019 11:07:57 -0600 - rev 519281
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1500257 part 8 - Remove dependency on RenderFrame from nsDisplayRemote. r=aosmond This commit removes the dependency on RenderFrame from nsDisplayRemote so that it can work in child processes with remote subframes. Instead nsDisplayRemote now works with an nsFrameLoader, which will return the LayerId from either the RenderFrame (for top-level remote browsers), or from RemoteFrameChild (for remote subframes). Differential Revision: https://phabricator.services.mozilla.com/D17448
4c85fb68f2ed297828bf4646301c2d80d1c8e0a1: Bug 1500257 part 7 - Modify RenderFrame to hold onto TabParent instead of nsFrameLoader. r=aosmond
Ryan Hunt <rhunt@eqrion.net> - Wed, 23 Jan 2019 09:52:30 -0600 - rev 519280
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1500257 part 7 - Modify RenderFrame to hold onto TabParent instead of nsFrameLoader. r=aosmond A TabParent for a remote subframe will have the same owner content as the top-level remote browser. This means that 'TabParent::GetFrameLoader()' will return the frame loader of the top-level remote browser. This is fine for getting the layer manager and compositor for connecting layer trees, but the frame loader is also used to acquire a TabParent for its process ID. This is incorrect in the remote subframe case, and will lead to the compositor rejecting layer transactions for the remote subframe because it will only accept them from the top-level remote browser's process. This commit switches RenderFrame to just hold on to TabParent, and acquire the nsFrameLoader as necessary. Another change is to RenderFrame::SetOwnerContent. Previously this method would take the new owner content and check an assertion. I don't see much value in the assertion, so I've removed it. Additionally, now that we acquire the owner content, and therefore the layer manager, from TabParent, we need to ensure that RenderFrame::SetOwnerContent is ran after the TabParent has had it's owner content updated. So the callsite has been moved into TabParent. This resolved a test failure with frame loader swapping. Differential Revision: https://phabricator.services.mozilla.com/D17447
ba62cc27c32f4d8a3fefff8eee5bf47d270130bc: Bug 1500257 part 6 - Update documentation for RenderFrame and nsDisplayRemote. r=aosmond
Ryan Hunt <rhunt@eqrion.net> - Wed, 23 Jan 2019 09:34:29 -0600 - rev 519279
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1500257 part 6 - Update documentation for RenderFrame and nsDisplayRemote. r=aosmond The documentation for these pieces are a bit out of date. Differential Revision: https://phabricator.services.mozilla.com/D17446
b0f67b8917f4c224e4b2a5ab7d1c2ee5590efc3f: Bug 1506376 - Make PCompositorBridge::DidComposite high priority message, r=aosmond
Olli Pettay <Olli.Pettay@helsinki.fi> - Fri, 08 Feb 2019 14:46:56 +0200 - rev 519196
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1506376 - Make PCompositorBridge::DidComposite high priority message, r=aosmond
cab981ef743b8e637d7d1bfcab49df0d4caaf3fb: Bug 1506376 - Make PCompositorBridge::DidComposite high priority message, r=aosmond
Olli Pettay <Olli.Pettay@helsinki.fi> - Fri, 08 Feb 2019 14:46:56 +0200 - rev 519184
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1506376 - Make PCompositorBridge::DidComposite high priority message, r=aosmond
97f2cfdbba0709fa304ce77ac7eef7146f134c12: Bug 1506495. Fallback to the system profile if we can't read the file for the profile. r=aosmond
Jeff Muizelaar <jrmuizel@gmail.com> - Fri, 01 Feb 2019 14:10:22 -0500 - rev 517402
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1506495. Fallback to the system profile if we can't read the file for the profile. r=aosmond This is a better default than just assuming no profile.
c36dbe29db24800d3e3ac6aa2bb8593c80df8b66: Bug 1522948 - Re-enable previously failing CSS background web platform tests for WebRender. r=aosmond
Andrew Osmond <aosmond@mozilla.com> - Fri, 25 Jan 2019 14:48:53 -0500 - rev 516533
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1522948 - Re-enable previously failing CSS background web platform tests for WebRender. r=aosmond
fb8a1b398f229ff4f7ce8b5d1234a08002ac8353: Bug 1515823 - Disable Direct2D on Qualcomm devices. r=aosmond a=lizzard
Jeff Muizelaar <jrmuizel@gmail.com> - Thu, 21 Feb 2019 13:27:04 -0500 - rev 516193
Push 1953 by ffxbld-merge at Mon, 11 Mar 2019 12:10:20 +0000
Bug 1515823 - Disable Direct2D on Qualcomm devices. r=aosmond a=lizzard There seem to be a number of problems with Direct2D on the Qualcomm devices. This includes visual corruption from bug 1515823 and crashes in CHwRasterizer::RasterizeEdges from 1515387.
e0a8013cd9c9723b19427ca24e7202e37822e3ad: Bug 1528909 - cross-origin checks in CanvasRenderingContext2D::DrawImage. r=aosmond, a=RyanVM DEVEDITION_66_0b10_BUILD1 DEVEDITION_66_0b10_RELEASE FIREFOX_66_0b10_BUILD1 FIREFOX_66_0b10_RELEASE
Andrea Marchesini <amarchesini@mozilla.com> - Wed, 20 Feb 2019 22:54:04 +0000 - rev 516070
Push 1953 by ffxbld-merge at Mon, 11 Mar 2019 12:10:20 +0000
Bug 1528909 - cross-origin checks in CanvasRenderingContext2D::DrawImage. r=aosmond, a=RyanVM Differential Revision: https://phabricator.services.mozilla.com/D20350
820b728e1ebe6dd1b211c9a8feb677104719b5ab: Bug 1516425 - Avoid unnecessarily attaching layers during shutdown of TabParent. r=aosmond, a=abillings
Ryan Hunt <rhunt@eqrion.net> - Fri, 11 Jan 2019 13:24:57 -0600 - rev 516064
Push 1953 by ffxbld-merge at Mon, 11 Mar 2019 12:10:20 +0000
Bug 1516425 - Avoid unnecessarily attaching layers during shutdown of TabParent. r=aosmond, a=abillings
d9a3fc93437f01530bc58ddf984e75837994cd57: Bug 1526218 - transferFromImageBitmap() should propage the origin-clean state to the canvas element. r=aosmond, a=RyanVM DEVEDITION_66_0b7_BUILD1 DEVEDITION_66_0b7_RELEASE FENNEC_66_0b7_BUILD1 FENNEC_66_0b7_RELEASE FIREFOX_66_0b7_BUILD1 FIREFOX_66_0b7_RELEASE
Andrea Marchesini <amarchesini@mozilla.com> - Mon, 11 Feb 2019 16:54:05 +0000 - rev 515884
Push 1953 by ffxbld-merge at Mon, 11 Mar 2019 12:10:20 +0000
Bug 1526218 - transferFromImageBitmap() should propage the origin-clean state to the canvas element. r=aosmond, a=RyanVM Differential Revision: https://phabricator.services.mozilla.com/D19371
864ba4d0315680df488437a8c31a9c3de8040164: Bug 1506495. Fallback to the system profile if we can't read the file for the profile. r=aosmond a=lizzard
Jeff Muizelaar <jrmuizel@gmail.com> - Fri, 01 Feb 2019 14:10:22 -0500 - rev 515724
Push 1953 by ffxbld-merge at Mon, 11 Mar 2019 12:10:20 +0000
Bug 1506495. Fallback to the system profile if we can't read the file for the profile. r=aosmond a=lizzard This is a better default than just assuming no profile.
5f1830b621aa67dedf3a9da4e8311b732a0bde97: Bug 1485463 - Part 2 - use IPC errors to handle an attempt to allocate too many PCompositorBridgeParent; r=aosmond
Alex Gaynor <agaynor@mozilla.com> - Wed, 23 Jan 2019 14:32:39 +0000 - rev 515199
Push 1953 by ffxbld-merge at Mon, 11 Mar 2019 12:10:20 +0000
Bug 1485463 - Part 2 - use IPC errors to handle an attempt to allocate too many PCompositorBridgeParent; r=aosmond This cannot actually happen in the real world because this path is specific to when the compositor process is also the parent process, and thus is not actually IPC. However, the fuzzer can trigger this case. Depends on D14587 Differential Revision: https://phabricator.services.mozilla.com/D14588
607394a48aca3721c9386d975fc2fce29bdcba59: Bug 1521685 - Get rid of unused GetLastError() API call in nsDataObj::GetDib() r=aosmond
Masayuki Nakano <masayuki@d-toybox.com> - Tue, 22 Jan 2019 11:34:20 +0000 - rev 514811
Push 1953 by ffxbld-merge at Mon, 11 Mar 2019 12:10:20 +0000
Bug 1521685 - Get rid of unused GetLastError() API call in nsDataObj::GetDib() r=aosmond nsDataObj::GetDib() calls GetLastError() API immediately after calling GlobalAlloc() and just return E_FAIL in such case. So, we don't need to call it. Differential Revision: https://phabricator.services.mozilla.com/D17214
965622da5962b6cfd9e9e8b5332896e1634070e1: Bug 1521027: Use the correct targets in ImageLib, allowing optimal behavior with OMTP. r=aosmond
Bas Schouten <bschouten@mozilla.com> - Fri, 18 Jan 2019 07:56:43 +0100 - rev 514606
Push 1953 by ffxbld-merge at Mon, 11 Mar 2019 12:10:20 +0000
Bug 1521027: Use the correct targets in ImageLib, allowing optimal behavior with OMTP. r=aosmond Differential Revision: https://phabricator.services.mozilla.com/D16945
ebeed768822e5d860e9f051c12f1800197e3697c: Bug 1514803 - Export nsICOEncoder r=aosmond
Barret Rennie <barret@brennie.ca> - Tue, 08 Jan 2019 21:30:46 +0000 - rev 513055
Push 1953 by ffxbld-merge at Mon, 11 Mar 2019 12:10:20 +0000
Bug 1514803 - Export nsICOEncoder r=aosmond Depends on D14815 Differential Revision: https://phabricator.services.mozilla.com/D14816
53a37a8d97ee37fbf7f9e8e6991d3964f20d38f7: Bug 1514803 - Export nsBMPEncoder r=aosmond
Barret Rennie <barret@brennie.ca> - Tue, 08 Jan 2019 21:30:45 +0000 - rev 513054
Push 1953 by ffxbld-merge at Mon, 11 Mar 2019 12:10:20 +0000
Bug 1514803 - Export nsBMPEncoder r=aosmond Depends on D14814 Differential Revision: https://phabricator.services.mozilla.com/D14815
a72d578c3a83289c63a6604e33e797a1f097aab2: Bug 1514803 - Expose nsPNGEncoder header r=aosmond
Barret Rennie <barret@brennie.ca> - Tue, 08 Jan 2019 21:30:45 +0000 - rev 513053
Push 1953 by ffxbld-merge at Mon, 11 Mar 2019 12:10:20 +0000
Bug 1514803 - Expose nsPNGEncoder header r=aosmond Differential Revision: https://phabricator.services.mozilla.com/D14814