searching for reviewer(aklotz)
063a0c6b1078ab9bab8e66c35ac41809d173da7f: Bug 1520929 - part 1 - add an isWowARM64 property to nsSystemInfo; r=aklotz a=pascalc
Nathan Froyd <froydnj@mozilla.com> - Wed, 03 Apr 2019 04:44:49 -0500 - rev 526100
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1520929 - part 1 - add an isWowARM64 property to nsSystemInfo; r=aklotz a=pascalc In addition to knowing whether we're running x86-on-x86-64, we'd also like to know about the x86-on-arm64 case. The current code doesn't provide enough information to determine that, so we need to query a little bit harder.
20c6fef1599eae9f5629f08ec19c04cf05acad47: Bug 1534209 - Do not readahead when PrefetchVirtualMemory is not available. r=aklotz a=pascalc
Mike Hommey <mh+mozilla@glandium.org> - Mon, 18 Mar 2019 22:39:44 +0000 - rev 525647
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1534209 - Do not readahead when PrefetchVirtualMemory is not available. r=aklotz a=pascalc Re-enabling the PGO jarlog, which was unexpectedly disabled since Firefox 56 showed a regression on Windows 7, due to the use of mozilla::ReadAhead, which on Windows 7 does explicit I/O on the caller thread. While there may be some benefit from doing so, evidence says the opposite, which is presumably due to the amount of data being loaded not being relevant in every case: the jarlog is gathered from a first-run, which has a different jar-loading profile from subsequent runs of Firefox. While we may want to improve the situation later on, the immediate thing we can do is stop doing this explicit read, while keeping the OS readahead hints on other platforms, which don't imply explicit I/O. All this does is effectively get us back to the same state as if jarlogs were disabled like it was since Firefox 56, for Windows 7 only. aFd not being used anymore, the code could be cleaned up a lot, but we may reintroduce the readahead later, so keep the status quo for now. Differential Revision: https://phabricator.services.mozilla.com/D23642
de92c0248a0b0ecbf0ad104650305a31985fa6ff: Bug 1529596 - part 3 - avoid directory creation in the common case; r=aklotz
Nathan Froyd <froydnj@gmail.com> - Thu, 07 Mar 2019 20:44:00 +0000 - rev 524158
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1529596 - part 3 - avoid directory creation in the common case; r=aklotz This change sets up nsLocalFileWin to mirror the behavior of nsLocalFileUnix, which is all-around more reasonable than the behavior nsLocalFileWin had before. We also, in passing, fix up some unnecessary error-handling code at the end of Create(). Depends on D22360 Differential Revision: https://phabricator.services.mozilla.com/D22361
b55a2c1df7bbc041c033747376cf974e545be26e: Bug 1529596 - part 2 - pull out code for creating files/directories; r=aklotz
Nathan Froyd <froydnj@gmail.com> - Thu, 07 Mar 2019 20:43:04 +0000 - rev 524157
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1529596 - part 2 - pull out code for creating files/directories; r=aklotz We eventually want to make the common path just attempt file creation, and only fall back to creating all the ancestor directories if the initial attempt failed. To do that in a reasonable way, we'll need re-usable code for the creation code, which is what this patch creates. Depends on D22359 Differential Revision: https://phabricator.services.mozilla.com/D22360
db0f22709ad1520a8cc81f9cdc3f8b851c99e08e: Bug 1529596 - part 1 - pull out common NS_ERROR_FILE_ACCESS_DENIED code; r=aklotz
Nathan Froyd <froydnj@gmail.com> - Thu, 07 Mar 2019 20:40:58 +0000 - rev 524156
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1529596 - part 1 - pull out common NS_ERROR_FILE_ACCESS_DENIED code; r=aklotz This condition logically belongs before we try creating anything. Differential Revision: https://phabricator.services.mozilla.com/D22359
63625c423683a941a2d6afeb3c67b0d578847bb7: Bug 1533775 - PoisonIOInterposerWin should report the filename when opening non-existant files, r=aklotz.
Florian Quèze <florian@queze.net> - Fri, 08 Mar 2019 17:15:21 +0000 - rev 524053
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1533775 - PoisonIOInterposerWin should report the filename when opening non-existant files, r=aklotz. Differential Revision: https://phabricator.services.mozilla.com/D22722
fa25d5068254d154157c605f572a7121d7ff995e: Bug 1533531 - Make NSPRIOInterposer report filenames, r=aklotz.
Florian Quèze <florian@queze.net> - Fri, 08 Mar 2019 12:28:12 +0000 - rev 524026
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1533531 - Make NSPRIOInterposer report filenames, r=aklotz. Differential Revision: https://phabricator.services.mozilla.com/D22585
346002ff619eef0712be55594102460b40f44db1: Bug 1529894 - Change jar log content. r=aklotz,chmanchester
Mike Hommey <mh+mozilla@glandium.org> - Thu, 07 Mar 2019 20:46:52 +0000 - rev 523934
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1529894 - Change jar log content. r=aklotz,chmanchester The jar log is used for optimization of the packaged jar files according to their usage patterns during a profile run. The current content of the file currently come with 2 caveats: - it contains entries for jar archives that aren't relevant to packaging, which is not a problem in itself, but see below. - it contains full paths for jar archives that may not correspond to the location of the packaged directory (on e.g. Android, where the build almost certainly doesn't happen in the same directory on the host as Fennec runs in the emulator/on the device). The current JarLog code does somehow handle the various ways paths are currently presented, but it's clearly missing code to map the paths in the log to packaged paths. Instead of requiring manual work and extra build options to handle this mapping, and considering the caveats above, it's just simpler to log archive paths as if they were relative to the packaged application directory in a build, and use that during packaging. Depends on D21655 Differential Revision: https://phabricator.services.mozilla.com/D21656
e19e5857c7a8dc26f96df4e9487c6d0af86863f8: Bug 1529894 - Change zip logging initialization. r=aklotz
Mike Hommey <mh+mozilla@glandium.org> - Thu, 07 Mar 2019 22:54:53 +0000 - rev 523933
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1529894 - Change zip logging initialization. r=aklotz Instead of checking the MOZ_JAR_LOG_FILE for each log entry, only check it once, and only check whether to log once per archive rather than once per item. Differential Revision: https://phabricator.services.mozilla.com/D21655
3c37fd9d30d50b66b9b899c3f85758079f8e31d1: Bug 1529894 - Change jar log content. r=aklotz,chmanchester
Mike Hommey <mh+mozilla@glandium.org> - Wed, 06 Mar 2019 01:18:10 +0000 - rev 523429
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1529894 - Change jar log content. r=aklotz,chmanchester The jar log is used for optimization of the packaged jar files according to their usage patterns during a profile run. The current content of the file currently come with 2 caveats: - it contains entries for jar archives that aren't relevant to packaging, which is not a problem in itself, but see below. - it contains full paths for jar archives that may not correspond to the location of the packaged directory (on e.g. Android, where the build almost certainly doesn't happen in the same directory on the host as Fennec runs in the emulator/on the device). The current JarLog code does somehow handle the various ways paths are currently presented, but it's clearly missing code to map the paths in the log to packaged paths. Instead of requiring manual work and extra build options to handle this mapping, and considering the caveats above, it's just simpler to log archive paths as if they were relative to the packaged application directory in a build, and use that during packaging. Depends on D21655 Differential Revision: https://phabricator.services.mozilla.com/D21656
e93f4871731b8e658c7febf013cd985738ad1435: Bug 1529894 - Change zip logging initialization. r=aklotz
Mike Hommey <mh+mozilla@glandium.org> - Tue, 05 Mar 2019 23:33:21 +0000 - rev 523428
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1529894 - Change zip logging initialization. r=aklotz Instead of checking the MOZ_JAR_LOG_FILE for each log entry, only check it once, and only check whether to log once per archive rather than once per item. Differential Revision: https://phabricator.services.mozilla.com/D21655
a67f7ae048586447c396bb9d28252929175273ac: Bug 1528651 - Another follow-up to fix warnings on beta/release builds. r=aklotz
Masatoshi Kimura <VYV03354@nifty.ne.jp> - Tue, 05 Mar 2019 20:18:48 +0000 - rev 523371
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1528651 - Another follow-up to fix warnings on beta/release builds. r=aklotz Differential Revision: https://phabricator.services.mozilla.com/D21821
0fd1ec8af3fd1e2a75f08613414ed590e76ea286: Bug 1503538 Part 2/5: Move AutoVirtualProtect to a shared header r=aklotz
Carl Corcoran <ccorcoran@mozilla.com> - Wed, 06 Mar 2019 00:40:55 +0000 - rev 523363
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1503538 Part 2/5: Move AutoVirtualProtect to a shared header r=aklotz AutoVirtualProtect will be useful for following patches. This moves it out of DllBlocklistWin.cpp and into WinHeaderOnlyUtils.h so it can be shared. Differential Revision: https://phabricator.services.mozilla.com/D13197
094cdc0182bc8cc9eb5bcf741a951d147588b77a: Bug 1503538 Part 1/5: Move printf_stderr to a shared header r=aklotz
Carl Corcoran <ccorcoran@mozilla.com> - Wed, 06 Mar 2019 00:51:15 +0000 - rev 523362
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1503538 Part 1/5: Move printf_stderr to a shared header r=aklotz In the tree we have two copies of printf_stderr() with the comment, "Ideally this should be shared". This moves the function to a new exported header which can be the basis for other similar debugging utility functions. To include it, #include "mozilla/glue/Debug.h" A small concern with this is that printf_stderr() is in the global namespace, and could conflict if it's inadvertently included along with, for example, nsDebug.h which also defines this function. The warning in the comment at the top of the file attempts to mitigate this. Differential Revision: https://phabricator.services.mozilla.com/D13196
3a2cf44afaa30fad24b970e7b129b341ce47a949: Bug 827976 - Improve usage of the hidden window for nsXULWindow::Destroy. r=aklotz
Felipe Gomes <felipc@gmail.com> - Mon, 04 Mar 2019 18:52:49 +0000 - rev 523345
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 827976 - Improve usage of the hidden window for nsXULWindow::Destroy. r=aklotz Differential Revision: https://phabricator.services.mozilla.com/D21075
3c2bc3b312f3a4e8ccfee9d7183e2d6373906ee1: Bug 827976 - Tablet Mode detection should favor using an existing window instead of the hidden window. r=aklotz
Felipe Gomes <felipc@gmail.com> - Mon, 04 Mar 2019 20:21:09 +0000 - rev 523343
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 827976 - Tablet Mode detection should favor using an existing window instead of the hidden window. r=aklotz Differential Revision: https://phabricator.services.mozilla.com/D21073
200e4a37af4741224dfc291a6f87e926089fd1c4: Bug 827976 - Create the hidden window lazily on non-Mac platforms. r=aklotz
Felipe Gomes <felipc@gmail.com> - Tue, 05 Mar 2019 20:18:25 +0000 - rev 523341
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 827976 - Create the hidden window lazily on non-Mac platforms. r=aklotz Differential Revision: https://phabricator.services.mozilla.com/D21071
3b64368cff52c1393816a40e7ccb9cc545f08e7a: Bug 827976 - Improve usage of the hidden window for nsXULWindow::Destroy. r=aklotz
Felipe Gomes <felipc@gmail.com> - Fri, 01 Mar 2019 21:06:48 +0000 - rev 522894
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 827976 - Improve usage of the hidden window for nsXULWindow::Destroy. r=aklotz Differential Revision: https://phabricator.services.mozilla.com/D21075
9203871a5c6f9bbb69c425ae2ec0b1cc805a061d: Bug 827976 - Tablet Mode detection should favor using an existing window instead of the hidden window. r=aklotz
Felipe Gomes <felipc@gmail.com> - Fri, 01 Mar 2019 21:05:32 +0000 - rev 522892
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 827976 - Tablet Mode detection should favor using an existing window instead of the hidden window. r=aklotz Differential Revision: https://phabricator.services.mozilla.com/D21073
e254496ff95b683df29479a41341f3f2fa6a71f4: Bug 827976 - Create the hidden window lazily on non-Mac platforms. r=aklotz
Felipe Gomes <felipc@gmail.com> - Fri, 01 Mar 2019 21:04:48 +0000 - rev 522890
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 827976 - Create the hidden window lazily on non-Mac platforms. r=aklotz Differential Revision: https://phabricator.services.mozilla.com/D21071
9ce3a685bbcd0901128dab0c7261ae00dd209381: Bug 1528651 - Followup to fix a warning on release or beta. r=aklotz
Masatoshi Kimura <VYV03354@nifty.ne.jp> - Sat, 23 Feb 2019 06:58:07 +0900 - rev 522755
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1528651 - Followup to fix a warning on release or beta. r=aklotz
537fb8251e616705a918541068782b04f9d8bee6: Bug 1530103 - Check for osint argument when checking for greomni and appomni arguments. r=aklotz
Robert Strong <robert.bugzilla@gmail.com> - Wed, 27 Feb 2019 19:18:38 +0000 - rev 522423
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1530103 - Check for osint argument when checking for greomni and appomni arguments. r=aklotz Differential Revision: https://phabricator.services.mozilla.com/D21326
13b55e07553224d3990469466e9d3ea5163813aa: Bug 1293043 - Do not shrink favicons down to 16x16. r=aklotz
Masatoshi Kimura <VYV03354@nifty.ne.jp> - Sat, 23 Feb 2019 13:32:12 +0900 - rev 522256
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1293043 - Do not shrink favicons down to 16x16. r=aklotz By this change, icons will never be shrunk to a smaller size. Windows will do it appropriately. Internet Explorer's icon handler will not paint the white background if the icon is large enough. I'm also replicating the behavior.
90ec592466c052a420e600f02c9c7b558c25b7fc: Bug 1528651 - Followup to fix a warning on release or beta. r=aklotz
Masatoshi Kimura <VYV03354@nifty.ne.jp> - Sat, 23 Feb 2019 06:58:07 +0900 - rev 521974
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1528651 - Followup to fix a warning on release or beta. r=aklotz
a716ff1b62ab72a859f1a016c6635919502d4abe: Bug 1529558 - Use PrefetchVirtualMemory in nsZipArchive::BuildFileList when supported. r=aklotz
Mike Hommey <mh+mozilla@glandium.org> - Tue, 26 Feb 2019 00:14:20 +0000 - rev 521903
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1529558 - Use PrefetchVirtualMemory in nsZipArchive::BuildFileList when supported. r=aklotz instead of ReadAhead, which does active reading on Windows. The PrefetchVirtualMemory is a system call that is new to Windows 8. Back when the readahead code for jar was added, in bug 810151, Windows 8 was still fresh out of the oven. 6 years later, we can do a runtime check and use the PrefetchVirtualMemory function. One downside is that the IOInterposer doesn't know about it (but it doesn't know about madvise on other platforms anyways). Differential Revision: https://phabricator.services.mozilla.com/D20807
2e92db777acff0551795391d97e05a57e051ec9c: Bug 1529551 - Only readahead jars in the parent process. r=aklotz
Mike Hommey <mh+mozilla@glandium.org> - Mon, 25 Feb 2019 23:40:55 +0000 - rev 521892
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1529551 - Only readahead jars in the parent process. r=aklotz Consequently, since we don't readahead jars in child processes, we don't record jar accesses from child processes. In fact, intertwining jar accesses from child processes with those from the parent process was arguably making things less efficient for the parent process. But this code was written at a time e10s was barely a thing, so it wasn't really thought for a multi-process world. Differential Revision: https://phabricator.services.mozilla.com/D20752
1c74156717f19c20279571e493dac202cf89d4ef: Bug 1529902 - Fix invalid use of NS_ConvertUTF16toUTF8. r=aklotz
Masatoshi Kimura <VYV03354@nifty.ne.jp> - Fri, 22 Feb 2019 22:37:48 +0900 - rev 521603
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1529902 - Fix invalid use of NS_ConvertUTF16toUTF8. r=aklotz
f473b0c9b01a17a6cc1f371892fa7be49242483d: Bug 1501932 - Enable ESLint for modules/ (manual changes). r=aklotz,njn
Ya'ar Hever <yhever@gmail.com> - Thu, 21 Feb 2019 00:50:18 +0000 - rev 521116
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1501932 - Enable ESLint for modules/ (manual changes). r=aklotz,njn Differential Revision: https://phabricator.services.mozilla.com/D14647
dc657cbebdaee8927e3d0980e808b28030560321: Bug 1501932 - Enable ESLint for modules/ (automatic changes). r=njn,aklotz
Ya'ar Hever <yhever@gmail.com> - Fri, 15 Feb 2019 20:03:05 +0000 - rev 521115
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1501932 - Enable ESLint for modules/ (automatic changes). r=njn,aklotz Differential Revision: https://phabricator.services.mozilla.com/D14645
045596fde4d0a2ee600f1c6c12ed3daa54baffb0: Bug 1528651 - Fix warnings and re-enable warnings-as-errors in ipc/mscom/. r=aklotz
Masatoshi Kimura <VYV03354@nifty.ne.jp> - Wed, 20 Feb 2019 20:57:00 +0900 - rev 521047
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1528651 - Fix warnings and re-enable warnings-as-errors in ipc/mscom/. r=aklotz
22e9a70db88661afd3a33e420c50434019fd3c67: Bug 1515088 Part 2: Set LoaderThreads to 1 in the RTL_USER_PROCESS_PARAMETERS structure on child process start-up. r=aklotz
Bob Owen <bobowencode@gmail.com> - Fri, 08 Feb 2019 17:17:52 +0000 - rev 520419
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1515088 Part 2: Set LoaderThreads to 1 in the RTL_USER_PROCESS_PARAMETERS structure on child process start-up. r=aklotz
8a968b7beaba6fb6f5e6323298db98501e28ef44: Bug 1521690 - Use `Unused <<` instead of `(void*)` in nsWindow.cpp r=aklotz,jmathies
Masayuki Nakano <masayuki@d-toybox.com> - Fri, 01 Feb 2019 20:15:04 +0000 - rev 517454
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1521690 - Use `Unused <<` instead of `(void*)` in nsWindow.cpp r=aklotz,jmathies Casting non-void result to `void*` causes warning of clang. Additionally, perhaps, we should use `Unused <<` because of modern style. And also this patch makes widget/windows is treated as "warning as errors" because this patch fixes the last warning. Differential Revision: https://phabricator.services.mozilla.com/D17216
9434867921051f6b2c9478346c74b09d5a75ba35: Bug 1530103 - Check for osint argument when checking for greomni and appomni arguments. r=aklotz a=lizzard
Robert Strong <robert.bugzilla@gmail.com> - Wed, 27 Feb 2019 19:18:38 +0000 - rev 516247
Push 1953 by ffxbld-merge at Mon, 11 Mar 2019 12:10:20 +0000
Bug 1530103 - Check for osint argument when checking for greomni and appomni arguments. r=aklotz a=lizzard Differential Revision: https://phabricator.services.mozilla.com/D21326
95364495ea7dde208f86e76ae14e644cdfabfaa3: Bug 1515088 Part 2: Set LoaderThreads to 1 in the RTL_USER_PROCESS_PARAMETERS structure on child process start-up. r=aklotz a=lizzard
Bob Owen <bobowencode@gmail.com> - Fri, 08 Feb 2019 17:17:52 +0000 - rev 516079
Push 1953 by ffxbld-merge at Mon, 11 Mar 2019 12:10:20 +0000
Bug 1515088 Part 2: Set LoaderThreads to 1 in the RTL_USER_PROCESS_PARAMETERS structure on child process start-up. r=aklotz a=lizzard
e0f21f574d36309f94a832c8985223e4b46a0dd2: Bug 1520880: Silence an unused variable warning in the stubbed-out ARM64 interceptor. r=aklotz
David Major <dmajor@mozilla.com> - Thu, 17 Jan 2019 21:59:06 -0500 - rev 514392
Push 1953 by ffxbld-merge at Mon, 11 Mar 2019 12:10:20 +0000
Bug 1520880: Silence an unused variable warning in the stubbed-out ARM64 interceptor. r=aklotz
ac8281636fba946242d7da3357948443cca6aba9: Bug 1516983 - Add the FRAPS .dll to the blocklist r=aklotz
Gabriele Svelto <gsvelto@mozilla.com> - Wed, 16 Jan 2019 19:33:45 +0000 - rev 514148
Push 1953 by ffxbld-merge at Mon, 11 Mar 2019 12:10:20 +0000
Bug 1516983 - Add the FRAPS .dll to the blocklist r=aklotz Differential Revision: https://phabricator.services.mozilla.com/D15524
79f7656b35eb2d612ff56302b1e299a55d885b9b: Bug 1518798: Treat SysWOW64 the same as the system directory in the untrusted modules ping r=aklotz
Carl Corcoran <ccorcoran@mozilla.com> - Mon, 14 Jan 2019 23:53:13 +0000 - rev 514082
Push 1953 by ffxbld-merge at Mon, 11 Mar 2019 12:10:20 +0000
Bug 1518798: Treat SysWOW64 the same as the system directory in the untrusted modules ping r=aklotz Under WOW64, the SysWOW64 directory is the effective system directory. A flag has been added (ModuleTrustFlags::SysWOW64Directory) representing this directory, and we now grant this the same trustworthiness as ModuleTrustFlags::SystemDirectory. Depends on D16013 Differential Revision: https://phabricator.services.mozilla.com/D16160
1b1fe5815dffcacf40731336a114a8c2fcc2adf7: Bug 1518490 Part 3/3: Send XUL load duration and module load duration via untrusted modules ping r=aklotz
Carl Corcoran <ccorcoran@mozilla.com> - Tue, 15 Jan 2019 22:30:54 +0000 - rev 514081
Push 1953 by ffxbld-merge at Mon, 11 Mar 2019 12:10:20 +0000
Bug 1518490 Part 3/3: Send XUL load duration and module load duration via untrusted modules ping r=aklotz This patch: - Adds two new fields to the untrusted modules ping - Updates documentation for the untrusted modules ping: - Documents these 2 new fields - Documents the new XUL ModuleTrustFlags bitfield value - Adds a "version history" section - Corrects documentation for ModuleTrustFlags (JIT, keyboard layouts) Differential Revision: https://phabricator.services.mozilla.com/D16013
1b8f7dd09d842bf97fa58840d48904a7f38eb4ac: Bug 1518490 Part 2/3: Measure xul.dll load duration r=aklotz
Carl Corcoran <ccorcoran@mozilla.com> - Tue, 15 Jan 2019 22:29:28 +0000 - rev 514080
Push 1953 by ffxbld-merge at Mon, 11 Mar 2019 12:10:20 +0000
Bug 1518490 Part 2/3: Measure xul.dll load duration r=aklotz In order to help unify DLL timings across machines with different performance characteristics, this change collects the load duration of xul.dll. Because xul.dll is always loaded, it can serve as a control value for DLL load times. Differential Revision: https://phabricator.services.mozilla.com/D16012
400434070f20f902659434c8e7d437f800613e35: Bug 1518490 Part 1/3: Measure DLL load timings and pass into UntrustedModulesManager r=aklotz
Carl Corcoran <ccorcoran@mozilla.com> - Tue, 15 Jan 2019 10:49:36 +0000 - rev 514079
Push 1953 by ffxbld-merge at Mon, 11 Mar 2019 12:10:20 +0000
Bug 1518490 Part 1/3: Measure DLL load timings and pass into UntrustedModulesManager r=aklotz This patch measures the duration of module loads and passes it up to UntrustedModulesManager where, in later patches, it will be consumed by telemetry. Differential Revision: https://phabricator.services.mozilla.com/D16011
bdc982dd78300d5f3ef14101440a415289d6be71: Bug 1514093 part 1: A11y HandlerProvider: Don't write any payload at all (even an empty one) if the handler isn't used for the target interface. r=aklotz
James Teh <jteh@mozilla.com> - Wed, 16 Jan 2019 08:08:05 +0000 - rev 514048
Push 1953 by ffxbld-merge at Mon, 11 Mar 2019 12:10:20 +0000
Bug 1514093 part 1: A11y HandlerProvider: Don't write any payload at all (even an empty one) if the handler isn't used for the target interface. r=aklotz We only use the handler for specific interfaces such as IAccessible* and IAccessibleHyperlink. For interfaces which don't use the handler, we currently write an empty payload, but this still adds bytes to the stream. This seems to break marshaling such an interface in a VT_UNKNOWN in a VARIANT. To fix this, just don't write any payload at all when we aren't using the handler for the target interface. Differential Revision: https://phabricator.services.mozilla.com/D16662
493f7ee0ee0069fb0005ad61002e04ed3ff80fe8: Bug 1508312 - Add assert to catch accidental re-enter of Slim RW lock r=ccorcoran,aklotz
Chris Martin <cmartin@mozilla.com> - Wed, 16 Jan 2019 01:21:16 +0000 - rev 514036
Push 1953 by ffxbld-merge at Mon, 11 Mar 2019 12:10:20 +0000
Bug 1508312 - Add assert to catch accidental re-enter of Slim RW lock r=ccorcoran,aklotz WindowsDllBlocklist installs a callback function that fires whenever a DLL is loaded. The installer function shares an SRWLock with the callback function. SRWLock is not re-entrant, so if the installer function accidently causes a DLL load before releasing the lock, the callback function will deadlock. This occured trying to solve Bug 1402282, where the installer function used "new" to allocate memory, which called the Win32 "RtlGenRandom()" function, which loaded bcrypt.dll, which caused the callback to fire off, which tried to lock the mutex that was already locked by the installer function. Hopefully this will save another developer lots of debug time in the future by turning a difficult-to-debug deadlock into a nice, loud assertion. Differential Revision: https://phabricator.services.mozilla.com/D15840
45b6acf51517246d77ddf6649fc6fa3cae219874: Bug 1519893 - Test the alwaysOnTop feature for Windows. r=aklotz
Mike Conley <mconley@mozilla.com> - Tue, 15 Jan 2019 22:29:21 +0000 - rev 513983
Push 1953 by ffxbld-merge at Mon, 11 Mar 2019 12:10:20 +0000
Bug 1519893 - Test the alwaysOnTop feature for Windows. r=aklotz These tests make sure that passing alwaysOnTop as a window feature results in a window with WS_EX_TOPMOST, and also ensures that web content cannot request alwaysOnTop windows. Differential Revision: https://phabricator.services.mozilla.com/D16570
2d7f5838e68fbac83742ee5c52d3c7ebf2a7315b: Bug 1519893 - Add alwaysOnTop chrome-only window feature for Windows. r=aklotz
Mike Conley <mconley@mozilla.com> - Tue, 15 Jan 2019 22:29:59 +0000 - rev 513982
Push 1953 by ffxbld-merge at Mon, 11 Mar 2019 12:10:20 +0000
Bug 1519893 - Add alwaysOnTop chrome-only window feature for Windows. r=aklotz Differential Revision: https://phabricator.services.mozilla.com/D16486
9e200f5673a3ff01ba2b27dbcf074d5ba86c978e: Bug 1430149 - Fix AsyncInvoker.h compilation on mingw. r=aklotz
Jacek Caban <jacek@codeweavers.com> - Mon, 07 Jan 2019 21:52:57 +0000 - rev 512912
Push 1953 by ffxbld-merge at Mon, 11 Mar 2019 12:10:20 +0000
Bug 1430149 - Fix AsyncInvoker.h compilation on mingw. r=aklotz MozReview-Commit-ID: FIswvwMzGdC Differential Revision: https://phabricator.services.mozilla.com/D15325
0d14ab4c9b5b31c4466252774a68539320f46f52: Bug 1514592: Don't call RpcExceptionCode if we don't HAVE_SEH_EXCEPTIONS. r=aklotz
David Major <dmajor@mozilla.com> - Mon, 07 Jan 2019 17:58:45 -0500 - rev 512824
Push 1953 by ffxbld-merge at Mon, 11 Mar 2019 12:10:20 +0000
Bug 1514592: Don't call RpcExceptionCode if we don't HAVE_SEH_EXCEPTIONS. r=aklotz
6150c08114a82b4f68a91b2a04a742cd9e34b4fe: Bug 1505482: Allow DLL patcher to resolve some backward short JMPs (r=aklotz)
David Parks <dparks@mozilla.com> - Wed, 26 Dec 2018 17:28:37 +0000 - rev 511919
Push 1953 by ffxbld-merge at Mon, 11 Mar 2019 12:10:20 +0000
Bug 1505482: Allow DLL patcher to resolve some backward short JMPs (r=aklotz) In Windows 7 x64, GetFileAttributesW begins with a short, backwards jump that can't safely be converted by the interceptor. Additionally, the function doesn't have enough NOP space after the JMP for the trampoline. However, the target of the short JMP is a long JMP, followed by plenty of NOP space. This patch moves the trampoline location from the first JMP to the second. Differential Revision: https://phabricator.services.mozilla.com/D11258
680af67bb1e231cfe7249bec2106c25ba99bd065: Bug 1430149 - Don't define INITGUID when not needed. r=aklotz
Jacek Caban <jacek@codeweavers.com> - Tue, 25 Dec 2018 18:49:39 +0100 - rev 511905
Push 1953 by ffxbld-merge at Mon, 11 Mar 2019 12:10:20 +0000
Bug 1430149 - Don't define INITGUID when not needed. r=aklotz On mingw this causes IIDs to be defined in headers. Those definitions conflict with _i.c files that are included as well. Since we include _i.c anyway, INITGUID is simply not needed.
eb56a37618db7e13647da7c91955d892a0a8a68a: Bug 1430149 - widl compatibility fixes. r=aklotz
Jacek Caban <jacek@codeweavers.com> - Tue, 25 Dec 2018 18:49:23 +0100 - rev 511904
Push 1953 by ffxbld-merge at Mon, 11 Mar 2019 12:10:20 +0000
Bug 1430149 - widl compatibility fixes. r=aklotz widl can't handle generating the typelib without explicit importlib() in this case. This should be fixed in widl as well, but using importlib() in this case looks right anyway.
1c7f0326d7b3450ef633ac3c24f65a54621cbc54: Bug 1430149 - Fix NtUndoc.h on mingw. r=aklotz
Jacek Caban <jacek@codeweavers.com> - Tue, 25 Dec 2018 18:48:59 +0100 - rev 511903
Push 1953 by ffxbld-merge at Mon, 11 Mar 2019 12:10:20 +0000
Bug 1430149 - Fix NtUndoc.h on mingw. r=aklotz mingw headers declare both ObjectNameInformation and OBJECT_NAME_INFORMATION, which conflicts with local definitions.