searching for reviewer(RyanVM)
305c7368c03b: Bug 1508279 - Use the correct intent for GeckoServicesCreatorService. r=sdaswani, a=RyanVM FENNEC_65_0_BUILD1
Vlad Baicu <vlad.baicu@softvision.ro> - Fri, 18 Jan 2019 18:14:44 +0000 - rev 509569
Push 1909 by ryanvm@gmail.com at Tue, 22 Jan 2019 18:17:23 +0000
Bug 1508279 - Use the correct intent for GeckoServicesCreatorService. r=sdaswani, a=RyanVM Differential Revision: https://phabricator.services.mozilla.com/D16998
83c4dc89cf3d: Bug 1482452 - Part 2: Validate object before sending to Java runtime. r=snorp, a=RyanVM
John Lin <jolin@mozilla.com> - Wed, 16 Jan 2019 16:31:19 +0000 - rev 509568
Push 1909 by ryanvm@gmail.com at Tue, 22 Jan 2019 18:17:23 +0000
Bug 1482452 - Part 2: Validate object before sending to Java runtime. r=snorp, a=RyanVM Depends on D16707 Differential Revision: https://phabricator.services.mozilla.com/D16708
288c5869de06: Bug 1482452 - Part 1: Validate buffer contents before accessing. r=snorp, a=RyanVM
John Lin <jolin@mozilla.com> - Wed, 16 Jan 2019 16:31:16 +0000 - rev 509567
Push 1909 by ryanvm@gmail.com at Tue, 22 Jan 2019 18:17:23 +0000
Bug 1482452 - Part 1: Validate buffer contents before accessing. r=snorp, a=RyanVM Differential Revision: https://phabricator.services.mozilla.com/D16707
9876a3bd6201: Bug 1517937 - Move JhengHei to the end of zh-TW sans-serif font prefs on late-beta/release so that previous default of PMingLiu will take precedence for now. r=m_kato, a=RyanVM FIREFOX_RELEASE_65_BASE
Jonathan Kew <jkew@mozilla.com> - Fri, 18 Jan 2019 18:16:42 +0000 - rev 509556
Push 1905 by ffxbld-merge at Mon, 21 Jan 2019 12:33:13 +0000
Bug 1517937 - Move JhengHei to the end of zh-TW sans-serif font prefs on late-beta/release so that previous default of PMingLiu will take precedence for now. r=m_kato, a=RyanVM
a95de9874038: Bug 1521066 - Fix double border rendering of border-collapsed tables. r=jrmuizel, a=RyanVM
Emilio Cobos Álvarez <emilio@crisal.io> - Fri, 18 Jan 2019 16:49:04 +0000 - rev 509555
Push 1905 by ffxbld-merge at Mon, 21 Jan 2019 12:33:13 +0000
Bug 1521066 - Fix double border rendering of border-collapsed tables. r=jrmuizel, a=RyanVM Gotta love C++... I missed the `break;` for that branch so we were always falling back to the solid border rendering path (which we use if the border is too small). Differential Revision: https://phabricator.services.mozilla.com/D16977
ff8f2153265d: Bug 1518002 - Update selection cache when initializing editor. r=masayuki, a=RyanVM
Makoto Kato <m_kato@ga2.so-net.ne.jp> - Fri, 18 Jan 2019 10:00:23 +0000 - rev 509554
Push 1905 by ffxbld-merge at Mon, 21 Jan 2019 12:33:13 +0000
Bug 1518002 - Update selection cache when initializing editor. r=masayuki, a=RyanVM GitLab's comment calls scrollTop on input event handler. The scollTop may cause reflow. When causing reflow, editor is destroyed and initialized again. Then nsTextEditorState will set current value to editor. But this is failure. By bug 1465702, selection is cached in edit action. When initializing editor, selection controller is updated, so selection into cache becomes invalid. It means that all selection methods will return error since document is different. So we should update selection cache when initializing editor. Also, I cannot create test case for this situation since we have to cause reflow in input and/or composition event. Do you have any idea? Differential Revision: https://phabricator.services.mozilla.com/D16944
32f1e101f514: Bug 1519762 - Fix a regression with browser.downloads.search(). r=kmag, a=RyanVM
Andrew Swan <aswan@mozilla.com> - Thu, 17 Jan 2019 11:12:46 -0800 - rev 509553
Push 1905 by ffxbld-merge at Mon, 21 Jan 2019 12:33:13 +0000
Bug 1519762 - Fix a regression with browser.downloads.search(). r=kmag, a=RyanVM The fixes in bug 1503760 inadvertently broke searches of downloads that have not yet started receiving data (which have a value of -1 for the totalBytes property). That regression is fixed here. Differential Revision: https://phabricator.services.mozilla.com/D16889
99b68e9d4a7c: Bug 1515970 - Don't access creditCards store in _updateSavedFieldNames unless it is enabled. r=MattN, a=RyanVM
Timothy Guan-tin Chien <timdream@gmail.com> - Fri, 04 Jan 2019 16:12:43 +0000 - rev 509552
Push 1905 by ffxbld-merge at Mon, 21 Jan 2019 12:33:13 +0000
Bug 1515970 - Don't access creditCards store in _updateSavedFieldNames unless it is enabled. r=MattN, a=RyanVM Differential Revision: https://phabricator.services.mozilla.com/D15393
9e5bf16f07c4: Bug 1520791 - Ensure initial browser's docshell is marked as active in the parent. r=mconley, a=RyanVM
Gijs Kruitbosch <gijskruitbosch@gmail.com> - Thu, 17 Jan 2019 15:58:36 +0000 - rev 509541
Push 1905 by ffxbld-merge at Mon, 21 Jan 2019 12:33:13 +0000
Bug 1520791 - Ensure initial browser's docshell is marked as active in the parent. r=mconley, a=RyanVM Differential Revision: https://phabricator.services.mozilla.com/D16862
d850ab97f26b: Bug 1518440 - Use CheckedInt in JSON Quote function. r=jwalden, a=RyanVM
Jan de Mooij <jdemooij@mozilla.com> - Thu, 17 Jan 2019 18:24:49 +0000 - rev 509540
Push 1905 by ffxbld-merge at Mon, 21 Jan 2019 12:33:13 +0000
Bug 1518440 - Use CheckedInt in JSON Quote function. r=jwalden, a=RyanVM Differential Revision: https://phabricator.services.mozilla.com/D16534
435e0e27532d: Bug 1510487 - Allow DTLS connection w/o SRTP extension. r=bwc, a=RyanVM
Nils Ohlmeier [:drno] <drno@ohlmeier.org> - Thu, 17 Jan 2019 14:16:01 +0000 - rev 509539
Push 1905 by ffxbld-merge at Mon, 21 Jan 2019 12:33:13 +0000
Bug 1510487 - Allow DTLS connection w/o SRTP extension. r=bwc, a=RyanVM Differential Revision: https://phabricator.services.mozilla.com/D14692
8f904ee0cae1: Bug 1489531 - Expose telemetry client_id header to about:addons. r=aswan, a=RyanVM
Shane Caraveo <scaraveo@mozilla.com> - Thu, 17 Jan 2019 15:26:15 +0000 - rev 509538
Push 1905 by ffxbld-merge at Mon, 21 Jan 2019 12:33:13 +0000
Bug 1489531 - Expose telemetry client_id header to about:addons. r=aswan, a=RyanVM Test Plan: Manual testing Differential Revision: https://phabricator.services.mozilla.com/D16857
f0f24bd868b5: Bug 1518786 - Wait until Fluent strings have been applied before sizing the window to content. r=Gijs, a=RyanVM
Jared Wein <jwein@mozilla.com> - Thu, 17 Jan 2019 11:46:54 -0500 - rev 509537
Push 1905 by ffxbld-merge at Mon, 21 Jan 2019 12:33:13 +0000
Bug 1518786 - Wait until Fluent strings have been applied before sizing the window to content. r=Gijs, a=RyanVM Differential Revision: https://phabricator.services.mozilla.com/D16866
e71504cbe594: Bug 1520260 - Collect *_KBREAD_PER_CONN on release as well. r=valentin, a=RyanVM
Dragana Damjanovic <dd.mozilla@gmail.com> - Wed, 16 Jan 2019 09:21:53 +0000 - rev 509535
Push 1905 by ffxbld-merge at Mon, 21 Jan 2019 12:33:13 +0000
Bug 1520260 - Collect *_KBREAD_PER_CONN on release as well. r=valentin, a=RyanVM Differential Revision: https://phabricator.services.mozilla.com/D16616
01bd5daff7e0: Bug 1520138 - Fix border-style conflict resolution in border-collapsed tables. r=dholbert, a=RyanVM
Emilio Cobos Álvarez <emilio@crisal.io> - Wed, 16 Jan 2019 19:40:08 +0000 - rev 509534
Push 1905 by ffxbld-merge at Mon, 21 Jan 2019 12:33:13 +0000
Bug 1520138 - Fix border-style conflict resolution in border-collapsed tables. r=dholbert, a=RyanVM Bug 1509717 removed Gecko's definition of StyleBorderStyle to use the Rust one. The Rust version was ordered in a different way, and the table code relied on the order in order to build the mapping for border conflict resolution. Simplify this mapping now that border constants are ordered in terms of priority, see the comment on top of `enum BorderStyle`. Differential Revision: https://phabricator.services.mozilla.com/D16565
f69157ba349e: Bug 1495363 - Abort the previous request, if a form is submitted twice - tests. r=smaug, a=RyanVM
Andrea Marchesini <amarchesini@mozilla.com> - Wed, 16 Jan 2019 22:51:17 +0100 - rev 509533
Push 1905 by ffxbld-merge at Mon, 21 Jan 2019 12:33:13 +0000
Bug 1495363 - Abort the previous request, if a form is submitted twice - tests. r=smaug, a=RyanVM
1790d083bb57: Bug 1495363 - Abort the previous request, if a form is submitted twice. r=nika, a=RyanVM
Andrea Marchesini <amarchesini@mozilla.com> - Wed, 16 Jan 2019 22:50:41 +0100 - rev 509532
Push 1905 by ffxbld-merge at Mon, 21 Jan 2019 12:33:13 +0000
Bug 1495363 - Abort the previous request, if a form is submitted twice. r=nika, a=RyanVM
6881825b5cd7: Bug 1520756 - Disable Window.event, Event.returnValue and setting keyCode and charCode of "keypress" events to same value. r=smaug, a=RyanVM
Masayuki Nakano <masayuki@d-toybox.com> - Wed, 16 Jan 2019 20:47:09 +0900 - rev 509531
Push 1905 by ffxbld-merge at Mon, 21 Jan 2019 12:33:13 +0000
Bug 1520756 - Disable Window.event, Event.returnValue and setting keyCode and charCode of "keypress" events to same value. r=smaug, a=RyanVM In bug 1496288, we decided to ship the following new features: - Windows.event - Setting keyCode and charCode of "keypress" events to same value - Stop dispatching non-printable "keypress" events - Start to dispatch "keydown" and "keyup" events even during composition However, the 2nd change breaks editor of Confluence. For making the shipment of 65 safer, we should cancel shipping the 2nd change. Then, we need to disable Window.event and Event.returnValue too because they are blocked by the 2nd (bug 1479964 and bug 1478102). On the other hand, perhaps, we should ship the last 2 changes as planned because web apps cannot detect these changes from any API and also we've already introduced these changes. So, some web apps have already started to check version number of Firefox. We shouldn't break such web apps.
21ebd471d7a6: Bug 1516768 - Put a border on add-on cards in high contrast mode. r=dao, a=RyanVM
Mark Striemer <mstriemer@mozilla.com> - Wed, 16 Jan 2019 12:38:42 +0000 - rev 509530
Push 1905 by ffxbld-merge at Mon, 21 Jan 2019 12:33:13 +0000
Bug 1516768 - Put a border on add-on cards in high contrast mode. r=dao, a=RyanVM Differential Revision: https://phabricator.services.mozilla.com/D16520
73101717e067: Bug 1432133 - Returning an error when FileInfo is missing as a short-term fix. r=asuth, data-review=chutten, a=RyanVM
Tom Tung <shes050117@gmail.com> - Wed, 16 Jan 2019 10:24:56 +0000 - rev 509529
Push 1905 by ffxbld-merge at Mon, 21 Jan 2019 12:33:13 +0000
Bug 1432133 - Returning an error when FileInfo is missing as a short-term fix. r=asuth, data-review=chutten, a=RyanVM Differential Revision: https://phabricator.services.mozilla.com/D16045
69143a6c191d: Bug 1507322 - Test deeply recursive weakmaps. r=jonco, a=RyanVM
Steve Fink <sfink@mozilla.com> - Wed, 16 Jan 2019 21:16:48 +0000 - rev 509528
Push 1905 by ffxbld-merge at Mon, 21 Jan 2019 12:33:13 +0000
Bug 1507322 - Test deeply recursive weakmaps. r=jonco, a=RyanVM Differential Revision: https://phabricator.services.mozilla.com/D16738
e758e8df7f9a: Bug 1507322 - Mark implicit edges via mark stack instead of eagerly. r=jonco, a=RyanVM
Steve Fink <sfink@mozilla.com> - Fri, 11 Jan 2019 15:43:56 -0800 - rev 509527
Push 1905 by ffxbld-merge at Mon, 21 Jan 2019 12:33:13 +0000
Bug 1507322 - Mark implicit edges via mark stack instead of eagerly. r=jonco, a=RyanVM
ba59016735fa: No Bug, mozilla-beta repo-update HSTS HPKP blocklist remote-settings - a=repo-update r=RyanVM
ffxbld <ffxbld@mozilla.com> - Thu, 17 Jan 2019 12:26:28 +0000 - rev 509525
Push 1905 by ffxbld-merge at Mon, 21 Jan 2019 12:33:13 +0000
No Bug, mozilla-beta repo-update HSTS HPKP blocklist remote-settings - a=repo-update r=RyanVM Differential Revision: https://phabricator.services.mozilla.com/D16818
86f5a024cd49: Bug 1519616 - Clear theme preview for themes that don't have previews. r=aswan, a=RyanVM
Mark Striemer <mstriemer@mozilla.com> - Tue, 15 Jan 2019 21:39:04 +0000 - rev 509524
Push 1905 by ffxbld-merge at Mon, 21 Jan 2019 12:33:13 +0000
Bug 1519616 - Clear theme preview for themes that don't have previews. r=aswan, a=RyanVM Differential Revision: https://phabricator.services.mozilla.com/D16594
2ea881a24d05: Bug 1519616 - Explicitly clear theme preview on details for non-themes. r=aswan, a=RyanVM
Mark Striemer <mstriemer@mozilla.com> - Tue, 15 Jan 2019 19:55:21 +0000 - rev 509523
Push 1905 by ffxbld-merge at Mon, 21 Jan 2019 12:33:13 +0000
Bug 1519616 - Explicitly clear theme preview on details for non-themes. r=aswan, a=RyanVM Differential Revision: https://phabricator.services.mozilla.com/D16589
c789ccba525f: Bug 1515816 - Fix missing OOM check in ReadableStreamCreateReadResult. r=arai, a=RyanVM
Jason Orendorff <jorendorff@mozilla.com> - Wed, 16 Jan 2019 00:34:24 +0000 - rev 509522
Push 1905 by ffxbld-merge at Mon, 21 Jan 2019 12:33:13 +0000
Bug 1515816 - Fix missing OOM check in ReadableStreamCreateReadResult. r=arai, a=RyanVM Differential Revision: https://phabricator.services.mozilla.com/D16361
c4fa46cb6918: Bug 1518664 - Make special casting properties available to UA Widget. r=smaug, a=RyanVM
Timothy Guan-tin Chien <timdream@gmail.com> - Tue, 15 Jan 2019 09:20:55 +0000 - rev 509521
Push 1905 by ffxbld-merge at Mon, 21 Jan 2019 12:33:13 +0000
Bug 1518664 - Make special casting properties available to UA Widget. r=smaug, a=RyanVM They are needed so the chrome script (CastingApp.js) can read back the state of the video element. Differential Revision: https://phabricator.services.mozilla.com/D16489
5a50ebe155c4: Bug 1515026 - Add telemetry pings for missing AS Snippets user actions. r=k88hudson, a=RyanVM
Andrei Oprea <andrei.br92@gmail.com> - Wed, 16 Jan 2019 14:15:48 +0000 - rev 509520
Push 1905 by ffxbld-merge at Mon, 21 Jan 2019 12:33:13 +0000
Bug 1515026 - Add telemetry pings for missing AS Snippets user actions. r=k88hudson, a=RyanVM Differential Revision: https://phabricator.services.mozilla.com/D16698
548bb5b013ff: Bug 1518728 - Pass key length to libprio public key export function and use long long for output. r=hsivonen, a=RyanVM
Robert Helmer <rhelmer@mozilla.com> - Fri, 11 Jan 2019 08:25:42 +0000 - rev 509519
Push 1905 by ffxbld-merge at Mon, 21 Jan 2019 12:33:13 +0000
Bug 1518728 - Pass key length to libprio public key export function and use long long for output. r=hsivonen, a=RyanVM Depends on D16266 Differential Revision: https://phabricator.services.mozilla.com/D16267
7f847507d3bb: Bug 1518728 - Update vendored libprio to 1.4. r=glandium, a=RyanVM
Robert Helmer <rhelmer@mozilla.com> - Mon, 14 Jan 2019 23:50:08 +0000 - rev 509518
Push 1905 by ffxbld-merge at Mon, 21 Jan 2019 12:33:13 +0000
Bug 1518728 - Update vendored libprio to 1.4. r=glandium, a=RyanVM Differential Revision: https://phabricator.services.mozilla.com/D16266
561137bf3210: Bug 1516224 - [Linux/Gtk] Disable ARGB toplevel visual on X11 SW compositor due to visible graphics artifacts, r=lsalzman, a=RyanVM
Martin Stransky <stransky@redhat.com> - Tue, 15 Jan 2019 17:45:35 +0000 - rev 509517
Push 1905 by ffxbld-merge at Mon, 21 Jan 2019 12:33:13 +0000
Bug 1516224 - [Linux/Gtk] Disable ARGB toplevel visual on X11 SW compositor due to visible graphics artifacts, r=lsalzman, a=RyanVM Differential Revision: https://phabricator.services.mozilla.com/D16561
b0abaa9984f6: Bug 1519922 - Call ProxyEvent for scrolling events on non-Android. r=Jamie, a=RyanVM
Eitan Isaacson <eitan@monotonous.org> - Mon, 14 Jan 2019 23:46:57 +0000 - rev 509516
Push 1905 by ffxbld-merge at Mon, 21 Jan 2019 12:33:13 +0000
Bug 1519922 - Call ProxyEvent for scrolling events on non-Android. r=Jamie, a=RyanVM Differential Revision: https://phabricator.services.mozilla.com/D16484
e3e8f1521ebd: Bug 1517197. Fix SVG masking and clipping regression. r=mattwoodrow, a=RyanVM
Jonathan Watt <jwatt@jwatt.org> - Tue, 15 Jan 2019 00:20:52 +0000 - rev 509515
Push 1905 by ffxbld-merge at Mon, 21 Jan 2019 12:33:13 +0000
Bug 1517197. Fix SVG masking and clipping regression. r=mattwoodrow, a=RyanVM This Make nsSVGIntegrationUtils::AdjustInvalidAreaForSVGEffects return the original area if there are no filter effects (instead of using some bogus fallback code). Differential Revision: https://phabricator.services.mozilla.com/D16516
944e9c24989d: Bug 1514016 - Check that all events are fired as expected for MediaRecorder-stop.html. r=jib, a=RyanVM
Andreas Pehrson <apehrson@mozilla.com> - Mon, 14 Jan 2019 18:32:58 +0000 - rev 509512
Push 1905 by ffxbld-merge at Mon, 21 Jan 2019 12:33:13 +0000
Bug 1514016 - Check that all events are fired as expected for MediaRecorder-stop.html. r=jib, a=RyanVM Differential Revision: https://phabricator.services.mozilla.com/D15912
c8acac1e463c: Bug 1514016 - Check that MediaRecorder::Stop is idempotent. r=jib, a=RyanVM
Andreas Pehrson <apehrson@mozilla.com> - Mon, 14 Jan 2019 18:32:57 +0000 - rev 509511
Push 1905 by ffxbld-merge at Mon, 21 Jan 2019 12:33:13 +0000
Bug 1514016 - Check that MediaRecorder::Stop is idempotent. r=jib, a=RyanVM Differential Revision: https://phabricator.services.mozilla.com/D15911
f11dd983a8aa: Bug 1514016 - Rework MediaRecorder-stop tests to use async-await. r=jib, a=RyanVM
Bryce Van Dyk <bvandyk@mozilla.com> - Mon, 14 Jan 2019 18:32:55 +0000 - rev 509510
Push 1905 by ffxbld-merge at Mon, 21 Jan 2019 12:33:13 +0000
Bug 1514016 - Rework MediaRecorder-stop tests to use async-await. r=jib, a=RyanVM Depends on D14891 Differential Revision: https://phabricator.services.mozilla.com/D14892
662ea26b9f34: Bug 1514016 - Add WPT for MediaRecorder pause and resume behaviour. r=jib, a=RyanVM
Bryce Van Dyk <bvandyk@mozilla.com> - Mon, 14 Jan 2019 18:32:54 +0000 - rev 509509
Push 1905 by ffxbld-merge at Mon, 21 Jan 2019 12:33:13 +0000
Bug 1514016 - Add WPT for MediaRecorder pause and resume behaviour. r=jib, a=RyanVM Differential Revision: https://phabricator.services.mozilla.com/D14891
f8fa8bc2b93f: Bug 1514016 - Make MediaRecorder::Pause and MediaRecorder::Resume idempotent. r=jib, a=RyanVM
Andreas Pehrson <apehrson@mozilla.com> - Mon, 14 Jan 2019 18:32:56 +0000 - rev 509508
Push 1905 by ffxbld-merge at Mon, 21 Jan 2019 12:33:13 +0000
Bug 1514016 - Make MediaRecorder::Pause and MediaRecorder::Resume idempotent. r=jib, a=RyanVM Differential Revision: https://phabricator.services.mozilla.com/D15910
e74775e3a741: Bug 1514016 - Make MediaRecorder::Stop idempotent. r=jib, a=RyanVM
Andreas Pehrson <apehrson@mozilla.com> - Mon, 14 Jan 2019 18:32:55 +0000 - rev 509507
Push 1905 by ffxbld-merge at Mon, 21 Jan 2019 12:33:13 +0000
Bug 1514016 - Make MediaRecorder::Stop idempotent. r=jib, a=RyanVM Depends on D14571 Differential Revision: https://phabricator.services.mozilla.com/D15909
9e2fe8635c95: Bug 1514016 - Use DispatchTrustedEvent helper in MediaRecorder::DispatchSimpleEvent. r=pehrsons, a=RyanVM
Bryce Van Dyk <bvandyk@mozilla.com> - Mon, 14 Jan 2019 18:32:54 +0000 - rev 509506
Push 1905 by ffxbld-merge at Mon, 21 Jan 2019 12:33:13 +0000
Bug 1514016 - Use DispatchTrustedEvent helper in MediaRecorder::DispatchSimpleEvent. r=pehrsons, a=RyanVM During review of bug 1458538, :bz noted that our event dispatching code could be simplified by using DOMEventTargetHelper::DispatchTrustedEvent. As this was not done during that bug, driveby fix here while we're making other changes. Differential Revision: https://phabricator.services.mozilla.com/D14571
5d242f707c45: Bug 1514016 - Add logging of this to MediaRecorder::pause and resume. r=pehrsons, a=RyanVM
Bryce Van Dyk <bvandyk@mozilla.com> - Mon, 14 Jan 2019 18:32:54 +0000 - rev 509505
Push 1905 by ffxbld-merge at Mon, 21 Jan 2019 12:33:13 +0000
Bug 1514016 - Add logging of this to MediaRecorder::pause and resume. r=pehrsons, a=RyanVM Driveby change to bring our logging here in line with out other logging. Depends on D14488 Differential Revision: https://phabricator.services.mozilla.com/D14489
90eb6008a5ae: Bug 1514016 - Fire pause and resume events asynchronously. r=pehrsons, a=RyanVM
Bryce Van Dyk <bvandyk@mozilla.com> - Mon, 14 Jan 2019 18:32:53 +0000 - rev 509504
Push 1905 by ffxbld-merge at Mon, 21 Jan 2019 12:33:13 +0000
Bug 1514016 - Fire pause and resume events asynchronously. r=pehrsons, a=RyanVM Depends on D14487 Differential Revision: https://phabricator.services.mozilla.com/D14488
eb356ac31743: Bug 1514016 - Replace DispatchStartEventRunnable with DispatchEventRunnable. r=pehrsons, a=RyanVM
Bryce Van Dyk <bvandyk@mozilla.com> - Mon, 14 Jan 2019 18:32:53 +0000 - rev 509503
Push 1905 by ffxbld-merge at Mon, 21 Jan 2019 12:33:13 +0000
Bug 1514016 - Replace DispatchStartEventRunnable with DispatchEventRunnable. r=pehrsons, a=RyanVM Depends on D14486 Differential Revision: https://phabricator.services.mozilla.com/D14487
7746b834faec: Bug 1514016 - Add DispatchEventRunnable to media recorder to aid with dispatching different named events. r=pehrsons, a=RyanVM
Bryce Van Dyk <bvandyk@mozilla.com> - Mon, 14 Jan 2019 18:32:52 +0000 - rev 509502
Push 1905 by ffxbld-merge at Mon, 21 Jan 2019 12:33:13 +0000
Bug 1514016 - Add DispatchEventRunnable to media recorder to aid with dispatching different named events. r=pehrsons, a=RyanVM Differential Revision: https://phabricator.services.mozilla.com/D14486
21f066e22f2a: Bug 1518514 - Correctly read and parse list.json in search engine manager. r=nalexander, a=RyanVM
Michael Kaply <mozilla@kaply.com> - Thu, 10 Jan 2019 19:07:18 +0000 - rev 509496
Push 1905 by ffxbld-merge at Mon, 21 Jan 2019 12:33:13 +0000
Bug 1518514 - Correctly read and parse list.json in search engine manager. r=nalexander, a=RyanVM Differential Revision: https://phabricator.services.mozilla.com/D15992
1cf642fe06ab: Bug 1493980 - Don't pass indefinite screen orientations to Gecko. r=snorp, a=RyanVM
Matt Brubeck <mbrubeck@mozilla.com> - Thu, 10 Jan 2019 21:46:12 +0000 - rev 509495
Push 1905 by ffxbld-merge at Mon, 21 Jan 2019 12:33:13 +0000
Bug 1493980 - Don't pass indefinite screen orientations to Gecko. r=snorp, a=RyanVM This eliminates one potential source of crashes from passing bad orientation values to onOrientationChange. Differential Revision: https://phabricator.services.mozilla.com/D16207
406819dad2e1: Bug 1494748 - Ensure GeckoView saved state lives at least as long as the app process. r=snorp, a=RyanVM
Jan Henning <jh+bugzilla@buttercookie.de> - Mon, 14 Jan 2019 19:21:49 +0000 - rev 509494
Push 1905 by ffxbld-merge at Mon, 21 Jan 2019 12:33:13 +0000
Bug 1494748 - Ensure GeckoView saved state lives at least as long as the app process. r=snorp, a=RyanVM The arguably most interesting bit of state of BrowserApp/GeckoApp, namely the currently open tabs, are living partly in Gecko and partly in the Tabs manager singleton, the lifetimes of both of which are tied to the lifetime of the app process. If the whole process has been killed, things are simple: Neither the Tabs manager nor Gecko know anything about any tabs and we simply restore them through the session store if enabled. If GeckoApp is however being restored into an app process in which it had already executed earlier on, meaning that we have some open tabs, it relies on the savedInstanceState in order to correctly reconnect its GeckoView instance with the correct previous GeckoSession. We can however end up in a state where we don't have a savedInstanceState (e.g. because the user swiped away the BrowserApp activity in the task switcher), but the app process keeps running throughout (if another activity of ours is still present in the task switcher, e.g. a custom tab, or else if a service is active, then standard Android keeps the process running even if the user swipes away an activity). In that case, if GeckoApp is subsequently recreated, the Android UI sees all the Android-side tabs in the Tabs manager, and Gecko in fact still has the Window open that is containing all those tabs, but without the savedInstanceState GeckoApp doesn't know anything about that Window and proceeds to open a fresh session instead. This means that all previous tabs will appear white and unresponsive, while freshly opened tabs will load, but they won't be correctly saved in the session store, their context menu isn't working, etc., because we're not really expecting to handle multiple Gecko-side Windows. To fix this, we disable automatic state-saving for GeckoApp's GeckoView instance and instead do it manually, so we can keep another reference to the saved state in GeckoApplication, and therefore are able to retrieve it from there for as long as the app process keeps running. Differential Revision: https://phabricator.services.mozilla.com/D16393
f4e3251f788d: Bug 1518619 - Pref on ASR Snippets for 65 Beta and Release. r=k88hudson, a=RyanVM
Ed Lee <edilee@mozilla.com> - Tue, 15 Jan 2019 19:55:34 +0000 - rev 509493
Push 1905 by ffxbld-merge at Mon, 21 Jan 2019 12:33:13 +0000
Bug 1518619 - Pref on ASR Snippets for 65 Beta and Release. r=k88hudson, a=RyanVM Differential Revision: https://phabricator.services.mozilla.com/D16591
0205f0c7abb2: Bug 1519019 - Uplift fix to CallStack Group with anonymous function. r=jlast, a=RyanVM
Nicolas Chevobbe <nchevobbe@users.noreply.github.com> - Thu, 03 Jan 2019 20:11:07 +0000 - rev 509492
Push 1905 by ffxbld-merge at Mon, 21 Jan 2019 12:33:13 +0000
Bug 1519019 - Uplift fix to CallStack Group with anonymous function. r=jlast, a=RyanVM This is the same patch as in Bug 1517572, applied on the beta branch. Differential Revision: https://phabricator.services.mozilla.com/D16156
92b23e3b94ef: Bug 1511878 - Start respecting the alpha channel for disabled control text color on macOS to accommodate the way this system color is declared by the OS on macOS 10.14+. r=mstange, a=RyanVM
Stephen A Pohl <spohl.mozilla.bugs@gmail.com> - Mon, 14 Jan 2019 19:54:32 -0500 - rev 509491
Push 1905 by ffxbld-merge at Mon, 21 Jan 2019 12:33:13 +0000
Bug 1511878 - Start respecting the alpha channel for disabled control text color on macOS to accommodate the way this system color is declared by the OS on macOS 10.14+. r=mstange, a=RyanVM