searching for reviewer(JanH)
9a68634dc411: Bug 1519418 - Replace MMA preferences with sharedPreferences. r=JanH a=lizzard
Vlad Baicu <vlad.baicu@softvision.ro> - Wed, 06 Mar 2019 04:04:30 +0200 - rev 516269
Push 1953 by ffxbld-merge at Mon, 11 Mar 2019 12:10:20 +0000
Bug 1519418 - Replace MMA preferences with sharedPreferences. r=JanH a=lizzard Summary: Patch D16319 attempted to clean the MMA code and allow for easier debugging of LP deeplinks on dev builds. However it introduced a regression because the MMA preferences were being accessed by the initializing activity. By making getDeviceId public and static, calling it from another activity would result in a null value returned. I have refactored the code to use shared preferences and remove the dependency on other activities. Reviewers: JanH, petru Reviewed By: petru Bug #: 1519418 Differential Revision: https://phabricator.services.mozilla.com/D21984
fd591b31f209: Bug 1527648 - Uid deeplink nullpointer check. r=JanH a=lizzard
Dorel Luca <dluca@mozilla.com> - Fri, 22 Feb 2019 11:11:03 +0200 - rev 516078
Push 1953 by ffxbld-merge at Mon, 11 Mar 2019 12:10:20 +0000
Bug 1527648 - Uid deeplink nullpointer check. r=JanH a=lizzard Summary: Patch from bug 1519418 introduced a regression by removing line separators from the uid parameter contained within deeplinks. However, not all deeplinks are mandatory to contain the uid parameter. Added a null check before replacing the line separators. Reviewers: JanH, petru Reviewed By: petru Bug #: 1527648 Differential Revision: https://phabricator.services.mozilla.com/D20367
6fec628734c8: Bug 1525872 PushEvent.data is null for push messages encrypted with aes128gcm r=JanH a=lizzard
Andrei Lazar <andrei.a.lazar@softvision.ro> - Mon, 18 Feb 2019 08:15:26 +0000 - rev 516057
Push 1953 by ffxbld-merge at Mon, 11 Mar 2019 12:10:20 +0000
Bug 1525872 PushEvent.data is null for push messages encrypted with aes128gcm r=JanH a=lizzard Added check for AES128GCM encoding since we won't have separate enckey and cryptokey but rather encoded in the body. Differential Revision: https://phabricator.services.mozilla.com/D19806
be69f7164f21: Bug 1516665 - Part 2: Cleanup. r=JanH a=lizzard
Vlad Baicu <vlad.baicu@softvision.ro> - Fri, 01 Feb 2019 15:08:00 +0000 - rev 515776
Push 1953 by ffxbld-merge at Mon, 11 Mar 2019 12:10:20 +0000
Bug 1516665 - Part 2: Cleanup. r=JanH a=lizzard Some code cleanup. Depends on D17391 Differential Revision: https://phabricator.services.mozilla.com/D18115
1ce04026e6eb: Bug 1516665 - Prevent MediaControlService NPE. r=JanH a=lizzard
Vlad Baicu <vlad.baicu@softvision.ro> - Fri, 01 Feb 2019 15:07:29 +0000 - rev 515775
Push 1953 by ffxbld-merge at Mon, 11 Mar 2019 12:10:20 +0000
Bug 1516665 - Prevent MediaControlService NPE. r=JanH a=lizzard Use MediaControlService's context when creating the notification in order to prevent a NPE. Differential Revision: https://phabricator.services.mozilla.com/D17391
5d0fef351a29: Bug 1473470 - Part 3 - Remove "Saved logins" from "Clear private data" options. r=JanH
Petru Lingurar <petru.lingurar@softvision.ro> - Tue, 15 Jan 2019 11:02:33 +0200 - rev 513888
Push 1953 by ffxbld-merge at Mon, 11 Mar 2019 12:10:20 +0000
Bug 1473470 - Part 3 - Remove "Saved logins" from "Clear private data" options. r=JanH Summary: Login data is to be removed only from "about:logins" where the users that use Sync are also informed about the perils of doing so. Depends on D16027 Reviewers: JanH, #geckoview-reviewers Reviewed By: JanH Subscribers: flod Bug #: 1473470 Differential Revision: https://phabricator.services.mozilla.com/D16029
ae52a3250ebf: Bug 1473470 - Part 2 - Inform user about synced logins if Sync is used. r=JanH
Petru Lingurar <petru.lingurar@softvision.ro> - Tue, 15 Jan 2019 11:01:08 +0200 - rev 513887
Push 1953 by ffxbld-merge at Mon, 11 Mar 2019 12:10:20 +0000
Bug 1473470 - Part 2 - Inform user about synced logins if Sync is used. r=JanH Summary: The reason for this ticket was that it was not immediately obvious for Sync users that deleting logins on this device may affect all logins stored in user's Sync account. So it was possible that users could unintentionally loose all their login data. While we should still offer the option to remove login data, even to Sync users, we will explicitly inform them that deleting logins can affect all their synced logins. Also refactored the code to minimize duplicated code. Depends on D16026 Reviewers: JanH, #geckoview-reviewers Reviewed By: JanH Subscribers: reviewbot, flod Bug #: 1473470 Differential Revision: https://phabricator.services.mozilla.com/D16027
a7034ada9fb3: Bug 1473470 - Part 1 - Add new "Delete all" option to about:logins; r=JanH
Petru Lingurar <petru.lingurar@softvision.ro> - Mon, 14 Jan 2019 13:42:42 +0000 - rev 513735
Push 1953 by ffxbld-merge at Mon, 11 Mar 2019 12:10:20 +0000
Bug 1473470 - Part 1 - Add new "Delete all" option to about:logins; r=JanH This new option allows removing all logins from our login manager. Differential Revision: https://phabricator.services.mozilla.com/D16026
4f4436e2493a: Bug 1513938 - Enforce a Bundle size limit and drop `privateSession` if exceeds it; r=JanH
Petru Lingurar <petru.lingurar@softvision.ro> - Fri, 21 Dec 2018 08:56:47 +0000 - rev 511636
Push 1953 by ffxbld-merge at Mon, 11 Mar 2019 12:10:20 +0000
Bug 1513938 - Enforce a Bundle size limit and drop `privateSession` if exceeds it; r=JanH The `privateSession` key would normally allow persisting the Private Browsing session across OOMs in Activity's Bundle. We need to do that to avoid storing private, sensible data on disk like we do with the normal browsing session. In some cases `privateSession` would contain a lot of data which, along with other possible concurrent transactions could overflow Binder's buffer which has a limited fixed size, currently 1Mb. To avoid this, we will drop `privateSession` from the Bundle if the resulting size is greater than a _speculative_ size of 300KBs which would mean that in the case of an OOM all Private Browsing state would be lost. Bug 1515592 is filed to investigate for a better solution. Differential Revision: https://phabricator.services.mozilla.com/D15067
4b128c704ca6: Bug 1509434 - Part 2 - Wait for AudioFocusAgent to be initialized before starting testMediaControl;r=JanH
Petru Lingurar <petru.lingurar@softvision.ro> - Sun, 16 Dec 2018 19:48:16 +0000 - rev 510882
Push 1953 by ffxbld-merge at Mon, 11 Mar 2019 12:10:20 +0000
Bug 1509434 - Part 2 - Wait for AudioFocusAgent to be initialized before starting testMediaControl;r=JanH Inside the tests from testMediaControl audio focus is not immediately checked as for the tests from testAudioFocus but nonetheless we should make sure AudioFocusAgent is initialized before proceeding with the media tests. Depends on D14417 Differential Revision: https://phabricator.services.mozilla.com/D14418
f525a4f572f6: Bug 1509434 - Part 1 - Wait for AudioFocusAgent to be initialized before starting testAudioFocus;r=JanH
Petru Lingurar <petru.lingurar@softvision.ro> - Mon, 17 Dec 2018 07:59:44 +0000 - rev 510881
Push 1953 by ffxbld-merge at Mon, 11 Mar 2019 12:10:20 +0000
Bug 1509434 - Part 1 - Wait for AudioFocusAgent to be initialized before starting testAudioFocus;r=JanH There is a small race between actually starting the test after Gecko:Ready and having the AudioFocusAgent that the tests depend on initialized, which is also done after Gecko:Ready. To avoid this situation we will wait for Gecko:Ready and then for AudioFocusAgent to complete it's initialization. Differential Revision: https://phabricator.services.mozilla.com/D14417
fd2587f34b52: Bug 1512267 - If you set a pres shell resolution, you must scale to it. r=kats,JanH
Botond Ballo <botond@mozilla.com> - Mon, 10 Dec 2018 19:32:59 +0000 - rev 509721
Push 1953 by ffxbld-merge at Mon, 11 Mar 2019 12:10:20 +0000
Bug 1512267 - If you set a pres shell resolution, you must scale to it. r=kats,JanH Differential Revision: https://phabricator.services.mozilla.com/D13928
2c2abfb19c1a: Bug 1501688 Temporary files generated by opening external files with content:// scheme should be sanitized r=JanH
Andrei Lazar <andrei.a.lazar@softvision.ro> - Mon, 10 Dec 2018 15:57:48 +0000 - rev 509683
Push 1953 by ffxbld-merge at Mon, 11 Mar 2019 12:10:20 +0000
Bug 1501688 Temporary files generated by opening external files with content:// scheme should be sanitized r=JanH Implemented cache sanitizing for files generated by handling the content:// scheme. Differential Revision: https://phabricator.services.mozilla.com/D11779
c85e2fe3af3b: Bug 1501024 WifiScanner should use ApplicationContext r=JanH
Andrei Lazar <andrei.a.lazar@softvision.ro> - Mon, 10 Dec 2018 09:33:18 +0000 - rev 509671
Push 1953 by ffxbld-merge at Mon, 11 Mar 2019 12:10:20 +0000
Bug 1501024 WifiScanner should use ApplicationContext r=JanH Fixed lint warning regarding memory leak inside WifiManager constructor. Differential Revision: https://phabricator.services.mozilla.com/D13930
8ec5f920524b: Bug 1516665 - Prevent MediaControlService NPE. r=JanH, a=RyanVM
Vlad Baicu <vlad.baicu@softvision.ro> - Fri, 01 Feb 2019 15:07:29 +0000 - rev 509635
Push 1935 by ryanvm@gmail.com at Mon, 11 Feb 2019 16:39:10 +0000
Bug 1516665 - Prevent MediaControlService NPE. r=JanH, a=RyanVM Use MediaControlService's context when creating the notification in order to prevent a NPE. Differential Revision: https://phabricator.services.mozilla.com/D17391
226db4f6cb06: Bug 1513938 - Enforce a Bundle size limit and drop `privateSession` if exceeds it. r=JanH, a=lizzard
Petru Lingurar <petru.lingurar@softvision.ro> - Fri, 21 Dec 2018 08:56:47 +0000 - rev 509195
Push 1905 by ffxbld-merge at Mon, 21 Jan 2019 12:33:13 +0000
Bug 1513938 - Enforce a Bundle size limit and drop `privateSession` if exceeds it. r=JanH, a=lizzard The `privateSession` key would normally allow persisting the Private Browsing session across OOMs in Activity's Bundle. We need to do that to avoid storing private, sensible data on disk like we do with the normal browsing session. In some cases `privateSession` would contain a lot of data which, along with other possible concurrent transactions could overflow Binder's buffer which has a limited fixed size, currently 1Mb. To avoid this, we will drop `privateSession` from the Bundle if the resulting size is greater than a _speculative_ size of 300KBs which would mean that in the case of an OOM all Private Browsing state would be lost. Bug 1515592 is filed to investigate for a better solution. Differential Revision: https://phabricator.services.mozilla.com/D15067
73c6129bfe79: Bug 1509434 - Part 2: Wait for AudioFocusAgent to be initialized before starting testMediaControl. r=JanH, a=test-only
Petru Lingurar <petru.lingurar@softvision.ro> - Sun, 16 Dec 2018 19:48:16 +0000 - rev 509066
Push 1905 by ffxbld-merge at Mon, 21 Jan 2019 12:33:13 +0000
Bug 1509434 - Part 2: Wait for AudioFocusAgent to be initialized before starting testMediaControl. r=JanH, a=test-only Inside the tests from testMediaControl audio focus is not immediately checked as for the tests from testAudioFocus but nonetheless we should make sure AudioFocusAgent is initialized before proceeding with the media tests. Depends on D14417 Differential Revision: https://phabricator.services.mozilla.com/D14418
4d21abcabd2a: Bug 1509434 - Part 1: Wait for AudioFocusAgent to be initialized before starting testAudioFocus. r=JanH, a=test-only
Petru Lingurar <petru.lingurar@softvision.ro> - Mon, 17 Dec 2018 07:59:44 +0000 - rev 509065
Push 1905 by ffxbld-merge at Mon, 21 Jan 2019 12:33:13 +0000
Bug 1509434 - Part 1: Wait for AudioFocusAgent to be initialized before starting testAudioFocus. r=JanH, a=test-only There is a small race between actually starting the test after Gecko:Ready and having the AudioFocusAgent that the tests depend on initialized, which is also done after Gecko:Ready. To avoid this situation we will wait for Gecko:Ready and then for AudioFocusAgent to complete it's initialization. Differential Revision: https://phabricator.services.mozilla.com/D14417
e2336587275f: Bug 1501688 - Temporary files generated by opening external files with content:// scheme should be sanitized. r=JanH, a=RyanVM
Andrei Lazar <andrei.a.lazar@softvision.ro> - Mon, 10 Dec 2018 18:46:32 +0200 - rev 508941
Push 1905 by ffxbld-merge at Mon, 21 Jan 2019 12:33:13 +0000
Bug 1501688 - Temporary files generated by opening external files with content:// scheme should be sanitized. r=JanH, a=RyanVM Implemented cache sanitizing for files generated by handling the content:// scheme. Differential Revision: https://phabricator.services.mozilla.com/D11779
f9ef4b24affa: Bug 1501024 WifiScanner should use ApplicationContext r=JanH a=RyanVM-on-IRC
Andrei Lazar <andrei.a.lazar@softvision.ro> - Mon, 10 Dec 2018 09:33:18 +0000 - rev 508922
Push 1905 by ffxbld-merge at Mon, 21 Jan 2019 12:33:13 +0000
Bug 1501024 WifiScanner should use ApplicationContext r=JanH a=RyanVM-on-IRC Fixed lint warning regarding memory leak inside WifiManager constructor. Differential Revision: https://phabricator.services.mozilla.com/D13930
6f37c64ae423: Bug 1501024 WifiScanner should use ApplicationContext r=JanH
Andrei Lazar <andrei.a.lazar@softvision.ro> - Fri, 07 Dec 2018 18:54:56 +0000 - rev 508844
Push 1905 by ffxbld-merge at Mon, 21 Jan 2019 12:33:13 +0000
Bug 1501024 WifiScanner should use ApplicationContext r=JanH Fixed lint warning regarding memory leak inside WifiManager constructor. Differential Revision: https://phabricator.services.mozilla.com/D13930
e1e05cf314a3: Bug 1499618 Crash in java.lang.IllegalArgumentException: at android.database.AbstractCursor.getColumnIndexOrThrow(AbstractCursor.java) r=JanH
Andrei Lazar <andrei.a.lazar@softvision.ro> - Wed, 21 Nov 2018 16:33:38 +0000 - rev 508348
Push 1905 by ffxbld-merge at Mon, 21 Jan 2019 12:33:13 +0000
Bug 1499618 Crash in java.lang.IllegalArgumentException: at android.database.AbstractCursor.getColumnIndexOrThrow(AbstractCursor.java) r=JanH Added fallback for the cases where trying to obtain a file absolute path from external storage was throwing an exception. Differential Revision: https://phabricator.services.mozilla.com/D9248
9fda62ff71b4: Bug 1502721 Crash in java.lang.NumberFormatException: at java.lang.Long.parseLong(Long.java) r=JanH
Andrei Lazar <andrei.a.lazar@softvision.ro> - Wed, 28 Nov 2018 20:45:44 +0000 - rev 507816
Push 1905 by ffxbld-merge at Mon, 21 Jan 2019 12:33:13 +0000
Bug 1502721 Crash in java.lang.NumberFormatException: at java.lang.Long.parseLong(Long.java) r=JanH Added catch for NumberFormatException that may be thrown when trying to open some downloaded files with Fennec. Differential Revision: https://phabricator.services.mozilla.com/D12773
f5bf87ab6448: Bug 1500479 - Part 1: browser.tabs.onActivated; r=mixedpuppy,rpl,JanH
Ryan Hendrickson <ryan.hendrickson@alum.mit.edu> - Mon, 26 Nov 2018 04:16:30 +0000 - rev 507590
Push 1905 by ffxbld-merge at Mon, 21 Jan 2019 12:33:13 +0000
Bug 1500479 - Part 1: browser.tabs.onActivated; r=mixedpuppy,rpl,JanH Add an optional previousTabId property to the onActivated event, which is present if the previously activated tab is still open. Differential Revision: https://phabricator.services.mozilla.com/D9271
e23085e6b51f: Bug 1484528 - Prevent page loading indicator running continuously; r=JanH
Petru Lingurar <petru.lingurar@softvision.ro> - Thu, 22 Nov 2018 14:52:46 +0000 - rev 506924
Push 1905 by ffxbld-merge at Mon, 21 Jan 2019 12:33:13 +0000
Bug 1484528 - Prevent page loading indicator running continuously; r=JanH The page loading indicator should be animated while it is visible. Previously for controlling the animation the visibility state of the parent Drawable - ShiftDrawable would be checked, which in all cases would return true, so the animation would run indefinitely. The patch modifies setVisible() in accordance with the Framework version of DrawableWrapper to corectly set the visibility of both the wrapper and the wrapped drawables so that isVisible() will now return the correct value which will allow stopping the animation. Differential Revision: https://phabricator.services.mozilla.com/D12552
5335dd9d85ca: Bug 1479724 - Part 3: Logos for Dev builds; r=sdaswani,bram,JanH
Petru Lingurar <petru.lingurar@softvision.ro> - Thu, 22 Nov 2018 00:07:14 +0000 - rev 506896
Push 1905 by ffxbld-merge at Mon, 21 Jan 2019 12:33:13 +0000
Bug 1479724 - Part 3: Logos for Dev builds; r=sdaswani,bram,JanH This are used as logos and by SiteIdentityPopup.java Depends on D12024 Differential Revision: https://phabricator.services.mozilla.com/D12025
a314851c740f: Bug 1479724 - Part 2: Pre-Oreo icons for Dev builds; r=sdaswani,bram,JanH
Petru Lingurar <petru.lingurar@softvision.ro> - Tue, 20 Nov 2018 21:19:28 +0000 - rev 506895
Push 1905 by ffxbld-merge at Mon, 21 Jan 2019 12:33:13 +0000
Bug 1479724 - Part 2: Pre-Oreo icons for Dev builds; r=sdaswani,bram,JanH Depends on D12023 Differential Revision: https://phabricator.services.mozilla.com/D12024
0a6efd77a79e: Bug 1479724 - Part 1: Adaptive icons for Beta and Dev builds; r=sdaswani,bram,JanH
Petru Lingurar <petru.lingurar@softvision.ro> - Tue, 20 Nov 2018 19:25:10 +0000 - rev 506894
Push 1905 by ffxbld-merge at Mon, 21 Jan 2019 12:33:13 +0000
Bug 1479724 - Part 1: Adaptive icons for Beta and Dev builds; r=sdaswani,bram,JanH Differential Revision: https://phabricator.services.mozilla.com/D12023
be4f02491218: Bug 1505685 - Part 3 - Register HeadSetStateReceiver on the main thread; r=JanH
Petru Lingurar <petru.lingurar@softvision.ro> - Wed, 21 Nov 2018 12:16:34 +0200 - rev 506734
Push 1905 by ffxbld-merge at Mon, 21 Jan 2019 12:33:13 +0000
Bug 1505685 - Part 3 - Register HeadSetStateReceiver on the main thread; r=JanH Summary: Speculative fix. initialize() is called by Gecko on it's background thread after it started. The value for the "dom.audiochannel.mediaControl" preference also comes on a background thread. This both can end up registering the HeadSetStateReceiver while unregistering it happens only on the main thread. The patch tries to avoid the race condition by making sure Receiver's registering and unregistering is done serially on the main thread. Depends on D12032 Reviewers: JanH Reviewed By: JanH Subscribers: jya Bug #: 1505685 Differential Revision: https://phabricator.services.mozilla.com/D12033
2a75f31dcd5f: Bug 1505685 - Part 2 - Cleanup - remove second SwitchBoard.loadConfig(); r=JanH
Petru Lingurar <petru.lingurar@softvision.ro> - Wed, 21 Nov 2018 12:15:12 +0200 - rev 506733
Push 1905 by ffxbld-merge at Mon, 21 Jan 2019 12:33:13 +0000
Bug 1505685 - Part 2 - Cleanup - remove second SwitchBoard.loadConfig(); r=JanH Summary: Executing SwitchBoard.loadConfig() on a background thread is the main purpose of the AsyncConfigLoader so executing it immediately again in the same thread is redundant. Depends on D12031 Reviewers: JanH Reviewed By: JanH Bug #: 1505685 Differential Revision: https://phabricator.services.mozilla.com/D12032
cbe820dfb9ad: Bug 1505685 - Part 1 - Register PackageAddedReceiver on the main thread; r=JanH
Petru Lingurar <petru.lingurar@softvision.ro> - Wed, 21 Nov 2018 12:12:53 +0200 - rev 506732
Push 1905 by ffxbld-merge at Mon, 21 Jan 2019 12:33:13 +0000
Bug 1505685 - Part 1 - Register PackageAddedReceiver on the main thread; r=JanH Summary: Speculative fix for avoiding the situation in which the initialization of Mma and registering of the PackageAddedReceiver continues on the background thread after BrowserApp is destroyed and calls for unregistering the receiver. By registering the receiver on the main thread we have the benefit of sequentially execution which would guarantee that the registration is done before trying to unregister it. Reviewers: JanH Reviewed By: JanH Bug #: 1505685 Differential Revision: https://phabricator.services.mozilla.com/D12031
6e2a67a9a9c9: Bug 1505685 - Part 3 - Register HeadSetStateReceiver on the main thread; r=JanH
Petru Lingurar <petru.lingurar@softvision.ro> - Wed, 21 Nov 2018 11:21:52 +0200 - rev 506729
Push 1905 by ffxbld-merge at Mon, 21 Jan 2019 12:33:13 +0000
Bug 1505685 - Part 3 - Register HeadSetStateReceiver on the main thread; r=JanH Summary: Speculative fix. initialize() is called by Gecko on it's background thread after it started. The value for the "dom.audiochannel.mediaControl" preference also comes on a background thread. This both can end up registering the HeadSetStateReceiver while unregistering it happens only on the main thread. The patch tries to avoid the race condition by making sure Receiver's registering and unregistering is done serially on the main thread. Depends on D12032 Reviewers: JanH Reviewed By: JanH Subscribers: jya Bug #: 1505685 Differential Revision: https://phabricator.services.mozilla.com/D12033
a46710b7723f: Bug 1505685 - Part 2 - Cleanup - remove second SwitchBoard.loadConfig(); r=JanH
Petru Lingurar <petru.lingurar@softvision.ro> - Wed, 21 Nov 2018 11:21:01 +0200 - rev 506728
Push 1905 by ffxbld-merge at Mon, 21 Jan 2019 12:33:13 +0000
Bug 1505685 - Part 2 - Cleanup - remove second SwitchBoard.loadConfig(); r=JanH Summary: Executing SwitchBoard.loadConfig() on a background thread is the main purpose of the AsyncConfigLoader so executing it immediately again in the same thread is redundant. Depends on D12031 Reviewers: JanH Reviewed By: JanH Bug #: 1505685 Differential Revision: https://phabricator.services.mozilla.com/D12032
9344087c8d8e: Bug 1505685 - Part 1 - Register PackageAddedReceiver on the main thread; r=JanH
Petru Lingurar <petru.lingurar@softvision.ro> - Wed, 21 Nov 2018 11:18:41 +0200 - rev 506727
Push 1905 by ffxbld-merge at Mon, 21 Jan 2019 12:33:13 +0000
Bug 1505685 - Part 1 - Register PackageAddedReceiver on the main thread; r=JanH Summary: Speculative fix for avoiding the situation in which the initialization of Mma and registering of the PackageAddedReceiver continues on the background thread after BrowserApp is destroyed and calls for unregistering the receiver. By registering the receiver on the main thread we have the benefit of sequentially execution which would guarantee that the registration is done before trying to unregister it. Reviewers: JanH Reviewed By: JanH Bug #: 1505685 Differential Revision: https://phabricator.services.mozilla.com/D12031
838185d7a6e7: Bug 1500479 - Part 1: browser.tabs.onActivated; r=mixedpuppy,rpl,JanH
Ryan Hendrickson <ryan.hendrickson@alum.mit.edu> - Thu, 15 Nov 2018 15:17:16 +0000 - rev 505857
Push 1905 by ffxbld-merge at Mon, 21 Jan 2019 12:33:13 +0000
Bug 1500479 - Part 1: browser.tabs.onActivated; r=mixedpuppy,rpl,JanH Add an optional previousTabId property to the onActivated event, which is present if the previously activated tab is still open. Differential Revision: https://phabricator.services.mozilla.com/D9271
02ea631f55c3: Bug 1500479 - Part 1: browser.tabs.onActivated; r=mixedpuppy,rpl,JanH
Ryan Hendrickson <ryan.hendrickson@alum.mit.edu> - Wed, 14 Nov 2018 17:22:26 +0000 - rev 505425
Push 1905 by ffxbld-merge at Mon, 21 Jan 2019 12:33:13 +0000
Bug 1500479 - Part 1: browser.tabs.onActivated; r=mixedpuppy,rpl,JanH Add an optional previousTabId property to the onActivated event, which is present if the previously activated tab is still open. Differential Revision: https://phabricator.services.mozilla.com/D9271
f5722c5e51e7: Bug 1506096 - Restore browser.urlbar.autocomplete.enabled for Android. r=JanH
Marco Bonardo <mbonardo@mozilla.com> - Fri, 09 Nov 2018 21:07:13 +0000 - rev 504691
Push 1905 by ffxbld-merge at Mon, 21 Jan 2019 12:33:13 +0000
Bug 1506096 - Restore browser.urlbar.autocomplete.enabled for Android. r=JanH Differential Revision: https://phabricator.services.mozilla.com/D11504
4f8d41b9bb67: Bug 1501648 - Prevent crashes for unregistered receivers from MmaDelegate and GeckoMediaControlAgent; r=jchen,JanH
Petru Lingurar <petru.lingurar@softvision.ro> - Thu, 08 Nov 2018 12:08:40 +0000 - rev 504334
Push 1905 by ffxbld-merge at Mon, 21 Jan 2019 12:33:13 +0000
Bug 1501648 - Prevent crashes for unregistered receivers from MmaDelegate and GeckoMediaControlAgent; r=jchen,JanH Although this two receivers are guarded by checks for if they were initialized (and so registered) there are reports of crashes because of trying to unregister them without them actually being registered. The underlying issue will be investigated further in bug 1505685 but for the moment wrapping the unregister operations in a try-catch saves the users from a crash and because the unregister is done when the app is closed (for the MmaDelegate receiver) or when the app finished playing media (for the GeckoMediaControlAgent receiver) the user doesn't loose any functionality going forward. Differential Revision: https://phabricator.services.mozilla.com/D11177
50d03049245a: Bug 1497144 part 2 - Get rid of ScrollPosition.jsm r=JanH,nika
Alphan Chen <alchen@mozilla.com> - Tue, 23 Oct 2018 08:17:51 +0000 - rev 501770
Push 1905 by ffxbld-merge at Mon, 21 Jan 2019 12:33:13 +0000
Bug 1497144 part 2 - Get rid of ScrollPosition.jsm r=JanH,nika Differential Revision: https://phabricator.services.mozilla.com/D8534
65621d0fe126: Bug 1513938 - Enforce a Bundle size limit and drop `privateSession` if exceeds it. r=JanH, a=jcristau FENNEC_64_0_2_BUILD1 FENNEC_64_0_2_RELEASE
Petru Lingurar <petru.lingurar@softvision.ro> - Fri, 21 Dec 2018 08:56:47 +0000 - rev 501492
Push 1892 by jcristau@mozilla.com at Tue, 08 Jan 2019 17:35:14 +0000
Bug 1513938 - Enforce a Bundle size limit and drop `privateSession` if exceeds it. r=JanH, a=jcristau The `privateSession` key would normally allow persisting the Private Browsing session across OOMs in Activity's Bundle. We need to do that to avoid storing private, sensible data on disk like we do with the normal browsing session. In some cases `privateSession` would contain a lot of data which, along with other possible concurrent transactions could overflow Binder's buffer which has a limited fixed size, currently 1Mb. To avoid this, we will drop `privateSession` from the Bundle if the resulting size is greater than a _speculative_ size of 300KBs which would mean that in the case of an OOM all Private Browsing state would be lost. Bug 1515592 is filed to investigate for a better solution. Differential Revision: https://phabricator.services.mozilla.com/D15067
8d5ec415316b: Bug 1484528 - Prevent page loading indicator running continuously. r=JanH, a=RyanVM
Petru Lingurar <petru.lingurar@softvision.ro> - Thu, 22 Nov 2018 14:52:46 +0000 - rev 501375
Push 1864 by ffxbld-merge at Mon, 03 Dec 2018 15:51:40 +0000
Bug 1484528 - Prevent page loading indicator running continuously. r=JanH, a=RyanVM The page loading indicator should be animated while it is visible. Previously for controlling the animation the visibility state of the parent Drawable - ShiftDrawable would be checked, which in all cases would return true, so the animation would run indefinitely. The patch modifies setVisible() in accordance with the Framework version of DrawableWrapper to corectly set the visibility of both the wrapper and the wrapped drawables so that isVisible() will now return the correct value which will allow stopping the animation. Differential Revision: https://phabricator.services.mozilla.com/D12552
7e437c76c270: Bug 1501648 - Prevent crashes for unregistered receivers from MmaDelegate and GeckoMediaControlAgent. r=jchen,JanH, a=jcristau
Petru Lingurar <petru.lingurar@softvision.ro> - Thu, 08 Nov 2018 12:08:40 +0000 - rev 501184
Push 1864 by ffxbld-merge at Mon, 03 Dec 2018 15:51:40 +0000
Bug 1501648 - Prevent crashes for unregistered receivers from MmaDelegate and GeckoMediaControlAgent. r=jchen,JanH, a=jcristau Although this two receivers are guarded by checks for if they were initialized (and so registered) there are reports of crashes because of trying to unregister them without them actually being registered. The underlying issue will be investigated further in bug 1505685 but for the moment wrapping the unregister operations in a try-catch saves the users from a crash and because the unregister is done when the app is closed (for the MmaDelegate receiver) or when the app finished playing media (for the GeckoMediaControlAgent receiver) the user doesn't loose any functionality going forward. Differential Revision: https://phabricator.services.mozilla.com/D11177
655818c009b1: Bug 1499372 - Find the media element from context menu event dispatched from video controls r=JanH
Timothy Guan-tin Chien <timdream@gmail.com> - Fri, 19 Oct 2018 17:43:16 +0000 - rev 500686
Push 1864 by ffxbld-merge at Mon, 03 Dec 2018 15:51:40 +0000
Bug 1499372 - Find the media element from context menu event dispatched from video controls r=JanH Differential Revision: https://phabricator.services.mozilla.com/D9016
8a510f2052d3: Bug 1406903 Part 2: Added support for opening HTML files. r=JanH
Andrei Lazar <andrei.a.lazar@softvision.ro> - Mon, 15 Oct 2018 11:05:26 +0000 - rev 499706
Push 1864 by ffxbld-merge at Mon, 03 Dec 2018 15:51:40 +0000
Bug 1406903 Part 2: Added support for opening HTML files. r=JanH Added support for opening HTML files from internal storage when user is choosing fennec in the dialog picker. Depends on D7167 Differential Revision: https://phabricator.services.mozilla.com/D7490
05d8e65ff651: Bug 1406903 Part 1: Import code for dealing with content:// URIs from aFileChooser. r=JanH,VladBaicu
Andrei Lazar <andrei.a.lazar@softvision.ro> - Fri, 12 Oct 2018 14:12:17 +0000 - rev 499705
Push 1864 by ffxbld-merge at Mon, 03 Dec 2018 15:51:40 +0000
Bug 1406903 Part 1: Import code for dealing with content:// URIs from aFileChooser. r=JanH,VladBaicu Added a part from FileUtils class with commit hash: 48d65e6 from https://github.com/iPaulPro/aFileChooser/blob/master/aFileChooser/src/com/ipaulpro/afilechooser/utils/FileUtils.java Differential Revision: https://phabricator.services.mozilla.com/D7167
e9dfaf584e37: Bug 1478735 Download with target=_blank switches to other tab target=_blank r=JanH,jchen
Andrei Lazar <andrei.a.lazar@softvision.ro> - Wed, 10 Oct 2018 09:49:07 +0000 - rev 498884
Push 1864 by ffxbld-merge at Mon, 03 Dec 2018 15:51:40 +0000
Bug 1478735 Download with target=_blank switches to other tab target=_blank r=JanH,jchen Download with target=_blank now switches to the parent tab. Differential Revision: https://phabricator.services.mozilla.com/D6928
9b019dd902c4: Bug 1496079 cannot view files due to missing READ_STORAGE_PERMISSION r=JanH
Andrei Lazar <andrei.a.lazar@softvision.ro> - Wed, 03 Oct 2018 14:36:51 +0000 - rev 497861
Push 1864 by ffxbld-merge at Mon, 03 Dec 2018 15:51:40 +0000
Bug 1496079 cannot view files due to missing READ_STORAGE_PERMISSION r=JanH Fixed the issue where the read storage permission was not requested due to a typo. Differential Revision: https://phabricator.services.mozilla.com/D7608
a42437c2e1fe: Bug 1478735 Download with target=_blank switches to other tab target=_blank r=JanH,jchen
Andrei Lazar <andrei.a.lazar@softvision.ro> - Tue, 02 Oct 2018 20:13:32 +0000 - rev 497860
Push 1864 by ffxbld-merge at Mon, 03 Dec 2018 15:51:40 +0000
Bug 1478735 Download with target=_blank switches to other tab target=_blank r=JanH,jchen Download with target=_blank now switches to the parent tab. Differential Revision: https://phabricator.services.mozilla.com/D6928
57994656668d: Bug 1397174 - Fix scale issue for AdaptiveIconDrawables. r=JanH
Vlad Baicu <vlad.baicu@softvision.ro> - Tue, 02 Oct 2018 18:54:15 +0000 - rev 497800
Push 1864 by ffxbld-merge at Mon, 03 Dec 2018 15:51:40 +0000
Bug 1397174 - Fix scale issue for AdaptiveIconDrawables. r=JanH Added a check for AdaptiveIconDrawables and a way to resize them to our specific size. Differential Revision: https://phabricator.services.mozilla.com/D7105
bc16bc807209: Bug 1492404 - Remove all downloads when Fennec asked to sanitize them; r=JanH
Petru Lingurar <petru.lingurar@softvision.ro> - Mon, 01 Oct 2018 13:06:56 +0000 - rev 497422
Push 1864 by ffxbld-merge at Mon, 03 Dec 2018 15:51:40 +0000
Bug 1492404 - Remove all downloads when Fennec asked to sanitize them; r=JanH Whenever Fennec asks to sanitize downloads all downloads will be deleted, irrespective of their current status (will include in progress downloads). Only when browsingData.removeDownloads WebExtension asks to sanitize downloads we will check to make sure a specific download conforms and can be deleted. Differential Revision: https://phabricator.services.mozilla.com/D6911