searching for reviewer(Jamie)
0d52451711522294346a175a1fac66859ad9f889: Bug 1581589 - Return null in GetAccessibleOrContainer for text leafs of unrendered maps. r?Jamie! a=lizzard
Eitan Isaacson <eitan@monotonous.org> - Thu, 26 Sep 2019 04:51:45 +0300 - rev 555572
Push 2165 by ffxbld-merge at Mon, 14 Oct 2019 16:30:58 +0000
Bug 1581589 - Return null in GetAccessibleOrContainer for text leafs of unrendered maps. r?Jamie! a=lizzard Differential Revision: https://phabricator.services.mozilla.com//D47185
1021b3e283c6eb34514b46ad600c42a647ad85a8: Bug 1578282 - Use flattened tree parent when getting inserted node container. r=Jamie a=lizzard DEVEDITION_70_0b5_BUILD1 DEVEDITION_70_0b5_RELEASE FIREFOX_70_0b5_BUILD1 FIREFOX_70_0b5_RELEASE
Eitan Isaacson <eitan@monotonous.org> - Fri, 06 Sep 2019 00:24:21 +0000 - rev 554936
Push 2165 by ffxbld-merge at Mon, 14 Oct 2019 16:30:58 +0000
Bug 1578282 - Use flattened tree parent when getting inserted node container. r=Jamie a=lizzard This assures that a node that has already been inserted in a shadow root subtree does not get erroneously reinserted into the top container. Differential Revision: https://phabricator.services.mozilla.com/D44880
59b97cbfadda1c89388c495061be448f8c475b46: Bug 1576549 - Use bounds in bundle argument instead of getter method. r=Jamie
Eitan Isaacson <eitan@monotonous.org> - Fri, 30 Aug 2019 01:29:31 +0000 - rev 554542
Push 2165 by ffxbld-merge at Mon, 14 Oct 2019 16:30:58 +0000
Bug 1576549 - Use bounds in bundle argument instead of getter method. r=Jamie Differential Revision: https://phabricator.services.mozilla.com/D44041
89963083c79dd5f7fbb1bcf90efe5f9985597db5: Bug 1576690 - Prune de-slotted accessibles, or relocate them to new slot. r=Jamie,emilio
Eitan Isaacson <eitan@monotonous.org> - Thu, 29 Aug 2019 16:14:48 +0000 - rev 554427
Push 2165 by ffxbld-merge at Mon, 14 Oct 2019 16:30:58 +0000
Bug 1576690 - Prune de-slotted accessibles, or relocate them to new slot. r=Jamie,emilio This patch does several things: 1. If there is a change to a host or a slot, check the slottable elements to see if they are rendered in the tree. Remove them if not. 2. Check slot elements' fallback content if it is rendered and remove if not. 3. Allow accessibles to be reinserted into a different parent or index. Differential Revision: https://phabricator.services.mozilla.com/D43489
7af553376576253a34735954c2f0e22b85847fec: Bug 1357071 - Implement support for implicit values for aria-value* attributes for scrollbar and slider roles, r=Jamie
Maliha Islam <mislam@mozilla.com> - Thu, 29 Aug 2019 06:39:28 +0000 - rev 554347
Push 2165 by ffxbld-merge at Mon, 14 Oct 2019 16:30:58 +0000
Bug 1357071 - Implement support for implicit values for aria-value* attributes for scrollbar and slider roles, r=Jamie Differential Revision: https://phabricator.services.mozilla.com/D43293
ecf3e677949399f0d886170c5bac66a5f0f34766: Bug 1522383 - Assign gridcell role to cells inside a table with grid role, r=Jamie
Maliha Islam <mislam@mozilla.com> - Thu, 29 Aug 2019 10:09:48 +0000 - rev 554346
Push 2165 by ffxbld-merge at Mon, 14 Oct 2019 16:30:58 +0000
Bug 1522383 - Assign gridcell role to cells inside a table with grid role, r=Jamie Differential Revision: https://phabricator.services.mozilla.com/D43858
7f1703036acfcd9e90003a8468fee793500556ae: Bug 1357071 - Implement support for implicit values for aria-value* attributes for scrollbar and slider roles, r=Jamie
Maliha Islam <mislam@mozilla.com> - Thu, 29 Aug 2019 00:18:08 +0000 - rev 554284
Push 2165 by ffxbld-merge at Mon, 14 Oct 2019 16:30:58 +0000
Bug 1357071 - Implement support for implicit values for aria-value* attributes for scrollbar and slider roles, r=Jamie Differential Revision: https://phabricator.services.mozilla.com/D43293
170a5ba09a6f9847405bc522b4984f33dface562: Bug 1572829 - Remove explicit children too when node has a shadow root. r=Jamie
Eitan Isaacson <eitan@monotonous.org> - Wed, 28 Aug 2019 23:02:19 +0000 - rev 554259
Push 2165 by ffxbld-merge at Mon, 14 Oct 2019 16:30:58 +0000
Bug 1572829 - Remove explicit children too when node has a shadow root. r=Jamie Differential Revision: https://phabricator.services.mozilla.com/D43488
8f193119390c2a2689b7584b91ff825c5a010ff2: Bug 1576925: Make AgileReference copyable; r=Jamie
Aaron Klotz <aklotz@mozilla.com> - Wed, 28 Aug 2019 15:05:32 +0000 - rev 554175
Push 2165 by ffxbld-merge at Mon, 14 Oct 2019 16:30:58 +0000
Bug 1576925: Make AgileReference copyable; r=Jamie Until now, AgileReference was not copyable because it could not handle the copying of global interface table cookies. By moving the cookie into its own reference counted object, we can enable copying on the AgileReference. Differential Revision: https://phabricator.services.mozilla.com/D43616
623da84b651a53382a63b0465fa57f2125a5b5f8: Bug 1573679: Add IsCurrentThread(Explicit|Implicit)MTA utility functions to mscom; r=Jamie
Aaron Klotz <aklotz@mozilla.com> - Tue, 27 Aug 2019 01:48:08 +0000 - rev 553754
Push 2165 by ffxbld-merge at Mon, 14 Oct 2019 16:30:58 +0000
Bug 1573679: Add IsCurrentThread(Explicit|Implicit)MTA utility functions to mscom; r=Jamie This patch provides us with utility functions that give us more specific information about the current thread's MTA if so desired. Differential Revision: https://phabricator.services.mozilla.com/D41852
e48fd9a20d62c98ceb843010a7c08df4dd9d9650: Bug 1576709 - Add crash test for bug 1572811. r=Jamie
Eitan Isaacson <eitan@monotonous.org> - Mon, 26 Aug 2019 23:12:27 +0000 - rev 553753
Push 2165 by ffxbld-merge at Mon, 14 Oct 2019 16:30:58 +0000
Bug 1576709 - Add crash test for bug 1572811. r=Jamie Differential Revision: https://phabricator.services.mozilla.com/D43499
7395aa7395272714890d0510247743ca19fcbcc6: Bug 1576696 - Add a '0x' prefix to hex pointer values in logging nodes. r=Jamie
Eitan Isaacson <eitan@monotonous.org> - Tue, 27 Aug 2019 02:02:01 +0000 - rev 553752
Push 2165 by ffxbld-merge at Mon, 14 Oct 2019 16:30:58 +0000
Bug 1576696 - Add a '0x' prefix to hex pointer values in logging nodes. r=Jamie Differential Revision: https://phabricator.services.mozilla.com/D43485
54d0977adb446888899d91be9ab9a5276ccbd012: Bug 1357100 - change implicit val for aria-level on a heading to 2 r=Jamie
Gautham Velchuru <gvelchuru@gmail.com> - Fri, 23 Aug 2019 01:28:13 +0000 - rev 553289
Push 2165 by ffxbld-merge at Mon, 14 Oct 2019 16:30:58 +0000
Bug 1357100 - change implicit val for aria-level on a heading to 2 r=Jamie Differential Revision: https://phabricator.services.mozilla.com/D35616
b47aa54a3dad5afba524bc047c8b9b8c5c4533c6: Bug 1572811 - Don't fire text change events if container accessible has no frame. r=Jamie
Eitan Isaacson <eitan@monotonous.org> - Thu, 22 Aug 2019 20:28:38 +0000 - rev 553239
Push 2165 by ffxbld-merge at Mon, 14 Oct 2019 16:30:58 +0000
Bug 1572811 - Don't fire text change events if container accessible has no frame. r=Jamie Differential Revision: https://phabricator.services.mozilla.com/D42199
ad9f9646f46cd86078ddfe8082828948eeef5b5b: Bug 1540813 - Support new ARIA roles insertion and deletion, r=Jamie
Maliha Islam <mislam@mozilla.com> - Wed, 21 Aug 2019 20:36:39 +0000 - rev 553036
Push 2165 by ffxbld-merge at Mon, 14 Oct 2019 16:30:58 +0000
Bug 1540813 - Support new ARIA roles insertion and deletion, r=Jamie Differential Revision: https://phabricator.services.mozilla.com/D42911
279533771340729b3112c25e889a91d2e5dd7f9d: Bug 1574950 - atk: Set returned values to -1 in case of errors, as newly documented in atk r=Jamie
Samuel Thibault <samuel.thibault@ens-lyon.org> - Tue, 20 Aug 2019 22:42:49 +0000 - rev 552824
Push 2165 by ffxbld-merge at Mon, 14 Oct 2019 16:30:58 +0000
Bug 1574950 - atk: Set returned values to -1 in case of errors, as newly documented in atk r=Jamie Differential Revision: https://phabricator.services.mozilla.com/D42515
73fb03448d1527347843eabd45c561ebfa8c6db6: Bug 1574298: Convert mscom::ProcessRuntime to use ProcessCategory enum and matching constructor; r=Jamie
Aaron Klotz <aklotz@mozilla.com> - Fri, 16 Aug 2019 16:06:45 +0000 - rev 552300
Push 2165 by ffxbld-merge at Mon, 14 Oct 2019 16:30:58 +0000
Bug 1574298: Convert mscom::ProcessRuntime to use ProcessCategory enum and matching constructor; r=Jamie In order to use `mscom::ProcessRuntime` in the maintenance service, we need `ProcessRuntime` to be able to distinguish between more than just whether or not the current process is the parent process. I've added a new `ProcessCategory` enum to track this information, and revised the constructors so that we now have one that accepts a ProcessCategory. The `ProcessCategory` constructor is private inside XUL, since the `GeckoProcessType` variant should always be used in that case. We also slightly change apartment initialization to depend on the underlying `ProcessCategory` value. Finally, I modify the one case where we instantiate a `ProcessRuntime` in the launcher process to use the new constructor. Differential Revision: https://phabricator.services.mozilla.com/D42225
067d47e20a9439ad81d0b119b1b660c9638ff08e: Bug 1572811 - Explicitly check for removed anonymous children in reframe. r=Jamie
Eitan Isaacson <eitan@monotonous.org> - Thu, 15 Aug 2019 16:06:33 +0000 - rev 552017
Push 2165 by ffxbld-merge at Mon, 14 Oct 2019 16:30:58 +0000
Bug 1572811 - Explicitly check for removed anonymous children in reframe. r=Jamie The DOM mutation observer method is called during frame destruction which is not a good state to be in when constructing and dispatching events. Differential Revision: https://phabricator.services.mozilla.com/D41825
9406ccf380bbc14f54eeecd3eec671750b22f53f: Bug 1573337 - remove XBL anon content filtering support from accessible tree traversal r=Jamie
Alexander Surkov <surkov.alexander@gmail.com> - Thu, 15 Aug 2019 00:58:28 +0000 - rev 551931
Push 2165 by ffxbld-merge at Mon, 14 Oct 2019 16:30:58 +0000
Bug 1573337 - remove XBL anon content filtering support from accessible tree traversal r=Jamie Differential Revision: https://phabricator.services.mozilla.com/D42022
3769178b9a30790002c9c9555a11a045d460d5a3: Bug 1501182 - Expose WAI-ARIA landmarks as landmark roles through accessibility APIs, r=Jamie
Marco Zehe <mzehe@mozilla.com> - Thu, 15 Aug 2019 01:25:56 +0000 - rev 551930
Push 2165 by ffxbld-merge at Mon, 14 Oct 2019 16:30:58 +0000
Bug 1501182 - Expose WAI-ARIA landmarks as landmark roles through accessibility APIs, r=Jamie This change will bring us on par with what Chrome does. However, if the author makes an error in applying a landmark role to an interactive element, or other element where the landmark role is illegal, as defined in the [WAI-ARIA in HTML specification section 2](https://www.w3.org/TR/html-aria/#document-conformance-requirements-for-use-of-aria-attributes-in-html), the accessible properties will now be that of the landmark role, no longer that of the native host language element. This might make some elements less accessible due to author error than before, but we currently do not know of examples in the wild that actually expose this problem. This could only be solved by applying the rules from said table also in the user agents, but that is not specified anywhere. Differential Revision: https://phabricator.services.mozilla.com/D41923
80c985e13b4713e0785a0de65b5c1f098e6b4ffa: Bug 1573750 - If header or footer elements are descendants of the main element, do not expose them as landmarks, r=Jamie
Marco Zehe <mzehe@mozilla.com> - Wed, 14 Aug 2019 06:10:24 +0000 - rev 551604
Push 2165 by ffxbld-merge at Mon, 14 Oct 2019 16:30:58 +0000
Bug 1573750 - If header or footer elements are descendants of the main element, do not expose them as landmarks, r=Jamie Differential Revision: https://phabricator.services.mozilla.com/D41893
5e72bd463b8f0ef5c01e34fc1e1486678410d885: Bug 1572256 - Clear virtual cursor position when focus clear action is invoked. r=geckoview-reviewers,Jamie,snorp
Eitan Isaacson <eitan@monotonous.org> - Fri, 09 Aug 2019 00:07:21 +0000 - rev 551012
Push 2165 by ffxbld-merge at Mon, 14 Oct 2019 16:30:58 +0000
Bug 1572256 - Clear virtual cursor position when focus clear action is invoked. r=geckoview-reviewers,Jamie,snorp Differential Revision: https://phabricator.services.mozilla.com/D41114
d5c7213d35064722ae719b6640a742d46a261456: Bug 1551344 - Part 1: Remove XULDocument code. r=smaug,Jamie
Brendan Dahl <bdahl@mozilla.com> - Fri, 09 Aug 2019 19:57:50 +0000 - rev 550981
Push 2165 by ffxbld-merge at Mon, 14 Oct 2019 16:30:58 +0000
Bug 1551344 - Part 1: Remove XULDocument code. r=smaug,Jamie All .xul files have been loading as HTMLDocuments for a few weeks now, so it should be safe to remove the XULDocument implementation. Differential Revision: https://phabricator.services.mozilla.com/D41238
44677a227173f811473b8bc3079cd92566f88e97: Bug 1572519 - Log all element attributes in accessibility logging. r=Jamie
Eitan Isaacson <eitan@monotonous.org> - Fri, 09 Aug 2019 00:02:51 +0000 - rev 550973
Push 2165 by ffxbld-merge at Mon, 14 Oct 2019 16:30:58 +0000
Bug 1572519 - Log all element attributes in accessibility logging. r=Jamie Differential Revision: https://phabricator.services.mozilla.com/D41265
97923749f8eb623318d4e71bba3bd5cdec34972c: Bug 1571616 - Prune or reinsert accessibles in non-accessible container. r=Jamie
Eitan Isaacson <eitan@monotonous.org> - Thu, 08 Aug 2019 16:47:14 +0000 - rev 550768
Push 2165 by ffxbld-merge at Mon, 14 Oct 2019 16:30:58 +0000
Bug 1571616 - Prune or reinsert accessibles in non-accessible container. r=Jamie We need to visit the descendants of a container that has no accessible, but has accessible children. Also added a test for delayed removal where we can put all these nasty cases. Differential Revision: https://phabricator.services.mozilla.com/D41059
36592e14f6cefa6e4fc32386f76d9f2558892922: Bug 1568361: Use StaticLocalAutoPtr for BackgroundMTAData; r=Jamie
Aaron Klotz <aklotz@mozilla.com> - Wed, 07 Aug 2019 01:48:31 +0000 - rev 550404
Push 2165 by ffxbld-merge at Mon, 14 Oct 2019 16:30:58 +0000
Bug 1568361: Use StaticLocalAutoPtr for BackgroundMTAData; r=Jamie The new StaticLocalAutoPtr smart pointer has a trivial destructor, so we will either properly clean up this data or leak it on process shutdown. Either way, we will not destroy it in a way that the underlying type does not support. Differential Revision: https://phabricator.services.mozilla.com/D40842
3b0f047710050088034bb83143f31478d99a516f: Bug 1568361: Use StaticLocalAutoPtr for BackgrundMTAData; r=Jamie
Aaron Klotz <aklotz@mozilla.com> - Tue, 06 Aug 2019 23:56:21 +0000 - rev 550395
Push 2165 by ffxbld-merge at Mon, 14 Oct 2019 16:30:58 +0000
Bug 1568361: Use StaticLocalAutoPtr for BackgrundMTAData; r=Jamie The new StaticLocalAutoPtr smart pointer has a trivial destructor, so we will either properly clean up this data or leak it on process shutdown. Either way, we will not destroy it in a way that the underlying type does not support. Differential Revision: https://phabricator.services.mozilla.com/D40842
0b0758d7768c226d1b460a69a03d9a4668b8a7c4: Bug 1571507 - Fix tree/test_invalidationlist.html. r=Jamie
Eitan Isaacson <eitan@monotonous.org> - Tue, 06 Aug 2019 00:05:44 +0000 - rev 550216
Push 2165 by ffxbld-merge at Mon, 14 Oct 2019 16:30:58 +0000
Bug 1571507 - Fix tree/test_invalidationlist.html. r=Jamie The current test doesn't actually do anything because divs with IDs are always created. Differential Revision: https://phabricator.services.mozilla.com/D40674
06d909e0de088e8dd586b4b4be6da83114c93148: Bug 686400 - Delay accessible removal on frame reconstruction. r=Jamie,emilio
Eitan Isaacson <eitan@monotonous.org> - Fri, 02 Aug 2019 22:13:28 +0000 - rev 549803
Push 2165 by ffxbld-merge at Mon, 14 Oct 2019 16:30:58 +0000
Bug 686400 - Delay accessible removal on frame reconstruction. r=Jamie,emilio We naively remove and then recreate accessibles when their content's frame is reconstructed. By delaying the removal until we are certain the content does not have a new layout frame, we can cut down on redundant recreations. When reconstructed content is re-inserted we can check it and its subtree for missing frames and prune those accessibles from the tree. Differential Revision: https://phabricator.services.mozilla.com/D38380
9c430a684fe03d185f8f21d3ad23960d9e943c4a: Bug 686400 - Filter content insertions in DocAccessible. r=Jamie
Eitan Isaacson <eitan@monotonous.org> - Thu, 01 Aug 2019 16:19:15 +0000 - rev 549558
Push 2165 by ffxbld-merge at Mon, 14 Oct 2019 16:30:58 +0000
Bug 686400 - Filter content insertions in DocAccessible. r=Jamie It seems a bit more sensible to me that if any filtering needs to happen from content insertions, it should happen in the doc and not the notification controller. Differential Revision: https://phabricator.services.mozilla.com/D40132
749582be170c17f818106756bef92b8890515b94: Bug 686400 - Add function to nsCoreUtils for display: contents. r=Jamie
Eitan Isaacson <eitan@monotonous.org> - Thu, 01 Aug 2019 16:19:06 +0000 - rev 549557
Push 2165 by ffxbld-merge at Mon, 14 Oct 2019 16:30:58 +0000
Bug 686400 - Add function to nsCoreUtils for display: contents. r=Jamie Differential Revision: https://phabricator.services.mozilla.com/D40131
327832d4b0354261824d1d25317b124ee2ef851b: Bug 1552716 - Part 1: Fix the keyboard navigation of the tracking protection icon. r=Jamie
Tim Huang <tihuang@mozilla.com> - Tue, 30 Jul 2019 06:31:58 +0000 - rev 549044
Push 2165 by ffxbld-merge at Mon, 14 Oct 2019 16:30:58 +0000
Bug 1552716 - Part 1: Fix the keyboard navigation of the tracking protection icon. r=Jamie This patch fixes the issue that the keyboard navigation doesn't work for the tracking protection icon. Differential Revision: https://phabricator.services.mozilla.com/D39329
45b9bfbc709b1fc2e4d9fb68ba47bd766238b97f: Bug 1552716 - Part 1: Fix the keyboard navigation of the tracking protection icon. r=Jamie
Tim Huang <tihuang@mozilla.com> - Fri, 26 Jul 2019 04:02:03 +0000 - rev 548878
Push 2165 by ffxbld-merge at Mon, 14 Oct 2019 16:30:58 +0000
Bug 1552716 - Part 1: Fix the keyboard navigation of the tracking protection icon. r=Jamie This patch fixes the issue that the keyboard navigation doesn't work for the tracking protection icon. Differential Revision: https://phabricator.services.mozilla.com/D39329
43322f9d1f3382b69fed2e34f118ad3fd4320dda: Bug 1568360 - Don't calculate the accessible names for table or grid rows unless they have an explicit ARIA role, r=Jamie
Marco Zehe <mzehe@mozilla.com> - Fri, 26 Jul 2019 09:14:55 +0000 - rev 548596
Push 2165 by ffxbld-merge at Mon, 14 Oct 2019 16:30:58 +0000
Bug 1568360 - Don't calculate the accessible names for table or grid rows unless they have an explicit ARIA role, r=Jamie Previously, we would always calculate the name for tr elements from their descendants unconditionally. Assistive technologies aren't using this information, moreover, it causes problems if the name gets too long, for example in layout tables. We now only calculate the name if the tr element has an explicit ARIA role. Differential Revision: https://phabricator.services.mozilla.com/D39314
fac0f2d6482207007677573668304d69d07be6b9: Bug 1568728 - Properly map thead to grouping if it is custom style, r=Jamie
Marco Zehe <mzehe@mozilla.com> - Fri, 26 Jul 2019 01:00:52 +0000 - rev 548545
Push 2165 by ffxbld-merge at Mon, 14 Oct 2019 16:30:58 +0000
Bug 1568728 - Properly map thead to grouping if it is custom style, r=Jamie This was an oversight in the checkin for bug 1461244. tfoot was duplicated due to a copy and paste error, thead was not mapped at all. It is now properly mapped, and the test adjusted accordingly. Differential Revision: https://phabricator.services.mozilla.com/D39305
af667e4c7419a4cd397ea7e7cd46c6b6fa201cbe: Bug 1566321 - Make meatball menu keyboard navigation match WAI-ARIA authoring practices. r=Jamie,jaws
Tim Nguyen <ntim.bugs@gmail.com> - Thu, 25 Jul 2019 19:36:13 +0000 - rev 548507
Push 2165 by ffxbld-merge at Mon, 14 Oct 2019 16:30:58 +0000
Bug 1566321 - Make meatball menu keyboard navigation match WAI-ARIA authoring practices. r=Jamie,jaws Differential Revision: https://phabricator.services.mozilla.com/D39246
2a77d3e78e0b757d676797a1dc71707146418dcb: Bug 1548389 - part 6: Add automated tests for new API and rendering of password fields r=m_kato,Jamie
Masayuki Nakano <masayuki@d-toybox.com> - Mon, 22 Jul 2019 03:55:13 +0000 - rev 547411
Push 2165 by ffxbld-merge at Mon, 14 Oct 2019 16:30:58 +0000
Bug 1548389 - part 6: Add automated tests for new API and rendering of password fields r=m_kato,Jamie Differential Revision: https://phabricator.services.mozilla.com/D38010
daf3f25dd398e6925dc00d064600528a2bc75a00: Bug 1566955: Make EnsureMTA fully thread-safe; r=Jamie
Aaron Klotz <aklotz@mozilla.com> - Thu, 18 Jul 2019 00:48:41 +0000 - rev 547012
Push 2165 by ffxbld-merge at Mon, 14 Oct 2019 16:30:58 +0000
Bug 1566955: Make EnsureMTA fully thread-safe; r=Jamie Until now we asserted that EnsureMTA was being called from the main thread unless the current thread was already in the MTA. This patch makes MTA thread initialization thread-safe by using a C++11 "magic static," thus allowing EnsureMTA to be safely invoked from any thread. Differential Revision: https://phabricator.services.mozilla.com/D38422
ff9a610b379397eda5341c5a00a7872d861d1cd4: Bug 1547518 - Disable accessibility tests on mingw-clang builds r=Jamie
Tom Ritter <tom@mozilla.com> - Tue, 16 Jul 2019 23:22:30 +0000 - rev 546805
Push 2165 by ffxbld-merge at Mon, 14 Oct 2019 16:30:58 +0000
Bug 1547518 - Disable accessibility tests on mingw-clang builds r=Jamie Differential Revision: https://phabricator.services.mozilla.com/D38033
71000a40a923067a32293ef3a01d515bbd864eed: Bug 1483687: Part 6 - Update a11y DLL blocking to use the new unified DLL blocklist; r=Jamie
Aaron Klotz <aklotz@mozilla.com> - Tue, 16 Jul 2019 18:03:54 +0000 - rev 546733
Push 2165 by ffxbld-merge at Mon, 14 Oct 2019 16:30:58 +0000
Bug 1483687: Part 6 - Update a11y DLL blocking to use the new unified DLL blocklist; r=Jamie Even though a11y DLLs are not strictly "DLL blocking," I felt that it would make sense to include them in our unified DLL blocklist. This patch delegates much of that functionality to the unified blocklist code. Going forward, any further blocklist entries for in-proc a11y DLLs should be added to mozglue/build/WindowsDllBlocklistDefs.in via the A11yBlocklistEntry type. Differential Revision: https://phabricator.services.mozilla.com/D37001
a3aa13e0e10bf6d5f9d288ce2c9352ad2dd76bbe: Bug 1563275 - make dynamically inserted slotted elements accessible r=Jamie
Alexander Surkov <surkov.alexander@gmail.com> - Fri, 05 Jul 2019 12:28:51 +0000 - rev 544313
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1563275 - make dynamically inserted slotted elements accessible r=Jamie Differential Revision: https://phabricator.services.mozilla.com/D36919
61732637cead0280583e01cc997a03f4843688a0: Bug 1474771 - Adjust accessibility test_list.html to deal with frames having NS_FRAME_IS_DIRTY more often. r=Jamie
L. David Baron <dbaron@dbaron.org> - Wed, 03 Jul 2019 05:30:30 +0000 - rev 544009
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1474771 - Adjust accessibility test_list.html to deal with frames having NS_FRAME_IS_DIRTY more often. r=Jamie `NS_FRAME_IS_DIRTY` being set on a frame has always meant that that frame and all of its descendants need to be reflowed. What the main patch on this bug is changing is when it gets propagated to descendants; prior to that patch it gets propagated during reflow, whereas after the patch it gets propagated when the bit is set. This means that `NS_FRAME_IS_DIRTY` is now (after the patch) a somewhat more reliable indicator of whether a frame requires reflow than it was before. However, this has a strange interaction with the particular sequence of operations that test_list.html performs. In particular, test_list.html: (1) makes a style change that requires reflow, (2) flushes style (but not layout), and (3) gets the name of an accessible whose layout was dirtied by the style change. Getting this name ends up here: ``` nsTextFrame::GetRenderedText at layout/generic/nsTextFrame.cpp:9600 nsTextEquivUtils::AppendTextEquivFromTextContent at accessible/base/nsTextEquivUtils.cpp:127 nsTextEquivUtils::AppendFromAccessible at accessible/base/nsTextEquivUtils.cpp:174 nsTextEquivUtils::AppendFromAccessibleChildren at accessible/base/nsTextEquivUtils.cpp:162 nsTextEquivUtils::GetNameFromSubtree at accessible/base/nsTextEquivUtils.cpp:39 mozilla::a11y::Accessible::NativeName at accessible/generic/Accessible.cpp:1991 mozilla::a11y::HyperTextAccessible::NativeName at accessible/generic/HyperTextAccessible.cpp:1760 mozilla::a11y::Accessible::Name at accessible/generic/Accessible.cpp:149 mozilla::a11y::xpcAccessible::GetName at accessible/xpcom/xpcAccessible.cpp:245 NS_InvokeByIndex at xpcom/reflect/xptcall/md/unix/xptcinvoke_asm_x86_64_unix.S:106 ``` What the main patch in the bug has changed is whether this `nsTextFrame` has the `NS_FRAME_IS_DIRTY` bit set at this point. This means that `GetRenderedText` will bail out without reporting the text, because the frame is marked dirty. On the assumption that this action -- getting accessible names while frames are dirty -- is an artificial situation set up in the test and not a real-world situation that we need to care about, I'm proposing that we make the straightforward adjustment to the test: flush layout in addition to flushing style at step (2) above, so that the test works again. As long as that assumption is correct, I think this should be fine. (I'd note that this is the *only* test that breaks as a result of the patch.) If, on the other hand, we actually do care about what accessible names return while layout state is dirty and reflow is needed, we should probably improve `nsTextFrame::GetRenderedText` so that it can somehow report useful state even when `NS_FRAME_IS_DIRTY` is set, or something else more complicated. Differential Revision: https://phabricator.services.mozilla.com/D36423
262d269322ed98636b9b47e1b3a754933a858c06: Bug 1558686 - Enable XUL default button behavior for any doc that allows XUL. r=Jamie
Brendan Dahl <bdahl@mozilla.com> - Wed, 12 Jun 2019 03:16:33 +0000 - rev 541309
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1558686 - Enable XUL default button behavior for any doc that allows XUL. r=Jamie Fixes test 'accessible/tests/mochitest/relations/test_general.xul' when loaded as XHTML. Differential Revision: https://phabricator.services.mozilla.com/D34655
e402a0d8195e117f07f2e1d4c91800f493cd52fa: Bug 1446699 - Fix ATK mapping for EVENT_TEXT_SELECTION_CHANGED r=Jamie
Joanmarie Diggs <jdiggs@igalia.com> - Wed, 12 Jun 2019 04:01:51 +0000 - rev 541211
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1446699 - Fix ATK mapping for EVENT_TEXT_SELECTION_CHANGED r=Jamie The correct mapping for nsIAccessibleEvent::EVENT_TEXT_SELECTION_CHANGED in ATK is text_selection_changed; not selection_changed. The latter is meant for containers which support selection of child objects, such as a menu or expanded select element. Differential Revision: https://phabricator.services.mozilla.com/D34521
be5b9ac813f5b515a1884fd2c5048e6b601da694: Bug 1548362 - Include visual viewport offsets in bounds and hittest calculations. r=Jamie
Eitan Isaacson <eitan@monotonous.org> - Wed, 15 May 2019 00:06:30 +0000 - rev 538052
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1548362 - Include visual viewport offsets in bounds and hittest calculations. r=Jamie Differential Revision: https://phabricator.services.mozilla.com/D30385
9d7773bd3ae77a29908e365d5eece5890a334ab6: Bug 1380905 - Allow HTMLComboboxAccessible to be shut down twice. r=Jamie
Eitan Isaacson <eitan@monotonous.org> - Wed, 22 May 2019 04:50:31 +0000 - rev 538051
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1380905 - Allow HTMLComboboxAccessible to be shut down twice. r=Jamie Accessibles can be shut down twice. For example, their doc might shut them down in its own ShutDown, while a reference is still being held by a dispatched event. When the event goes away, or the cycle collector kicks in, the accessible may be finally released and shut down again via LastRelease. Differential Revision: https://phabricator.services.mozilla.com/D31815
cd3ba329d43a71d35fe96a9b70bbefdcddf22916: Bug 1551825 - Release mAnchorJumpElm and mInvalidationList in DocAccessible::Shutdown. r=Jamie
Eitan Isaacson <eitan@monotonous.org> - Wed, 22 May 2019 22:03:44 +0000 - rev 537892
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1551825 - Release mAnchorJumpElm and mInvalidationList in DocAccessible::Shutdown. r=Jamie Differential Revision: https://phabricator.services.mozilla.com/D32197
f0d9b81a5aedaad55a49c61a951989f1e385c2cc: Bug 1506514 - Don't create accessibles for unselected deck panel descendants. r=Jamie
Eitan Isaacson <eitan@monotonous.org> - Mon, 20 May 2019 15:54:56 +0000 - rev 537411
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1506514 - Don't create accessibles for unselected deck panel descendants. r=Jamie Differential Revision: https://phabricator.services.mozilla.com/D31656
a7f03576065a7353db51688b8bbe8cc19ac5d924: Bug 1506514 - Don't create accessibles for unselected deck panel descendants. r=Jamie a=jcristau
Eitan Isaacson <eitan@monotonous.org> - Mon, 20 May 2019 15:54:56 +0000 - rev 536758
Push 2082 by ffxbld-merge at Mon, 01 Jul 2019 08:34:18 +0000
Bug 1506514 - Don't create accessibles for unselected deck panel descendants. r=Jamie a=jcristau Differential Revision: https://phabricator.services.mozilla.com/D31656
2aeaee73c3a47e0862cb65177ef3a0126fb735f4: Bug 1551825 - Release mAnchorJumpElm and mInvalidationList in DocAccessible::Shutdown. r=Jamie a=jcristau
Eitan Isaacson <eitan@monotonous.org> - Wed, 22 May 2019 22:03:44 +0000 - rev 536537
Push 2082 by ffxbld-merge at Mon, 01 Jul 2019 08:34:18 +0000
Bug 1551825 - Release mAnchorJumpElm and mInvalidationList in DocAccessible::Shutdown. r=Jamie a=jcristau Differential Revision: https://phabricator.services.mozilla.com/D32197