searching for reviewer(Gijs)
da1aee264bc8bf07a170e713e2f8a23efcda0cb8: Bug 1546599 - Reset FxA avatar menu title on logout r=Gijs a=pascalc
Vijay Budhram <vbudhram@mozilla.com> - Wed, 24 Apr 2019 22:41:27 +0000 - rev 526441
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1546599 - Reset FxA avatar menu title on logout r=Gijs a=pascalc Differential Revision: https://phabricator.services.mozilla.com/D28712
9fa4cf7dfb75f9591fd91a76776221af0868a995: Bug 1546326: Correctly detect missing directories on Windows. r=Gijs a=pascalc
Dave Townsend <dtownsend@oxymoronical.com> - Tue, 23 Apr 2019 17:23:35 +0000 - rev 526362
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1546326: Correctly detect missing directories on Windows. r=Gijs a=pascalc Differential Revision: https://phabricator.services.mozilla.com/D28514
a64500e3a18b4355db601dcdeda5b348e31bb523: Bug 1529879: Block changing the profile list when another process has changed it. r=froydnj,Gijs,flod a=pascalc l10n=flod
Dave Townsend <dtownsend@oxymoronical.com> - Tue, 05 Mar 2019 12:51:44 -0800 - rev 526296
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1529879: Block changing the profile list when another process has changed it. r=froydnj,Gijs,flod a=pascalc l10n=flod On startup we record the size and modified time of the profile lists. If changed we refuse to flush any new changes to disk. Also adds a getter to check if they've changed so the UI can do something sensible. All attempts to flush are now checked for success. In some cases in early startup the failure mode isn't great, we just quit startup. The assumption though is that it's extremely unlikely that the files will have changed on disk in the time between when they are read and when profile selection occurs, likely less than a second later. The profile reset flow is changed to only delete the old profile and flush once all the migration has completed, so if something fails the user gets back to their old profile. In testing I ended up having to fix bug 1522584 so background file deletions on a background thread are safer. I haven't implemented any UI tests right now since making modifications to the profiles means modifying the actual user's profiles which I'm not keen to do. See bug 1539868. Differential Revision: https://phabricator.services.mozilla.com/D25278
9b8ad8b840ed4cc8545123c49a2cafb401e322d3: Bug 1539414 - checkboxes are not redrawn on Win7 classic theme r=Gijs a=RyanVM
Alexander Surkov <surkov.alexander@gmail.com> - Tue, 16 Apr 2019 16:01:33 +0000 - rev 526276
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1539414 - checkboxes are not redrawn on Win7 classic theme r=Gijs a=RyanVM Differential Revision: https://phabricator.services.mozilla.com/D27727
6cd36394e2aeaea04ad1978e7131ac86da02f1f1: Bug 1543828 - Use <bdi> inside video controls content. r=Gijs a=pascalc
Brian Grinstead <bgrinstead@mozilla.com> - Sun, 21 Apr 2019 03:07:49 +0300 - rev 526262
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1543828 - Use <bdi> inside video controls content. r=Gijs a=pascalc Reviewers: Gijs Reviewed By: Gijs Subscribers: Kwan Bug #: 1543828 Differential Revision: https://phabricator.services.mozilla.com/D27757
550ae4e7da5df567c7974dc469c16ea66995745c: Bug 1541045 - Drag space checkbox should be grey out when disabled r=Gijs a=pascalc
Alexander Surkov <surkov.alexander@gmail.com> - Thu, 11 Apr 2019 15:38:57 +0000 - rev 526212
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1541045 - Drag space checkbox should be grey out when disabled r=Gijs a=pascalc Differential Revision: https://phabricator.services.mozilla.com/D27065
d49678c63d88b0c19d5168743c16adfe2f6339a5: Bug 1525941 - Adds ability to change permissions on network/cert error pages. r=johannh,Gijs a=pascalc
danielleleb <danielleleb12@gmail.com> - Wed, 03 Apr 2019 15:43:54 +0000 - rev 526210
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1525941 - Adds ability to change permissions on network/cert error pages. r=johannh,Gijs a=pascalc Differential Revision: https://phabricator.services.mozilla.com/D24052
730af3807039c56c000064063b76fa6d121867e1: Bug 1528939. r=Gijs a=pascalc
Marco Bonardo <mbonardo@mozilla.com> - Tue, 09 Apr 2019 07:20:01 +0000 - rev 526166
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1528939. r=Gijs a=pascalc Differential Revision: https://phabricator.services.mozilla.com/D26534
8842c0d0cef24b7eff3550daed701ae33cb6ec7d: Bug 1542221: Correctly save the state of nsIToolkitProfileService.startWithLastProfile. r=Gijs a=pascalc
Dave Townsend <dtownsend@oxymoronical.com> - Mon, 08 Apr 2019 22:50:42 +0000 - rev 526104
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1542221: Correctly save the state of nsIToolkitProfileService.startWithLastProfile. r=Gijs a=pascalc Differential Revision: https://phabricator.services.mozilla.com/D26576
19e1fc9a203cb2f4c4b9b1ae5a5dfac2bafeb2f2: Bug 1541804: Make profile refresh for non-ascii named profiles work correctly. r=Gijs a=pascalc
Dave Townsend <dtownsend@oxymoronical.com> - Tue, 09 Apr 2019 12:28:49 +0300 - rev 526064
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1541804: Make profile refresh for non-ascii named profiles work correctly. r=Gijs a=pascalc Summary: This fixes two bugs. The first is that when the firefox profile migrator doesn't know which profile to migrate it attempts to fall back to another profile. I think this was intended to be the default but in bug 1322797 I ended up making it the current profile, which is the profile we're restoring into now. I think at this stage the profile directory doesn't even exist so things go wrong. Changing to use the actual default works but.... When the profile migrator UI doesn't know what profile to migrate from it uses the default profile. So if the profile you're actually trying to restore is not the default we'll effectively throw its data into the archive and replace it with data from the default profile. I'm inclined to say that if the migrator does not know what profile to migrate from it should error at that point for safety. Why would the profile migrator not know what profile to migrate from? Because of a long-standing text encoding problem. In C++ profile names are encoded in UTF8. But we try to pass them to JS through an IDL parameter of type ACString. This does no UTF8 decoding and so JS recieves an incorrect name if the name includes non-ascii characters and so can't find the profile. This patch fixes the IDL parameter to AUTF8String which does the decoding correctly and so JS gets the name correctly. We should probably think about whether just passing the nsIToolkitProfile object to the migrator is a better choice here. Reviewers: Gijs Reviewed By: Gijs Subscribers: MattN Bug #: 1541804 Differential Revision: https://phabricator.services.mozilla.com/D26250
c6091e97fad76956b6bc1576fd28e3083ce3ad3a: Bug 1539647: Make the "Show more bookmarks" button navigable with the keyboard. r=Gijs a=pascalc
James Teh <jteh@mozilla.com> - Fri, 29 Mar 2019 00:46:57 +0000 - rev 526060
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1539647: Make the "Show more bookmarks" button navigable with the keyboard. r=Gijs a=pascalc When the Bookmarks toolbar overflows, it contains buttons with style visibility: hidden. ToolbarKeyboardNavigator wasn't checking for this and was trying to focus these buttons, which simply failed. We now skip over these buttons, which means that the Show more bookmarks button can now be reached. Differential Revision: https://phabricator.services.mozilla.com/D25180
cc0d59ec03cfabb3b2c3e0aa8f92c9628bfb99bc: Bug 1539820: Fix test_claim_locked.js to work with dev-edition. r=Gijs a=test-only
Dave Townsend <dtownsend@oxymoronical.com> - Thu, 04 Apr 2019 21:56:42 +0000 - rev 526025
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1539820: Fix test_claim_locked.js to work with dev-edition. r=Gijs a=test-only The original name of the profile is irrelevant here since we aren't testing a migration to profiles-per-install. On dev-edition DEDICATED_NAME is the same as PROFILE_DEFAULT so we correctly make a new profile with a unique name. Differential Revision: https://phabricator.services.mozilla.com/D26230
dc02c36e1aa49025f09456b65c4805d337b28a1f: Bug 1528573 - [RTL] The sloth SVG is overlapping the header in about:rights, r=Gijs a=pascalc
Yuan Cheng <chengy12@msu.edu> - Thu, 04 Apr 2019 16:45:56 +0000 - rev 525979
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1528573 - [RTL] The sloth SVG is overlapping the header in about:rights, r=Gijs a=pascalc Differential Revision: https://phabricator.services.mozilla.com/D26064
3ba898f98afad26f0b12d5e63b6c273392376311: Bug 1539137 - Fix help link in browser languages dialog r=Gijs a=pascalc
Mark Striemer <mstriemer@mozilla.com> - Wed, 03 Apr 2019 23:01:29 +0000 - rev 525978
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1539137 - Fix help link in browser languages dialog r=Gijs a=pascalc Differential Revision: https://phabricator.services.mozilla.com/D25998
ca218beefd316b68731d8e89c87bfae8c6f92483: Bug 1539408 Pass referrerInfo to gContextMenuContentData in non-remote r=Gijs a=pascalc
Thomas Nguyen <tnguyen@mozilla.com> - Tue, 02 Apr 2019 08:53:28 +0000 - rev 525970
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1539408 Pass referrerInfo to gContextMenuContentData in non-remote r=Gijs a=pascalc Differential Revision: https://phabricator.services.mozilla.com/D25419
2255b45c876b29f68c819f3c3192e35adda4c2f2: Bug 1538575: Toolbar keyboard navigation: Make arrow keys behave as expected for RTL locales. r=Gijs a=pascalc
James Teh <jteh@mozilla.com> - Tue, 26 Mar 2019 10:35:21 +0000 - rev 525914
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1538575: Toolbar keyboard navigation: Make arrow keys behave as expected for RTL locales. r=Gijs a=pascalc Differential Revision: https://phabricator.services.mozilla.com/D24841
21ab0c178e238a7ff14fa59ba79205b491456987: Bug 1538575 part 2: Add RTL test for toolbar keyboard navigation. r=Gijs a=pascalc
James Teh <jteh@mozilla.com> - Wed, 27 Mar 2019 11:15:34 +0000 - rev 525912
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1538575 part 2: Add RTL test for toolbar keyboard navigation. r=Gijs a=pascalc Differential Revision: https://phabricator.services.mozilla.com/D25017
734b7738a6c485a6fd11099fdd9a14920d32b21d: Bug 1535080, Fix file picker not opening on Windows, r=Gijs a=pascalc
Jonas Allmann <jallmann@mozilla.com> - Tue, 26 Mar 2019 10:30:39 +0000 - rev 525898
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1535080, Fix file picker not opening on Windows, r=Gijs a=pascalc Move addEventhandler to top of appPickerLoad() to avoid not reaching it when errors occur later in the function. Differential Revision: https://phabricator.services.mozilla.com/D24866
cba236106e276ca96713e2ccd921f59f9139a589: Bug 1537883 - Silently fail in case aPrincipal is null within SpeculativeConnectInternal. r=valentin,gijs a=pascalc
Christoph Kerschbaumer <ckerschb@christophkerschbaumer.com> - Fri, 29 Mar 2019 13:30:49 +0100 - rev 525893
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1537883 - Silently fail in case aPrincipal is null within SpeculativeConnectInternal. r=valentin,gijs a=pascalc
f83ea1d76d6e4a785c84bad975659e24c40f5c85: Bug 1537648 - remove change avatar button from FxA menu r=Gijs, a=pascalc
Vijay Budhram <vbudhram@mozilla.com> - Fri, 22 Mar 2019 20:52:47 +0000 - rev 525848
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1537648 - remove change avatar button from FxA menu r=Gijs, a=pascalc Differential Revision: https://phabricator.services.mozilla.com/D24527
0b05c9bed71b2c90b490dca27c38623236e90691: Bug 1536895 - Disable send tab on Fxa avatar menu for unsupported pages, r=gijs, a=pascalc
Vijay Budhram <vbudhram@mozilla.com> - Thu, 21 Mar 2019 21:14:34 +0000 - rev 525847
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1536895 - Disable send tab on Fxa avatar menu for unsupported pages, r=gijs, a=pascalc Differential Revision: https://phabricator.services.mozilla.com//D24430
cfb2d7610755e1d487cea0e0fec537c8e36e639a: Bug 1537647 - fix focus on FxA menu when activated via keyboard r=Gijs, a=pascalc
Vijay Budhram <vbudhram@mozilla.com> - Thu, 21 Mar 2019 18:22:49 +0000 - rev 525846
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1537647 - fix focus on FxA menu when activated via keyboard r=Gijs, a=pascalc Differential Revision: https://phabricator.services.mozilla.com/D24381
3876472b3140e3f85b5064bd2d8530dbbc8607d9: Bug 1536467 - bind callbacks to `this` for Send Tab to Device subview so they work when we're waiting for the initial sync r=Gijs, a=pascalc
Vijay Budhram <vbudhram@mozilla.com> - Tue, 19 Mar 2019 19:25:01 +0000 - rev 525845
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1536467 - bind callbacks to `this` for Send Tab to Device subview so they work when we're waiting for the initial sync r=Gijs, a=pascalc Differential Revision: https://phabricator.services.mozilla.com/D24068
fbad8125c402cef4a29c923701b230843f8140e1: Bug 1524665 - Add send tab to device button, r=gijs, a=pascalc
Vijay Budhram <vbudhram@mozilla.com> - Wed, 13 Mar 2019 20:31:59 +0000 - rev 525842
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1524665 - Add send tab to device button, r=gijs, a=pascalc Differential Revision: https://phabricator.services.mozilla.com//D23387
51e5fcce16d5401a4f4daf2ba4405b70bcf5f327: Bug 1524665 - Add FxA avatar toolbar menu, r=gijs,eoger, a=pascalc
Vijay Budhram <vbudhram@mozilla.com> - Sat, 23 Feb 2019 17:56:19 +0000 - rev 525840
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1524665 - Add FxA avatar toolbar menu, r=gijs,eoger, a=pascalc Differential Revision: https://phabricator.services.mozilla.com//D20433
b4d3f8ae02748dd0cf3d5aa3e496d38d0ac65b88: Bug 1535307 - Remove an extra bracket when set update status in aboutUrlClassifier. r=Gijs a=pascalc
dlee <dlee@mozilla.com> - Wed, 20 Mar 2019 13:57:11 +0000 - rev 525806
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1535307 - Remove an extra bracket when set update status in aboutUrlClassifier. r=Gijs a=pascalc Differential Revision: https://phabricator.services.mozilla.com/D24172
7b34fc9165b9047186a4bf940d8028aaf0281f3f: Bug 1536521: Use a capturing listener for PanelMultiView's keydown handler. r=Gijs a=pascalc
James Teh <jteh@mozilla.com> - Tue, 26 Mar 2019 10:33:11 +0000 - rev 525752
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1536521: Use a capturing listener for PanelMultiView's keydown handler. r=Gijs a=pascalc PanelMultiView adds the keydown handler on the window so that it handles key presses when a panel appears but doesn't get focus, as happens when a button to open a panel is clicked with the mouse. However, this means the listener is on an ancestor of the panel, which means that handlers such as ToolbarKeyboardNavigator are deeper in the tree. Previously, PanelMultiView used a bubbling (default) listener. This meant that ToolbarKeyboardNavigator handled the event first, causing it to interfere when a panel opened within the toolbar; e.g. the Library menu. To fix this, use a capturing listener for PanelMultiView so it gets the event first. Differential Revision: https://phabricator.services.mozilla.com/D24848
32cf4d4997be449f91a22ca0c0155860dd49916d: Bug 1536752 - Remove sync pane from about:preferences when identity.fxaccounts.enabled is false r=Gijs a=pascalc
Brian Grinstead <bgrinstead@mozilla.com> - Fri, 22 Mar 2019 20:49:53 +0000 - rev 525725
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1536752 - Remove sync pane from about:preferences when identity.fxaccounts.enabled is false r=Gijs a=pascalc This fixes a bug in where we render out the text content of the template when searching. Differential Revision: https://phabricator.services.mozilla.com/D24544
4f154c1d9d9fbc34a6a237613f79909d0448aa79: Bug 1534447 - Replace login and login-detailed icon with new icon. r=Gijs a=pascalc
Narcis Beleuzu <nbeleuzu@mozilla.com> - Sat, 23 Mar 2019 18:34:53 +0200 - rev 525680
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1534447 - Replace login and login-detailed icon with new icon. r=Gijs a=pascalc Reviewers: Gijs Reviewed By: Gijs Subscribers: MattN Bug #: 1534447 Differential Revision: https://phabricator.services.mozilla.com/D23749
bda705ea201f2bbc11f260d7691ad1c69029c424: Bug 1534447 - Add application menu item to show Logins & Passwords. r=Gijs a=pascalc
Narcis Beleuzu <nbeleuzu@mozilla.com> - Sat, 23 Mar 2019 18:33:59 +0200 - rev 525679
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1534447 - Add application menu item to show Logins & Passwords. r=Gijs a=pascalc Reviewers: Gijs Reviewed By: Gijs Subscribers: MattN Bug #: 1534447 Differential Revision: https://phabricator.services.mozilla.com/D23737
018abdd16060b7849be760b348242a12ec8cf4dd: Bug 1536073 - Remove DevTools button in browser_identityBlock_focus.js to prevent branch-specific focus in toolbar r=Gijs a=test-only l10n=a=same-version-merge DEVEDITION_67_0b3_BUILD1 DEVEDITION_67_0b3_RELEASE FENNEC_67_0b3_BUILD1 FENNEC_67_0b3_RELEASE FIREFOX_67_0b3_BUILD1 FIREFOX_67_0b3_RELEASE
Sebastian Hengst <archaeopteryx@coole-files.de> - Mon, 18 Mar 2019 14:37:04 +0000 - rev 525626
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1536073 - Remove DevTools button in browser_identityBlock_focus.js to prevent branch-specific focus in toolbar r=Gijs a=test-only l10n=a=same-version-merge Differential Revision: https://phabricator.services.mozilla.com/D23858
cb4eac8d65949e75804cfc6f373a844961c6ec31: Bug 1536069 - Remove DevTools button in browser_multiselect_tabs_using_keyboard.js to prevent branch-specific focus in toolbar r=Gijs a=test-only
Sebastian Hengst <archaeopteryx@coole-files.de> - Mon, 18 Mar 2019 14:36:13 +0000 - rev 525625
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1536069 - Remove DevTools button in browser_multiselect_tabs_using_keyboard.js to prevent branch-specific focus in toolbar r=Gijs a=test-only Differential Revision: https://phabricator.services.mozilla.com/D23855
d15b22ef4b88a6be3e0adaf3163022e61fe3e275: Bug 1535666 - Explicitly turn on new cert error pages in browser_aboutCertError_noSubjectAltName.js to let it pass on beta r=Gijs a=test-only
Sebastian Hengst <archaeopteryx@coole-files.de> - Mon, 18 Mar 2019 15:27:16 +0000 - rev 525624
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1535666 - Explicitly turn on new cert error pages in browser_aboutCertError_noSubjectAltName.js to let it pass on beta r=Gijs a=test-only Differential Revision: https://phabricator.services.mozilla.com/D23728
7444d00f6a08178777d83c4a4ab61da6c88c2b69: Bug 1521725 - Remove remaining about:searchreset references. r=Gijs
Dale Harvey <dale@arandomurl.com> - Sun, 17 Mar 2019 13:03:52 +0000 - rev 525602
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1521725 - Remove remaining about:searchreset references. r=Gijs Differential Revision: https://phabricator.services.mozilla.com/D17563
46e6675abc338804c81392b90bf0aac5e5c09cdc: Bug 1534714 handle checkbox state when appmenu refreshed across windows r=Gijs
Shane Caraveo <scaraveo@mozilla.com> - Thu, 14 Mar 2019 18:31:07 +0000 - rev 525600
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1534714 handle checkbox state when appmenu refreshed across windows r=Gijs This adds an onRefresh option for app menus so we can update custom controls in any opened window. In this case, we need to refresh the checkbox state in the addon-installed panel. We test this using the theme install test and verify both windows do not have the checkbox. Differential Revision: https://phabricator.services.mozilla.com/D23224
b12dda048dd5b1d0bed3d3e0cb7387c4cb6b66cf: Bug 1535666 - Explicitly turn on new cert error pages in browser_aboutCertError_noSubjectAltName.js to let it pass on beta r=Gijs
Sebastian Hengst <archaeopteryx@coole-files.de> - Fri, 15 Mar 2019 22:45:46 +0000 - rev 525378
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1535666 - Explicitly turn on new cert error pages in browser_aboutCertError_noSubjectAltName.js to let it pass on beta r=Gijs Differential Revision: https://phabricator.services.mozilla.com/D23728
e08f9ad9fcbb171e7fa001d021b68a9103d431b4: Bug 1525193 - Move actions to more options menu in HTML about:addons r=Gijs,flod
Mark Striemer <mstriemer@mozilla.com> - Fri, 15 Mar 2019 19:19:21 +0000 - rev 525315
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1525193 - Move actions to more options menu in HTML about:addons r=Gijs,flod Differential Revision: https://phabricator.services.mozilla.com/D21294
adbb2fb5c8eca65f1df0ca77b20933c9aae54ae7: Bug 1532712 - Fix tests to await for gotoPref. r=gijs
Zibi Braniecki <zbraniecki@mozilla.com> - Wed, 13 Mar 2019 19:43:50 +0000 - rev 525068
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1532712 - Fix tests to await for gotoPref. r=gijs Differential Revision: https://phabricator.services.mozilla.com//D23377
10dfa9788b2b83e2a56a51d53cfe75813f89fa2e: Bug 1532712 - Optimize Preferences translation. r=gijs
Zibi Braniecki <zbraniecki@mozilla.com> - Wed, 13 Mar 2019 00:27:31 +0000 - rev 525067
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1532712 - Optimize Preferences translation. r=gijs Differential Revision: https://phabricator.services.mozilla.com//D23245
4d62ab0e31fd6918ca95763914a8bdf41afe757a: Bug 1528695 - Part 2 : Use referrerInfo in openWindow, contextmenu and openLinkIn r=Gijs
Thomas Nguyen <tnguyen@mozilla.com> - Fri, 15 Mar 2019 05:10:17 +0000 - rev 525014
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1528695 - Part 2 : Use referrerInfo in openWindow, contextmenu and openLinkIn r=Gijs Differential Revision: https://phabricator.services.mozilla.com/D21911
8d51957df27ad95b830b8bb93c32ebc2727be918: Bug 1535291: Actually use aContentPolicyType argument within nsWebBrowserPersist::SaveURIInternal r=Gijs
Christoph Kerschbaumer <ckerschb@christophkerschbaumer.com> - Thu, 14 Mar 2019 18:42:47 +0000 - rev 524922
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1535291: Actually use aContentPolicyType argument within nsWebBrowserPersist::SaveURIInternal r=Gijs Differential Revision: https://phabricator.services.mozilla.com/D23484
f73f629e8ccaf586ae6f54256f8e80e6619c48ab: Bug 1517528 - Capstone: convert about:privatebrowsing using gandalf's conversion script, r=Gijs,jaws,zbraniecki,flod
Nicholas Cowles <cowlesni@msu.edu> - Mon, 11 Mar 2019 17:56:36 +0000 - rev 524816
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1517528 - Capstone: convert about:privatebrowsing using gandalf's conversion script, r=Gijs,jaws,zbraniecki,flod Differential Revision: https://phabricator.services.mozilla.com/D19250
e5f1bcb6046e604bfd884b419827061405c8cadd: Bug 1534475 - Use a responsive monitor frame in "Set As Desktop Background" preview. r=Gijs
Ian Moody <moz-ian@perix.co.uk> - Wed, 13 Mar 2019 16:24:40 +0000 - rev 524769
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1534475 - Use a responsive monitor frame in "Set As Desktop Background" preview. r=Gijs Currently for any screen with a ratio 1.6 or above, the preview uses a 16:10 image. However, the majority of Fx users have a screen that is 16:9[0], so for most users the preview shows images distorted (compressed horizontally). Originally I just added a new 16:9 version of the monitor image, but then I realised I could save on filesize _and_ make it responsive to whatever the user's screen actually is, rather than using arbitrary presets, by using border-image. The new image files are just sliced up versions of the original monitor.png files, zopfli compressed to match (though with the power indicator dropped from the Linux/Windows version to avoid distorting it). The combined filesize savings seem to be 8.5KiB on macOS and 6.5KiB on Linux/Windows. With the removal of the use of margins on the canvas we no longer need the platform-specific setDesktopBackground.css file. [0] https://data.firefox.com/dashboard/hardware As of 3rd March 2019 the top three resolutions, 1366x768, 1080p, & 1600x900, are all 16:9 and make up 67% of the userbase. Differential Revision: https://phabricator.services.mozilla.com/D23114
1af088f5fc34935f780c2153f1d279ca482e735a: Bug 1532712 - Optimize Preferences translation. r=Gijs
Zibi Braniecki <zbraniecki@mozilla.com> - Wed, 13 Mar 2019 16:39:43 +0000 - rev 524729
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1532712 - Optimize Preferences translation. r=Gijs Differential Revision: https://phabricator.services.mozilla.com/D23245
7417187bdee40dd267586fc334b52c1e4d2743d0: Bug 1528939. r=Gijs
Marco Bonardo <mbonardo@mozilla.com> - Wed, 13 Mar 2019 10:20:00 +0000 - rev 524690
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1528939. r=Gijs Differential Revision: https://phabricator.services.mozilla.com/D23195
2a1b3ad472dfde89a67ff0bd5c31af146f7809cd: Bug 1532208 - Update Add Dictionary Link in right click context menu. r=Gijs
championshuttler <shivams2799@gmail.com> - Wed, 13 Mar 2019 10:26:59 +0000 - rev 524686
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1532208 - Update Add Dictionary Link in right click context menu. r=Gijs See also: https://github.com/mozilla/addons-frontend/issues/7658 As a result of AMO's switch to a new frontend, the old URL has gone 404. A redirect has been put in, but it'd be better to use the post-redirect URL directly in product. This change accomplishes that. Differential Revision: https://phabricator.services.mozilla.com/D21943
3a075843a5ccddc55d2d04f5bc810ae35b0f6c09: Bug 1524665 - add strings for FxA avatar toolbar menu, r=gijs
Vijay Budhram <vbudhram@mozilla.com> - Tue, 12 Mar 2019 22:22:52 +0000 - rev 524678
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1524665 - add strings for FxA avatar toolbar menu, r=gijs
bd3b527094a9d4caa240a2dbab7ff6f3f82861cc: Bug 1534447 - Add new string for application menu item to access Logins/Passwords. r=flod,Gijs
Sam Foster <sfoster@mozilla.com> - Wed, 13 Mar 2019 06:54:25 +0000 - rev 524654
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1534447 - Add new string for application menu item to access Logins/Passwords. r=flod,Gijs Differential Revision: https://phabricator.services.mozilla.com/D23216
2f068b111006dfcd21caa9d10579a5569c8ea48c: Bug 1531155 - Remove editmenu.ftl from browser_all_files_referenced.js;r=Gijs
Brian Grinstead <bgrinstead@mozilla.com> - Tue, 12 Mar 2019 20:31:36 +0000 - rev 524599
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1531155 - Remove editmenu.ftl from browser_all_files_referenced.js;r=Gijs Differential Revision: https://phabricator.services.mozilla.com/D23199
7b997d966c3c5fad733d2255a4d57aff2237112a: Bug 1533693, just compare the drop point against event.clientY instead of using a complicated check involving scroll positions, fixes the subfolder not opening in bookmarks menu when dragging over it, r=Gijs
Neil Deakin <neil@mozilla.com> - Mon, 11 Mar 2019 14:14:14 +0000 - rev 524580
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1533693, just compare the drop point against event.clientY instead of using a complicated check involving scroll positions, fixes the subfolder not opening in bookmarks menu when dragging over it, r=Gijs Differential Revision: https://phabricator.services.mozilla.com/D22751