searching for reviewer(Gijs)
0b7f3caba2aa: Bug 1532719 - Reset _pinnedUnscrollable flag when unpinning a tab. r=Gijs a=lizzard
Dão Gottwald <dao@mozilla.com> - Thu, 07 Mar 2019 11:47:26 +0000 - rev 516343
Push 1953 by ffxbld-merge at Mon, 11 Mar 2019 12:10:20 +0000
Bug 1532719 - Reset _pinnedUnscrollable flag when unpinning a tab. r=Gijs a=lizzard Differential Revision: https://phabricator.services.mozilla.com/D22474
de039c1269c3: Bug 1530288 - Center align the reload button in customize mode r=Gijs a=lizzard
Brian Grinstead <bgrinstead@mozilla.com> - Fri, 01 Mar 2019 12:00:10 +0000 - rev 516270
Push 1953 by ffxbld-merge at Mon, 11 Mar 2019 12:10:20 +0000
Bug 1530288 - Center align the reload button in customize mode r=Gijs a=lizzard Differential Revision: https://phabricator.services.mozilla.com/D21323
370feb072937: Bug 1511053 - Stop affecting the titlebar's height while dragging tabs. r=Gijs a=lizzard
Dão Gottwald <dao@mozilla.com> - Sun, 10 Feb 2019 15:34:22 +0000 - rev 516167
Push 1953 by ffxbld-merge at Mon, 11 Mar 2019 12:10:20 +0000
Bug 1511053 - Stop affecting the titlebar's height while dragging tabs. r=Gijs a=lizzard Differential Revision: https://phabricator.services.mozilla.com/D19268
b9fe883c6c1e: Bug 1504766 - Let explicit Dark and Light themes ignore the Windows 10 setting for accent color in title bars. r=ntim,Gijs a=lizzard
Dão Gottwald <dao@mozilla.com> - Wed, 20 Feb 2019 07:20:52 +0000 - rev 516104
Push 1953 by ffxbld-merge at Mon, 11 Mar 2019 12:10:20 +0000
Bug 1504766 - Let explicit Dark and Light themes ignore the Windows 10 setting for accent color in title bars. r=ntim,Gijs a=lizzard Differential Revision: https://phabricator.services.mozilla.com/D19764
690a467b10e1: Bug 1519376 - Fixes text wrapping issues in extension detail page. r=mstriemer,Gijs a=lizzard
championshuttler <shivams2799@gmail.com> - Mon, 11 Feb 2019 15:39:24 +0000 - rev 516054
Push 1953 by ffxbld-merge at Mon, 11 Mar 2019 12:10:20 +0000
Bug 1519376 - Fixes text wrapping issues in extension detail page. r=mstriemer,Gijs a=lizzard Differential Revision: https://phabricator.services.mozilla.com/D19272
b8a567422987: Bug 1523956 - Add a null check against mRefreshTimerVsyncDispatcher getting nulled concurrently. r=Gijs a=jcristau
Kartikaya Gupta <kgupta@mozilla.com> - Wed, 13 Feb 2019 22:46:19 +0000 - rev 516028
Push 1953 by ffxbld-merge at Mon, 11 Mar 2019 12:10:20 +0000
Bug 1523956 - Add a null check against mRefreshTimerVsyncDispatcher getting nulled concurrently. r=Gijs a=jcristau Differential Revision: https://phabricator.services.mozilla.com/D19703
dd68a244ab58: Bug 1524258 - Sort the permission capabilities based on their localization ID so we don't have to wait for the asynchronous localization. r=Gijs, a=jcristau
Jared Wein <jwein@mozilla.com> - Tue, 05 Feb 2019 21:01:08 +0000 - rev 516013
Push 1953 by ffxbld-merge at Mon, 11 Mar 2019 12:10:20 +0000
Bug 1524258 - Sort the permission capabilities based on their localization ID so we don't have to wait for the asynchronous localization. r=Gijs, a=jcristau Differential Revision: https://phabricator.services.mozilla.com/D18372
720c87f798e3: Bug 1506102 - Don't count lastFallbackLocale as installed when just fluent is included r=zbraniecki,Gijs a=lizzard
Mark Striemer <mstriemer@mozilla.com> - Tue, 12 Feb 2019 23:28:27 +0000 - rev 515945
Push 1953 by ffxbld-merge at Mon, 11 Mar 2019 12:10:20 +0000
Bug 1506102 - Don't count lastFallbackLocale as installed when just fluent is included r=zbraniecki,Gijs a=lizzard Differential Revision: https://phabricator.services.mozilla.com/D18386
e4d259ea825a: Bug 1521599 - Delete the failures data after it has been output. r=Gijs a=lizzard
Jared Wein <jwein@mozilla.com> - Thu, 31 Jan 2019 23:40:33 +0000 - rev 515878
Push 1953 by ffxbld-merge at Mon, 11 Mar 2019 12:10:20 +0000
Bug 1521599 - Delete the failures data after it has been output. r=Gijs a=lizzard The failures were remaining in the data object, which later had any remaining keys printed in the diagnostics section. This bug was introduced because we stopped using Array objects to generate formatted strings. In the previous code, this would have ended up just printing out the first failure listed in the diagnostics section (a partial duplicate of the actual Failure Log). Differential Revision: https://phabricator.services.mozilla.com/D18289
7c5414a3d4b0: Bug 1524857 - Part 1: Separate base domain for doorhangers from base domain used for domain highlighting. r=Gijs a=lizzard
Jan Henning <jh+bugzilla@buttercookie.de> - Thu, 07 Feb 2019 19:23:47 +0000 - rev 515873
Push 1953 by ffxbld-merge at Mon, 11 Mar 2019 12:10:20 +0000
Bug 1524857 - Part 1: Separate base domain for doorhangers from base domain used for domain highlighting. r=Gijs a=lizzard Currently, the Android front-end uses a tab's base domain both for permission prompt doorhangers, as well as for doing domain highlighting in the URL bar. The base domain in turn is based on the document's nodePrincipal's URI. As per bug 1325955, the nodePrincipal is the right choice for permission prompts, but it causes some problems for domain highlighting instead: For error pages for example, the nodePrincipal's URI will be some variety of about:neterror, which means that the front-end won't be able to do any domain highlighting based on that, since a) we don't generate any baseDomain anyway because the URI's scheme isn't HTTP(S)/FTP, and b) even if we did, the nodePrincipal's baseDomain won't match the contents of the URI displayed in the URL bar. Therefore, we want to separate these two concerns, and generate two baseDomains: One based on the nodePrincipal for use in permission prompts, and one based on the display URI, which going forward will power our domain highlighting. Differential Revision: https://phabricator.services.mozilla.com/D18586
0cfbcd1d35c4: Bug 1524857 - Part 0: Use short form where possible for defining properties. r=Gijs a=lizzard
Jan Henning <jh+bugzilla@buttercookie.de> - Thu, 07 Feb 2019 19:21:27 +0000 - rev 515872
Push 1953 by ffxbld-merge at Mon, 11 Mar 2019 12:10:20 +0000
Bug 1524857 - Part 0: Use short form where possible for defining properties. r=Gijs a=lizzard Differential Revision: https://phabricator.services.mozilla.com/D18585
ee2b9d8d4b0b: Bug 1524210 - Only clear the richlistbox selection when the box itself is clicked if the richlistbox is of multiselection type. r=Gijs a=lizzard
Jared Wein <jwein@mozilla.com> - Mon, 04 Feb 2019 22:14:57 +0000 - rev 515836
Push 1953 by ffxbld-merge at Mon, 11 Mar 2019 12:10:20 +0000
Bug 1524210 - Only clear the richlistbox selection when the box itself is clicked if the richlistbox is of multiselection type. r=Gijs a=lizzard There are a couple ways to fix this specific bug in Preferences. We could expand the padding up to the start border and remove the margin, though there would still exist a 1px padding on the richlistbox. Historically this code, at least for Preferences, was impossible to hit. The scrollbox couldn't get clicked because its size was defined by an inner xul:box that was the size of the richlistitems and whatever margin they had. Clicking next to the richlistitems in the Preferences before this regression was a click on the anonymous box and thus didn't clear the selection. Another potential fix could be if we added a special attribute that doesn't allow deselecting if clicking into nothing, but that seems like a band-aid that we would end up using in many other places instead of just removing this behavior. Differential Revision: https://phabricator.services.mozilla.com/D18371
b61d0fdc785b: Bug 1523696 - Wait until the style attribute is applied to the dialog before sizing it. r=Gijs a=RyanVM
Jared Wein <jwein@mozilla.com> - Fri, 08 Feb 2019 03:47:33 +0000 - rev 515835
Push 1953 by ffxbld-merge at Mon, 11 Mar 2019 12:10:20 +0000
Bug 1523696 - Wait until the style attribute is applied to the dialog before sizing it. r=Gijs a=RyanVM Differential Revision: https://phabricator.services.mozilla.com/D19037
e2f693bac4d4: Bug 1517410 - Don't show the unknown multiprocess status string while the page is loading. r=Gijs a=lizzard
Jared Wein <jwein@mozilla.com> - Tue, 29 Jan 2019 19:49:45 +0000 - rev 515704
Push 1953 by ffxbld-merge at Mon, 11 Mar 2019 12:10:20 +0000
Bug 1517410 - Don't show the unknown multiprocess status string while the page is loading. r=Gijs a=lizzard Differential Revision: https://phabricator.services.mozilla.com/D17948
08c85a7f6bcc: Bug 1521884 - Use proper case for maxLength attribute in datetimebox widget. r=Gijs
Emilio Cobos Álvarez <emilio@crisal.io> - Wed, 23 Jan 2019 14:48:42 +0000 - rev 515269
Push 1953 by ffxbld-merge at Mon, 11 Mar 2019 12:10:20 +0000
Bug 1521884 - Use proper case for maxLength attribute in datetimebox widget. r=Gijs In non-HTML documents, getAttribute is not case-insensitive. Differential Revision: https://phabricator.services.mozilla.com/D17355
f6094ca026ad: Bug 1521170 - Add a rule that prevents calling some Array and String accessor methods without using the return value. r=Standard8,Gijs
Jared Wein <jwein@mozilla.com> - Wed, 23 Jan 2019 17:03:32 +0000 - rev 515136
Push 1953 by ffxbld-merge at Mon, 11 Mar 2019 12:10:20 +0000
Bug 1521170 - Add a rule that prevents calling some Array and String accessor methods without using the return value. r=Standard8,Gijs Differential Revision: https://phabricator.services.mozilla.com/D17020
63d80647ebd2: Bug 1521040 - Remove ondialoghelp attribute and add custom event handler r=Gijs
vinoth <cegvinoth@gmail.com> - Mon, 21 Jan 2019 21:29:54 +0000 - rev 514827
Push 1953 by ffxbld-merge at Mon, 11 Mar 2019 12:10:20 +0000
Bug 1521040 - Remove ondialoghelp attribute and add custom event handler r=Gijs Differential Revision: https://phabricator.services.mozilla.com/D16946
585816362855: Bug 1517529 - Migrate safeMode dialog to Fluent for localization, r=Gijs,flod
cowlesni <cowlesni@msu.edu> - Mon, 21 Jan 2019 21:51:10 +0000 - rev 514753
Push 1953 by ffxbld-merge at Mon, 11 Mar 2019 12:10:20 +0000
Bug 1517529 - Migrate safeMode dialog to Fluent for localization, r=Gijs,flod Differential Revision: https://phabricator.services.mozilla.com/D16987
dc8020199c4b: Bug 1521212 - Unset visibility of the reset button instead of setting it to visible. r=Gijs
Emilio Cobos Álvarez <emilio@crisal.io> - Mon, 21 Jan 2019 12:58:41 +0000 - rev 514686
Push 1953 by ffxbld-merge at Mon, 11 Mar 2019 12:10:20 +0000
Bug 1521212 - Unset visibility of the reset button instead of setting it to visible. r=Gijs CSS visibility doesn't work like `display`. `visibility: visible` elements in a `visibility: hidden` subtree still get shown. Differential Revision: https://phabricator.services.mozilla.com/D17068
48c7d643d2fa: Bug 1517025 - Change default pref URLs to localhost instead of %(server) r=Gijs
Valentin Gosu <valentin.gosu@gmail.com> - Mon, 21 Jan 2019 09:55:02 +0000 - rev 514673
Push 1953 by ffxbld-merge at Mon, 11 Mar 2019 12:10:20 +0000
Bug 1517025 - Change default pref URLs to localhost instead of %(server) r=Gijs We now disallow the % sign in the hostname of a URL. If the app.normandy.api_url pref isn't set explicitly, it'll remain the default set in xpcshell/user.js: https://%(server)s/selfsupport-dummy/. As you can see, this one has a % sign in it; and the test will fail. Otherwise, the error we catch is not a NormandyApi.InvalidSignatureError, but NS_ERROR_MALFORMED_URI. Differential Revision: https://phabricator.services.mozilla.com/D16695
188f7a851811: Bug 1520865 - Use the return value of Array.concat when building the list of nodes that are being localized before window.sizeToContent. r=Gijs
Jared Wein <jwein@mozilla.com> - Thu, 17 Jan 2019 23:16:36 +0000 - rev 514450
Push 1953 by ffxbld-merge at Mon, 11 Mar 2019 12:10:20 +0000
Bug 1520865 - Use the return value of Array.concat when building the list of nodes that are being localized before window.sizeToContent. r=Gijs Differential Revision: https://phabricator.services.mozilla.com/D16887
2677d2e45ead: Bug 1518786 - Wait until Fluent strings have been applied before sizing the window to content. r=Gijs
Jared Wein <jwein@mozilla.com> - Wed, 16 Jan 2019 20:56:55 +0000 - rev 514137
Push 1953 by ffxbld-merge at Mon, 11 Mar 2019 12:10:20 +0000
Bug 1518786 - Wait until Fluent strings have been applied before sizing the window to content. r=Gijs Differential Revision: https://phabricator.services.mozilla.com/D16587
4fae3add610f: Bug 1516022 - Regression test. r=Gijs
Mike Conley <mconley@mozilla.com> - Wed, 16 Jan 2019 18:38:18 +0000 - rev 514116
Push 1953 by ffxbld-merge at Mon, 11 Mar 2019 12:10:20 +0000
Bug 1516022 - Regression test. r=Gijs Differential Revision: https://phabricator.services.mozilla.com/D16093
a51d26029042: Bug 1509888: Remove Browser Error Collection. r=Gijs,flod
Michael Kelly <mkelly@mozilla.com> - Tue, 15 Jan 2019 18:04:28 +0000 - rev 513940
Push 1953 by ffxbld-merge at Mon, 11 Mar 2019 12:10:20 +0000
Bug 1509888: Remove Browser Error Collection. r=Gijs,flod Differential Revision: https://phabricator.services.mozilla.com/D15879
bff0f583c673: Bug 1518799: Show a custom page on startup on Nightly on a specific date. r=Gijs
Dave Townsend <dtownsend@oxymoronical.com> - Fri, 11 Jan 2019 17:23:11 +0000 - rev 513834
Push 1953 by ffxbld-merge at Mon, 11 Mar 2019 12:10:20 +0000
Bug 1518799: Show a custom page on startup on Nightly on a specific date. r=Gijs We want to show an informative message about dedicated profiles per channel to users of Nightly on a specific date. We currently only have the ability to do this when the version changes. This adds the ability to show a page once on startup on a specific date. This will probably be backed out past that date. Differential Revision: https://phabricator.services.mozilla.com/D16249
456b9b7963eb: Bug 1303384 - Part 3: Manage extension shortcuts page r=aswan,Gijs,flod
Mark Striemer <mstriemer@mozilla.com> - Sat, 12 Jan 2019 06:45:17 +0000 - rev 513719
Push 1953 by ffxbld-merge at Mon, 11 Mar 2019 12:10:20 +0000
Bug 1303384 - Part 3: Manage extension shortcuts page r=aswan,Gijs,flod MozReview-Commit-ID: KeZsoB6qj88 Differential Revision: https://phabricator.services.mozilla.com/D4507
789fdfc911f7: Bug 1406872 - Remove perf monitoring code - r=jandem,Gijs
Tarek Ziadé <tarek@mozilla.com> - Mon, 14 Jan 2019 14:09:09 +0000 - rev 513710
Push 1953 by ffxbld-merge at Mon, 11 Mar 2019 12:10:20 +0000
Bug 1406872 - Remove perf monitoring code - r=jandem,Gijs This patch removes the StopWatch code that was used in the first version of about:performance, and not being used anymore. Differential Revision: https://phabricator.services.mozilla.com/D7453
eace4709948c: Bug 1518799: Show a custom page on startup on Nightly on a specific date. r=Gijs
Dave Townsend <dtownsend@oxymoronical.com> - Fri, 11 Jan 2019 17:23:11 +0000 - rev 513494
Push 1953 by ffxbld-merge at Mon, 11 Mar 2019 12:10:20 +0000
Bug 1518799: Show a custom page on startup on Nightly on a specific date. r=Gijs We want to show an informative message about dedicated profiles per channel to users of Nightly on a specific date. We currently only have the ability to do this when the version changes. This adds the ability to show a page once on startup on a specific date. This will probably be backed out past that date. Differential Revision: https://phabricator.services.mozilla.com/D16249
ebff3389b3e4: Bug 1518799: Show a custom page on startup on a specific date. r=Gijs
Dave Townsend <dtownsend@oxymoronical.com> - Fri, 11 Jan 2019 17:08:16 +0000 - rev 513487
Push 1953 by ffxbld-merge at Mon, 11 Mar 2019 12:10:20 +0000
Bug 1518799: Show a custom page on startup on a specific date. r=Gijs Still waiting on a couple of details from product but I'd like to get the review started now as we will want to land this a.s.a.p. Differential Revision: https://phabricator.services.mozilla.com/D16249
71cb45922e34: Bug 1513241: Update frontend consumers of loadURI and pass loadURIOptions dictionary. r=gijs
Christoph Kerschbaumer <ckerschb@christophkerschbaumer.com> - Fri, 11 Jan 2019 12:44:20 +0100 - rev 513400
Push 1953 by ffxbld-merge at Mon, 11 Mar 2019 12:10:20 +0000
Bug 1513241: Update frontend consumers of loadURI and pass loadURIOptions dictionary. r=gijs
f8cfb3571b81: Bug 1518866 - Land strings for new UI for Private Browsing with Search r=flod,Gijs
Ricky Rosario <rickyrosario@gmail.com> - Thu, 10 Jan 2019 16:43:08 +0000 - rev 513324
Push 1953 by ffxbld-merge at Mon, 11 Mar 2019 12:10:20 +0000
Bug 1518866 - Land strings for new UI for Private Browsing with Search r=flod,Gijs MozReview-Commit-ID: EGUdZ6WJJij Differential Revision: https://phabricator.services.mozilla.com/D16144
f747aad08cbc: Bug 1519184: Fix cache purging on windows. r=Gijs
Dave Townsend <dtownsend@oxymoronical.com> - Thu, 10 Jan 2019 20:10:04 +0000 - rev 513320
Push 1953 by ffxbld-merge at Mon, 11 Mar 2019 12:10:20 +0000
Bug 1519184: Fix cache purging on windows. r=Gijs When Firefox runs we cache a number of things, JS, XUL, XBL, CSS etc. Whenever a new build of Firefox runs against a profile we clear the cache to rebuild with the new information. On the first run of a profile where compatibility.ini doesn't exist (presumably to cover the case of upgrading from a very old versions of Firefox, but also affects new profiles) we attempt to clear the cache as well. If any attempt to clear the cache fails we set a flag in compatibility.ini telling us to clear the cache on next startup. Unfortunately nsIFile.remove returns different error codes on different platforms when the file in question already doesn't exist. So an attempt to remove a cache that does't exist is counted as a failure on Windows and so the cache will be cleared again on second run. This change counts the file not found return code as counting as a success when clearing the cache. Differential Revision: https://phabricator.services.mozilla.com/D16224
a140784a7b05: Bug 1414804 - Fix test for expired certificate "helpful" messaging to users with broken system clocks. r=Gijs
Johann Hofmann <jhofmann@mozilla.com> - Wed, 09 Jan 2019 17:23:18 +0000 - rev 513102
Push 1953 by ffxbld-merge at Mon, 11 Mar 2019 12:10:20 +0000
Bug 1414804 - Fix test for expired certificate "helpful" messaging to users with broken system clocks. r=Gijs We initially thought we would need a new test certificate to be able to test clock skew, but I found that we can reliably produce the clock skew page by making Firefox believe that the validity range of the cert used by expired.example.com is the correct date. How we do that is described in more detail in the test comments. This patch also updates the formatter for the new clock skew page to not show hours and minutes, as it did previously on the old clock skew warnings. Differential Revision: https://phabricator.services.mozilla.com/D13690
86cbcf2195f9: Bug 1356036 - remove unreferenced PerformanceWatcher-content.js and PerformanceWatcher.jsm, r=Gijs.
Florian Quèze <florian@queze.net> - Mon, 16 Jul 2018 12:04:03 +0200 - rev 513062
Push 1953 by ffxbld-merge at Mon, 11 Mar 2019 12:10:20 +0000
Bug 1356036 - remove unreferenced PerformanceWatcher-content.js and PerformanceWatcher.jsm, r=Gijs.
b0858dddedf9: Bug 1518292: use env instead of environment in JEXL context r=Gijs
Ethan Glasser-Camp <ethan@betacantrips.com> - Tue, 08 Jan 2019 23:52:35 +0000 - rev 512980
Push 1953 by ffxbld-merge at Mon, 11 Mar 2019 12:10:20 +0000
Bug 1518292: use env instead of environment in JEXL context r=Gijs Differential Revision: https://phabricator.services.mozilla.com/D15951
6bc15d28e6ec: Bug 1517505 - Remove app/feature and bootstrap exceptions from all_files_referenced test r=Gijs
Dhyey Thakore <dhyey35@gmail.com> - Tue, 08 Jan 2019 15:25:50 +0000 - rev 512908
Push 1953 by ffxbld-merge at Mon, 11 Mar 2019 12:10:20 +0000
Bug 1517505 - Remove app/feature and bootstrap exceptions from all_files_referenced test r=Gijs Differential Revision: https://phabricator.services.mozilla.com/D15783
cf3598ee865b: Bug 1517029: Fail favicon requests when encountering an icon that requires credentials. r=Gijs
Dave Townsend <dtownsend@oxymoronical.com> - Mon, 07 Jan 2019 17:57:46 +0000 - rev 512711
Push 1953 by ffxbld-merge at Mon, 11 Mar 2019 12:10:20 +0000
Bug 1517029: Fail favicon requests when encountering an icon that requires credentials. r=Gijs Differential Revision: https://phabricator.services.mozilla.com/D15768
43c43fa35d2a: Bug 1516658: Favicon requests should use an accept header appropriate for images. r=Gijs
Dave Townsend <dtownsend@oxymoronical.com> - Mon, 07 Jan 2019 17:43:23 +0000 - rev 512710
Push 1953 by ffxbld-merge at Mon, 11 Mar 2019 12:10:20 +0000
Bug 1516658: Favicon requests should use an accept header appropriate for images. r=Gijs Differential Revision: https://phabricator.services.mozilla.com/D15778
4b9c119d25c3: Bug 1501244 - Preserve privateBrowsingId OA when userContextId is set r=Gijs
Rob Wu <rob@robwu.nl> - Wed, 24 Oct 2018 21:23:17 +0000 - rev 512708
Push 1953 by ffxbld-merge at Mon, 11 Mar 2019 12:10:20 +0000
Bug 1501244 - Preserve privateBrowsingId OA when userContextId is set r=Gijs Differential Revision: https://phabricator.services.mozilla.com/D9535
92f9e0296e62: Bug 1512048 - Convert tabmodalprompt binding to JSM module r=Gijs
Timothy Guan-tin Chien <timdream@gmail.com> - Fri, 04 Jan 2019 19:29:34 +0000 - rev 512564
Push 1953 by ffxbld-merge at Mon, 11 Mar 2019 12:10:20 +0000
Bug 1512048 - Convert tabmodalprompt binding to JSM module r=Gijs This converts the tabmodalprompt binding to a class, to be constructed along side with the element by TabModalPromptBox. TabModalPromptBox will keep the instances in a map and pass it to the callers, instead of the element. The tests and callers can access the class instance by passing the element reference to the map. Differential Revision: https://phabricator.services.mozilla.com/D15505
c68ba2c62949: Bug 1507595 - Test fixes. r=flod,Gijs
Jared Wein <jwein@mozilla.com> - Fri, 28 Dec 2018 19:40:33 +0000 - rev 512066
Push 1953 by ffxbld-merge at Mon, 11 Mar 2019 12:10:20 +0000
Bug 1507595 - Test fixes. r=flod,Gijs There are multiple fixes contained in this patch: - fixes for Android/mobile support - adding extra strings to the ftl file that were never defined before, and previously the ID was just printed to the page - update test_l10n.py to not rely on about:support anymore - changing Troubleshoot.jsm to return and ID and args for the strings that should be displayed, so it is compatible with the Fluent API - misc. fixes so strings that are not localized don't go through the Fluent codepath Differential Revision: https://phabricator.services.mozilla.com/D15437
32fe57d45d1b: Bug 1507595 - Use data-l10n-id instead of formatValue where the change is relatively straightforward. r=Gijs
Jared Wein <jwein@mozilla.com> - Fri, 28 Dec 2018 19:40:20 +0000 - rev 512065
Push 1953 by ffxbld-merge at Mon, 11 Mar 2019 12:10:20 +0000
Bug 1507595 - Use data-l10n-id instead of formatValue where the change is relatively straightforward. r=Gijs Differential Revision: https://phabricator.services.mozilla.com/D14906
3f16eb2a8603: Bug 1507595 - Convert about:support to Fluent. r=Gijs,flod
Jared Wein <jwein@mozilla.com> - Fri, 28 Dec 2018 19:40:17 +0000 - rev 512064
Push 1953 by ffxbld-merge at Mon, 11 Mar 2019 12:10:20 +0000
Bug 1507595 - Convert about:support to Fluent. r=Gijs,flod Initial patch by Collin Wing (masterkrombi@gmail.com). Differential Revision: https://phabricator.services.mozilla.com/D14905
485ea25a3b82: Bug 1507595 - Use data-l10n-id instead of formatValue where the change is relatively straightforward. r=Gijs
Jared Wein <jwein@mozilla.com> - Mon, 24 Dec 2018 16:19:21 +0000 - rev 511856
Push 1953 by ffxbld-merge at Mon, 11 Mar 2019 12:10:20 +0000
Bug 1507595 - Use data-l10n-id instead of formatValue where the change is relatively straightforward. r=Gijs Differential Revision: https://phabricator.services.mozilla.com/D14906
28805dd1b97a: Bug 1507595 - Convert about:support to Fluent. r=Gijs,flod
Jared Wein <jwein@mozilla.com> - Mon, 24 Dec 2018 16:19:20 +0000 - rev 511855
Push 1953 by ffxbld-merge at Mon, 11 Mar 2019 12:10:20 +0000
Bug 1507595 - Convert about:support to Fluent. r=Gijs,flod Initial patch by Collin Wing (masterkrombi@gmail.com). Differential Revision: https://phabricator.services.mozilla.com/D14905
dbaf671d5e84: Bug 1509767: Support keyboard activation (space/enter) of the Back/Forward buttons when focused. r=Gijs
James Teh <jteh@mozilla.com> - Thu, 20 Dec 2018 05:33:32 +0000 - rev 511853
Push 1953 by ffxbld-merge at Mon, 11 Mar 2019 12:10:20 +0000
Bug 1509767: Support keyboard activation (space/enter) of the Back/Forward buttons when focused. r=Gijs When focused, the Back and Forward buttons previously couldn't be activated by pressing space or enter. Although they do have a command event handler, they have type="menu", which means the command event is not fired for key presses by default. Since these buttons are special (in that they have type="menu" and a command event), this change implements specific keyboard behavior for these buttons. Differential Revision: https://phabricator.services.mozilla.com/D12868
fb3f227c4f29: Bug 1506504: Add/fix keyboard behaviour for browser toolbar buttons which open popups. r=Gijs
James Teh <jteh@mozilla.com> - Thu, 20 Dec 2018 11:33:32 +0000 - rev 511852
Push 1953 by ffxbld-merge at Mon, 11 Mar 2019 12:10:20 +0000
Bug 1506504: Add/fix keyboard behaviour for browser toolbar buttons which open popups. r=Gijs 1. Fix the Firefox menu button so that it only handles space and enter, rather than incorrectly activating for *all* key presses. 2. Add keyboard support (space and enter) for the Library and page Actions buttons. 3. Add keyboard support (space and enter) for customizable widgets of type "view"; e.g. the Developer button. 4. Add keyboard support (space and enter) for page action buttons pinned to the URL bar; e.g. the Send Tab to Device button. Differential Revision: https://phabricator.services.mozilla.com/D11608
185b7717cc2e: Bug 1441168 - Make promiseDocumentFlushed reject if the DOM is modified in the callback. r=Gijs
Mike Conley <mconley@mozilla.com> - Wed, 19 Dec 2018 18:32:18 +0000 - rev 511515
Push 1953 by ffxbld-merge at Mon, 11 Mar 2019 12:10:20 +0000
Bug 1441168 - Make promiseDocumentFlushed reject if the DOM is modified in the callback. r=Gijs Differential Revision: https://phabricator.services.mozilla.com/D14101
fe181f5f1a96: Bug 1509388 - Part 1 - Don't use a toolbarbutton element for the download-subview-toolbarbutton binding. r=Gijs
Paolo Amadini <paolo.mozmail@amadzone.org> - Thu, 13 Dec 2018 18:47:28 +0000 - rev 511441
Push 1953 by ffxbld-merge at Mon, 11 Mar 2019 12:10:20 +0000
Bug 1509388 - Part 1 - Don't use a toolbarbutton element for the download-subview-toolbarbutton binding. r=Gijs Download items in the Downloads Subview of the Library Panel are implemented using a XBL binding that is associated to a "toolbarbutton" element, but inherits from "button-base" in order to avoid the display="xul:button" of the "toolbarbutton" binding. This is because the item contains an inner button, and using a button CSS frame for the outer element would break hover behavior and mouse events. This changes the binding so it doesn't use a "toolbarbutton" element, which is a different way to avoid the outer button CSS frame, and eventually allows removing support for the "display" attribute in XBL. Differential Revision: https://phabricator.services.mozilla.com/D14572
7c5b9046b433: Bug 1365542 - Use HTML5 FormData object rather than hand-rolling form data for search keyword handling r=Gijs
Arshad Kazmi <arshadkazmi42@gmail.com> - Tue, 18 Dec 2018 23:44:15 +0000 - rev 511196
Push 1953 by ffxbld-merge at Mon, 11 Mar 2019 12:10:20 +0000
Bug 1365542 - Use HTML5 FormData object rather than hand-rolling form data for search keyword handling r=Gijs Differential Revision: https://phabricator.services.mozilla.com/D14877