01f44eb7977ceb241941e1226014f12e51c071b4: No Bug, mozilla-release repo-update remote-settings - a=repo-update r=RyanVM default tip
ffxbld <ffxbld@mozilla.com> - Thu, 20 Jan 2022 08:14:07 +0000 - rev 675145
Push 2750 by ryanvm@gmail.com at Thu, 20 Jan 2022 14:58:20 +0000
No Bug, mozilla-release repo-update remote-settings - a=repo-update r=RyanVM Differential Revision: https://phabricator.services.mozilla.com/D136456
f63c05730e878f5660854170dde6d67c0909d292: Automatic version bump CLOSED TREE NO BUG a=release DONTBUILD
Mozilla Releng Treescript <release+treescript@mozilla.org> - Thu, 20 Jan 2022 13:25:45 +0000 - rev 675144
Push 2749 by ffxbld at Thu, 20 Jan 2022 13:25:56 +0000
Automatic version bump CLOSED TREE NO BUG a=release DONTBUILD
dfa44b5382f47fcd62cae15878ce463d3640d0b0: No bug - Tagging 78c76c55ba02435ac7b4e57af6e6e938c9510812 with FIREFOX_96_0_2_RELEASE a=release CLOSED TREE DONTBUILD
Mozilla Releng Treescript <release+treescript@mozilla.org> - Thu, 20 Jan 2022 13:25:38 +0000 - rev 675143
Push 2749 by ffxbld at Thu, 20 Jan 2022 13:25:56 +0000
No bug - Tagging 78c76c55ba02435ac7b4e57af6e6e938c9510812 with FIREFOX_96_0_2_RELEASE a=release CLOSED TREE DONTBUILD
29c74c5a7e755da93cd985d60777be2ff03ad592: No bug - Tagging 78c76c55ba02435ac7b4e57af6e6e938c9510812 with FIREFOX_96_0_2_BUILD1 a=release CLOSED TREE DONTBUILD
Mozilla Releng Treescript <release+treescript@mozilla.org> - Wed, 19 Jan 2022 22:51:59 +0000 - rev 675142
Push 2748 by ffxbld at Wed, 19 Jan 2022 22:52:07 +0000
No bug - Tagging 78c76c55ba02435ac7b4e57af6e6e938c9510812 with FIREFOX_96_0_2_BUILD1 a=release CLOSED TREE DONTBUILD
78c76c55ba02435ac7b4e57af6e6e938c9510812: Bug 1750211 - Return an error in unexpected state. r=necko-reviewers,kershaw, a=dsmith FIREFOX_96_0_2_BUILD1 FIREFOX_96_0_2_RELEASE
Dragana Damjanovic <dd.mozilla@gmail.com> - Wed, 19 Jan 2022 16:29:39 +0000 - rev 675141
Push 2747 by dsmith@mozilla.com at Wed, 19 Jan 2022 19:04:39 +0000
Bug 1750211 - Return an error in unexpected state. r=necko-reviewers,kershaw, a=dsmith Differential Revision: https://phabricator.services.mozilla.com/D136005
d601a48661840dd4b9d78c353a15d73b46f48b0f: Bug 1714276 - Limit height of tab when font size is changed r=dao,desktop-theme-reviewers, a=dsmith
Bernard Igiri <bigiri@mozilla.com> - Thu, 06 Jan 2022 16:33:27 +0000 - rev 675140
Push 2747 by dsmith@mozilla.com at Wed, 19 Jan 2022 19:04:39 +0000
Bug 1714276 - Limit height of tab when font size is changed r=dao,desktop-theme-reviewers, a=dsmith Set a maximum height on tabs to prevent it from expanding and moving the display of the web page. Differential Revision: https://phabricator.services.mozilla.com/D134169
ef58cb25be7aa6582d607a7a26b0c0fc5eb3abae: Bug 1748912 - Add null check in CanonicalBrowsingContext::RemoveFromSessionHistory. r=smaug, a=dsmith
Andrew McCreight <continuation@gmail.com> - Fri, 07 Jan 2022 14:16:07 +0000 - rev 675139
Push 2747 by dsmith@mozilla.com at Wed, 19 Jan 2022 19:04:39 +0000
Bug 1748912 - Add null check in CanonicalBrowsingContext::RemoveFromSessionHistory. r=smaug, a=dsmith Differential Revision: https://phabricator.services.mozilla.com/D135270
e851157242f2e91bf748418af66d5b3be0869a7d: Bug 1749644 - Fix RemoteL10n Fluent directory. r=emcminn, a=RyanVM,dsmith
Barret Rennie <barret@brennie.ca> - Wed, 12 Jan 2022 16:46:05 +0000 - rev 675138
Push 2746 by dsmith@mozilla.com at Wed, 19 Jan 2022 04:07:36 +0000
Bug 1749644 - Fix RemoteL10n Fluent directory. r=emcminn, a=RyanVM,dsmith Differential Revision: https://phabricator.services.mozilla.com/D135665
dd275f7d8b4343bebefd88c473b00338c09008a6: Bug 1747575 - Fix a bug that prevents search mode from being exited in new windows. r=harry, a=RyanVM,dsmith
Drew Willcoxon <adw@mozilla.com> - Tue, 11 Jan 2022 23:16:07 +0000 - rev 675137
Push 2746 by dsmith@mozilla.com at Wed, 19 Jan 2022 04:07:36 +0000
Bug 1747575 - Fix a bug that prevents search mode from being exited in new windows. r=harry, a=RyanVM,dsmith This is a regression from bug 1723158, specifically [this change](https://hg.mozilla.org/mozilla-central/rev/904db8e18e53#l4.12). `this._queryContext` is undefined in the view in new windows. If you press the key shortcut to enter search mode immediately in a new window, search mode is entered without running a query. Then if you hit Escape or Backspace, we hit the `allowEmptySelection` getter and throw an error because `this._queryContext` is undefined but we're trying to destructure it. This bug does not happen if you first focus the urlbar and then enter search mode because focusing the urlbar causes the top-sites query to run. Differential Revision: https://phabricator.services.mozilla.com/D135583
8d55b95f31d0b4e4edaec0a3710eb986c70282b1: Bug 1748158 - Omit sender.frameId if sender.tab is unset r=rpl,geckoview-reviewers,jonalmeida, a=dsmith
Rob Wu <rob@robwu.nl> - Thu, 06 Jan 2022 14:15:47 +0000 - rev 675136
Push 2746 by dsmith@mozilla.com at Wed, 19 Jan 2022 04:07:36 +0000
Bug 1748158 - Omit sender.frameId if sender.tab is unset r=rpl,geckoview-reviewers,jonalmeida, a=dsmith `sender.frameId` should be set iff `sender.tab` is set, as documented at https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/API/runtime/MessageSender The removal of the `viewType == "tab"` condition broke this in https://hg.mozilla.org/mozilla-central/rev/2dc4f1baccc8 This patch makes the presence of `frameId` conditional on `tab`, and fixes several tests that relied on the incorrect behavior: - Move the runtime.onConnect test from test_ext_contentscript_in_background.js to a new mochitest at test_ext_runtime_connect_iframe.html. - Simplify test_ext_contentscript_in_background.js to continue to provide test coverage for contentScripts.register + allFrames. - Replace runtime.onConnect with runtime.getFrameId in test_ext_contentscript_xorigin_frame.js, since sender.frameId is no longer available in xpcshell tests (because internals to support the tabs extension API are not available in xpcshell tests). The test cannot be moved to a mochitest because its purpose is to provide test coverage for process switching in a xpcshell test (bug 1580811). Differential Revision: https://phabricator.services.mozilla.com/D135057
a1e89a2bb5a01796a6cdaf4f6aac8dba96df7447: Bug 1746084 - Avoid generating InterpolateMatrix operations if there are no size dependencies. r=hiro, a=dsmith
Emilio Cobos Álvarez <emilio@crisal.io> - Wed, 05 Jan 2022 19:10:28 +0000 - rev 675135
Push 2746 by dsmith@mozilla.com at Wed, 19 Jan 2022 04:07:36 +0000
Bug 1746084 - Avoid generating InterpolateMatrix operations if there are no size dependencies. r=hiro, a=dsmith The issue here is that we end up with a transition between mismatched transform lists that ends up generating an InterpolateMatrix {} operation. So far so good, but we end up interpolating that a lot of times and generating an unboundedly-deep operation list. This implementas an optimization that flattens them to a single matrix when possible (when there's no dependencies on the containing box). This is similar to: https://chromium.googlesource.com/chromium/src.git/+/2b89cc4df436e672ef9cf940d1c0dc73fef82a4a We fix the to_pixel_length() behavior for LenghtPercentage to be correct (and update callers to preserve behavior). Differential Revision: https://phabricator.services.mozilla.com/D134784
5a35d4c0fabb34f62a1941efb56013d5dc6fff13: Bug 1750205 - Properly handle a11y when the Firefox Suggest online opt-in modal changes panes/sections. r=daisuke, a=RyanVM, a=dsmith
Drew Willcoxon <adw@mozilla.com> - Sun, 16 Jan 2022 00:36:04 +0000 - rev 675134
Push 2745 by dsmith@mozilla.com at Tue, 18 Jan 2022 22:29:26 +0000
Bug 1750205 - Properly handle a11y when the Firefox Suggest online opt-in modal changes panes/sections. r=daisuke, a=RyanVM, a=dsmith Updating `aria-labelledby` and `aria-describedby` seems to work. We aren't using `aria-live` correctly I think, which is my fault since I suggested it. AFAICT that should be used on an element whose subtree changes. That's not the case for these `h1` elements. It is the case for the `body` element, and I tried setting `aria-live=polite` on it, but it ended up causing everything in the main section to be read multiple times. Differential Revision: https://phabricator.services.mozilla.com/D136055
258b5b037bfccf9ad55e2635c1cd8e156b350191: Bug 1750390 - Don't show the Firefox Suggest online opt-in modal on top of about:welcome. r=nanj, a=RyanVM,dsmith
Drew Willcoxon <adw@mozilla.com> - Mon, 17 Jan 2022 20:20:14 +0000 - rev 675133
Push 2745 by dsmith@mozilla.com at Tue, 18 Jan 2022 22:29:26 +0000
Bug 1750390 - Don't show the Firefox Suggest online opt-in modal on top of about:welcome. r=nanj, a=RyanVM,dsmith The logic we added to `_maybeShowDefaultBrowserPrompt()` in BrowserGlue in D135308 isn't enough to prevent the modal from opening on top of about:welcome. AFAICT the decision to open about:welcome isn't part of that logic at all. This revision bails out of `maybeShowOnboardingDialog()` if the top window's current tab is about:welcome. That seems sufficient to prevent this from happening in most cases. There are a couple of cases where this wouldn't work: 1. about:welcome is opened *after* the Suggest modal. But so far I've never seen that happen and I'm not sure it's even possible. Preventing this case would require deeper integration with the logic that opens about:welcome. It would also block the remainder of `_maybeShowDefaultBrowserPrompt()` that is awaiting the call to `maybeShowOnboardingDialog()`, which seems like a bad idea. 2. about:welcome is open in an unselected tab. This seems very unlikely because the user would need to select/open a new tab in the brief period of time between when about:welcome is shown and the modal is shown. It would be simple to look through all tabs in the top window (and all windows), but if the profile isn't new -- which would be the common case -- and it has restored a ton of tabs, it would be inefficient to look through all of them, and preventing this case is just not worth that. (tabbrowser doesn't have a set or map keyed on URLs that would provide O(1) lookup AFAIK.) Differential Revision: https://phabricator.services.mozilla.com/D136071
d6c785be454845ac794df4999973f50d57e617e1: Bug 1749758 - Disable session store for the Firefox Suggest toggles/checkboxes in about:preferences. r=Gijs, a=RyanVM,dsmith
Drew Willcoxon <adw@mozilla.com> - Sat, 15 Jan 2022 20:22:34 +0000 - rev 675132
Push 2745 by dsmith@mozilla.com at Tue, 18 Jan 2022 22:29:26 +0000
Bug 1749758 - Disable session store for the Firefox Suggest toggles/checkboxes in about:preferences. r=Gijs, a=RyanVM,dsmith Please see bug 1749758 comment 6 for background. In summary, session store is restoring the states of the Firefox Suggest `<html:input>` checkboxes in about:preferences#privacy, which intermittently happens **after** their states are initialized by the preferences code. If a checkbox's session store state does not match the value of its underlying pref, then the checkbox and pref both end up with the wrong value because session store sets the wrong checked state of the checkbox, which fires an input event, which then updates the pref. This can only happen when the pref value is changed outside of about:preferences, which is indeed the case for the Firefox Suggest pref discussed in the bug. To fix it, I tried adding `autocomplete=off` to each input, but unfortunately that does not work because `input[type=checkbox]` is specifically not allowed to opt out of autocomplete/session store. The code path for restoring input checkboxes is: # [CollectInputElement](https://searchfox.org/mozilla-central/rev/3de56eb5f266f523340e739ae1b53258e0a95dfe/toolkit/components/sessionstore/SessionStoreUtils.cpp#580) # CollectInputElement [calls](https://searchfox.org/mozilla-central/rev/3de56eb5f266f523340e739ae1b53258e0a95dfe/toolkit/components/sessionstore/SessionStoreUtils.cpp#603) [nsContentUtils::IsAutocompleteEnabled](https://searchfox.org/mozilla-central/rev/3de56eb5f266f523340e739ae1b53258e0a95dfe/dom/base/nsContentUtils.cpp#1070) # nsContentUtils::IsAutocompleteEnabled [calls](https://searchfox.org/mozilla-central/rev/3de56eb5f266f523340e739ae1b53258e0a95dfe/dom/base/nsContentUtils.cpp#1075) [HTMLInputElement::GetAutocomplete](https://searchfox.org/mozilla-central/rev/3de56eb5f266f523340e739ae1b53258e0a95dfe/dom/html/HTMLInputElement.cpp#1394) # HTMLInputElement::GetAutocomplete [calls](https://searchfox.org/mozilla-central/rev/3de56eb5f266f523340e739ae1b53258e0a95dfe/dom/html/HTMLInputElement.cpp#1395) [HTMLInputElement::DoesAutocompleteApply](https://searchfox.org/mozilla-central/source/dom/html/HTMLInputElement.cpp#6365) # HTMLInputElement::DoesAutocompleteApply [returns false](https://searchfox.org/mozilla-central/rev/3de56eb5f266f523340e739ae1b53258e0a95dfe/dom/html/HTMLInputElement.cpp#6398) for FormControlType::InputCheckbox # Back in nsContentUtils::IsAutocompleteEnabled, the `autocomplete` string is empty because HTMLInputElement::DoesAutocompleteApply did not set it to anything, so then the method [checks](https://searchfox.org/mozilla-central/rev/3de56eb5f266f523340e739ae1b53258e0a95dfe/dom/base/nsContentUtils.cpp#1078) if the input has a form and sets `autocomplete` to the value of the form's autocomplete attribute # nsContentUtils::IsAutocompleteEnabled then returns false iff `autocomplete` is "off" # Back in CollectInputElement, if nsContentUtils::IsAutocompleteEnabled returned true, then it continues and checks a couple of other things, but at that point there's no way for the input checkbox to opt out of autocomplete/session store. So, the only way to disable autocomplete seems to be to associate the input with a form and set `autocomplete=off` on the form, so that's what I've done. It would be simpler to make these XUL checkboxes instead, which AFAICT don't participate in session store, but these checkboxes need the toggle-switch styling. Finally, this is a problem for all `<html:input>`s used in about:preferences. I didn't update any others because I want to keep this scoped for uplift, and maybe the other input checkboxes should be XUL checkboxes anyway? Differential Revision: https://phabricator.services.mozilla.com/D136054
972637fc3dbf0217eb972f8b90f1dc02c8fddaed: Bug 1749740: Add a tooltip for the X close button. r=adw, a=RyanVM,dsmith
Daisuke Akatsuka <daisuke@birchill.co.jp> - Thu, 13 Jan 2022 00:35:54 +0000 - rev 675131
Push 2745 by dsmith@mozilla.com at Tue, 18 Jan 2022 22:29:26 +0000
Bug 1749740: Add a tooltip for the X close button. r=adw, a=RyanVM,dsmith Differential Revision: https://phabricator.services.mozilla.com/D135755
255f79986bad2299721e209fa5357639c660c27c: Bug 1749742 - Fix some a11y problems in the new Firefox Suggest opt-in modal. r=daisuke, a=RyanVM,dsmith
Drew Willcoxon <adw@mozilla.com> - Thu, 13 Jan 2022 00:53:32 +0000 - rev 675130
Push 2745 by dsmith@mozilla.com at Tue, 18 Jan 2022 22:29:26 +0000
Bug 1749742 - Fix some a11y problems in the new Firefox Suggest opt-in modal. r=daisuke, a=RyanVM,dsmith There are a couple of problems: (1) When a radio button has the keyboard focus, the corresponding title and description are not read. This seems to be because the `<label>` doesn't have any content to read. The actual content is in a different div. I fixed this by moving the title and description inside the `<label>`. (2) The options' titles and descriptions are not read on hover/mouseover. This seems to be related to how the `<label>` has an absolute position and is layed out on top of or underneath the titles and descriptions. It interferes with the screenreader. I fixed that by removing the absolute position. With that change combined with the fix mentioned above, you can still click the title and description text to select the radio button, but it breaks the ability to click outside the text to select the button, for example clicking directly underneath the radio button. To fix that, I gave the `<label>` a positive padding and negative margin so that its padding extends to the border of the option. * * * I tested this on all three platforms and with the NVDA screenreader on Windows. This revision makes one other change that isn't strictly necessary: Instead of setting the width of the options to 100% - some margin, we can set `align-items: stretch` on the section, which I think is a little nicer. We also don't have to specify the widths of the images that way, only the heights. However, it also makes the the buttons and not-now link take up the entire width of the section, but we can fix that by putting them inside a div, which I called `.buttonBox`. Differential Revision: https://phabricator.services.mozilla.com/D135753
de0750426f67d79ffbad5749bd11274567b24787: Bug 1749425: Add X close button on introduction page for all UI variations. r=adw, a=RyanVM,dsmith
Daisuke Akatsuka <daisuke@birchill.co.jp> - Tue, 11 Jan 2022 02:34:59 +0000 - rev 675129
Push 2745 by dsmith@mozilla.com at Tue, 18 Jan 2022 22:29:26 +0000
Bug 1749425: Add X close button on introduction page for all UI variations. r=adw, a=RyanVM,dsmith Differential Revision: https://phabricator.services.mozilla.com/D135573
1134f309f55fac353fd786eaec22d1aa442af713: Bug 1745026 - Part 4: Hook into the upgrade- and default-browser-dialog logic when determining whether to show the Firefox Suggest opt-in modal. r=nanj,a=dsmith
Drew Willcoxon <adw@mozilla.com> - Fri, 07 Jan 2022 21:33:04 +0000 - rev 675128
Push 2745 by dsmith@mozilla.com at Tue, 18 Jan 2022 22:29:26 +0000
Bug 1745026 - Part 4: Hook into the upgrade- and default-browser-dialog logic when determining whether to show the Firefox Suggest opt-in modal. r=nanj,a=dsmith Currently we check in a startup idle task whether we should show the Firefox Suggest online modal, which means the modal competes with the upgrade dialog and default-browser prompt. This revision moves the check to the same site where we check for the other two dialogs. So now the sequence is: 1. Show the upgrade dialog? If yes, show it and stop. If no, continue. 2. Show the default-browser prompt? If yes, show it and stop. If no, continue. 3. Show the Suggest modal if necessary. Only one of these dialogs will be shown per Firefox session. Differential Revision: https://phabricator.services.mozilla.com/D135308
983e7bb5032c6ad99b88ee86ce667e6cc7384156: Bug 1745026 - Part 3: Update telemetries for Firefox suggest onboarding dialog. r=adw, a=dsmith
Daisuke Akatsuka <daisuke@birchill.co.jp> - Fri, 07 Jan 2022 21:33:04 +0000 - rev 675127
Push 2745 by dsmith@mozilla.com at Tue, 18 Jan 2022 22:29:26 +0000
Bug 1745026 - Part 3: Update telemetries for Firefox suggest onboarding dialog. r=adw, a=dsmith Differential Revision: https://phabricator.services.mozilla.com/D134374
8e104fa2eaac0d57bdc713f0714b1ebc2f9c60ac: Bug 1745026 - Part 2: Update messages and UI by Nimbus. r=adw,flod, a=dsmith
Daisuke Akatsuka <daisuke@birchill.co.jp> - Fri, 07 Jan 2022 21:33:03 +0000 - rev 675126
Push 2745 by dsmith@mozilla.com at Tue, 18 Jan 2022 22:29:26 +0000
Bug 1745026 - Part 2: Update messages and UI by Nimbus. r=adw,flod, a=dsmith Differential Revision: https://phabricator.services.mozilla.com/D133993
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 tip