f464ecbaeeda2c62e78f5a3b862597f737601f8a: Bug 1496059 - Don't use PGO for Windows opt-msvc builds now that they're not being shipped. r=froydnj
Ryan VanderMeulen <ryanvm@gmail.com> - Fri, 12 Oct 2018 17:44:43 +0000 - rev 499361
Push 1864 by ffxbld-merge at Mon, 03 Dec 2018 15:51:40 +0000
Bug 1496059 - Don't use PGO for Windows opt-msvc builds now that they're not being shipped. r=froydnj This is a straight revert of bug 1474756. Differential Revision: https://phabricator.services.mozilla.com/D8454
74b2087ee696eb7369b65727b81fc67121789f7d: Bug 1488439: Part 2 - Patch GetFileAttributesW for appdata parent folders in sandboxed plugin process (r=bobowen,jmathies)
David Parks <dparks@mozilla.com> - Fri, 12 Oct 2018 17:41:29 +0000 - rev 499360
Push 1864 by ffxbld-merge at Mon, 03 Dec 2018 15:51:40 +0000
Bug 1488439: Part 2 - Patch GetFileAttributesW for appdata parent folders in sandboxed plugin process (r=bobowen,jmathies) Flash analyzes the parents of the path to its appdata folder on Windows using GetFileAttributesW. If it runs into an error, it makes some internal decisions that cause it to break DRM video. Our new sandbox hardening causes GetFileAttributesW to return an error for some components of the path. This patch alters the behavior of GetFileAttributesW so that it always reports FILE_ATTRIBUTE_DIRECTORY for any path that both 1) would otherwise return an error and 2) is an ancestor of the appdata folder. This may not always be 100% accurate (for instance, if the folder is a reparse point) but restores video functionality. Depends on D7532 Differential Revision: https://phabricator.services.mozilla.com/D7533
53dfca556ff165528d145ebcaf64186ca274ccd3: Bug 1197370 - Add chown method to adb.py, refactor chmod r=bc
Edwin Gao <egao@mozilla.com> - Fri, 12 Oct 2018 16:58:35 +0000 - rev 499359
Push 1864 by ffxbld-merge at Mon, 03 Dec 2018 15:51:40 +0000
Bug 1197370 - Add chown method to adb.py, refactor chmod r=bc Behavior changes: - added method for ADBDevice class called chown - when initializing ADBDevice class, check if recursive flag is supported (similar to chmod -R) Other changes: - handling for situation where recursive is desired but -R flag is not supported is in place - changed behavior above situation to mirror chmod (creation of temporary file based on `self.ls` output, then executing script on device using adb Unit Tests: - unit tests to exercise attributes and common paths created. Would need further expansion of tests at some point. - additional mocking fixtures created. Differential Revision: https://phabricator.services.mozilla.com/D8128
2064477895c3d93ec55cab9dede17ba01a434b21: Bug 1494069 - [lint] Explicitly list out objdirs rather than depend on 'obj*' in the global exclude, r=rwood
Andrew Halberstadt <ahalberstadt@mozilla.com> - Fri, 12 Oct 2018 15:57:44 +0000 - rev 499358
Push 1864 by ffxbld-merge at Mon, 03 Dec 2018 15:51:40 +0000
Bug 1494069 - [lint] Explicitly list out objdirs rather than depend on 'obj*' in the global exclude, r=rwood When using globs in exclude directorives, FileFinder will return every *file* that gets matched. This is can be thousands of files in the case of an objdir. While we now collapse these files down to highest possible directories, this collapse operation can still take a noticeable amount of time (0.6s). This simply scans topsrcdir for files that start with 'obj' to avoid the glob. This also moves the '_activate_virtualenv' call to the top of the function because in CI, this will cause an objdir to be created (to store the virtualenv). If this happens *after* calculating the global excludes, we won't catch it since it doesn't exist yet. This will result in the objdir's virtualenv being linted and erroneous failures. Depends on D7739 Differential Revision: https://phabricator.services.mozilla.com/D7740
b7e586708ecccea803d5c4b77e3f9d7bbcb912f6: Bug 1494069 - [mozlint] Collapse exclude paths into their smallest possible set, r=egao
Andrew Halberstadt <ahalberstadt@mozilla.com> - Fri, 12 Oct 2018 15:57:42 +0000 - rev 499357
Push 1864 by ffxbld-merge at Mon, 03 Dec 2018 15:51:40 +0000
Bug 1494069 - [mozlint] Collapse exclude paths into their smallest possible set, r=egao Often we specify globs in our exclude patterns, e.g: exclude: - **/node_modules - obj* However, these globs get expanded out to *every* file that matches them. This can sometimes be thousands or even tens of thousands of files. We then pass these paths on to the underlying linters and tell them to exclude them all. This causes a lot of overhead and slows down performance. This commit implements a "collapse" function. Given a set of paths, it'll collapse them into the smallest set of parent directories that contain the original set, and that don't contain any extra files. For example, given a directory structure like this: a -- foo.txt -- b -- bar.txt -- baz.txt -- c -- ham.txt -- d -- spam.txt Then the following will happen: >>> collapse(['a/foo.txt', 'a/b/bar.txt', 'a/c/ham.txt', 'a/c/d/spam.txt']) ['a/foo.txt', 'b/bar.txt', 'c'] Since all files under directory 'c' are specified by the original set (both 'c/ham.txt' and 'c/d/spam.txt'), we can collapse it down to just 'c'. However not all files under 'b' are specified (we're missing 'a/b/baz.txt'), so we can't collapse 'b' (and by extension also can't collapse 'a'). If we had included 'a/b/baz.txt': >>> collapse(['a/foo.txt', 'a/b/bar.txt', 'a/b/baz.txt', 'a/c/ham.txt', 'a/c/d/spam.txt']) ['a'] In both cases, the smallest set of paths that contains the original set (and only the original set) is computed. The collapse function has a little bit of overhead but it's not too bad. For example collapsing all files matched by '**/node_modules' takes ~0.015s. Collapsing two full objdirs, takes ~0.6s. But a follow up commit is planned to make sure we stop using 'obj*' to reduce that overhead. Depends on D7738 Differential Revision: https://phabricator.services.mozilla.com/D7739
85575fc37555213a204b8565bbadef7270edd19e: Bug 1488439: Part 1 - Replace Windows temp folder in sandboxed plugin process (r=bobowen,erahm)
David Parks <dparks@mozilla.com> - Fri, 12 Oct 2018 17:40:10 +0000 - rev 499356
Push 1864 by ffxbld-merge at Mon, 03 Dec 2018 15:51:40 +0000
Bug 1488439: Part 1 - Replace Windows temp folder in sandboxed plugin process (r=bobowen,erahm) The sandbox blocks GetTempFileName's prior response, causing the system to end up searching a number of (inaccessible) folders to use as a replacement for the temp folder. This patch provides a path to a new folder on the command line for the plugin process. This new temp folder, specific to this plugin process instance, is then communicated to the system via the TEMP/TMP environment variables. This is similar to what is done for the content process but avoids nsDirectoryService, which doesn't exist in plugin processes. Differential Revision: https://phabricator.services.mozilla.com/D7532
067a1c08f91d13f9ad8b7c73b40b2a9065d24c0e: Merge mozilla-central to autoland. a=merge CLOSED TREE
Cosmin Sabou <csabou@mozilla.com> - Fri, 12 Oct 2018 20:35:52 +0300 - rev 499355
Push 1864 by ffxbld-merge at Mon, 03 Dec 2018 15:51:40 +0000
Merge mozilla-central to autoland. a=merge CLOSED TREE
95931b0b064b84a2ff9beb254b70caa4436e8c54: Bug 1497984 - whitelist allowPtrace scope, too r=bstack
Dustin J. Mitchell <dustin@mozilla.com> - Wed, 10 Oct 2018 23:49:37 +0000 - rev 499354
Push 1864 by ffxbld-merge at Mon, 03 Dec 2018 15:51:40 +0000
Bug 1497984 - whitelist allowPtrace scope, too r=bstack Differential Revision: https://phabricator.services.mozilla.com/D8279
f1d7d48f099d67b42484b568ea7e67983cca1914: Merge mozilla-central to autoland. CLOSED TREE
Csoregi Natalia <ncsoregi@mozilla.com> - Fri, 12 Oct 2018 19:58:03 +0300 - rev 499353
Push 1864 by ffxbld-merge at Mon, 03 Dec 2018 15:51:40 +0000
Merge mozilla-central to autoland. CLOSED TREE
6ac06a913b07f9b86c17e1fe122eaca4ecb5561e: Backed out changeset e7f9ba7e8ac2 (bug 821610) for ES lint failure CLOSED TREE
Bogdan Tara <btara@mozilla.com> - Fri, 12 Oct 2018 19:52:47 +0300 - rev 499352
Push 1864 by ffxbld-merge at Mon, 03 Dec 2018 15:51:40 +0000
Backed out changeset e7f9ba7e8ac2 (bug 821610) for ES lint failure CLOSED TREE
dbab4e3611fb95778c944fc66ab9edca42c88133: Bug 1351308 - Ensure sanitizing before shutdown; r=jchen
Petru Lingurar <petru.lingurar@softvision.ro> - Fri, 12 Oct 2018 15:46:02 +0000 - rev 499351
Push 1864 by ffxbld-merge at Mon, 03 Dec 2018 15:51:40 +0000
Bug 1351308 - Ensure sanitizing before shutdown; r=jchen Need to use the already initialized instance of DownloadIntegration, which has an already initialized DownloadStore to actually store the updated list of downloads. Differential Revision: https://phabricator.services.mozilla.com/D8403
e7c817964e523db7d5326b2da88f4601dc99f2b9: Bug 1498181 - Initial methods for handling result selection in the new address bar architecture. r=dao
Mark Banner <standard8@mozilla.com> - Fri, 12 Oct 2018 16:13:42 +0000 - rev 499350
Push 1864 by ffxbld-merge at Mon, 03 Dec 2018 15:51:40 +0000
Bug 1498181 - Initial methods for handling result selection in the new address bar architecture. r=dao The intent here is that the input/view deal with the handling of clicks/pressing enter, and the controller only deals with opening the required item. Differential Revision: https://phabricator.services.mozilla.com/D8382
e7f9ba7e8ac2707c9ad1caf569ad134635caec1e: Bug 821610 - Update thread-client to work with xhr breakpoints
Annshul Malik <malikanshul29@gmail.com> - Fri, 12 Oct 2018 14:57:03 +0000 - rev 499349
Push 1864 by ffxbld-merge at Mon, 03 Dec 2018 15:51:40 +0000
Bug 821610 - Update thread-client to work with xhr breakpoints Differential Revision: https://phabricator.services.mozilla.com/D8544
11fb0d6e940adb9c0a1efd00915eff74c5b4ae46: Bug 1498571 - Cleanup FontPropertyTypes. r=jwatt
Emilio Cobos Álvarez <emilio@crisal.io> - Fri, 12 Oct 2018 14:20:23 +0000 - rev 499348
Push 1864 by ffxbld-merge at Mon, 03 Dec 2018 15:51:40 +0000
Bug 1498571 - Cleanup FontPropertyTypes. r=jwatt Now that they can be constexpr, do that. Also, make default constructors initialize to the minimum value, now that we no longer need to use the default due to nsCSSValue. Differential Revision: https://phabricator.services.mozilla.com/D7757
e2bb81a7129763535fea3400a10df096fc801323: No bug: [mozharness] Remove unreferenced `base_name` setting; r=jlund
Tom Prince <mozilla@hocat.ca> - Fri, 12 Oct 2018 16:31:55 +0000 - rev 499347
Push 1864 by ffxbld-merge at Mon, 03 Dec 2018 15:51:40 +0000
No bug: [mozharness] Remove unreferenced `base_name` setting; r=jlund Differential Revision: https://phabricator.services.mozilla.com/D8420
b8b9cf480f4129f09ed07718e2dce0117783e634: Bug 1479575 - Merge reset region pref patch for consistency r=Gijs
Michael Kaply <mozilla@kaply.com> - Fri, 12 Oct 2018 16:19:41 +0000 - rev 499346
Push 1864 by ffxbld-merge at Mon, 03 Dec 2018 15:51:40 +0000
Bug 1479575 - Merge reset region pref patch for consistency r=Gijs Differential Revision: https://phabricator.services.mozilla.com/D8572
a471f63471541d373a70dbc4676dd0249122e187: Bug 1498608 - Add js/src/builtin/intl/TimeZoneDataGenerated.h to .clang-format-ignore r=andi
Sylvestre Ledru <sledru@mozilla.com> - Fri, 12 Oct 2018 16:16:01 +0000 - rev 499345
Push 1864 by ffxbld-merge at Mon, 03 Dec 2018 15:51:40 +0000
Bug 1498608 - Add js/src/builtin/intl/TimeZoneDataGenerated.h to .clang-format-ignore r=andi Differential Revision: https://phabricator.services.mozilla.com/D8560
b2ddfd6799978bd4b8bd2d2c92079d14099a0ac3: Bug 1485441 - Don't enable robust buffer access on Adreno 630 devices r=jgilbert
Jamie Nicol <jnicol@mozilla.com> - Fri, 12 Oct 2018 15:57:32 +0000 - rev 499344
Push 1864 by ffxbld-merge at Mon, 03 Dec 2018 15:51:40 +0000
Bug 1485441 - Don't enable robust buffer access on Adreno 630 devices r=jgilbert It was causing the linking of some shaders to fail. Differential Revision: https://phabricator.services.mozilla.com/D8207
e9e765c5d7f7ec8b357f7c120aa153d1b5d18dfc: Backed out changeset 94ccc53c61a7 (bug 1488375) for test_memory_allocations_0x.html failures CLOSED TREE
Bogdan Tara <btara@mozilla.com> - Fri, 12 Oct 2018 19:18:18 +0300 - rev 499343
Push 1864 by ffxbld-merge at Mon, 03 Dec 2018 15:51:40 +0000
Backed out changeset 94ccc53c61a7 (bug 1488375) for test_memory_allocations_0x.html failures CLOSED TREE
88e822bc1ea5802357ddb7b68b3d1f2254ebfa67: Backed out changeset 5b5ed02f86c7 (bug 1498487) for browser_all_files_referenced.js failures CLOSED TREE
Bogdan Tara <btara@mozilla.com> - Fri, 12 Oct 2018 19:13:10 +0300 - rev 499342
Push 1864 by ffxbld-merge at Mon, 03 Dec 2018 15:51:40 +0000
Backed out changeset 5b5ed02f86c7 (bug 1498487) for browser_all_files_referenced.js failures CLOSED TREE
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 tip