f0ac391dd02a4296a724462cdfa3c89cc8e39a00: Bug 1557338 - Fix up TestSprintfLiteral.cpp for warnings on clang trunk r=andi
David Major <dmajor@mozilla.com> - Mon, 01 Jul 2019 21:37:44 +0000 - rev 543682
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1557338 - Fix up TestSprintfLiteral.cpp for warnings on clang trunk r=andi LLVM r356397 added some new warnings to the compiler that in this file complain about `size argument is too large; destination buffer has size 100, but size argument is 101`. The easiest path is to just remove those lines; doing so doesn't really weaken the test coverage of the SprintfLiteral checker. Differential Revision: https://phabricator.services.mozilla.com/D36515
358e1d1cc617c4cd801df3b8a1f756bd11bf3e4a: Bug 1553433 - Use the system theme's colors for the installer wizard welcome/finish pages. r=agashlin
Matt Howell <mhowell@mozilla.com> - Mon, 01 Jul 2019 22:02:31 +0000 - rev 543681
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1553433 - Use the system theme's colors for the installer wizard welcome/finish pages. r=agashlin We can use MUI_BGCOLOR to change the background color, but there's no way to globally override the text color, so we additionally need to set that on every affected control in the Show functions (we have to wait until Show because that's the earliest point that the controls have been created and we can get handles to them). This patch fixes both the full installer and the uninstaller. Differential Revision: https://phabricator.services.mozilla.com/D33189
ed65b4d20a8969f6b6d9789270fe574a36793bff: Backed out changeset 23973e3a5e95 (bug 1557338) for causing bustages on OS X Cross Compiled. CLOSED TREE
Mihai Alexandru Michis <malexandru@mozilla.com> - Tue, 02 Jul 2019 00:30:06 +0300 - rev 543680
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Backed out changeset 23973e3a5e95 (bug 1557338) for causing bustages on OS X Cross Compiled. CLOSED TREE
f05db6efaf095958ba67ffcd7d77d2a29497edb8: Bug 1560119: Remove DOMMatrix scaleNonUniformSelf() r=bzbarsky
Kagami Sascha Rosylight <saschanaz@outlook.com> - Mon, 01 Jul 2019 21:07:20 +0000 - rev 543679
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1560119: Remove DOMMatrix scaleNonUniformSelf() r=bzbarsky We probably just can remove it given that no other implementations are there. Differential Revision: https://phabricator.services.mozilla.com/D36491
9bc355a1aea3bdfdc04bc6c14a657b5e6aa6a972: Bug 1562725 - export UPLOAD_PATH in run-profileserver.sh; r=firefox-build-system-reviewers,chmanchester
Mike Shal <mshal@mozilla.com> - Mon, 01 Jul 2019 20:32:35 +0000 - rev 543678
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1562725 - export UPLOAD_PATH in run-profileserver.sh; r=firefox-build-system-reviewers,chmanchester When adding Windows compatibility in bug 1557785, we stopped exported UPLOAD_PATH by default. UPLOAD_PATH is used by profileserver.py to determine where to store the logs; when it is unset, the logs go to stdout and the artifacts aren't created. We should always export UPLOAD_PATH to get the same logging behavior on all platforms. Differential Revision: https://phabricator.services.mozilla.com/D36521
f4f0c43a164e10feb3a0374b4296e85ba3f57b55: Bug 1562258 - Disable tests on instrumented builds; r=froydnj
Mike Shal <mshal@mozilla.com> - Mon, 01 Jul 2019 20:09:48 +0000 - rev 543677
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1562258 - Disable tests on instrumented builds; r=froydnj We don't run any tests on these builds, since they are just used to generate the profile data for the final build. We can save some time by skipping all test related code. Differential Revision: https://phabricator.services.mozilla.com/D36511
78d99b96c1045f89d3833b12bd7516d53f1efc29: Bug 1561288 - Don't override currentContent when focusing something on a shadow root. r=smaug
Emilio Cobos Álvarez <emilio@crisal.io> - Mon, 01 Jul 2019 20:04:07 +0000 - rev 543676
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1561288 - Don't override currentContent when focusing something on a shadow root. r=smaug It is wrong, what we're trying to focus is frame->GetContent() still. This is not reproducible outside of Thunderbird because for it to happen the focus manager needs to wrap around the start content. Here's what's going on: * We start with a <tree> focused, which is a shadow host. * There's nothing else to focus inside the <tree>, or after the <tree> in document order. * So we restart the search with a different tabindex (1), but find nothing before the tree (since all focusable elements before the tree also have tabindex 0), and we return wrongly in [1], instead of searching with tabindex 0 again afterwards. (Since the child frame is not focusable, we wrongly end up at [1], and returning early, since currentContent != frame->GetContent(), instead of keeping looking for the right thing to focus.) As I said this cannot reproduce on content, as far as I can tell, so I'm not sure how to go about testing this, but all the shadow dom tab navigation tests keep passing with this change. [1]: https://searchfox.org/mozilla-central/rev/06bd14ced96f25ff1dbd5352cb985fc0fa12a64e/dom/base/nsFocusManager.cpp#3560 Differential Revision: https://phabricator.services.mozilla.com/D36196
00eaa63cc4d71de171c083df48bde2c1d32a6cd7: Bug 1557781 - Better life-time management for BodyStream/FetchStream - part 3 - JS::ReadableStreamReleaseCCObject, r=jorendorff
Andrea Marchesini <amarchesini@mozilla.com> - Mon, 01 Jul 2019 20:01:17 +0000 - rev 543675
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1557781 - Better life-time management for BodyStream/FetchStream - part 3 - JS::ReadableStreamReleaseCCObject, r=jorendorff Differential Revision: https://phabricator.services.mozilla.com/D36466
ea96413122a8329ccb00eacc31416354c854b7b0: Bug 1557781 - Better life-time management for BodyStream/FetchStream - part 2 - BodyStream, r=smaug
Andrea Marchesini <amarchesini@mozilla.com> - Mon, 01 Jul 2019 20:01:17 +0000 - rev 543674
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1557781 - Better life-time management for BodyStream/FetchStream - part 2 - BodyStream, r=smaug Differential Revision: https://phabricator.services.mozilla.com/D35529
b43fac4ccd1dfd19f30d5d8ac74d0c622a9f1521: Bug 1557781 - Better life-time management for BodyStream/FetchStream - part 1 - JSCLASS_PRIVATE_IS_NSISUPPORTS, r=jonco,jorendorff
Andrea Marchesini <amarchesini@mozilla.com> - Mon, 01 Jul 2019 19:59:33 +0000 - rev 543673
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1557781 - Better life-time management for BodyStream/FetchStream - part 1 - JSCLASS_PRIVATE_IS_NSISUPPORTS, r=jonco,jorendorff Differential Revision: https://phabricator.services.mozilla.com/D35528
2db482852bec317c0a2d270f178821095f4e3163: Bug 1497204: Apply Meta CSP to about:profiles. r=Gijs
Christoph Kerschbaumer <ckerschb@christophkerschbaumer.com> - Mon, 01 Jul 2019 19:47:16 +0000 - rev 543672
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1497204: Apply Meta CSP to about:profiles. r=Gijs Differential Revision: https://phabricator.services.mozilla.com/D36520
4f8400c7d8e57315fa2afb1636344c0dd7ffd2fd: Bug 1561570 - Ensure the BrowserChild is updated with the new chrome offset after fullscreen changes happen. r=rhunt
Kartikaya Gupta <kgupta@mozilla.com> - Mon, 01 Jul 2019 18:27:55 +0000 - rev 543671
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1561570 - Ensure the BrowserChild is updated with the new chrome offset after fullscreen changes happen. r=rhunt Apparently the GetChromeOffset() in BrowserChild becomes stale after exiting fullscreen, but it's not clear to me what is supposed to keep it updated. So this patch adds a fullscreenchange event listener that updates it. If we encounter other scenarios where this happens maybe we can find a better way to do this but without more knowledge of the scenarios this is the best option I have. Differential Revision: https://phabricator.services.mozilla.com/D36080
0d31da2473ba3a3785068d7c0c42cade6dfabd09: Bug 1553537 Part 2 - Port the InetBgDL plugin to Visual Studio 2019. r=agashlin
Matt Howell <mhowell@mozilla.com> - Tue, 25 Jun 2019 00:34:13 +0000 - rev 543670
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1553537 Part 2 - Port the InetBgDL plugin to Visual Studio 2019. r=agashlin Depends on D33844 Differential Revision: https://phabricator.services.mozilla.com/D33845
73734fe2f3ffc7050043caf01920987ca0a5f420: Bug 1554189 - Disabled org.mozilla.geckoview.test.MediaDelegateTest.testDeviceRecordingEventAudioAndVideo on debug builds. r=gbrown
Csoregi Natalia <ncsoregi@mozilla.com> - Sat, 29 Jun 2019 16:08:51 +0000 - rev 543669
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1554189 - Disabled org.mozilla.geckoview.test.MediaDelegateTest.testDeviceRecordingEventAudioAndVideo on debug builds. r=gbrown Differential Revision: https://phabricator.services.mozilla.com/D35158
23973e3a5e9503919dbf529d531ac1212cf4641a: Bug 1557338 - Fix up TestSprintfLiteral.cpp for warnings on clang trunk r=andi
David Major <dmajor@mozilla.com> - Mon, 01 Jul 2019 18:32:34 +0000 - rev 543668
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1557338 - Fix up TestSprintfLiteral.cpp for warnings on clang trunk r=andi LLVM r356397 added some new warnings to the compiler that in this file complain about `size argument is too large; destination buffer has size 100, but size argument is 101`. The easiest path is to just remove those lines; doing so doesn't really weaken the test coverage of the SprintfLiteral checker. Differential Revision: https://phabricator.services.mozilla.com/D36515
0b887601d2150c2827c0e24700aed45f2be89ded: Backed out changeset 61a027216c5e (bug 1560299) for presentation api failures on a CLOSED TREE.
Gurzau Raul <rgurzau@mozilla.com> - Mon, 01 Jul 2019 21:48:43 +0300 - rev 543667
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Backed out changeset 61a027216c5e (bug 1560299) for presentation api failures on a CLOSED TREE.
98db541275e5d242f5c5d3fff6ccacbfb5716481: Bug 1553537 Part 1 - Close our WinInet handles before terminating the file transfer thread. r=agashlin
Matt Howell <mhowell@mozilla.com> - Mon, 01 Jul 2019 18:30:25 +0000 - rev 543666
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1553537 Part 1 - Close our WinInet handles before terminating the file transfer thread. r=agashlin Also reduce the timeout for terminating the thread to 5 seconds, because 10 seconds is too long to be completely hanging the UI. Differential Revision: https://phabricator.services.mozilla.com/D33844
8d6b6b345e249a49802444da28119c111621786d: Bug 1561002 - Use buildingRect for remote browser clipping when we don't have anything more precise. r=mattwoodrow
Ryan Hunt <rhunt@eqrion.net> - Wed, 26 Jun 2019 02:50:36 +0000 - rev 543665
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1561002 - Use buildingRect for remote browser clipping when we don't have anything more precise. r=mattwoodrow Differential Revision: https://phabricator.services.mozilla.com/D35677
832c35afa350fdad83140fa71d46de9609991e79: Bug 1544452 - Increase slack boundaries for ExpirationTracker gtest r=froydnj
Kristen Wright <kwright@mozilla.com> - Mon, 01 Jul 2019 18:08:25 +0000 - rev 543664
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1544452 - Increase slack boundaries for ExpirationTracker gtest r=froydnj Increased slack boundaries to account for issues with timer bounds in macos 1014. Lower bound slack = 60ms and upper bound slack = 1200ms. The intent is to get gtests working in the short term while timer delays are fixed, then roll the slack boundary back to 30ms. Differential Revision: https://phabricator.services.mozilla.com/D36419
24e366d72108f284984da25a27be95738fa3f3a5: Bug 1558602 - Allow DocumentL10n to use LocalizationSync. r=smaug,Pike
Zibi Braniecki <zbraniecki@mozilla.com> - Mon, 01 Jul 2019 17:56:57 +0000 - rev 543663
Push 2131 by ffxbld-merge at Mon, 26 Aug 2019 18:30:20 +0000
Bug 1558602 - Allow DocumentL10n to use LocalizationSync. r=smaug,Pike Differential Revision: https://phabricator.services.mozilla.com/D34584
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 tip