e11d6ca7abe7416d5cead0c104b77a9b106f6363: servo: Merge #19350 - Ignore aborted responses in caching (from gterzian:ignore_aborted_responses_in_caching); r=jdm
Gregory Terzian <gterzian@users.noreply.github.com> - Tue, 23 Jan 2018 14:47:16 -0600 - rev 455463
Push 1683 by sfraser@mozilla.com at Thu, 26 Apr 2018 16:43:40 +0000
servo: Merge #19350 - Ignore aborted responses in caching (from gterzian:ignore_aborted_responses_in_caching); r=jdm <!-- Please describe your changes on the following line: --> @jdm @KiChjang @Manishearth Follow up on https://github.com/servo/servo/pull/18676 and https://github.com/servo/servo/pull/19274 to ignore aborted responses in caching. I also found out the cache shouldn't return any response whose body is still in `ResponseBody::Receiving` mode, because that fails the assertion at https://github.com/servo/servo/blob/master/components/net/fetch/methods.rs#L438(we might want to add a channel as pat of the cached response later on to deal with this case). I only found out now because I needed the response from the server to trickle in so that it could be cached and aborted. I copied the `http-cache.py` server from the wpt folder, and added a 'trickle' option, which is necessary to actually have a failing test with a cached but aborted request, it's now passing. I also remove one unused import that slippled through previously. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [ ] `./mach build -d` does not report any errors - [ ] `./mach test-tidy` does not report any errors - [ ] These changes fix #__ (github issue number if applicable). <!-- Either: --> - [ ] There are tests for these changes OR - [ ] These changes do not require tests because _____ <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> Source-Repo: https://github.com/servo/servo Source-Revision: 4307b6e67b0cb35e2afc46ba0b64e7bc5bde1bdf
d1484bf37d1ed02e27e264a75f61b70ef7a100bc: Bug 1432576 - Remove B2G shared global isms from Promise.jsm. r=Gijs
Andrew McCreight <continuation@gmail.com> - Tue, 23 Jan 2018 10:14:24 -0800 - rev 455462
Push 1683 by sfraser@mozilla.com at Thu, 26 Apr 2018 16:43:40 +0000
Bug 1432576 - Remove B2G shared global isms from Promise.jsm. r=Gijs B2G used to do shared globals in a weird way which required this, but that is no longer used. MozReview-Commit-ID: DKnNYW5XP1N
96f1c52398fd0b0bb920d75c0fdbcb149711bd28: Bug 1432463 - Fix clang-tidy warnings by replacing some 0 with nullptr. r=botond
Kartikaya Gupta <kgupta@mozilla.com> - Tue, 23 Jan 2018 08:33:52 -0500 - rev 455461
Push 1683 by sfraser@mozilla.com at Thu, 26 Apr 2018 16:43:40 +0000
Bug 1432463 - Fix clang-tidy warnings by replacing some 0 with nullptr. r=botond MozReview-Commit-ID: B8YguXD5Ybu
ed390edef55a3d6ad1469ffdbf2e01fbb6779770: Bug 1408361 - Add ellipsis when truncating received tab URI for display. r=eoger
Thom Chiovoloni <tchiovoloni@mozilla.com> - Tue, 16 Jan 2018 12:57:36 -0500 - rev 455460
Push 1683 by sfraser@mozilla.com at Thu, 26 Apr 2018 16:43:40 +0000
Bug 1408361 - Add ellipsis when truncating received tab URI for display. r=eoger MozReview-Commit-ID: 4PVX5J59kpM
810d9381f0b0c664d97e77d516d16705ff6dd818: servo: Merge #19843 - Added default fall-back when CARGO_HOME is not set for clean-cargo-cache (from terracotaPie:master); r=jdm
Timur Borkhodoev <timur.borkhodoev@mail.utoronto.ca> - Tue, 23 Jan 2018 13:28:35 -0600 - rev 455459
Push 1683 by sfraser@mozilla.com at Thu, 26 Apr 2018 16:43:40 +0000
servo: Merge #19843 - Added default fall-back when CARGO_HOME is not set for clean-cargo-cache (from terracotaPie:master); r=jdm Added default fall-back when CARGO_HOME is not set. --- - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #19823 (github issue number if applicable). Source-Repo: https://github.com/servo/servo Source-Revision: 06aa339a1bf578d90f4c5a88877b579b67f33a56
6026ed8be2674a90a5a583ac546f4aceee9ac202: Bug 1432517 Add shellcheck support for mach lint r=ahal
Simon Fraser <sfraser@mozilla.com> - Tue, 23 Jan 2018 16:32:04 +0000 - rev 455458
Push 1683 by sfraser@mozilla.com at Thu, 26 Apr 2018 16:43:40 +0000
Bug 1432517 Add shellcheck support for mach lint r=ahal MozReview-Commit-ID: 1Mzg6y3JKbn
e8d981d2ce37ecf6f34909ed3bd76dd536012ef3: Backed out changeset b764ca8d82da (bug 1429824) for failing browser chrome devtools at devtools/client/netmonitor/test/browser_net_autoscroll.js on a CLOSED TREE
Andreea Pavel <apavel@mozilla.com> - Tue, 23 Jan 2018 22:34:51 +0200 - rev 455457
Push 1683 by sfraser@mozilla.com at Thu, 26 Apr 2018 16:43:40 +0000
Backed out changeset b764ca8d82da (bug 1429824) for failing browser chrome devtools at devtools/client/netmonitor/test/browser_net_autoscroll.js on a CLOSED TREE
7f41dd3bbc2d25f937fa24a54612c25bc839f5ab: Bug 1419581 - Part 6: Add Android build configuration --without-google-play-services. r=dustin
Nick Alexander <nalexander@mozilla.com> - Thu, 04 Jan 2018 15:45:56 -0800 - rev 455456
Push 1683 by sfraser@mozilla.com at Thu, 26 Apr 2018 16:43:40 +0000
Bug 1419581 - Part 6: Add Android build configuration --without-google-play-services. r=dustin MozReview-Commit-ID: 526BCiQwlm6
d4d42899e5cd4255df3bfb4332532936e42ebf43: Bug 1419581 - Part 5: Add --without-google-play-services. r=chmanchester
Nick Alexander <nalexander@mozilla.com> - Thu, 04 Jan 2018 15:37:15 -0800 - rev 455455
Push 1683 by sfraser@mozilla.com at Thu, 26 Apr 2018 16:43:40 +0000
Bug 1419581 - Part 5: Add --without-google-play-services. r=chmanchester Historically, we used MOZ_NATIVE_DEVICES to proxy for Google Play Services. (MOZ_NATIVE_DEVICES was the first GPS-consuming feature in Fennec.) With Python moz.configure, we can easily add the real top-level flag that distributions like F-Droid actually want, which is to build without (non-free) Google Play Services entirely. MozReview-Commit-ID: 7YJKw3G1lQA
78828bf781d737b03c249de3dd41dc9edec788fc: Bug 1419581 - Part 4: Allow setting MOZ_ANDROID_GCM in mozconfig. r=chmanchester
Nick Alexander <nalexander@mozilla.com> - Wed, 22 Nov 2017 09:48:02 -0800 - rev 455454
Push 1683 by sfraser@mozilla.com at Thu, 26 Apr 2018 16:43:40 +0000
Bug 1419581 - Part 4: Allow setting MOZ_ANDROID_GCM in mozconfig. r=chmanchester This also verifies that we have Google Play Services (via MOZ_NATIVE_DEVICES=1) if we ask to build with GCM. This was just an oversight earlier. MozReview-Commit-ID: BvJi7Sfo4pu
5224db0c36aa41d3a333875b29c9048e25eca651: Bug 1419581 - Part 3: Guard PresentationMediaPlayer windows with MOZ_NATIVE_DEVICES. r=jchen
Nick Alexander <nalexander@mozilla.com> - Fri, 05 Jan 2018 11:35:00 -0800 - rev 455453
Push 1683 by sfraser@mozilla.com at Thu, 26 Apr 2018 16:43:40 +0000
Bug 1419581 - Part 3: Guard PresentationMediaPlayer windows with MOZ_NATIVE_DEVICES. r=jchen MozReview-Commit-ID: 3ZlVUMufn2g
072108d165905e8e6dfdc6720512b6610e30cd68: Bug 1419581 - Part 2: Guard media Fennec JNI primitives with MOZ_NATIVE_DEVICES. r=jchen
Nick Alexander <nalexander@mozilla.com> - Wed, 06 Dec 2017 20:28:04 -0800 - rev 455452
Push 1683 by sfraser@mozilla.com at Thu, 26 Apr 2018 16:43:40 +0000
Bug 1419581 - Part 2: Guard media Fennec JNI primitives with MOZ_NATIVE_DEVICES. r=jchen MozReview-Commit-ID: 3NWZ6BL5Tlr
f8b3e95f18e4082ab8404187508d09eadba8612e: Bug 1419581 - Part 1: Simplify MMA GCM sender IDs logic. r=nechen
Tad <tad@spotco.us> - Fri, 12 Jan 2018 15:03:37 -0800 - rev 455451
Push 1683 by sfraser@mozilla.com at Thu, 26 Apr 2018 16:43:40 +0000
Bug 1419581 - Part 1: Simplify MMA GCM sender IDs logic. r=nechen Right now, the MMA glue is built into constants.jar. constants.jar is the home of preprocessed Java code; it's built very early in the build process and intended to be a tiny kernel of shared definitions. The fact that the MMA glue has to live there is just a sad consequence of the non-Gradle build system, which makes dependency injection difficult. Unfortunately, another consequence is that it's not possible to move reference org.mozilla.gecko.{gcm,push} in the MMA glue, because those packages are built after constants.jar. Instead, this patch lifts some of the logic into AppConstants, which is part of constants.jar. We had grown a twisty maze of indirection around the GCM sender IDs and it just wasn't necessary; this just lifts the static pieces up a level and removes a bunch of interface indirection. What surprises me is that asking Google's InstanceId.getToken for a GCM token with a "comma,separated,list" of GCM sender IDs works -- and indeed, has worked since we added the second MMA sender ID. I didn't expect that and can't explain it, but this doesn't change that logic and local testing (both of the existing APKs, and APKs with this modification) looks good. MozReview-Commit-ID: 3hObfAwNlPH *** a0c07e53 o draft Bug 1419581 - Part 1: Move MMA setGcmSenderID from MmaDelegate to MmaLeanplumImp. r=nechen MozReview-Commit-ID: A4hrk6pVqGW
5f7645a19bf1ff9aa822314135f8e702f57b3771: Bug 1419581 - Pre: Add missing excludes when building without MOZ_NATIVE_DEVICES. r=nalexander
Nick Alexander <nalexander@mozilla.com> - Thu, 04 Jan 2018 14:49:58 -0800 - rev 455450
Push 1683 by sfraser@mozilla.com at Thu, 26 Apr 2018 16:43:40 +0000
Bug 1419581 - Pre: Add missing excludes when building without MOZ_NATIVE_DEVICES. r=nalexander MozReview-Commit-ID: BXNFBEs2017
f5fe81e72056ad5c024a059570ac09db474894d6: Bug 1389829 - Part 4 - Add simple Robocop test for View Page Source. r=nechen
Jan Henning <jh+bugzilla@buttercookie.de> - Sat, 13 Jan 2018 21:10:45 +0100 - rev 455449
Push 1683 by sfraser@mozilla.com at Thu, 26 Apr 2018 16:43:40 +0000
Bug 1389829 - Part 4 - Add simple Robocop test for View Page Source. r=nechen MozReview-Commit-ID: DFC17YSSinx
64116410472893571e34abbfe2c50b7b5cc68b9a: Bug 1389829 - Part 3 - Handle "View Page Source" on the JS side. r=esawin
Jan Henning <jh+bugzilla@buttercookie.de> - Sun, 13 Aug 2017 18:28:50 +0200 - rev 455448
Push 1683 by sfraser@mozilla.com at Thu, 26 Apr 2018 16:43:40 +0000
Bug 1389829 - Part 3 - Handle "View Page Source" on the JS side. r=esawin MozReview-Commit-ID: AOmTcNQ7qlj
cfc307ae9cc7100e63374d7ad38f2c6802847058: Bug 1389829 - Part 2 - Make files needed for View Source available for Fennec. r=esawin
Jan Henning <jh+bugzilla@buttercookie.de> - Sat, 13 Jan 2018 17:46:29 +0100 - rev 455447
Push 1683 by sfraser@mozilla.com at Thu, 26 Apr 2018 16:43:40 +0000
Bug 1389829 - Part 2 - Make files needed for View Source available for Fennec. r=esawin viewPartialSource.js/xul and viewSource.css/js/xul are only required for opening the source in a new, special window. On Android we'll always use a new tab instead, so we don't have to include them there. MozReview-Commit-ID: LjX1WKELjqz
d9e0b22fd920e4cf5ae82ea5dfaeb005721bfc22: Bug 1389829 - Part 1 - Add "View Page Source" to the Page menu in the UI. r=nechen
Jan Henning <jh+bugzilla@buttercookie.de> - Sun, 13 Aug 2017 16:15:26 +0200 - rev 455446
Push 1683 by sfraser@mozilla.com at Thu, 26 Apr 2018 16:43:40 +0000
Bug 1389829 - Part 1 - Add "View Page Source" to the Page menu in the UI. r=nechen The Page menu is disabled when no tab is open, so not doing a null-check on the currently selected tab in the menu click handler is safe. MozReview-Commit-ID: CYKHJ5N1q8I
90b986308ba8f756b5062cd8750a9eb894b9920b: servo: Merge #19838 - Make ToCss' SequenceWriter not monomorphise like a maniac anymore (from servo:rm-sequence-writer-as-it-was); r=emilio
Anthony Ramine <n.oxyde@gmail.com> - Tue, 23 Jan 2018 12:03:41 -0600 - rev 455445
Push 1683 by sfraser@mozilla.com at Thu, 26 Apr 2018 16:43:40 +0000
servo: Merge #19838 - Make ToCss' SequenceWriter not monomorphise like a maniac anymore (from servo:rm-sequence-writer-as-it-was); r=emilio Source-Repo: https://github.com/servo/servo Source-Revision: 6b2e5283c9e810ac316c203849b6ea25544a62c7
f84c3854510ee367372477abbd331a9c74bc0ea1: Backed out changeset 994e33a96d17 (bug 1428530) for build bustage at z:\build\build\src\intl\locale\locale.h on a CLOSED TREE
Andreea Pavel <apavel@mozilla.com> - Tue, 23 Jan 2018 20:43:43 +0200 - rev 455444
Push 1683 by sfraser@mozilla.com at Thu, 26 Apr 2018 16:43:40 +0000
Backed out changeset 994e33a96d17 (bug 1428530) for build bustage at z:\build\build\src\intl\locale\locale.h on a CLOSED TREE
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 tip