c53c961ce40713f348b443b4517179b0c6c96f93: Bug 1399111 - Keep the loading indicator gray for tabs that have been unselected since load. r=Gijs, a=sledru
Jared Wein <jwein@mozilla.com> - Thu, 28 Sep 2017 14:45:29 -0400 - rev 434458
Push 1567 by jlorenzo@mozilla.com at Thu, 02 Nov 2017 12:36:05 +0000
Bug 1399111 - Keep the loading indicator gray for tabs that have been unselected since load. r=Gijs, a=sledru MozReview-Commit-ID: JPEy3XDsGmb
66cc570df716f149096f16a8f8f5cbaafa659dc1: Bug 1399111 - Tabs that start loading in the background and haven't been selected before completing loading will show a lighter tab burst. r=Gijs, a=sledru
Jared Wein <jwein@mozilla.com> - Wed, 27 Sep 2017 14:34:29 -0400 - rev 434457
Push 1567 by jlorenzo@mozilla.com at Thu, 02 Nov 2017 12:36:05 +0000
Bug 1399111 - Tabs that start loading in the background and haven't been selected before completing loading will show a lighter tab burst. r=Gijs, a=sledru MozReview-Commit-ID: FdXwaQr7Glt
154153211b83353c8c5ff7fe11b653cad7fc2292: Bug 1403293 - Add a test. r=kats, a=sledru
Boris Zbarsky <bzbarsky@mit.edu> - Fri, 29 Sep 2017 08:51:40 -0400 - rev 434456
Push 1567 by jlorenzo@mozilla.com at Thu, 02 Nov 2017 12:36:05 +0000
Bug 1403293 - Add a test. r=kats, a=sledru MozReview-Commit-ID: GyWZGiT6xeG
282e28b451d508e2c58e4f7592ca0a5dc0f3f7e5: Bug 1403293 - Make sure that anonymous table columns and column groups never affect hit testing. r=heycam, a=sledru
Boris Zbarsky <bzbarsky@mit.edu> - Thu, 28 Sep 2017 22:03:54 -0400 - rev 434455
Push 1567 by jlorenzo@mozilla.com at Thu, 02 Nov 2017 12:36:05 +0000
Bug 1403293 - Make sure that anonymous table columns and column groups never affect hit testing. r=heycam, a=sledru Per spec, these boxes shouldn't even exist. MozReview-Commit-ID: 9tQdqSgXg76
55da6c78301249430edcbc84ed0a739eb06af788: Bug 1404036 - Display window titles in non-default themes when titlebars are showing on macOS. r=mstange, a=sledru
Stephen A Pohl <spohl.mozilla.bugs@gmail.com> - Thu, 28 Sep 2017 14:01:17 -0400 - rev 434454
Push 1567 by jlorenzo@mozilla.com at Thu, 02 Nov 2017 12:36:05 +0000
Bug 1404036 - Display window titles in non-default themes when titlebars are showing on macOS. r=mstange, a=sledru
675fb0ab7887e791f3b64d02c27c946c2861e3d3: Bug 1403875 - Add missing fill and fill-opacity attributes to bookmarks-toolbar.svg. r=dao, a=sledru
Towkir Ahmed <towkir17@gmail.com> - Thu, 28 Sep 2017 12:44:18 +0200 - rev 434453
Push 1567 by jlorenzo@mozilla.com at Thu, 02 Nov 2017 12:36:05 +0000
Bug 1403875 - Add missing fill and fill-opacity attributes to bookmarks-toolbar.svg. r=dao, a=sledru MozReview-Commit-ID: IHqDu1ceNTV
abbc7bcb54e365d56c0abd70cbb7c48f97ddb08a: Bug 1403202 - Update macOS DMG Backgrounds for label reability. r=dolske, a=sledru
Stephen Horlander <shorlander@mozilla.com> - Wed, 27 Sep 2017 21:08:14 -0700 - rev 434452
Push 1567 by jlorenzo@mozilla.com at Thu, 02 Nov 2017 12:36:05 +0000
Bug 1403202 - Update macOS DMG Backgrounds for label reability. r=dolske, a=sledru
8d89adbab6e645c5a8725da163ebe7c47f67d4ec: Bug 1402740 - Position modal sheets correctly on macOS now that titlebars are being hidden by bug 1401297. r=mstange, a=sledru
Stephen A Pohl <spohl.mozilla.bugs@gmail.com> - Thu, 28 Sep 2017 14:01:10 -0400 - rev 434451
Push 1567 by jlorenzo@mozilla.com at Thu, 02 Nov 2017 12:36:05 +0000
Bug 1402740 - Position modal sheets correctly on macOS now that titlebars are being hidden by bug 1401297. r=mstange, a=sledru
d1bb539f6325eb1f58d819316e9b99e46b1eaccc: Bug 1403962 - Add JS test for FillWithUndefined special-case. r=anba, a=test-only
Christian Holler <choller@mozilla.com> - Thu, 28 Sep 2017 17:11:58 +0200 - rev 434450
Push 1567 by jlorenzo@mozilla.com at Thu, 02 Nov 2017 12:36:05 +0000
Bug 1403962 - Add JS test for FillWithUndefined special-case. r=anba, a=test-only MozReview-Commit-ID: FBa8qw3kUSU
6cbe936e07c21d7920976a10c764fcb9bd9b574c: Bug 1403023 - Set mSentCommitOrAbort to true when HoldWorker call fails to silence the destructor assertion (this is a followup fix for bug 1399322). r=asuth, a=debug-only
Jan Varga <jan.varga@gmail.com> - Fri, 29 Sep 2017 08:48:47 +0200 - rev 434449
Push 1567 by jlorenzo@mozilla.com at Thu, 02 Nov 2017 12:36:05 +0000
Bug 1403023 - Set mSentCommitOrAbort to true when HoldWorker call fails to silence the destructor assertion (this is a followup fix for bug 1399322). r=asuth, a=debug-only
0b50c7250aa635957c72a9e49eddc8b7cd65cdf6: Bug 1402503 - Part 2: Add test for extension slow script dialog. r=mixedpuppy, a=sledru
Kris Maglione <maglione.k@gmail.com> - Wed, 27 Sep 2017 20:44:30 -0700 - rev 434448
Push 1567 by jlorenzo@mozilla.com at Thu, 02 Nov 2017 12:36:05 +0000
Bug 1402503 - Part 2: Add test for extension slow script dialog. r=mixedpuppy, a=sledru MozReview-Commit-ID: BknBhAttKHS
41942dc5a92f1fef3f2f8ec78bafb5d9a87b1951: Bug 1402503 - Part 1: Fix slow script add-on ID detection. r=mixedpuppy, a=sledru
Kris Maglione <maglione.k@gmail.com> - Mon, 25 Sep 2017 10:52:11 -0700 - rev 434447
Push 1567 by jlorenzo@mozilla.com at Thu, 02 Nov 2017 12:36:05 +0000
Bug 1402503 - Part 1: Fix slow script add-on ID detection. r=mixedpuppy, a=sledru MozReview-Commit-ID: EYhOn2TQCq1
9bd05768af69c88d44b84ffcaa9a2644d9a0a6ec: Bug 1403945 - Add utility functions to recognize OS X 10.13. r=mstange, a=sledru
Milan Sreckovic <milan@mozilla.com> - Thu, 28 Sep 2017 10:21:10 -0400 - rev 434446
Push 1567 by jlorenzo@mozilla.com at Thu, 02 Nov 2017 12:36:05 +0000
Bug 1403945 - Add utility functions to recognize OS X 10.13. r=mstange, a=sledru MozReview-Commit-ID: Bw0jkyWrIzD
0460ea0333f964f3ff09093260dc648933f43e67: Bug 1403853 - Hide the menu button separator in popup windows. r=nhnt11, a=sledru
Dão Gottwald <dao@mozilla.com> - Thu, 28 Sep 2017 10:19:23 +0200 - rev 434445
Push 1567 by jlorenzo@mozilla.com at Thu, 02 Nov 2017 12:36:05 +0000
Bug 1403853 - Hide the menu button separator in popup windows. r=nhnt11, a=sledru MozReview-Commit-ID: HxAC8oXcQOn
ccce663812da531d339710da3901fc8b4bc64ab8: Bug 1403758 - Sync shield-recipe-client v76 from GitHub (commit 2419d02). r=Gijs, a=sledru
Michael Cooper <mcooper@mozilla.com> - Wed, 27 Sep 2017 16:09:56 -0700 - rev 434444
Push 1567 by jlorenzo@mozilla.com at Thu, 02 Nov 2017 12:36:05 +0000
Bug 1403758 - Sync shield-recipe-client v76 from GitHub (commit 2419d02). r=Gijs, a=sledru - #1070: Use the correct attribute name when comparing telemetry timestamps. https://github.com/mozilla/normandy/pull/1070 - #1071: Fix #957: Use UpdateUtils.jsm to determine the update channel. https://github.com/mozilla/normandy/pull/1071 MozReview-Commit-ID: Jdpc02PBQRv
dade9951a461fef6a6af9265760861e86c9b06ca: Bug 1403615 - Also follow the NODE_DESCENDANTS_NEED_FRAMES bit in ClearRestyleStateFromSubtree. r=bholley, a=sledru
Emilio Cobos Álvarez <emilio@crisal.io> - Wed, 27 Sep 2017 19:19:12 +0200 - rev 434443
Push 1567 by jlorenzo@mozilla.com at Thu, 02 Nov 2017 12:36:05 +0000
Bug 1403615 - Also follow the NODE_DESCENDANTS_NEED_FRAMES bit in ClearRestyleStateFromSubtree. r=bholley, a=sledru We don't follow this bit intentionally because we know that even if it's set, when none of the other two bits are set there are no other restyle / change hints down the tree. We rely on the frame constructor to clean the mess up, though, and it doesn't really do a good work about it. In particular, the case we're hitting on the test-case is: <body descendant-need-frames change=reconstruct style="display: table-column-group"> <div descendant-need-frames> <div descendant-need-frames> <span needs-frame></span> </div> </div> </body> When we see we need to reconstruct the body, we call ClearRestyleStateFromSubtree, but that doesn't do much now, since we don't follow the descendant-need-frames bits. Then, when we reconstruct the content, we arrive at[1] when constructing the first child <div>. The <div> flags have been cleared, but not the children's! Then a text-node is inserted in a <div>, breaking all sorts of invariants. This is the easiest fix. Other fixes include clearing the flags on SetAsUndisplayedContent. But that implies not clearing them in ShouldCreateItemsForChild, and doing that somewhere more sensible. I suspect it's not too hard, but that's a slightly more risky change, will do it if you prefer it. [1]: http://searchfox.org/mozilla-central/rev/3dbb47302e114219c53e99ebaf50c5cb727358ab/layout/base/nsCSSFrameConstructor.cpp#6092 MozReview-Commit-ID: 7026wkQLQkz
f98a2bd7044165abb4e6244e1f6448596897fba8: Bug 1403592 - Crashtest. r=Manishearth, a=sledru
Emilio Cobos Álvarez <emilio@crisal.io> - Wed, 27 Sep 2017 18:16:25 +0200 - rev 434442
Push 1567 by jlorenzo@mozilla.com at Thu, 02 Nov 2017 12:36:05 +0000
Bug 1403592 - Crashtest. r=Manishearth, a=sledru I've made it crash at least once, though it's intermittent-y. I guess it's better than no crashtest. MozReview-Commit-ID: 5m2VCrEs8lM
1322c11127a063fc0172f8519b06e04380917163: Bug 1403592 - Never flush the user font set when getting font metrics from style resolution. r=Manishearth, a=sledru
Emilio Cobos Álvarez <emilio@crisal.io> - Wed, 27 Sep 2017 18:09:31 +0200 - rev 434441
Push 1567 by jlorenzo@mozilla.com at Thu, 02 Nov 2017 12:36:05 +0000
Bug 1403592 - Never flush the user font set when getting font metrics from style resolution. r=Manishearth, a=sledru In this case, the caller doesn't go through all the PreTraverseSync stuff (we don't really want it to do so), via GetComputedStyleNoFlush. It makes sense to not flush the user font set that case, we'll schedule a restyle properly if / when needed. Since the set should be flushed otherwise, let's just not flush it from the styling code. MozReview-Commit-ID: LLHfxemJ8QQ
c786424818eae74178d9412cf999507be271d3cd: Bug 1403127 - Don't try to pass fullscreen element through IPC. r=jaws, a=sledru
Xidorn Quan <me@upsuper.org> - Wed, 27 Sep 2017 16:27:36 +1000 - rev 434440
Push 1567 by jlorenzo@mozilla.com at Thu, 02 Nov 2017 12:36:05 +0000
Bug 1403127 - Don't try to pass fullscreen element through IPC. r=jaws, a=sledru MozReview-Commit-ID: DaiBNVdqAOh
04e56dc5714e1b5d71dedc47ab372f03a2fcc19b: Bug 1402896 - Make the url bar strip javascript even when preceded by control characters. r=mak, a=sledru
Gijs Kruitbosch <gijskruitbosch@gmail.com> - Mon, 25 Sep 2017 17:24:26 +0100 - rev 434439
Push 1567 by jlorenzo@mozilla.com at Thu, 02 Nov 2017 12:36:05 +0000
Bug 1402896 - Make the url bar strip javascript even when preceded by control characters. r=mak, a=sledru MozReview-Commit-ID: 5ZO8n5lfvnl
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 +100000 tip