c13bd0798514ce1b6d4b2849e4cef3d661aa2029: Bug 1387862 - Lint taskcluster's cron.yml file, fixup lint errors. r=dustin
Justin Wood <Callek@gmail.com> - Sun, 06 Aug 2017 13:35:27 -0400 - rev 425786
Push 1567 by jlorenzo@mozilla.com at Thu, 02 Nov 2017 12:36:05 +0000
Bug 1387862 - Lint taskcluster's cron.yml file, fixup lint errors. r=dustin We should have CI Lint YAML files in the tree. MozReview-Commit-ID: 758kdSddjJN
a86a804e64eed74f26f77177315ba658ecd26730: Bug 1387862 - Lint taskcluster yaml files. r=dustin
Justin Wood <Callek@gmail.com> - Sun, 06 Aug 2017 13:26:13 -0400 - rev 425785
Push 1567 by jlorenzo@mozilla.com at Thu, 02 Nov 2017 12:36:05 +0000
Bug 1387862 - Lint taskcluster yaml files. r=dustin We should have CI Lint YAML files in the tree. MozReview-Commit-ID: L83j6SODA3w
98c08b9cc52e6e62a57dcd3eaaa389011a0b159a: Bug 1387862 - Add initial support for ./mach lint -l yaml r=ahal,dustin
Justin Wood <Callek@gmail.com> - Sun, 06 Aug 2017 13:23:48 -0400 - rev 425784
Push 1567 by jlorenzo@mozilla.com at Thu, 02 Nov 2017 12:36:05 +0000
Bug 1387862 - Add initial support for ./mach lint -l yaml r=ahal,dustin We should have CI Lint YAML files in the tree. MozReview-Commit-ID: HYVWXzNnnzG
0b60862b3898fe8f31a13a3dfccc279e001ee2ac: Bug 1389008 - Stop centering the tab label on Mac. r=nhnt11
Dão Gottwald <dao@mozilla.com> - Thu, 10 Aug 2017 09:50:09 +0200 - rev 425783
Push 1567 by jlorenzo@mozilla.com at Thu, 02 Nov 2017 12:36:05 +0000
Bug 1389008 - Stop centering the tab label on Mac. r=nhnt11 MozReview-Commit-ID: HLE3RQilyUp
2defe6e0a9932d71b0aff0cf6cffc4074eda7751: Bug 1314670 - Update browser_google_behavior.js to use the same test structure as browser_searchEngineBehaviors.js. r=florian
Mark Banner <standard8@mozilla.com> - Wed, 09 Aug 2017 07:41:51 +0100 - rev 425782
Push 1567 by jlorenzo@mozilla.com at Thu, 02 Nov 2017 12:36:05 +0000
Bug 1314670 - Update browser_google_behavior.js to use the same test structure as browser_searchEngineBehaviors.js. r=florian MozReview-Commit-ID: 7hBEfgn6duc
e301b87418a634cc7e2b03ec7e8bd43acd30a656: Bug 1314670 - Merge the browser_*behavior.js tests into the new tests. r=florian
Mark Banner <standard8@mozilla.com> - Wed, 09 Aug 2017 09:38:15 +0100 - rev 425781
Push 1567 by jlorenzo@mozilla.com at Thu, 02 Nov 2017 12:36:05 +0000
Bug 1314670 - Merge the browser_*behavior.js tests into the new tests. r=florian Excluding Google due to it not being able to run in artifact builds. MozReview-Commit-ID: B15iW1iC2Lk
5ad5569f62ae5110ed75fb385873a9c32c7b8fa7: Bug 1314670 - Rewrite the new search engine behaviors test to use async functionality. r=florian
Mark Banner <standard8@mozilla.com> - Wed, 19 Jul 2017 16:22:02 +0100 - rev 425780
Push 1567 by jlorenzo@mozilla.com at Thu, 02 Nov 2017 12:36:05 +0000
Bug 1314670 - Rewrite the new search engine behaviors test to use async functionality. r=florian MozReview-Commit-ID: 396ci4r6ion
236bbdf4fc277fe5bc6685378fc315189fddb626: Bug 1314670 - Create a new search engine behaviors test to replace the old individual ones. r=florian
Mark Banner <standard8@mozilla.com> - Wed, 19 Jul 2017 14:46:52 +0100 - rev 425779
Push 1567 by jlorenzo@mozilla.com at Thu, 02 Nov 2017 12:36:05 +0000
Bug 1314670 - Create a new search engine behaviors test to replace the old individual ones. r=florian MozReview-Commit-ID: HQtFQVxiyvV
53b88290184c874fbc70437d6aa255557562c648: Bug 1319340 - part9: Make nsComposerDocumentCommands use concrete class when calling methods of editor r=m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Mon, 07 Aug 2017 18:27:16 +0900 - rev 425778
Push 1567 by jlorenzo@mozilla.com at Thu, 02 Nov 2017 12:36:05 +0000
Bug 1319340 - part9: Make nsComposerDocumentCommands use concrete class when calling methods of editor r=m_kato MozReview-Commit-ID: 15WBfUpfo6L
c6d10ba42666107be8cd71f2ec1f4641bd2264ed: Bug 1319340 - part8: EditorCommands should use TextEditor instead of nsIEditor, nsIPlaintextEditor and nsIEditorMailSupport r=m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Fri, 04 Aug 2017 20:41:20 +0900 - rev 425777
Push 1567 by jlorenzo@mozilla.com at Thu, 02 Nov 2017 12:36:05 +0000
Bug 1319340 - part8: EditorCommands should use TextEditor instead of nsIEditor, nsIPlaintextEditor and nsIEditorMailSupport r=m_kato EditorCommands implements common edit commands. So, we can use TextEditor even if the instance is HTMLEditor. Then, EditorCommands can use non-virtual methods of the concrete classes. MozReview-Commit-ID: DgKHqC0osRb
b88824858b72b658ef4fab9b2f449708735a9991: Bug 1319340 - part7: Fix some warnings in nsComposerCommands.h r=m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Fri, 04 Aug 2017 18:50:26 +0900 - rev 425776
Push 1567 by jlorenzo@mozilla.com at Thu, 02 Nov 2017 12:36:05 +0000
Bug 1319340 - part7: Fix some warnings in nsComposerCommands.h r=m_kato MozReview-Commit-ID: A0KnOCCWqYZ
1fbb78c53ea81d749f009bec6738e5c106025e04: Bug 1319340 - part6: Implement some interface methods as non-virtual methods of EditorBase or HTMLEditor r=m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Fri, 04 Aug 2017 18:30:13 +0900 - rev 425775
Push 1567 by jlorenzo@mozilla.com at Thu, 02 Nov 2017 12:36:05 +0000
Bug 1319340 - part6: Implement some interface methods as non-virtual methods of EditorBase or HTMLEditor r=m_kato nsComposerCommands uses some simple getter methods. They can be simpler non-virtual methods. So, we should do it. Note that this changes that EditorBase::GetIsSelectionEditable() won't return error. However, it has returned error only when selection controller isn't available. That means that the selection controller has been destroyed and the editor will be destroyed. So, this must not be problem since it returns false (non-editable) instead and won't break any behavior since the editor won't be editable by users nor JS anymore. MozReview-Commit-ID: E9ccFspG6na
2762a672be69a1be86d6dec1a58ddea555e2339b: Bug 1319340 - part5: Make nsComposerCommands use concrete class when calling methods of editor r=m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Fri, 04 Aug 2017 17:12:01 +0900 - rev 425774
Push 1567 by jlorenzo@mozilla.com at Thu, 02 Nov 2017 12:36:05 +0000
Bug 1319340 - part5: Make nsComposerCommands use concrete class when calling methods of editor r=m_kato Compiler may can optimize to call virtual methods at build time if we call them with concrete classes because some of them may have final keyword. Even if not so, we can optimize some methods with creating non-virtual methods. MozReview-Commit-ID: K3bRlc0URml
ba3a07622a50eea0251b74e60e0e63a1a8f8e518: Bug 1319340 - part4: SetState() of nsComposerCommands should take HTMLEditor* instead of nsIEditor* r=m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Fri, 04 Aug 2017 16:20:56 +0900 - rev 425773
Push 1567 by jlorenzo@mozilla.com at Thu, 02 Nov 2017 12:36:05 +0000
Bug 1319340 - part4: SetState() of nsComposerCommands should take HTMLEditor* instead of nsIEditor* r=m_kato All SetState() methods in nsComposerCommands require HTMLEditor. So, it should take HTMLEditor* rather than nsIEditor*. MozReview-Commit-ID: AVbnRsMsmeY
33412f3fd23b3f0c6b55e1d9c2df95dac956ed52: Bug 1319340 - part3: ToggleState() in nsComposerCommands should take HTMLEditor* instead of nsIEditor* r=m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Fri, 04 Aug 2017 15:57:57 +0900 - rev 425772
Push 1567 by jlorenzo@mozilla.com at Thu, 02 Nov 2017 12:36:05 +0000
Bug 1319340 - part3: ToggleState() in nsComposerCommands should take HTMLEditor* instead of nsIEditor* r=m_kato Similar to GetCurrentState(), all ToggleState() methods require HTMLEditor. So, they should take HTMLEditor* instead of nsIEditor*. MozReview-Commit-ID: BwM6WRKFn6Q
c612ed5072bdd989f1f60cd7e0f9de1e1f6cdca8: Bug 1319340 - part2: GetCurrentState() of the classes in nsComposerCommands should take HTMLEditor instead of nsIEditor r=m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Fri, 04 Aug 2017 15:41:42 +0900 - rev 425771
Push 1567 by jlorenzo@mozilla.com at Thu, 02 Nov 2017 12:36:05 +0000
Bug 1319340 - part2: GetCurrentState() of the classes in nsComposerCommands should take HTMLEditor instead of nsIEditor r=m_kato All GetCurrentState() methods in nsComposerCommands require HTMLEditor but its argument is nsIEditor*. So, it should take HTMLEditor* and it shouldn't be called if given editor isn't HTMLEditor since it's virtual method. MozReview-Commit-ID: HsvYJN8hIxN
af626178b4de7ef2932baca3190cdac5ca674c5c: Bug 1319340 - part1 Move AsTextEditor() and AsHTMLEditor() to nsIEditor r=m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Fri, 04 Aug 2017 15:01:36 +0900 - rev 425770
Push 1567 by jlorenzo@mozilla.com at Thu, 02 Nov 2017 12:36:05 +0000
Bug 1319340 - part1 Move AsTextEditor() and AsHTMLEditor() to nsIEditor r=m_kato nsIEditor is still first contact with editor class for some modules. They should be accessible to the concrete classes without QI. Therefore, nsIEditor should have As*Editor() methods. Additionally, this adds AsEditorBase(). That is always implemented but it might be necessary for some files for minimizing its include files. MozReview-Commit-ID: 8WqkDJLiVDs
051e18fe22d039d373628f4bf3a5ebddaba1f2e5: Bug 1388394 - Give dark url bar an opaque background. r=dao
Dale Harvey <dale@arandomurl.com> - Thu, 10 Aug 2017 11:54:42 +0100 - rev 425769
Push 1567 by jlorenzo@mozilla.com at Thu, 02 Nov 2017 12:36:05 +0000
Bug 1388394 - Give dark url bar an opaque background. r=dao MozReview-Commit-ID: IzuEwQRc9Gl
d55ad0a1396d142848dc0e79c0eb015aa29e14ff: Bug 1388746 - Do not split start/end text nodes in deleteContents/extractContents; r=smaug
Aryeh Gregor <ayg@aryeh.name> - Wed, 09 Aug 2017 17:39:06 +0300 - rev 425768
Push 1567 by jlorenzo@mozilla.com at Thu, 02 Nov 2017 12:36:05 +0000
Bug 1388746 - Do not split start/end text nodes in deleteContents/extractContents; r=smaug If a range endpoint is in the middle of a text node, and you call deleteContents() or extractContents(), the spec says to delete the data from the node. In the case of extractContents(), the new text node that's inserted into the DocumentFragment is a clone with its data set to the bit that was deleted. <https://dom.spec.whatwg.org/#dom-range-deletecontents> <https://dom.spec.whatwg.org/#dom-range-extractcontents> We don't do this. Instead, we split the text node. Then the bit to delete is deleted naturally at a later stage together with all the other nodes. The result is the same, but on the way there we do a bunch more node mutations. This causes extra mutation records, which cause us to fail a WPT test. Chrome passes. Changing to match the spec actually reduces our lines of code anyway. MozReview-Commit-ID: FTTV5yNSj71
efcedec7e0a0f89a0de307a3bf8c93dd4882c009: Bug 956731 - Remove legacy add-on bar and statusbar shims. r=Gijs
Dão Gottwald <dao@mozilla.com> - Thu, 10 Aug 2017 09:17:48 +0200 - rev 425767
Push 1567 by jlorenzo@mozilla.com at Thu, 02 Nov 2017 12:36:05 +0000
Bug 956731 - Remove legacy add-on bar and statusbar shims. r=Gijs MozReview-Commit-ID: 2deeujcHYUM
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 +100000 tip