6504b5468b32786ec2f492e0dc6cd2ed3f1cf55d: Bug 1489308 part 5. Align the work we do on document.open with the spec. r=mccr8,smaug
Boris Zbarsky <bzbarsky@mit.edu> - Wed, 27 Feb 2019 23:24:48 +0000 - rev 522454
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1489308 part 5. Align the work we do on document.open with the spec. r=mccr8,smaug The main behavior changes are: 1) We no longer create a new Window when doing document.open(). We use the same Window but remove all the event listeners on it and on the existing DOM tree before removing the document's existing kids. 2) We no longer create a new session history entry. The existing one always gets replaced instead. 3) We now support document.open on documents that are not in a Window. The reasons for the various test changes are as follows: The change to browser_modifiedclick_inherit_principal.js is because we no longer set the docshell to a wyciwyg URL when document.open() happens and the test was depending on that to terminate. browser_wyciwyg_urlbarCopying.js is being removed because it's trying to test wyciwyg URIs, which no longer exist. The changes in docshell/test/navigation are because document.open() no longer affects session history. One of the tests was testing the interactions there and is being removed; another is being repurposed to just test that document.open() does not affect history.length. The change to test_x-frame-options.html is because document.open() now removes event listeners on the window, which it didn't use to do (and in the specific case in this test reused the existing inner too, so the listener was still around in practice). The new behavior matches other browsers. The removal of test_bug172261.html is because document.open() no longer affects session history, so you can't go back across it or forward to the "opened" state, so the situation that test is trying to test no longer exists. The changes to test_bug255820.html are because reloading a document after document.open() will now just load the URL of the document that was the entry document for the open() call, not reload the written content. So there's not much point testing reload behavior, and in this test it was just reloading the toplevel test file inside the frames. The change to test_bug346659.html is because now we no longer create a new Window on document.open(). The change to test_bug1232829.html is because document.open() (implicit in this test) no longer adds history entries, so the back() was just leaving the test page instead of going back across the document.open(). The test is a crashtest in practice, so might still be testing something useful about how document.open() interacts with animations. The change to test_bug715739.html is because the URL of the document after document.open() is now the URL of the entry document, not a wyciwyg URL, so reload() has different behavior than it used to. The change to test_bug329869.html is because now when we go back we're reloading the original document we had, not doing a wyciwyg load, and the security info now doesn't include the untrusted script. The changes to the wpt expectations are removing a bunch of expected failures now that we pass those tests and disabling some tests that are fundamentally racy and hence fail randomly. The latter all have github issues filed for the test problem. The change to testing/web-platform/tests/common/object-association.js is fixing tests that were not matching the spec (and were failing in other browsers). The change to parser-uses-registry-of-owner-document.html is fixing tests that were not matching the spec (and were failing in other browsers). The change to document-write.tentative.html is because the test was buggy: it was using the same iframe element for all its tests and racing loads from some tests against API calls from other tests, etc. It's a wonder it ever managed to pass, independent of these patches (and in fact it doesn't pass according to wpt.fyi data, even in Firefox). The changes in html/browsers/history/the-history-interface are because document.open() no longer adds history entries. The test was failing in all other browsers for the same reason. The changes in html/browsers/history/the-location-interface are because reloading a document.open()-created thing now loads the URL of the page that was the entry document for the open() call. The test was failing in all other browsers. The change to reload_document_open_write.html is because we now reload the url of the document that entered the script that called open() when we reload, not the written content. Other browsers were failing this test too; Gecko with the old document.open implementation was the only one that passed. The change to http-refresh.py is to fix a test bug: it was not returning a Content-Type header, so we were putting up helper app dialogs, etc. The change to test_ext_contentscript.js is because we no create a new global for document.open() calls. Kris Maglione OKed this part. Differential Revision: https://phabricator.services.mozilla.com/D17323
015db4a424d9f817a7dbaee4e520e81f20430727: Bug 1489308 part 4. Allow UpdateURLAndHistory to work even if there's no root session history. r=smaug
Boris Zbarsky <bzbarsky@mit.edu> - Wed, 27 Feb 2019 05:10:11 +0000 - rev 522453
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1489308 part 4. Allow UpdateURLAndHistory to work even if there's no root session history. r=smaug This can happen when someone does a document.open() on a document that has no session history. Differential Revision: https://phabricator.services.mozilla.com/D17322
b393e04da7e97d49c577c5537c1f62cb0cc6b91e: Bug 1489308 part 3. Add a public RemoveAllListeners method on EventListenerManager. r=smaug
Boris Zbarsky <bzbarsky@mit.edu> - Wed, 27 Feb 2019 05:08:50 +0000 - rev 522452
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1489308 part 3. Add a public RemoveAllListeners method on EventListenerManager. r=smaug Differential Revision: https://phabricator.services.mozilla.com/D17321
f2b0ceb55cedd2cffea476c0ff187d4b283ec4e2: Bug 1489308 part 2. Allow UpdateURLAndHistory to work even if mOSHE is null, if we're doing a replace. r=smaug
Boris Zbarsky <bzbarsky@mit.edu> - Wed, 27 Feb 2019 06:01:57 +0000 - rev 522451
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1489308 part 2. Allow UpdateURLAndHistory to work even if mOSHE is null, if we're doing a replace. r=smaug We're going to end up hitting this if someone does a document.open() before mOSHE has been set. We shouldn't need to worry about mLSHE, because the document.open() will cancel the corresponding load. Differential Revision: https://phabricator.services.mozilla.com/D17319
6f00a2d89b5fa9785dac8ea8d4f47dfe17827702: Bug 1489308 part 1. Factor out part of nsDocShell::AddState into a separate method. r=qdot
Boris Zbarsky <bzbarsky@mit.edu> - Wed, 27 Feb 2019 05:56:23 +0000 - rev 522450
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1489308 part 1. Factor out part of nsDocShell::AddState into a separate method. r=qdot This implements the "URL and history update steps" from the HTML spec. See <https://html.spec.whatwg.org/multipage/history.html#url-and-history-update-steps>. Differential Revision: https://phabricator.services.mozilla.com/D17318
2624b1bdee9b2bab41ca9a8c784cf0a7f14c2b7e: Bug 1531160 - Add the original NS_tsnprintf and use a new name for the new function. r=mhowell
Robert Strong <robert.bugzilla@gmail.com> - Thu, 28 Feb 2019 00:33:12 +0000 - rev 522449
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1531160 - Add the original NS_tsnprintf and use a new name for the new function. r=mhowell Differential Revision: https://phabricator.services.mozilla.com/D21468
67213a91036c5830a6f830bc48ccb55c424d34ca: Backed out changeset c2091f595c72 (bug 1530550) for ,ultiple leakcheck failures CLOSED TREE
Ciure Andrei <aciure@mozilla.com> - Thu, 28 Feb 2019 02:56:12 +0200 - rev 522448
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Backed out changeset c2091f595c72 (bug 1530550) for ,ultiple leakcheck failures CLOSED TREE
71dd92230a54beb5037cf8ddef92b0f227653f93: Bug 1528744 - Port browser_urlbar_search.js and browser_urlbar_keyed_search.js to QuantumBar. r=Standard8,mconley
Drew Willcoxon <adw@mozilla.com> - Thu, 28 Feb 2019 00:32:08 +0000 - rev 522447
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1528744 - Port browser_urlbar_search.js and browser_urlbar_keyed_search.js to QuantumBar. r=Standard8,mconley Differential Revision: https://phabricator.services.mozilla.com/D21242
20c54f8dd7fa7ad7390330856a1a7f666bbcbf12: Bug 1531185 - Disable test_autofill_highlight.html on Android r=geckoview-reviewers,esawin
James Willcox <snorp@snorp.net> - Wed, 27 Feb 2019 23:35:02 +0000 - rev 522446
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1531185 - Disable test_autofill_highlight.html on Android r=geckoview-reviewers,esawin Differential Revision: https://phabricator.services.mozilla.com/D21467
9b84cbe0e2a3e0ec2e29c7e79a7a080025816a15: Bug 1530489 - Checking VRGPUParent is available before closing it. r=kip
Daosheng Mu <daoshengmu@gmail.com> - Wed, 27 Feb 2019 22:38:58 +0000 - rev 522445
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1530489 - Checking VRGPUParent is available before closing it. r=kip Differential Revision: https://phabricator.services.mozilla.com/D21064
170b333092c82ce0cf39eec04f91f3700c9260e4: Bug 1531128 part 2. Add a docshell API for determining whether a navigation is in progress. r=mccr8
Boris Zbarsky <bzbarsky@mit.edu> - Wed, 27 Feb 2019 23:21:29 +0000 - rev 522444
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1531128 part 2. Add a docshell API for determining whether a navigation is in progress. r=mccr8 This is needed by the document.open spec, which cancels loads for the document only if a navigation is pending. Differential Revision: https://phabricator.services.mozilla.com/D21441
21c7deb32a777b484039c8f85d748b75a47f5b95: Bug 1531128 part 1. Add an nsIScriptChannel API to ask whether the channel is a document load. r=mccr8
Boris Zbarsky <bzbarsky@mit.edu> - Wed, 27 Feb 2019 22:05:59 +0000 - rev 522443
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1531128 part 1. Add an nsIScriptChannel API to ask whether the channel is a document load. r=mccr8 Differential Revision: https://phabricator.services.mozilla.com/D21439
4b6ea94397b45153eccfddfac342d3076773975a: Bug 1529795 - Record profiler markers when we drop video frames. r=mstange
Matt Woodrow <mwoodrow@mozilla.com> - Wed, 27 Feb 2019 17:35:05 +0000 - rev 522442
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1529795 - Record profiler markers when we drop video frames. r=mstange Differential Revision: https://phabricator.services.mozilla.com/D20755
20fcf9d9494ac77d9c8166444e5fa8346ff13be1: Bug 1525319 - Removing context from OnDataAvailable r=valentin
Jonathan Kingston <jkt@mozilla.com> - Wed, 27 Feb 2019 23:42:27 +0000 - rev 522441
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1525319 - Removing context from OnDataAvailable r=valentin Differential Revision: https://phabricator.services.mozilla.com/D20881
2f665c88b0c8c0f6502088c4866778ea5e3fc0cb: Bug 1525319 - Changing js to remove context from onStartRequest and onStopRequest r=valentin
Jonathan Kingston <jkt@mozilla.com> - Wed, 27 Feb 2019 23:41:54 +0000 - rev 522440
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1525319 - Changing js to remove context from onStartRequest and onStopRequest r=valentin Differential Revision: https://phabricator.services.mozilla.com/D20771
c48f47f793c0f0d9b4acf2caf9324b8bd7a5a683: Bug 1525319 - Removing context from OnStopRequest r=valentin
Jonathan Kingston <jkt@mozilla.com> - Wed, 27 Feb 2019 23:41:31 +0000 - rev 522439
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1525319 - Removing context from OnStopRequest r=valentin Differential Revision: https://phabricator.services.mozilla.com/D20770
b5f7ff4ca9b58d002c2bebe0a11b529680068b0c: Bug 1525319 - Removing context from OnStartRequest r=valentin
Jonathan Kingston <jkt@mozilla.com> - Wed, 27 Feb 2019 23:41:04 +0000 - rev 522438
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1525319 - Removing context from OnStartRequest r=valentin Differential Revision: https://phabricator.services.mozilla.com/D20769
cce8077b2174bc21e2ab776a40fbb541635d050c: Backed out changeset d158405da514 (bug 1528352) for perma failing test_udpsocket.js CLOSED TREE
Ciure Andrei <aciure@mozilla.com> - Thu, 28 Feb 2019 01:58:42 +0200 - rev 522437
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Backed out changeset d158405da514 (bug 1528352) for perma failing test_udpsocket.js CLOSED TREE
1b973064ca5778532190fef25d81b75e8cf77281: Backed out changeset 2c0ca241bd4b (bug 1519621) for frame-reconstruction-scroll-clamping.html high frequency failures CLOSED TREE
Ciure Andrei <aciure@mozilla.com> - Thu, 28 Feb 2019 01:52:04 +0200 - rev 522436
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Backed out changeset 2c0ca241bd4b (bug 1519621) for frame-reconstruction-scroll-clamping.html high frequency failures CLOSED TREE
81941f492e8c1ff98c84bb470e3341c4457bce86: Backed out 2 changesets (bug 1509466) for rusttests build bustages CLOSED TREE
Ciure Andrei <aciure@mozilla.com> - Thu, 28 Feb 2019 01:29:15 +0200 - rev 522435
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Backed out 2 changesets (bug 1509466) for rusttests build bustages CLOSED TREE Backed out changeset 65c438efa01f (bug 1509466) Backed out changeset e1cdaf345c39 (bug 1509466)
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 tip