5955f883a957e165be245385c640fa3a64fabd8d: Bug 1471583. Don't record a successful image draw if the image isn't marked complete. r=mattwoodrow
Timothy Nikkel <tnikkel@gmail.com> - Wed, 29 Aug 2018 00:53:06 -0500 - rev 491497
Push 1815 by ffxbld-merge at Mon, 15 Oct 2018 10:40:45 +0000
Bug 1471583. Don't record a successful image draw if the image isn't marked complete. r=mattwoodrow The image can be decoded but we haven't notified such (and hence the image state doesn't indicate such). We are able to draw the image at this point because painting has special access to the image that bypasses the image state (this happens via nsStyleImage::StartDecoding -> imgIRequest::StartDecodingWithResult). In this state if we record a successful draw then any parts of the image that we newly drew but weren't invalidated for some other reason won't get updated. When the async decode notification gets processed it will invalidate the image and that will result in it getting updated. But if we get a paint that asks for sync decoding of images before this it will see that we sucessfully drew the image and not invalidate its area and the sync decode paint won't update the image. So we still draw the image but we don't record a successful draw unless the image state is complete and hence the decode notification has been processed (image state and notifications are always in sync). Note that we still have to draw the image in this state because if we get a normal paint after a sync decode paint we have to draw the image because if we don't we effectively erase the image.
e471c532fd11675b0cfafa7c161a2e5e147944b3: Bug 1478269 - Fix the outputs and clobbers of inline assembly blocks in yuv_row_posix.cpp. r=jrmuizel
Mike Hommey <mh+mozilla@glandium.org> - Fri, 24 Aug 2018 10:12:21 +0900 - rev 491496
Push 1815 by ffxbld-merge at Mon, 15 Oct 2018 10:40:45 +0000
Bug 1478269 - Fix the outputs and clobbers of inline assembly blocks in yuv_row_posix.cpp. r=jrmuizel While the current code compiles fine with the file as it is, with LTO enabled, some functions end up inlined into their callers and their callers, recursively, and the compiler doesn't know some of the registers have been modified by the assembly, leading to bad decisions, and bad behavior at runtime. The same problem would likely happen if we were using UNIFIED_SOURCES in the directory. Differential Revision: https://phabricator.services.mozilla.com/D4200
a69ed9d1f49c097a67d6f67bdc0e91d7f26e32b4: Bug 1478269 - Use symbolic names as input operands. r=jrmuizel
Mike Hommey <mh+mozilla@glandium.org> - Fri, 24 Aug 2018 10:07:16 +0900 - rev 491495
Push 1815 by ffxbld-merge at Mon, 15 Oct 2018 10:40:45 +0000
Bug 1478269 - Use symbolic names as input operands. r=jrmuizel Differential Revision: https://phabricator.services.mozilla.com/D4199
998cf7d22736ed2197fd018e1ee28a8257e3de96: Bug 1478269 - Remove ycbcr update script and patches. r=jrmuizel
Mike Hommey <mh+mozilla@glandium.org> - Fri, 24 Aug 2018 10:46:14 +0900 - rev 491494
Push 1815 by ffxbld-merge at Mon, 15 Oct 2018 10:40:45 +0000
Bug 1478269 - Remove ycbcr update script and patches. r=jrmuizel ycbcr is dead upstream, and has been for almost as long as the code in the gecko tree hasn't been updated. Let's not pretend that we can actually run the update script and that having the patches separated matters, because there's no upstream to apply those patches to anymore. Update README accordingly. Differential Revision: https://phabricator.services.mozilla.com/D4198
7acaf7396b0dbe05b241eb41973f23d29e152462: Bug 1486654 - Enable static analysis on all Linux CI builds. r=ted
Mike Hommey <mh+mozilla@glandium.org> - Fri, 24 Aug 2018 22:16:28 +0900 - rev 491493
Push 1815 by ffxbld-merge at Mon, 15 Oct 2018 10:40:45 +0000
Bug 1486654 - Enable static analysis on all Linux CI builds. r=ted And turn off separate static analysis build tasks.
424d07248f36a06baad7fe75e34416eb1a4de92f: Bug 1486652 - Make x86 linux builds actual cross builds. r=ted
Mike Hommey <mh+mozilla@glandium.org> - Tue, 28 Aug 2018 07:37:12 +0900 - rev 491492
Push 1815 by ffxbld-merge at Mon, 15 Oct 2018 10:40:45 +0000
Bug 1486652 - Make x86 linux builds actual cross builds. r=ted The x86 linux builds originally were performed in x86 build environment. That was a long time ago. Since then, they moved to x86-64 hosts with x86 headers and libraries. But for reasons that might have to do with the build system not really supporting cross-compilation nicely back then, the build is still explicitly passing both --host and --target, making those builds non-cross builds. Since the toolchains used to build are for x86-64, the fact that --host is for x86 actually prevents enabling the clang plugin, so we need to turn these builds in actual cross builds if we want to enable the clang plugin.
f52b086cbd9d4f59a3c3df895b7422e9658cf74d: Bug 1486938: Remove login-manager-storage category entry. r=MattN
Kris Maglione <maglione.k@gmail.com> - Tue, 28 Aug 2018 14:58:51 -0700 - rev 491491
Push 1815 by ffxbld-merge at Mon, 15 Oct 2018 10:40:45 +0000
Bug 1486938: Remove login-manager-storage category entry. r=MattN This is an unused feature, with a strange implementation. If we need such an override in the future, it can be accomplished by just overriding a contract ID. This patch also changes the implementation to simply define a contract ID for the appropriate default implementation at registration time rather than adding a duplicate platform check at runtime.
41719b855c4bbeb8cf18cedc3f9b99d06c6c0751: Bug 1482357 - Part 2. Drop panel parameter from assertAnimations* common functions. r=daisuke
Mantaroh Yoshinaga <mantaroh@gmail.com> - Wed, 29 Aug 2018 12:42:54 +0900 - rev 491490
Push 1815 by ffxbld-merge at Mon, 15 Oct 2018 10:40:45 +0000
Bug 1482357 - Part 2. Drop panel parameter from assertAnimations* common functions. r=daisuke Differential Revision: https://phabricator.services.mozilla.com/D4417
0da110967e8bd3005d157a1665a9db6cb8c9e0c4: Bug 1482357 - Part 1. Skip the space key handling of resume/pause button when the target is itself. r=daisuke
Mantaroh Yoshinaga <mantaroh@gmail.com> - Wed, 29 Aug 2018 12:40:48 +0900 - rev 491489
Push 1815 by ffxbld-merge at Mon, 15 Oct 2018 10:40:45 +0000
Bug 1482357 - Part 1. Skip the space key handling of resume/pause button when the target is itself. r=daisuke The PauseResumeButton component listens to the key event and clicks event. As the results of it, space key will trigger the both of event. This patch will skip the space key handling when the event target is itself. Differential Revision: https://phabricator.services.mozilla.com/D4305
74318e0ebe1ecc477cc9ffb8870420721ecc42f6: Bug 1486690 - Remove an unnecessary NS_FREE_XPCOM_ISUPPORTS_POINTER_ARRAY call. r=glandium
Nicholas Nethercote <nnethercote@mozilla.com> - Tue, 28 Aug 2018 16:00:05 +1000 - rev 491488
Push 1815 by ffxbld-merge at Mon, 15 Oct 2018 10:40:45 +0000
Bug 1486690 - Remove an unnecessary NS_FREE_XPCOM_ISUPPORTS_POINTER_ARRAY call. r=glandium
8257797fd2d80b0954d44d8eebcb33459a9a569a: Bug 1486690 - Rename nsMemory::Clone() and remove unnecessary checks after it. r=glandium
Nicholas Nethercote <nnethercote@mozilla.com> - Tue, 28 Aug 2018 15:59:19 +1000 - rev 491487
Push 1815 by ffxbld-merge at Mon, 15 Oct 2018 10:40:45 +0000
Bug 1486690 - Rename nsMemory::Clone() and remove unnecessary checks after it. r=glandium The 'x' in the new name makes it clearer that it's infallible.
d6ccf1492e714566c84bb63de3fae0405cc465d9: Bug 1486690 - Rename NS_str{,}dup and remove unnecessary checks after calls to them. r=glandium
Nicholas Nethercote <nnethercote@mozilla.com> - Tue, 28 Aug 2018 15:58:54 +1000 - rev 491486
Push 1815 by ffxbld-merge at Mon, 15 Oct 2018 10:40:45 +0000
Bug 1486690 - Rename NS_str{,}dup and remove unnecessary checks after calls to them. r=glandium The 'x' prefix makes it clearer that these are infallible. A couple of nsJSID methods are now also infallible.
c330fb64bcd0eb4e8ef98c0389dbd1df19b62b96: Bug 1486690 - Remove unnecessary checks after moz_xrealloc() calls. r=glandium
Nicholas Nethercote <nnethercote@mozilla.com> - Tue, 28 Aug 2018 15:56:23 +1000 - rev 491485
Push 1815 by ffxbld-merge at Mon, 15 Oct 2018 10:40:45 +0000
Bug 1486690 - Remove unnecessary checks after moz_xrealloc() calls. r=glandium
8afde49af9c1f5a04c3611d6ef6de53ac98f0d8d: Bug 1486690 - Remove unnecessary checks after moz_xmalloc() calls. r=glandium
Nicholas Nethercote <nnethercote@mozilla.com> - Tue, 28 Aug 2018 15:56:01 +1000 - rev 491484
Push 1815 by ffxbld-merge at Mon, 15 Oct 2018 10:40:45 +0000
Bug 1486690 - Remove unnecessary checks after moz_xmalloc() calls. r=glandium There are surprisingly many of them. (Plus a couple of unnecessary checks after `new` calls that were nearby.)
e5734413c06fefcb1247c096af3e9241235d1857: Bug 1486690 - Remove moz_x{malloc,free} in jprof. r=jesup
Nicholas Nethercote <nnethercote@mozilla.com> - Tue, 28 Aug 2018 15:55:45 +1000 - rev 491483
Push 1815 by ffxbld-merge at Mon, 15 Oct 2018 10:40:45 +0000
Bug 1486690 - Remove moz_x{malloc,free} in jprof. r=jesup They appear to be unused; jprof builds without them. Also jprof.h is included prior to their definition in contradiction to the comment above them.
7aa3a17103b6a4b504e448b0908bd60cb1f5705b: Bug 1486690 - Remove NS_ALIGNMENT_OF. r=glandium
Nicholas Nethercote <nnethercote@mozilla.com> - Tue, 28 Aug 2018 15:55:20 +1000 - rev 491482
Push 1815 by ffxbld-merge at Mon, 15 Oct 2018 10:40:45 +0000
Bug 1486690 - Remove NS_ALIGNMENT_OF. r=glandium It's unused, and MFBT has MOZ_ALIGNOF.
04849dfc7b7e66d5e930dbf8289e0b7fe71068ed: Bug 1472904 - Part 2. Move Tooltip variable to tooltips.css. r=jdescottes
Mantaroh Yoshinaga <mantaroh@gmail.com> - Wed, 29 Aug 2018 10:34:14 +0900 - rev 491481
Push 1815 by ffxbld-merge at Mon, 15 Oct 2018 10:40:45 +0000
Bug 1472904 - Part 2. Move Tooltip variable to tooltips.css. r=jdescottes Differential Revision: https://phabricator.services.mozilla.com/D4177
6da0f1618ac3bf06710f514f401bd5b74a48295d: Bug 1472904 - Part 1. Add the common variable of tooltip and autopopup. r=jdescottes
Mantaroh Yoshinaga <mantaroh@gmail.com> - Wed, 29 Aug 2018 10:32:29 +0900 - rev 491480
Push 1815 by ffxbld-merge at Mon, 15 Oct 2018 10:40:45 +0000
Bug 1472904 - Part 1. Add the common variable of tooltip and autopopup. r=jdescottes Before moving the tooltip's variable to tooltips.css, this patch will define the common variable of tooltip and autopopup. Differential Revision: https://phabricator.services.mozilla.com/D4176
b205a608fff3adb169a081318f3207a3ae1d507d: Bug 1328820 - Add documentation comment to Promise.h, AsyncFunction.h, and AsyncIteration.h r=anba DONTBUILD comment-only
Tooru Fujisawa <arai_a@mac.com> - Wed, 29 Aug 2018 12:15:32 +0900 - rev 491479
Push 1815 by ffxbld-merge at Mon, 15 Oct 2018 10:40:45 +0000
Bug 1328820 - Add documentation comment to Promise.h, AsyncFunction.h, and AsyncIteration.h r=anba DONTBUILD comment-only
e806780b53a84edc295ae4f394e9702139d99b85: Backed out changeset 692efe8acba9 (bug 1486654) for wd failures on /builds/worker/workspace/build/tests/bin/geckodriver
Dorel Luca <dluca@mozilla.com> - Wed, 29 Aug 2018 05:16:55 +0300 - rev 491478
Push 1815 by ffxbld-merge at Mon, 15 Oct 2018 10:40:45 +0000
Backed out changeset 692efe8acba9 (bug 1486654) for wd failures on /builds/worker/workspace/build/tests/bin/geckodriver
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 tip