544d195743e3ba3022fe025a305af977eec7b4d3: Bug 1326028 - We now upgrade elements in the proper order. r=smaug
Blake Kaplan <mrbkap@gmail.com> - Thu, 22 Feb 2018 16:30:37 -0800 - rev 464094
Push 1728 by jlund@mozilla.com at Mon, 18 Jun 2018 21:12:27 +0000
Bug 1326028 - We now upgrade elements in the proper order. r=smaug MozReview-Commit-ID: Dt4sc8FYmT7
c5f33612c491cd580d5dca5d6d510e7393176597: bug 1326028 - Upgrade elements in the right order. r=smaug
Blake Kaplan <mrbkap@gmail.com> - Wed, 21 Feb 2018 16:43:09 -0800 - rev 464093
Push 1728 by jlund@mozilla.com at Mon, 18 Jun 2018 21:12:27 +0000
bug 1326028 - Upgrade elements in the right order. r=smaug MozReview-Commit-ID: 4u5PipUqN0j
29aeb9151593f4202733b0836687b5b7570eaa4c: Bug 1326028 - Allow moving a reference into nsInterfaceHashtable. r=smaug
Blake Kaplan <mrbkap@gmail.com> - Thu, 22 Feb 2018 14:09:26 -0800 - rev 464092
Push 1728 by jlund@mozilla.com at Mon, 18 Jun 2018 21:12:27 +0000
Bug 1326028 - Allow moving a reference into nsInterfaceHashtable. r=smaug Without this patch, it's impossible for clients to move a reference into an nsInterfaceHashtable. That causes at least one extra addref/release pair when they otherwise could. With this patch, a client can do `hashTable.Put(key, comptr.forget());` to avoid the additional refcounting. MozReview-Commit-ID: Ghm7n41ziZp
dbf853820066253e476d7fbcee35da534f9cc538: Bug 1443948 - Remove NODE_FORCE_XBL_BINDINGS;r=bz
Brian Grinstead <bgrinstead@mozilla.com> - Mon, 12 Mar 2018 13:24:10 -0700 - rev 464091
Push 1728 by jlund@mozilla.com at Mon, 18 Jun 2018 21:12:27 +0000
Bug 1443948 - Remove NODE_FORCE_XBL_BINDINGS;r=bz This was used to attach a binding to a cloned node before it got inserted into the doc. This is no longer used in the browser chrome, so this patch removes the feature to prevent future usage and simplify dom code. MozReview-Commit-ID: KnkHWJ8oQig
a7d42da37878ba41504181f7474203c6dda3694c: Bug 1443346 - Allow empty favicon URL for GPO compat. r=Felipe
Michael Kaply <mozilla@kaply.com> - Tue, 06 Mar 2018 17:27:51 -0600 - rev 464090
Push 1728 by jlund@mozilla.com at Mon, 18 Jun 2018 21:12:27 +0000
Bug 1443346 - Allow empty favicon URL for GPO compat. r=Felipe MozReview-Commit-ID: OFSFed5Yar
d9c664130c22e6d34bed79662275e90267658f48: Bug 1445104 - Format HTMLMediaElement constructor with leading ',' instead of trailing. r=jya
Chris Pearce <cpearce@mozilla.com> - Tue, 13 Mar 2018 13:41:46 +1300 - rev 464089
Push 1728 by jlund@mozilla.com at Mon, 18 Jun 2018 21:12:27 +0000
Bug 1445104 - Format HTMLMediaElement constructor with leading ',' instead of trailing. r=jya MozReview-Commit-ID: DiRjKmtERGq
e8a5c35df168c72c085ca8ea5d03ad8408e60979: Bug 1445104 - Remove HTMLMediaElement::{mStatsShowing,mMediaSecurityVerified} as they're unused. r=jya
Chris Pearce <cpearce@mozilla.com> - Tue, 13 Mar 2018 13:33:42 +1300 - rev 464088
Push 1728 by jlund@mozilla.com at Mon, 18 Jun 2018 21:12:27 +0000
Bug 1445104 - Remove HTMLMediaElement::{mStatsShowing,mMediaSecurityVerified} as they're unused. r=jya MozReview-Commit-ID: LtKw4Hj3M0G
e865836987b36817a8883cfc2bab34421daf0a83: Bug 1445104 - Initialize HTMLMediaElement fields in class declaration. r=jya
Chris Pearce <cpearce@mozilla.com> - Tue, 13 Mar 2018 13:32:05 +1300 - rev 464087
Push 1728 by jlund@mozilla.com at Mon, 18 Jun 2018 21:12:27 +0000
Bug 1445104 - Initialize HTMLMediaElement fields in class declaration. r=jya This makes the constructor simpler. MozReview-Commit-ID: 30CO1iBj4rH
1141d759f71a41d087c90fbd54873658722363c7: Bug 1445386 - Use GreD for artifact build scalars. r=chutten
J. Ryan Stinnett <jryans@gmail.com> - Mon, 12 Mar 2018 19:24:30 -0500 - rev 464086
Push 1728 by jlund@mozilla.com at Mon, 18 Jun 2018 21:12:27 +0000
Bug 1445386 - Use GreD for artifact build scalars. r=chutten On macOS, the paths for the special directories `GreD` (Resources) vs. `GreBinD` (MacOS) are different. On other platforms, they are the same. With scalar loading for artifact builds, we need to load a file from `Resources`, so `GreD` should be used for this case. MozReview-Commit-ID: 91JFwOISQCk
1af9fcd0041c6e9a3164c6d18083a43429d26392: Bug 1441683 - response.complete() should make the completeStatus available to the payment UI service. r=baku
Jared Wein <jwein@mozilla.com> - Tue, 13 Mar 2018 10:30:08 -0400 - rev 464085
Push 1728 by jlund@mozilla.com at Mon, 18 Jun 2018 21:12:27 +0000
Bug 1441683 - response.complete() should make the completeStatus available to the payment UI service. r=baku MozReview-Commit-ID: TnszpuqAa
52977e0274275892591c0ed4081e34625078ffe5: Bug 1445249 - Part 3 - Make it an error to call IToplevelProtocol::OtherPid() on an unconnected protocol; r=jld
Alex Gaynor <agaynor@mozilla.com> - Mon, 12 Mar 2018 13:06:33 -0400 - rev 464084
Push 1728 by jlund@mozilla.com at Mon, 18 Jun 2018 21:12:27 +0000
Bug 1445249 - Part 3 - Make it an error to call IToplevelProtocol::OtherPid() on an unconnected protocol; r=jld MozReview-Commit-ID: HAMXOYUeHoU
6341884397ca46626be778ebffded8a7e661d970: Bug 1445249 - Part 2 - avoid calling OtherPid() where it might return an invalid pid on android; r=jld
Alex Gaynor <agaynor@mozilla.com> - Tue, 13 Mar 2018 12:54:35 -0400 - rev 464083
Push 1728 by jlund@mozilla.com at Mon, 18 Jun 2018 21:12:27 +0000
Bug 1445249 - Part 2 - avoid calling OtherPid() where it might return an invalid pid on android; r=jld MozReview-Commit-ID: EXio3oNJy4U
d638bedc1a36ae5a1755550266b96b036dad7504: Bug 1445249 - Part 1 - Remove unused aProcessId parameter when deleting shared memory; r=jld
Alex Gaynor <agaynor@mozilla.com> - Tue, 13 Mar 2018 10:07:18 -0400 - rev 464082
Push 1728 by jlund@mozilla.com at Mon, 18 Jun 2018 21:12:27 +0000
Bug 1445249 - Part 1 - Remove unused aProcessId parameter when deleting shared memory; r=jld MozReview-Commit-ID: Cn0q46Q67hd
d5912e36b50a0183229d1b93111c1c3fdd49e56e: Backed out changeset 3df355881aa0 (bug 1445386) for xpcshell failures on test_TelemetryScalars_buildFaster.js CLOSED TREE
Bogdan Tara <btara@mozilla.com> - Tue, 13 Mar 2018 22:33:14 +0200 - rev 464081
Push 1728 by jlund@mozilla.com at Mon, 18 Jun 2018 21:12:27 +0000
Backed out changeset 3df355881aa0 (bug 1445386) for xpcshell failures on test_TelemetryScalars_buildFaster.js CLOSED TREE
a644a4855be72a71e4bd134f85690c70560b4452: Bug 1445412 - Fix typo resulting in compilation error. r=njn
Kartikaya Gupta <kgupta@mozilla.com> - Tue, 13 Mar 2018 15:57:53 -0400 - rev 464080
Push 1728 by jlund@mozilla.com at Mon, 18 Jun 2018 21:12:27 +0000
Bug 1445412 - Fix typo resulting in compilation error. r=njn MozReview-Commit-ID: 6Rtl4mtRirZ
5dc1d09ffedf4a6e36b20224b67ddd863ad16154: Bug 1416169 - Part 4 - Switch the MediaControlService to running only on demand. r=snorp
Jan Henning <jh+bugzilla@buttercookie.de> - Sun, 11 Mar 2018 12:50:22 +0100 - rev 464079
Push 1728 by jlund@mozilla.com at Mon, 18 Jun 2018 21:12:27 +0000
Bug 1416169 - Part 4 - Switch the MediaControlService to running only on demand. r=snorp Now that the AudioFocusAgent keeps monitoring all relevant tab events and notifies the MediaControlService as necessary, we can revert to only running the service when actually required to show the notification and keep us alive during (background) media playback. MozReview-Commit-ID: KV6ars2BbMW
3e917ebfc7ba27ad9ad14babb4a2cef9d7ee5c91: Bug 1416169 - Part 3 - Resolve some lifecycle issues. r=snorp
Jan Henning <jh+bugzilla@buttercookie.de> - Tue, 13 Mar 2018 19:13:55 +0100 - rev 464078
Push 1728 by jlund@mozilla.com at Mon, 18 Jun 2018 21:12:27 +0000
Bug 1416169 - Part 3 - Resolve some lifecycle issues. r=snorp We're not a bound service and the MediaSession is initialised during onCreate(), so its release conversely needs to happen during onDestroy(). For consistency, we also move unregistering of the HeadSetStateReceiver into the shutdown helper method. Additionally, while things seem to have worked anyway in practice (possibly be- cause we're only using the MediaSession within the same process?), technically you're supposed to explicitly activate the session before using it. MozReview-Commit-ID: 1HDva7p2ljF
6b1099c4b838cda680f18aa4ddd83cdb325bc64f: Bug 1416169 - Part 2 - Move monitoring of Tab media events out of the MediaControlService. r=snorp
Jan Henning <jh+bugzilla@buttercookie.de> - Sat, 10 Mar 2018 18:38:32 +0100 - rev 464077
Push 1728 by jlund@mozilla.com at Mon, 18 Jun 2018 21:12:27 +0000
Bug 1416169 - Part 2 - Move monitoring of Tab media events out of the MediaControlService. r=snorp At the moment the MediaControlService is structured such that it is started shortly after Firefox has launched. Then, it registers a Tab event listener and starts listening for various, mainly media-related tab events, in response to which the playback notification is then shown or hidden as appropriate. This setup has the drawback that the service itself has to remain running all the time, even when we're not actually showing the notification, so Firefox now keeps showing up as a "Running service" even when in background and not doing anything interesting. It is however relatively easily possible to move the tab event tracking into a different class that won't require a service to stay alive, and set the Media- ControlService's state (and at the same time start it if necessary) through a set of special intent actions. As the AudioFocusAgent is a) alive for the whole lifetime of the application and b) already interacting with the MediaControlService, we designate it as the class responsible for this. MozReview-Commit-ID: 1CzBpC1LTuZ
1a1f19183f38eabb73d25522da0754cfbc98c569: Bug 1416169 - Part 1 - Silence StaticFieldLeak linter. r=snorp
Jan Henning <jh+bugzilla@buttercookie.de> - Sun, 11 Mar 2018 13:06:25 +0100 - rev 464076
Push 1728 by jlund@mozilla.com at Mon, 18 Jun 2018 21:12:27 +0000
Bug 1416169 - Part 1 - Silence StaticFieldLeak linter. r=snorp In practice we've already been using the application context anyway, but this way makes it more explicit. With that out of the way, we can also silence the linter here, since the Static- FieldLeak check is only really relevant when holding onto non-Application contexts. MozReview-Commit-ID: CYOs8MPnlcN
c909f553340c334a5f94df6cc4e3f6f2c096bbcf: Bug 1416169 - Part 0 - Cleanups. r=snorp
Jan Henning <jh+bugzilla@buttercookie.de> - Sat, 10 Mar 2018 18:20:39 +0100 - rev 464075
Push 1728 by jlund@mozilla.com at Mon, 18 Jun 2018 21:12:27 +0000
Bug 1416169 - Part 0 - Cleanups. r=snorp Fix some style inconsistencies, plus things Android Studio is complaining about. MozReview-Commit-ID: BdO0UTTsidi
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 tip