50f9b4a613b0c9a9bcd659f856e5d4df0e9d3ae0: Bug 1287671 - Simplify jscpucfg.h. r=njn
Mike Hommey <mh+mozilla@glandium.org> - Tue, 19 Jul 2016 14:54:37 +0900 - rev 361471
Push 1369 by jlorenzo@mozilla.com at Mon, 27 Feb 2017 14:59:41 +0000
Bug 1287671 - Simplify jscpucfg.h. r=njn Endianness is figured out in mfbt/EndianUtils.h, which can be reused. Apart from endianness, jscpucfg.h is defining JS_HAVE_LONG_LONG, which isn't used anywhere, defines a macro for the Watcom C/C++ compiler, and tries to figure out stack growth direction. The first is obviously unnecessary. The second is not useful now that building JS requires a C++11-capable compiler, which the Watcom C/C++ compiler isn't. The latter, however, is still relevant, but the check based on sys/isa_def.h is, afaict, only relevant on HP-UX on PA-RISC, which is already covered by the check for __hppa. Consequently, the various checks setting JS_HAVE_header_H defines can all be removed.
b3947e0eeeb838daf9b1c9d809113aaa49bcfc25: Bug 1305943 Don't consume following WM_SYSCHAR message for some key combinations which are reserved by the system r=m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Fri, 30 Sep 2016 17:32:34 +0900 - rev 361470
Push 1369 by jlorenzo@mozilla.com at Mon, 27 Feb 2017 14:59:41 +0000
Bug 1305943 Don't consume following WM_SYSCHAR message for some key combinations which are reserved by the system r=m_kato When key combination is reserved by the system, web apps shouldn't be able to consume the key events. In such case, we've decided that we never expose the key events in web contents (including chrome contents). Therefore, NativeKey stops dispatching keyboard events only for Alt+Space. However, new code of the fix of bug 1300003 always consumes WM_SYSCHAR which follows WM_SYSKEYDOWN of Alt+Space. This is the cause of bug 1305943. For fixing this bug, NativeKey should have a helper method, IsReservedBySystem(), and when it returns true, it should do nothing when Handle*Message() is called and should not consume following WM_SYSCHAR messages at handling WM_*KEYDOWN. Unfortunately, it's impossible to test this regression because nsDOMWindowUtils::SendNativeKeyEvent() may call nsIWidget::SynthesizeNativeKeyEvent() asynchronously. See <https://dxr.mozilla.org/mozilla-central/source/dom/base/nsDOMWindowUtils.cpp#1105-1108>. Therefore, it cannot return if it's consumed. MozReview-Commit-ID: 9ABh2rYNkFs
0bf2bbd0c300ade6567d0381481fd44b03960233: Bug 1306549 part.10 Reorder member declaration of KeyboardLayout class r=m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Tue, 04 Oct 2016 16:37:07 +0900 - rev 361469
Push 1369 by jlorenzo@mozilla.com at Mon, 27 Feb 2017 14:59:41 +0000
Bug 1306549 part.10 Reorder member declaration of KeyboardLayout class r=m_kato We usually declare class members with following order: 1. public members 2. private members 3. friends However, current KeyboardLayout is declared with completely opposite order. Let's use usual order for preventing mistakes. MozReview-Commit-ID: LwOcEUbJzes
be15fd5862d35175c6d70db7a1e2e924aa4d05f3: Bug 1306549 part.9 Create KeyboardLayout::IsInDeadKeySequence() which returns true while it's in a dead key sequence r=m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Fri, 30 Sep 2016 15:55:51 +0900 - rev 361468
Push 1369 by jlorenzo@mozilla.com at Mon, 27 Feb 2017 14:59:41 +0000
Bug 1306549 part.9 Create KeyboardLayout::IsInDeadKeySequence() which returns true while it's in a dead key sequence r=m_kato Currently, checking if it's in dead key sequence directly refers mActiveDeadKey. However, this isn't clear for most developers. So, let's create a helper method, IsInDeadKeySequence(), and wrap the nonintuitive check. MozReview-Commit-ID: 7qTer9R8Gfs
7dbd5e61db3794bfbe2c4bc0679ce565146bb90d: Bug 1306549 part.8 Get rid of |virtualKey| and |isKeyDown| from KeyboardLayout::InitNativeKey() and KeyboardLayout::MaybeInitNativeKeyAsDeadKey() r=m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Fri, 30 Sep 2016 15:40:40 +0900 - rev 361467
Push 1369 by jlorenzo@mozilla.com at Mon, 27 Feb 2017 14:59:41 +0000
Bug 1306549 part.8 Get rid of |virtualKey| and |isKeyDown| from KeyboardLayout::InitNativeKey() and KeyboardLayout::MaybeInitNativeKeyAsDeadKey() r=m_kato For preventing wrapping long lines, old KeyboardLayout::InitNativeKey() uses two variables |virtualKey| and |isKeyDown| which are never modified. However, they may be not clear for some developers where they came from. Additionally, preceding patches reduced a lot of users of them and indent level. Therefore, even if we remove these variables, we don't need additional line breaks in most cases. So, removing them is better for easier to understand. MozReview-Commit-ID: 680bYVINPAE
489e11449d8e62b1eee742090ad177762d9dab2d: Bug 1306549 part.7 Create KeyboardLayout::MaybeInitNativeKeyAsDeadKey() r=m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Fri, 30 Sep 2016 16:06:00 +0900 - rev 361466
Push 1369 by jlorenzo@mozilla.com at Mon, 27 Feb 2017 14:59:41 +0000
Bug 1306549 part.7 Create KeyboardLayout::MaybeInitNativeKeyAsDeadKey() r=m_kato This patch creates KeyboardLayout::MaybeInitNativeKeyAsDeadKey() for wrapping dead key handling code in KeyboardLayout::InitNativeKey(). This makes InitNativeKey() code simpler. Now, any developers must be able to understand what InitNativeKey() does easier than before fixing this bug. MozReview-Commit-ID: C59ESUXeTxU
9be247c306a1250c8416feb2f68d284a5e3f4942: Bug 1306549 part.6 Create KeyboardLayout::ActivateDeadKeyState() r=m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Fri, 16 Sep 2016 19:09:12 +0900 - rev 361465
Push 1369 by jlorenzo@mozilla.com at Mon, 27 Feb 2017 14:59:41 +0000
Bug 1306549 part.6 Create KeyboardLayout::ActivateDeadKeyState() r=m_kato There is DeactivateDeadKeyState() but not ActivateDeadKeyState(). There should be both of them and hides the dead key state management into them. MozReview-Commit-ID: JvAPE5f2HVy
adba65212c35be06d1fb6a46303f1583525fe9bd: Bug 1306549 part.5 Create KeyboardLayout::GetCompositeChar() for wrapping VirtualKey::GetCompositeChar() r=m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Fri, 16 Sep 2016 18:54:48 +0900 - rev 361464
Push 1369 by jlorenzo@mozilla.com at Mon, 27 Feb 2017 14:59:41 +0000
Bug 1306549 part.5 Create KeyboardLayout::GetCompositeChar() for wrapping VirtualKey::GetCompositeChar() r=m_kato VirtualKey::GetCompositeChar() needs index of virtual keycode which may make around the caller messy. So, KeyboardLayout::GetCompositeChar() should wrap it and KeyboardLayout::MaybeInitNativeKeyWithCompositeChar() should use it. MozReview-Commit-ID: 8KLTJpCFZ8u
fd077161e636ef594f21b1c541f01c7a6701780b: Bug 1306549 part.4 Create KeyboardLayout::GetNativeUniCharsAndModifiers() for wrapping VirtualKey::GetNativeUniChars() r=m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Fri, 16 Sep 2016 18:38:53 +0900 - rev 361463
Push 1369 by jlorenzo@mozilla.com at Mon, 27 Feb 2017 14:59:41 +0000
Bug 1306549 part.4 Create KeyboardLayout::GetNativeUniCharsAndModifiers() for wrapping VirtualKey::GetNativeUniChars() r=m_kato Similar to VirtualKey::GetUniChars(), VirtualKey::GetNativeUniChars() needs key index. So, it should be wrapped by a new helper method, KeyboardLayout::GetNativeUniCharsAndModifiers(), and KeyboardEvent::InitNativeKey() should use this instead of accessing its member's GetNativeUniChars(). MozReview-Commit-ID: 7M9OlNF698Y
2e45f263fb199c054454f1c841160a7ff01c7173: Bug 1306549 part.3 KeyboardLayout::InitNativeKey() should use GetUniCharsAndModifiers() instead of using VirtualKey::GetUniChars() directly r=m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Fri, 16 Sep 2016 18:22:12 +0900 - rev 361462
Push 1369 by jlorenzo@mozilla.com at Mon, 27 Feb 2017 14:59:41 +0000
Bug 1306549 part.3 KeyboardLayout::InitNativeKey() should use GetUniCharsAndModifiers() instead of using VirtualKey::GetUniChars() directly r=m_kato When InitNativeKey() retrieves UniCharsAndModifiers for a key, it needs key index for the given virtual keycode. Therefore, wrapping the code with GetUniCharsAndModifiers() makes InitNativeKey() code simpler since each call specifies the virtual keycode to the method instead of key index. MozReview-Commit-ID: Azy8chXexaz
bb92cb94dcac0e4c968d6c712ef1fded2b5d6567: Bug 1306549 part.2 Create overload methods which take ModifierKeyState instead of VirtualKey::ShiftState r=m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Fri, 30 Sep 2016 15:32:10 +0900 - rev 361461
Push 1369 by jlorenzo@mozilla.com at Mon, 27 Feb 2017 14:59:41 +0000
Bug 1306549 part.2 Create overload methods which take ModifierKeyState instead of VirtualKey::ShiftState r=m_kato This patch gets rid of |shiftState| from KeyboardLayout::InitNativeKey() and make each caller clearer. This must make other developers understand what modifier state is used at each call. MozReview-Commit-ID: 6zydP1jkffv
54940e9b9a1b663c95782dde5d6e8aa02caa7231: Bug 1306549 part.1 KeyboardLayout::InitNativeKey() should use KeyboardLayout::IsDeadKey() r=m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Fri, 16 Sep 2016 17:24:39 +0900 - rev 361460
Push 1369 by jlorenzo@mozilla.com at Mon, 27 Feb 2017 14:59:41 +0000
Bug 1306549 part.1 KeyboardLayout::InitNativeKey() should use KeyboardLayout::IsDeadKey() r=m_kato KeyboardLayout::InitNativeKey() is very messy because it handles a lot of cases without helper methods. It's important to make it simpler implementation for preventing regressions caused by some patches which are written with misunderstanding. So, let's rewrite the method with helper method. First, this patch make InitNativeKey() use IsDeadKey() instead of referring the table because calling IsDeadKey() is easier to understand. MozReview-Commit-ID: DtN9qoh7Gz7
0d72f5bf9cb4ba7aaef36b41c4a75be450791467: Bug 1303236 - Skip check_vanilla_allocations if -flto flag is set; r=glandium
Enes Goktas <egoktas@mozilla.com> - Wed, 21 Sep 2016 12:31:41 -0700 - rev 361459
Push 1369 by jlorenzo@mozilla.com at Mon, 27 Feb 2017 14:59:41 +0000
Bug 1303236 - Skip check_vanilla_allocations if -flto flag is set; r=glandium MozReview-Commit-ID: 7WOz6LpRP7L
22d95521160beb0c26e6dcee7c979e0cb617bb56: Bug 1303227 - Wrap libxul.so linker to prevent getting the linking process killed; r=glandium
Enes Goktas <egoktas@mozilla.com> - Tue, 20 Sep 2016 17:58:34 -0700 - rev 361458
Push 1369 by jlorenzo@mozilla.com at Mon, 27 Feb 2017 14:59:41 +0000
Bug 1303227 - Wrap libxul.so linker to prevent getting the linking process killed; r=glandium This patch removes the memory usage tracking in the script that wraps the linking of the xul library. This patch also generalizes the wrapping of the xul linking process to all platforms. MozReview-Commit-ID: HyncF3aVwdx
02e7753c526100e7041d94dbc4ae2514d4c093fd: Bug 1306566 - Remove the check for mIsVisible from MDSM::DonePrerollingVideo(). r=kamidphish
JW Wang <jwwang@mozilla.com> - Fri, 30 Sep 2016 16:11:58 +0800 - rev 361457
Push 1369 by jlorenzo@mozilla.com at Mon, 27 Feb 2017 14:59:41 +0000
Bug 1306566 - Remove the check for mIsVisible from MDSM::DonePrerollingVideo(). r=kamidphish MozReview-Commit-ID: GIEibT6YKmC
42c95d88aaaa7c2eca1d278399421d437441ac4d: merge mozilla-inbound to mozilla-central a=merge
Carsten "Tomcat" Book <cbook@mozilla.com> - Tue, 04 Oct 2016 11:58:07 +0200 - rev 361456
Push 1369 by jlorenzo@mozilla.com at Mon, 27 Feb 2017 14:59:41 +0000
merge mozilla-inbound to mozilla-central a=merge
40f8f400737a01edca17c982fecf3788419e1e91: Backed out changeset cf588a950083 (bug 1306235) for failures in at least test_xhr_progressevents.html and test_blobconstructor.html
Phil Ringnalda <philringnalda@gmail.com> - Mon, 03 Oct 2016 23:30:44 -0700 - rev 361455
Push 1369 by jlorenzo@mozilla.com at Mon, 27 Feb 2017 14:59:41 +0000
Backed out changeset cf588a950083 (bug 1306235) for failures in at least test_xhr_progressevents.html and test_blobconstructor.html MozReview-Commit-ID: HJlw9w1quhu
c9be4dec127165fa4967e9fee4c54b18195042c9: Bug 1305970 - land NSS 0xe7553afc7665, r=me
Franziskus Kiefer <franziskuskiefer@gmail.com> - Tue, 04 Oct 2016 07:59:19 +0200 - rev 361454
Push 1369 by jlorenzo@mozilla.com at Mon, 27 Feb 2017 14:59:41 +0000
Bug 1305970 - land NSS 0xe7553afc7665, r=me
607f7f0e140a801a2a9a62e461b9220f10044bef: Bug 1286911. r=wchen.
Henri Sivonen <hsivonen@hsivonen.fi> - Tue, 27 Sep 2016 13:47:53 +0300 - rev 361453
Push 1369 by jlorenzo@mozilla.com at Mon, 27 Feb 2017 14:59:41 +0000
Bug 1286911. r=wchen. MozReview-Commit-ID: hzAu0jKAxt
cf588a9500836adbf84aad383bbc1f0b48ceb6fd: Bug 1306235 - XHR should set lengthComputable only if total value is set, r=wisniewskit, r=smaug
Andrea Marchesini <amarchesini@mozilla.com> - Tue, 04 Oct 2016 07:31:26 +0200 - rev 361452
Push 1369 by jlorenzo@mozilla.com at Mon, 27 Feb 2017 14:59:41 +0000
Bug 1306235 - XHR should set lengthComputable only if total value is set, r=wisniewskit, r=smaug
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 +100000 tip