2f913db74eb514ea53dccc1d1f4bfe636a7c8391: Bug 1509446 - part8 : modify wpt 'activeCues.html'. r=jya
Alastor Wu <alwu@mozilla.com> - Thu, 07 Mar 2019 19:25:56 +0000 - rev 523967
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1509446 - part8 : modify wpt 'activeCues.html'. r=jya According to the spec [1], activeCues attribute must return a `live` TextTrackCueList object, so we should get the correct cue list immediately, no need to wait for next event loop. [1] https://html.spec.whatwg.org/multipage/media.html#dom-texttrack-activecues Differential Revision: https://phabricator.services.mozilla.com/D22152
b2ad34980053a07a6673cb5b47f9be162ff7a981: Bug 1509446 - part7 : add a reftest. r=jya
Alastor Wu <alwu@mozilla.com> - Tue, 05 Mar 2019 19:49:32 +0000 - rev 523966
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1509446 - part7 : add a reftest. r=jya Adding a reftest to ensure we would update the cue display after removing cue from the text track, the removed cue should not display on the video's rendering area. Differential Revision: https://phabricator.services.mozilla.com/D21144
a0d8bc1dab63df42cffdc450b98ba606d94de445: Bug 1509446 - part6 : update cues display without checking whether cue is active or not. r=jya
Alastor Wu <alwu@mozilla.com> - Tue, 05 Mar 2019 19:48:31 +0000 - rev 523965
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1509446 - part6 : update cues display without checking whether cue is active or not. r=jya We should update cue display everytime when the cues list changed. In addition, we shouldn't check whether cue is active when we update display, because it's always inactive when the cue has been removed from `TextTrack::RemoveCue()`. Differential Revision: https://phabricator.services.mozilla.com/D21143
057318480b0eea6a017f4c7abb036ee4319401c1: Bug 1509446 - part5 : enable wpt test 'track-cues-enter-exit.html'. r=jya
Alastor Wu <alwu@mozilla.com> - Thu, 07 Mar 2019 19:24:20 +0000 - rev 523964
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1509446 - part5 : enable wpt test 'track-cues-enter-exit.html'. r=jya Fix the missing parameter in `cueEntered()` and enable this wpt. Differential Revision: https://phabricator.services.mozilla.com/D22151
ad7bfe5bbc3a2f5f04a85365d4c320cac94d8525: Bug 1509446 - part4 : remove set dirty. r=jya
Alastor Wu <alwu@mozilla.com> - Thu, 07 Mar 2019 19:24:02 +0000 - rev 523963
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1509446 - part4 : remove set dirty. r=jya As the `active cues list` would be automatically contruct when there are any active cues being added or inactive cues being removed, we have no need to use dirty to reset the `active cues list`. Differential Revision: https://phabricator.services.mozilla.com/D22150
d1046aea2e0e1bca30de7d44b08bf56915a5aefc: Bug 1509446 - part3 : run 'TimeMarchesOn' directly, instead of queuing a task. r=jya
Alastor Wu <alwu@mozilla.com> - Fri, 08 Mar 2019 03:12:42 +0000 - rev 523962
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1509446 - part3 : run 'TimeMarchesOn' directly, instead of queuing a task. r=jya According to the spec [1], we should run `TimeMarchesOn` algorithm directly when the specific situations happen, the spec doesn't say that we need to queue a task for it. In addition, all the call sites for `TimeMarchesOn` are on the main thread, so we don't need to worry about race condition. [1] https://html.spec.whatwg.org/multipage/media.html#playing-the-media-resource:time-marches-on-2 https://html.spec.whatwg.org/multipage/media.html#playing-the-media-resource:time-marches-on-3 https://html.spec.whatwg.org/multipage/media.html#playing-the-media-resource:time-marches-on-4 Differential Revision: https://phabricator.services.mozilla.com/D22149
fa26e1068b50e500135204c3cd3a0fdea9db2757: Bug 1509446 - part2 : use current cue in 'TimeMarchesOn' algorithm. r=jya
Alastor Wu <alwu@mozilla.com> - Thu, 07 Mar 2019 19:21:22 +0000 - rev 523961
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1509446 - part2 : use current cue in 'TimeMarchesOn' algorithm. r=jya According to the spec [1], the `current cue` is not equal with the `active cue`, because it might contain non active cues, which might be set to active later during the `TimeMarchesOn`. The `current cue` should be a list of cues, initialized to contain all the cues of all the hidden or showing text tracks of the media element (not the disabled ones) whose start times are less than or equal to the current playback position and whose end times are greater than the current playback position. [1] https://html.spec.whatwg.org/multipage/media.html#time-marches-on Differential Revision: https://phabricator.services.mozilla.com/D22148
3944dae3dabd2963ffd9d75cdad0a8968934ddb7: Bug 1509446 - part1 : update active cues list when cue's active state changed. r=jya
Alastor Wu <alwu@mozilla.com> - Fri, 08 Mar 2019 03:10:45 +0000 - rev 523960
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1509446 - part1 : update active cues list when cue's active state changed. r=jya According to spec [1], `activeCues` should represent a subset of the text track cues whose active flag was set when the script started. We should only depend on the `TimeMarchesOn` algorithm which will change cue's active state, and then add or remove cue to `activeCues`. [1] https://html.spec.whatwg.org/multipage/media.html#dom-texttrack-activecues Differential Revision: https://phabricator.services.mozilla.com/D22147
df1b1891f2f85f34846067282ada1a5260d37139: Bug 1533127 - Force unsigned operation. r=gerald
Jean-Yves Avenard <jyavenard@mozilla.com> - Fri, 08 Mar 2019 03:03:16 +0000 - rev 523959
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1533127 - Force unsigned operation. r=gerald 1 << 31 is defined since C++14 and produces INT_MIN, but subtracting any positive number from INT_MIN would result in a signed overflow. This can be avoided by making the first argument unsigned (and in this case the second argument will be converted to unsigned as well.) Differential Revision: https://phabricator.services.mozilla.com/D22482
22b988a39a32a7dc02051aff5426bb02ad0b751c: Bug 1466208 - part 35: Reduce one indent level in PresShell::EventHandler::HandleEventInternal() r=smaug
Masayuki Nakano <masayuki@d-toybox.com> - Thu, 07 Mar 2019 06:30:36 +0000 - rev 523958
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1466208 - part 35: Reduce one indent level in PresShell::EventHandler::HandleEventInternal() r=smaug If `aEvent` requires frame but there is no event target, `PresShell::EventHandler::HandleEventInternal()` just records the response time. So, we can reduce one indent level in the big method. Note that I'm not sure recording the response time in such case because the *good* values may make the average and median better. But this is out of scope of bug 1466208. Differential Revision: https://phabricator.services.mozilla.com/D21336
3573ac73853a361bee85971f394e3e8e26a03784: Bug 1533556 - disable devtools/client/accessibility/test/browser/browser_accessibility_panel_highlighter.js r=jmaher
Edwin Gao <egao@mozilla.com> - Fri, 08 Mar 2019 00:04:47 +0000 - rev 523957
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1533556 - disable devtools/client/accessibility/test/browser/browser_accessibility_panel_highlighter.js r=jmaher A new failure cropped up when preceding tests were disabled. Differential Revision: https://phabricator.services.mozilla.com/D22609
14d642e940b23c3ad2531b2375ff57e99e5c599c: Bug 1533534 - disable browser_accessibility_mutations.js r=jmaher
Edwin Gao <egao@mozilla.com> - Thu, 07 Mar 2019 21:22:42 +0000 - rev 523956
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1533534 - disable browser_accessibility_mutations.js r=jmaher Depends on D22597 Differential Revision: https://phabricator.services.mozilla.com/D22598
b2a4a77d583b2f37ee9721f8d8d1e238a0d1b937: Bug 1533529 - disable browser_inspector_addNode_01.js, browser_inspector_addNode_02.js r=jmaher
Edwin Gao <egao@mozilla.com> - Thu, 07 Mar 2019 21:23:14 +0000 - rev 523955
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1533529 - disable browser_inspector_addNode_01.js, browser_inspector_addNode_02.js r=jmaher Depends on D22596 Differential Revision: https://phabricator.services.mozilla.com/D22597
e88f596100e887d73496b62c297fc682d6925f06: Bug 1531584 - disable browser_markup_anonymous_02/03/04.js r=jmaher
Edwin Gao <egao@mozilla.com> - Thu, 07 Mar 2019 21:21:53 +0000 - rev 523954
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1531584 - disable browser_markup_anonymous_02/03/04.js r=jmaher Depends on D22595 Differential Revision: https://phabricator.services.mozilla.com/D22596
2ba6900e81cb9f076d9adcadf1262d57fa605a33: Bug 1533507 - disable devtools/client/inspector/markup/test/browser_markup_shadowdom_open_debugger.js r=jmaher
Edwin Gao <egao@mozilla.com> - Thu, 07 Mar 2019 21:21:10 +0000 - rev 523953
Push 2032 by ffxbld-merge at Mon, 13 May 2019 09:36:57 +0000
Bug 1533507 - disable devtools/client/inspector/markup/test/browser_markup_shadowdom_open_debugger.js r=jmaher Depends on D22594 Differential Revision: https://phabricator.services.mozilla.com/D22595
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -15 +15 +100 +300 +1000 +3000 +10000 +30000 +100000 tip