1d11b6bedc3057a1cfea8762d17874b6567c836b: Bug 1453541 - Part 3: Add reftests. r=mstange, a=RyanVM
Matt Woodrow <mwoodrow@mozilla.com> - Sun, 15 Apr 2018 16:38:45 +1200 - rev 473350
Push 1728 by jlund@mozilla.com at Mon, 18 Jun 2018 21:12:27 +0000
Bug 1453541 - Part 3: Add reftests. r=mstange, a=RyanVM MozReview-Commit-ID: 95DOq6UBUnq
35c4b04bb305f9f6cdf9c58cc6e3e5ab4ca4ab08: Bug 1453541 - Part 2: Look for Out Of Flow frames with modified ancestors during ProcessFrame instead of during display list building. r=mstange, a=RyanVM
Matt Woodrow <mwoodrow@mozilla.com> - Sun, 15 Apr 2018 16:38:45 +1200 - rev 473349
Push 1728 by jlund@mozilla.com at Mon, 18 Jun 2018 21:12:27 +0000
Bug 1453541 - Part 2: Look for Out Of Flow frames with modified ancestors during ProcessFrame instead of during display list building. r=mstange, a=RyanVM MozReview-Commit-ID: KsgrFqr2gVN
f13fb5d37547d5e9d870bf92557f18354446883f: Bug 1453541 - Part 1: Move more code into ProcessFrame so that we can call it from multiple places. r=mstange, a=RyanVM
Matt Woodrow <mwoodrow@mozilla.com> - Sun, 15 Apr 2018 16:38:44 +1200 - rev 473348
Push 1728 by jlund@mozilla.com at Mon, 18 Jun 2018 21:12:27 +0000
Bug 1453541 - Part 1: Move more code into ProcessFrame so that we can call it from multiple places. r=mstange, a=RyanVM MozReview-Commit-ID: AOXPgteSgTL
ea0bb21de30467e052dbc8913e6571aae86d241e: Bug 1455462 - Part 6. Add test of confirming the position of 'all menu' popup. r=jdescottes, a=RyanVM
Mantaroh Yoshinaga <mantaroh@gmail.com> - Mon, 14 May 2018 17:19:00 -0400 - rev 473347
Push 1728 by jlund@mozilla.com at Mon, 18 Jun 2018 21:12:27 +0000
Bug 1455462 - Part 6. Add test of confirming the position of 'all menu' popup. r=jdescottes, a=RyanVM The accessing all menu button will be shown to the inspector, so this test will use inspector's this button. This button didn't have an id, so this patch will add id for testing. MozReview-Commit-ID: 2xFXYKwpQoe
abd62e896138d08e0fcf69542a0b3dec1b2cf11a: Bug 1455462 - Part 5. Add toolbox's menu position test. r=jdescottes, a=RyanVM
Mantaroh Yoshinaga <mantaroh@gmail.com> - Mon, 14 May 2018 17:19:00 -0400 - rev 473346
Push 1728 by jlund@mozilla.com at Mon, 18 Jun 2018 21:12:27 +0000
Bug 1455462 - Part 5. Add toolbox's menu position test. r=jdescottes, a=RyanVM This test will check that popup menu of toolbox will be displayed under the menu button. This test tolerates an error since some platform (like macOS) will add the offset value. (i.e. eIntID_ContextMenuOffsetHorizontal and eIntID_ContextMenuOffsetVertical) MozReview-Commit-ID: 5TaM5JiNhdk
181056a15e4ba770b13220a0547e88fc7e69dbf9: Bug 1455462 - Part 4. Use the async_task in devtool's zoom test. r=jdescottes, a=RyanVM
Mantaroh Yoshinaga <mantaroh@gmail.com> - Mon, 14 May 2018 17:19:00 -0400 - rev 473345
Push 1728 by jlund@mozilla.com at Mon, 18 Jun 2018 21:12:27 +0000
Bug 1455462 - Part 4. Use the async_task in devtool's zoom test. r=jdescottes, a=RyanVM This patch will change test to use the async_task before touching this tests and use the first decimal place when checking a result.
fa0085fa3c49f482d5734aa8800508a5dd3615a1: Bug 1455462 - Part 3. Use zoom value when showing popup menu. r=jdescottes, a=RyanVM
Mantaroh Yoshinaga <mantaroh@gmail.com> - Mon, 14 May 2018 17:18:00 -0400 - rev 473344
Push 1728 by jlund@mozilla.com at Mon, 18 Jun 2018 21:12:27 +0000
Bug 1455462 - Part 3. Use zoom value when showing popup menu. r=jdescottes, a=RyanVM The openPopupAtScreen() use the zoomed css coordinate value as position value, devtools's caller of this function use css pixel value without zoom. So position of popup will missaligned if zooming out/in the devtool panel.
69dec209ab576d4c6af7fe85b3fa16cca495a89a: Bug 1455462 - Part 2. Use the rounded zoom value of devtool panel. r=jdescottes, a=RyanVM
Mantaroh Yoshinaga <mantaroh@gmail.com> - Mon, 14 May 2018 17:17:00 -0400 - rev 473343
Push 1728 by jlund@mozilla.com at Mon, 18 Jun 2018 21:12:27 +0000
Bug 1455462 - Part 2. Use the rounded zoom value of devtool panel. r=jdescottes, a=RyanVM This patch will use rounded zoom value of dev tool panel. This changes will ensure the zoom value test.
d234aa23f84f8c13a301c95787c06f60a4ed8ba0: Bug 1455462 - Part 1. Use the toolbox.zoomIn3.key shortcut. r=ochameau, a=RyanVM
Mantaroh Yoshinaga <mantaroh@gmail.com> - Mon, 14 May 2018 17:17:00 -0400 - rev 473342
Push 1728 by jlund@mozilla.com at Mon, 18 Jun 2018 21:12:27 +0000
Bug 1455462 - Part 1. Use the toolbox.zoomIn3.key shortcut. r=ochameau, a=RyanVM This key will empty string, so we don't use this key now. But we might use this key in the future.
594d4ff3b55bca69fedc366b0573bf17e204f118: Bug 1460767 - Return device ineligible when appropriate for U2F. r=ttaubert, a=RyanVM
J.C. Jones <jjones@mozilla.com> - Thu, 10 May 2018 16:36:18 -0700 - rev 473341
Push 1728 by jlund@mozilla.com at Mon, 18 Jun 2018 21:12:27 +0000
Bug 1460767 - Return device ineligible when appropriate for U2F. r=ttaubert, a=RyanVM Summary: FIDO U2F's specification says that when the wrong security key responds to a signature, or when an already-registered key exists, that the UA should return error code 4, DEVICE_INELIGIBLE. We used to do that, but adjusted some things for WebAuthn and now we don't. This changes the soft token to return that at the appropriate times, and updates the expectations of U2F.cpp that it should use InvalidStateError as the signal to reutrn DEVICE_INELIGIBLE. Also, note that WebAuthn's specification says that if any authenticator returns "InvalidStateError" that it should be propagated, as it indicates that the authenticator obtained user consent and failed to complete its job [1]. This change to the Soft Token affects the WebAuthn tests, but in a good way. Reading the WebAuthn spec, we should not be returning NotAllowedError when there is consent from the user via the token (which the softtoken always deliveres). As such, this adjusts the affected WebAuthn tests, and adds a couple useful checks to test_webauthn_get_assertion.html for future purposes. [1] https://w3c.github.io/webauthn/#createCredential section 5.1.3 "Create a new credential", Step 20, Note 2: "If any authenticator returns an error status equivalent to "InvalidStateError"..." Test Plan: https://treeherder.mozilla.org/#/jobs?repo=try&revision=f2fc930f7fc8eea69b1ebc96748fe95e150a92a4 Reviewers: ttaubert Bug #: 1460767 Differential Revision: https://phabricator.services.mozilla.com/D1269
305d61ed533a4e3672d278128322f564dde378d6: Bug 1460287 - Use black as a fallback for textcolor and always set lwtheme attribute if theme is active. r=dao, a=RyanVM
Gijs Kruitbosch <gijskruitbosch@gmail.com> - Fri, 11 May 2018 18:48:53 +0100 - rev 473340
Push 1728 by jlund@mozilla.com at Mon, 18 Jun 2018 21:12:27 +0000
Bug 1460287 - Use black as a fallback for textcolor and always set lwtheme attribute if theme is active. r=dao, a=RyanVM MozReview-Commit-ID: 30NKcuz94d
6247c3de81214476abc9d6f30465db4a4402441f: Bug 1461750 - Backout blocklist signature verification from Firefox 61. r=leplatrem, a=RyanVM
Ryan VanderMeulen <ryanvm@gmail.com> - Wed, 16 May 2018 19:44:47 -0400 - rev 473339
Push 1728 by jlund@mozilla.com at Mon, 18 Jun 2018 21:12:27 +0000
Bug 1461750 - Backout blocklist signature verification from Firefox 61. r=leplatrem, a=RyanVM
1b250783a12f4a9c1caee3a1a8f6eeb6f5fb2df0: Bug 1440865 - Stop overriding tabbrowser-tabpanels' background for [pendingpaint]. r=mconley, a=RyanVM
Dão Gottwald <dao@mozilla.com> - Tue, 15 May 2018 11:37:09 +0200 - rev 473338
Push 1728 by jlund@mozilla.com at Mon, 18 Jun 2018 21:12:27 +0000
Bug 1440865 - Stop overriding tabbrowser-tabpanels' background for [pendingpaint]. r=mconley, a=RyanVM MozReview-Commit-ID: 42yr3JYMjWJ
c0246ac14207d82a8f46b0e1679304c06818364a: Bug 1461696 - Add telemetry for DOMAttrModified event. r=smaug, a=RyanVM
Xidorn Quan <me@upsuper.org> - Wed, 16 May 2018 08:42:48 +1000 - rev 473337
Push 1728 by jlund@mozilla.com at Mon, 18 Jun 2018 21:12:27 +0000
Bug 1461696 - Add telemetry for DOMAttrModified event. r=smaug, a=RyanVM MozReview-Commit-ID: D6cjCJB92ex
64f47af70eb40d1b170e76498ac8fd0220aeef7a: Bug 1461326 - Add some release assertions to dom/clients/manager code. r=baku, a=RyanVM
Ben Kelly <ben@wanderview.com> - Tue, 15 May 2018 08:53:54 -0700 - rev 473336
Push 1728 by jlund@mozilla.com at Mon, 18 Jun 2018 21:12:27 +0000
Bug 1461326 - Add some release assertions to dom/clients/manager code. r=baku, a=RyanVM
e68716a3b4fe7e1910ab57e539340bd176ab84f5: Bug 1459899 - Reuse previous values when updating an existing rollout. r=Gijs, a=RyanVM
Mike Cooper <mcooper@mozilla.com> - Thu, 10 May 2018 15:35:14 -0700 - rev 473335
Push 1728 by jlund@mozilla.com at Mon, 18 Jun 2018 21:12:27 +0000
Bug 1459899 - Reuse previous values when updating an existing rollout. r=Gijs, a=RyanVM MozReview-Commit-ID: 3kHo7b69vdS
dd12c80cff71af9c113d5919577169538d2bc873: Bug 1460301 - Web Authentication - Don't use U2F_PING to initialize tokens. r=jcj, a=RyanVM
Tim Taubert <ttaubert@mozilla.com> - Mon, 14 May 2018 17:37:47 +0200 - rev 473334
Push 1728 by jlund@mozilla.com at Mon, 18 Jun 2018 21:12:27 +0000
Bug 1460301 - Web Authentication - Don't use U2F_PING to initialize tokens. r=jcj, a=RyanVM Reviewers: jcj Reviewed By: jcj Bug #: 1460301 Differential Revision: https://phabricator.services.mozilla.com/D1270
0819f088efec2a36349302ffc450d7f478e2300f: Bug 1459513 - Handle null uri components gracefully in WebAppManifest. r=snorp, a=RyanVM
Dylan Roeh <droeh@mozilla.com> - Fri, 11 May 2018 16:28:51 -0500 - rev 473333
Push 1728 by jlund@mozilla.com at Mon, 18 Jun 2018 21:12:27 +0000
Bug 1459513 - Handle null uri components gracefully in WebAppManifest. r=snorp, a=RyanVM
7a8b8efc8098c0c6a9038e405c3175935e60340d: Bug 1364624 - Part 2: Switch from CRITICALSECTION to SRWLOCK. r=froydnj, a=RyanVM
Eric Rahm <erahm@mozilla.com> - Fri, 27 Apr 2018 16:48:47 -0700 - rev 473332
Push 1728 by jlund@mozilla.com at Mon, 18 Jun 2018 21:12:27 +0000
Bug 1364624 - Part 2: Switch from CRITICALSECTION to SRWLOCK. r=froydnj, a=RyanVM
9c083d037ce2528c1914c683902c0198afb7cd25: Bug 1364624 - Part 1: Manually manage locks in MessageChannel::Close. r=froydnj, a=RyanVM
Eric Rahm <erahm@mozilla.com> - Thu, 26 Apr 2018 17:14:22 -0700 - rev 473331
Push 1728 by jlund@mozilla.com at Mon, 18 Jun 2018 21:12:27 +0000
Bug 1364624 - Part 1: Manually manage locks in MessageChannel::Close. r=froydnj, a=RyanVM This switches over to manually managing the locking in MessageChannel::Close in order to avoid a deadlock on msvc opt builds. It has the added benefit of avoid a superfluous lock/unlock pair.
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 tip