1b868efa368f0e8f2caa4df8568fca04f756a00e: Bug 1368209 - Refactor `Engine::_processIncoming` into three stages. r=eoger,tcsc
Kit Cambridge <kit@yakshaving.ninja> - Wed, 01 Nov 2017 11:09:57 -0700 - rev 443233
Push 1618 by Callek@gmail.com at Thu, 11 Jan 2018 17:45:48 +0000
Bug 1368209 - Refactor `Engine::_processIncoming` into three stages. r=eoger,tcsc * In the first stage, we fetch changed records, newest first, up to the download limit. We keep track of the oldest record modified time we see. * Once we've fetched all records, we reconcile, noting records that fail to decrypt or reconcile for the next sync. We then ask the store to apply all remaining records. Previously, `applyIncomingBatchSize` specified how many records to apply at a time. I removed this because it added an extra layer of indirection that's no longer necessary, now that download batching buffers all records in memory, and all stores are async. * In the second stage, we fetch IDs for all remaining records changed between the last sync and the oldest modified time we saw in the first stage. We *don't* set the download limit here, to ensure we add *all* changed records to our backlog, and we use the `"oldest"` sort order instead of `"index"`. * In the third stage, we backfill as before. We don't want large deltas to delay other engines from syncing, so we still only take IDs up to the download limit from the backlog, and include failed IDs from the previous sync. On subsequent syncs, we'll keep fetching from the backlog until it's empty. Other changes to note in this patch: * `Collection::_rebuildURL` now allows callers to specify both `older` and `newer`. According to :rfkelly, this is explicitly and intentionally supported. * Tests that exercise `applyIncomingBatchSize` are gone, since that's no longer a thing. * The test server now shuffles records if the sort order is unspecified. MozReview-Commit-ID: 4EXvNOa8mIo
b88c681ccdc1614c3589730e72ac37ff342d22a7: Bug 1368209 - Add a test for fetching backlogged history records. r=tcsc
Kit Cambridge <kit@yakshaving.ninja> - Fri, 27 Oct 2017 17:54:48 -0700 - rev 443232
Push 1618 by Callek@gmail.com at Thu, 11 Jan 2018 17:45:48 +0000
Bug 1368209 - Add a test for fetching backlogged history records. r=tcsc The test captures the existing logic in `_processIncoming`, even though it's not quite correct: * First, we fetch all records changed since the last sync, up to the download limit, and without an explicit sort order. This happens to work correctly now because the Python server uses "newest" by default, but can change in the future. * If we reached the download limit fetching records, we request IDs for all records changed since the last sync, also up to the download limit, and sorted by index. This is likely to return IDs for records we've already seen, since the index is based on the frecency. It's also likely to miss IDs for other changed records, because the number of changed records might be higher than the download limit. * Since we then fast-forward the last sync time, we'll never download any remaining changed records that we didn't add to our backlog. * Finally, we backfill previously failed and backlogged records. MozReview-Commit-ID: 7uQLXMseMIU
4b8e56844ae98e4129f567c23491f34d4f6ce708: Bug 1368209 - Add support for `sortindex` and `older` to the mock Sync server. r=tcsc
Kit Cambridge <kit@yakshaving.ninja> - Fri, 27 Oct 2017 17:55:30 -0700 - rev 443231
Push 1618 by Callek@gmail.com at Thu, 11 Jan 2018 17:45:48 +0000
Bug 1368209 - Add support for `sortindex` and `older` to the mock Sync server. r=tcsc MozReview-Commit-ID: 6YI1OEE8x7R
12f7bd502d4dbff24bc1e381de45df9c41cf5f6f: Bug 1403358 Only reference ActivationContext if Acessibility is enabled r=aklotz
Tom Ritter <tom@mozilla.com> - Thu, 26 Oct 2017 15:09:50 -0500 - rev 443230
Push 1618 by Callek@gmail.com at Thu, 11 Jan 2018 17:45:48 +0000
Bug 1403358 Only reference ActivationContext if Acessibility is enabled r=aklotz This also enables the crash reporter on the MinGW build, as this is the only thing blocking that from working. MozReview-Commit-ID: Hygd7UUQvwl
9ee2bbdb739021cf352e4cac630d0bdd596b6c33: Bug 1413680 - DrawTargetRecording should return the real size instead of the dummy drawtarget's size. r=jrmuizel
Ethan Lin <ethlin@mozilla.com> - Thu, 02 Nov 2017 13:50:38 +0800 - rev 443229
Push 1618 by Callek@gmail.com at Thu, 11 Jan 2018 17:45:48 +0000
Bug 1413680 - DrawTargetRecording should return the real size instead of the dummy drawtarget's size. r=jrmuizel MozReview-Commit-ID: E63f8ZIGYm2
a16aef250227226e3abe41cf0e835fdbb57ded13: Bug 1413397 - Avoid empty border's fallback. r=kats
Ethan Lin <ethlin@mozilla.com> - Wed, 01 Nov 2017 17:30:04 +0800 - rev 443228
Push 1618 by Callek@gmail.com at Thu, 11 Jan 2018 17:45:48 +0000
Bug 1413397 - Avoid empty border's fallback. r=kats MozReview-Commit-ID: 1KXYjcObJdi
2c77266e1b40c7a67901de4c3ccca2554422da4a: Bug 1407561 - Lazy loading of tooltip text when user hovers the status column. r=gasolin
abhinav <abhinav.koppula@gmail.com> - Tue, 31 Oct 2017 08:27:21 +0530 - rev 443227
Push 1618 by Callek@gmail.com at Thu, 11 Jan 2018 17:45:48 +0000
Bug 1407561 - Lazy loading of tooltip text when user hovers the status column. r=gasolin MozReview-Commit-ID: BXP8B10Q5LT
e15cf10f369acd8129126525c349ade395abf876: Bug 1414097 - Convert nsDisplaySelectionOverlay to WebRender. r=ethlin
Markus Stange <mstange@themasta.com> - Thu, 02 Nov 2017 19:43:08 -0400 - rev 443226
Push 1618 by Callek@gmail.com at Thu, 11 Jan 2018 17:45:48 +0000
Bug 1414097 - Convert nsDisplaySelectionOverlay to WebRender. r=ethlin MozReview-Commit-ID: 5icpe4OR0Qa
efbfeacfdb9621ab2c67b2400cb89d92669b6c53: Bug 1411808. P3 - InitAsClone() shouldn't call |mMediaCache->OpenStream(this)| until initialization is done. r=gerald
JW Wang <jwwang@mozilla.com> - Thu, 26 Oct 2017 11:13:38 +0800 - rev 443225
Push 1618 by Callek@gmail.com at Thu, 11 Jan 2018 17:45:48 +0000
Bug 1411808. P3 - InitAsClone() shouldn't call |mMediaCache->OpenStream(this)| until initialization is done. r=gerald We don't want MediaCache to use a half-initialized stream. MozReview-Commit-ID: LjPLOYwy0Wd
875d91b29c311400cc3108f959da53d09bab66b3: Bug 1411808. P2 - don't call mClient->IsSuspended() off the main thread in Update(). r=gerald
JW Wang <jwwang@mozilla.com> - Tue, 24 Oct 2017 11:25:41 +0800 - rev 443224
Push 1618 by Callek@gmail.com at Thu, 11 Jan 2018 17:45:48 +0000
Bug 1411808. P2 - don't call mClient->IsSuspended() off the main thread in Update(). r=gerald By mirroring the suspend status of the client, Update() is able to make decisions on reading streams without calling mClient->IsSuspended(). MozReview-Commit-ID: G4gS2VGiMjj
f26682779a1841d5ff52797e9693dee02d8fbade: Bug 1411808. P1 - run Update() loops off the main thread. r=gerald
JW Wang <jwwang@mozilla.com> - Mon, 23 Oct 2017 17:12:07 +0800 - rev 443223
Push 1618 by Callek@gmail.com at Thu, 11 Jan 2018 17:45:48 +0000
Bug 1411808. P1 - run Update() loops off the main thread. r=gerald Note we will fix bugs required to run Update() off the main thread in the following patches. MozReview-Commit-ID: CYwT5kDjD9R
1955a40abe6fadb8a2a870a98a626e3e4b6bae40: Bug 1413484 - tighten some assertions. r=gerald
JW Wang <jwwang@mozilla.com> - Fri, 27 Oct 2017 22:17:41 +0800 - rev 443222
Push 1618 by Callek@gmail.com at Thu, 11 Jan 2018 17:45:48 +0000
Bug 1413484 - tighten some assertions. r=gerald mCallback->GetMediaOwner() now is always called before Close() and won't return null. So is owner->GetMediaElement(). MozReview-Commit-ID: HbxbyuogYAB
6af2bb14bd4c1ada3e9dc68ff9c40b3a9e0893e0: Bug 1413829 - RequestListContent scroll to bottom should avoid sync reflow r=Honza
Ricky Chien <ricky060709@gmail.com> - Thu, 02 Nov 2017 16:56:53 +0800 - rev 443221
Push 1618 by Callek@gmail.com at Thu, 11 Jan 2018 17:45:48 +0000
Bug 1413829 - RequestListContent scroll to bottom should avoid sync reflow r=Honza MozReview-Commit-ID: KwPVFJfRQQK
180cd6b0a9748b0de0c563a7d58d8be7eedc94c8: Bug 1413941 - Fix broken netmonitor launchpad regression from bug 1360457 r=Honza
Ricky Chien <ricky060709@gmail.com> - Thu, 02 Nov 2017 22:40:44 +0800 - rev 443220
Push 1618 by Callek@gmail.com at Thu, 11 Jan 2018 17:45:48 +0000
Bug 1413941 - Fix broken netmonitor launchpad regression from bug 1360457 r=Honza MozReview-Commit-ID: 6EzLlNfQ4FX
e6d86b7284bae701700b9d300ee1476ebe5f3eed: Bug 1414073 - Rename arena_bin_t fields. r=njn
Mike Hommey <mh+mozilla@glandium.org> - Fri, 03 Nov 2017 09:26:07 +0900 - rev 443219
Push 1618 by Callek@gmail.com at Thu, 11 Jan 2018 17:45:48 +0000
Bug 1414073 - Rename arena_bin_t fields. r=njn At the same time, fold malloc_bin_stats_t into it.
3aba4a72b8a524e137d45ae2e9545e6344fa584d: Bug 1413858 - Resume() needs to reset mPendingSeekOffset before calling Seek(). r=gerald
JW Wang <jwwang@mozilla.com> - Thu, 02 Nov 2017 20:25:57 +0800 - rev 443218
Push 1618 by Callek@gmail.com at Thu, 11 Jan 2018 17:45:48 +0000
Bug 1413858 - Resume() needs to reset mPendingSeekOffset before calling Seek(). r=gerald MozReview-Commit-ID: GbZ3SvSTMvR
92ff0c88e94d176ff9615abe61322413b7f38e55: servo: Merge #18750 - Make transforms generic (from Manishearth:transform-generic); r=emilio,xidorn
Manish Goregaokar <manishsmail@gmail.com> - Thu, 02 Nov 2017 17:02:07 -0500 - rev 443217
Push 1618 by Callek@gmail.com at Thu, 11 Jan 2018 17:45:48 +0000
servo: Merge #18750 - Make transforms generic (from Manishearth:transform-generic); r=emilio,xidorn This makes the specified and computed value of transform share a generic backing enum. This will eventually be a complete fix for https://bugzilla.mozilla.org/show_bug.cgi?id=1391145 , and also incidentally fixes https://bugzilla.mozilla.org/show_bug.cgi?id=1405881 Currently WIP -- the generic transform exists and is used, but this currently misses some animation and glue cases. Source-Repo: https://github.com/servo/servo Source-Revision: c494d25e24d515509a5d8bb86a30669ee01742b9
6bc39f03ea571fb109ae603b0c8f69778ec14384: Bug 1413648 fix default extension icon use, r=aswan
Shane Caraveo <scaraveo@mozilla.com> - Thu, 02 Nov 2017 15:49:38 -0700 - rev 443216
Push 1618 by Callek@gmail.com at Thu, 11 Jan 2018 17:45:48 +0000
Bug 1413648 fix default extension icon use, r=aswan MozReview-Commit-ID: 3Dh2DjGIAgn
008cf4865cb5cfd7766a7367875e184cf013c1c5: merge mozilla-central to mozilla-inbound. r=merge a=merge
Sebastian Hengst <archaeopteryx@coole-files.de> - Thu, 02 Nov 2017 23:19:03 +0100 - rev 443215
Push 1618 by Callek@gmail.com at Thu, 11 Jan 2018 17:45:48 +0000
merge mozilla-central to mozilla-inbound. r=merge a=merge
fe038577ea44764e107ebcb79c9844d3578bdf4d: Bug 1333126 - Use win64 PE unwind metadata to improve client-side stack walking; r=gsvelto
Carl Corcoran <carlco@gmail.com> - Sun, 06 Aug 2017 08:46:50 +0200 - rev 443214
Push 1618 by Callek@gmail.com at Thu, 11 Jan 2018 17:45:48 +0000
Bug 1333126 - Use win64 PE unwind metadata to improve client-side stack walking; r=gsvelto This includes tests that cover both regular CFI stack walking as well as pathological corner cases. MozReview-Commit-ID: GDARnPSemyu
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 +100000 tip