000398f8c373407ba621d56cbd3b370cf43469a8: Bug 1428589: Don't read a destroyed cookie list if the last cookie in the entry expired. r=jdm a=gchang
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 11 Jan 2018 14:12:38 +0200 - rev 445637
Push 1618 by Callek@gmail.com at Thu, 11 Jan 2018 17:45:48 +0000
Bug 1428589: Don't read a destroyed cookie list if the last cookie in the entry expired. r=jdm a=gchang Consider the following situation, which is what causes the failure: * `cookies` is an array of length 1 (either from the beginning, or because other cookies have been expired while in this loop). * the only cookie that remains is expired. We append the cookie to removedList, and then we call gCookieService->RemoveCookieFromList, which has the following code: if (aIter.entry->GetCookies().Length() == 1) { mDBState->hostTable.RawRemoveEntry(aIter.entry); } else { aIter.entry->GetCookies().RemoveElementAt(aIter.index); } If we enter the first branch, as it's the case, that will destroy the array. We're effectively removing stuff from the array while mutating it, which is scary. It's fine if we don't delete the array, since we iterate through it using indices, but still it's dangerous as heck. If we're the last element in the array though, we're doomed, because `cookies` is now destroyed. We not only try to access the array length again, but also we try to index on it the next time because we never stopped the loop (`i` is still zero, and the length may very well be garbage). Fix it by keeping the length in sync from the stack and breaking out from the loop if appropriately. MozReview-Commit-ID: 6qaC9yclvP2
e57848b337fcaeec8a8e23f45354603df11c2b5b: Bug 1396399 - Clarify rules for applying activeTab permission to content scripts. r=kmag, r=bz a=gchang
Andrew Swan <aswan@mozilla.com> - Sat, 04 Nov 2017 21:06:20 -0700 - rev 445636
Push 1618 by Callek@gmail.com at Thu, 11 Jan 2018 17:45:48 +0000
Bug 1396399 - Clarify rules for applying activeTab permission to content scripts. r=kmag, r=bz a=gchang MozReview-Commit-ID: 9xPDX8Qk2iR
3f7a950871b4587af63fae0e82f601e0f4f10ba6: Bug 1426449: set the correct number of temporal layers for screencasts r=drno a=gchang
Randell Jesup <rjesup@jesup.org> - Wed, 10 Jan 2018 20:41:03 -0500 - rev 445635
Push 1618 by Callek@gmail.com at Thu, 11 Jan 2018 17:45:48 +0000
Bug 1426449: set the correct number of temporal layers for screencasts r=drno a=gchang
398360c9d5c6fcc80d7ced94afe65ee7f672b0bf: Bug 1429542 Make HttpChannelChild::OverrideRunnable check for nullptr before using mNewChannel. r=asuth a=gchang
Ben Kelly <ben@wanderview.com> - Wed, 10 Jan 2018 14:45:17 -0500 - rev 445634
Push 1618 by Callek@gmail.com at Thu, 11 Jan 2018 17:45:48 +0000
Bug 1429542 Make HttpChannelChild::OverrideRunnable check for nullptr before using mNewChannel. r=asuth a=gchang
76192bc7ded10f07dd8eb314af1b268d2b0af248: Bug 1426500 - Disable WebVR for macOS on Beta and Release r=daoshengmu a=gchang
Kearwood "Kip" Gilbert <kgilbert@mozilla.com> - Wed, 10 Jan 2018 16:14:21 -0800 - rev 445633
Push 1618 by Callek@gmail.com at Thu, 11 Jan 2018 17:45:48 +0000
Bug 1426500 - Disable WebVR for macOS on Beta and Release r=daoshengmu a=gchang - WebVR will continue to be enabled on macOS for Nightly and Dev Edition MozReview-Commit-ID: LpEX13yZVbb
3a94f3140a144491cde0c1805afcd13ae9922b7f: bug 1422735 - Change symbol upload URL from Socorro to Tecken. r=nalexander a=gchang
Ted Mielczarek <ted@mielczarek.org> - Wed, 06 Dec 2017 06:28:41 -0500 - rev 445632
Push 1618 by Callek@gmail.com at Thu, 11 Jan 2018 17:45:48 +0000
bug 1422735 - Change symbol upload URL from Socorro to Tecken. r=nalexander a=gchang MozReview-Commit-ID: BBs6G8dFfPz
7047976f6bec7c8e611009b74456986e0045cfc9: Bug 1421214 - Try GoToAnchor() with unescaped string before using document's charset. r=smaug a=gchang
Alphan Chen <alchen@mozilla.com> - Fri, 05 Jan 2018 15:12:16 +0800 - rev 445631
Push 1618 by Callek@gmail.com at Thu, 11 Jan 2018 17:45:48 +0000
Bug 1421214 - Try GoToAnchor() with unescaped string before using document's charset. r=smaug a=gchang
ab58ba2c32b801fdf46eb753b889412e2ddab71a: Backed out changeset 41f57230d558 (bug 1403365) for browser_pageinfo_firstPartyIsolation.js failures.
Ryan VanderMeulen <ryanvm@gmail.com> - Wed, 10 Jan 2018 23:04:55 -0500 - rev 445630
Push 1618 by Callek@gmail.com at Thu, 11 Jan 2018 17:45:48 +0000
Backed out changeset 41f57230d558 (bug 1403365) for browser_pageinfo_firstPartyIsolation.js failures.
3e7bec52b1431c8dfd56c86ec5062514434fa788: Bug 1427126 - Use setElementWithType instead of setElement in AppendToList. r=bhackett, a=gchang
Jan de Mooij <jdemooij@mozilla.com> - Tue, 09 Jan 2018 16:37:12 -0500 - rev 445629
Push 1618 by Callek@gmail.com at Thu, 11 Jan 2018 17:45:48 +0000
Bug 1427126 - Use setElementWithType instead of setElement in AppendToList. r=bhackett, a=gchang
a1d9a99f12a544df996ebdf833cf3e65357a7361: Bug 1426801 - Clear gFirstIdleTask if we fail to dispatch the runnable. r=mrbkap, a=gchang
Andrew McCreight <continuation@gmail.com> - Thu, 04 Jan 2018 14:59:14 -0800 - rev 445628
Push 1618 by Callek@gmail.com at Thu, 11 Jan 2018 17:45:48 +0000
Bug 1426801 - Clear gFirstIdleTask if we fail to dispatch the runnable. r=mrbkap, a=gchang MozReview-Commit-ID: 23f9VDTyyqg
38fd987182186720bc0b252a1dc94444f6db39f5: Bug 1428165 - Part 2: Fix history expiration query. r=nalexander, a=gchang
Grigory Kruglov <gkruglov@mozilla.com> - Thu, 04 Jan 2018 23:15:42 -0500 - rev 445627
Push 1618 by Callek@gmail.com at Thu, 11 Jan 2018 17:45:48 +0000
Bug 1428165 - Part 2: Fix history expiration query. r=nalexander, a=gchang 'modified' value might be missing; in SQLite, max(123, null) is null, and so we must coalesce fields which might be missing values. MozReview-Commit-ID: Bn1P0kdaHHT
916cbb15381ea0571c81e33ef37514855f152203: Bug 1428165 - Part 1: Ensure that 'modified' and 'created' timestamps are set when inserting history from sync. r=nalexander, a=gchang
Grigory Kruglov <gkruglov@mozilla.com> - Fri, 05 Jan 2018 21:15:55 -0500 - rev 445626
Push 1618 by Callek@gmail.com at Thu, 11 Jan 2018 17:45:48 +0000
Bug 1428165 - Part 1: Ensure that 'modified' and 'created' timestamps are set when inserting history from sync. r=nalexander, a=gchang This fixes a regression introduced in Bug 1291821. History records would be bulk-inserted from sync, and our ContentProvider would erroneously forget to set these two timestamp fields. MozReview-Commit-ID: 2k0afijN62H
5b67ac2c216bef0bcf3a3cf7577eade0ffb5e0e2: Bug 1426042 - Ensure we don't forget to set bidi data when required on a zero-length trailing frame. r=dholbert, a=gchang
Jonathan Kew <jkew@mozilla.com> - Fri, 05 Jan 2018 13:58:51 +0000 - rev 445625
Push 1618 by Callek@gmail.com at Thu, 11 Jan 2018 17:45:48 +0000
Bug 1426042 - Ensure we don't forget to set bidi data when required on a zero-length trailing frame. r=dholbert, a=gchang
b5147bc4e38410b1c5b66368f9e0d67f02e98738: Bug 1426042 - Reftest for bidi reordering where line has an empty trailing ::after pseudo-element. r=dholbert, a=gchang
Jonathan Kew <jkew@mozilla.com> - Fri, 05 Jan 2018 13:58:42 +0000 - rev 445624
Push 1618 by Callek@gmail.com at Thu, 11 Jan 2018 17:45:48 +0000
Bug 1426042 - Reftest for bidi reordering where line has an empty trailing ::after pseudo-element. r=dholbert, a=gchang
ed60f2c05c4ae44d1385176764dafe9b9c0321fa: Bug 1427089 - Wait for a previous empty transaction to complete before doing another empty transaction. r=dvander, a=gchang
Ryan Hunt <rhunt@eqrion.net> - Wed, 03 Jan 2018 16:56:25 -0600 - rev 445623
Push 1618 by Callek@gmail.com at Thu, 11 Jan 2018 17:45:48 +0000
Bug 1427089 - Wait for a previous empty transaction to complete before doing another empty transaction. r=dvander, a=gchang
aaea46054159fabc3b045ed11e6efb6e808c4031: Bug 1427089 - Only queue a ContentClient buffer state if it has operations. r=dvander, a=gchang
Ryan Hunt <rhunt@eqrion.net> - Wed, 03 Jan 2018 16:55:01 -0600 - rev 445622
Push 1618 by Callek@gmail.com at Thu, 11 Jan 2018 17:45:48 +0000
Bug 1427089 - Only queue a ContentClient buffer state if it has operations. r=dvander, a=gchang
d5eaaf2bbd80515c1570d3dcc612b69326c4b6c0: Bug 1421262 - [Mac] Add access to hw.cachelinesize sysctl, /Library/GPUBundles to content sandbox rules. r=Alex_Gaynor, a=gchang
Haik Aftandilian <haftandilian@mozilla.com> - Thu, 21 Dec 2017 14:15:29 -0800 - rev 445621
Push 1618 by Callek@gmail.com at Thu, 11 Jan 2018 17:45:48 +0000
Bug 1421262 - [Mac] Add access to hw.cachelinesize sysctl, /Library/GPUBundles to content sandbox rules. r=Alex_Gaynor, a=gchang MozReview-Commit-ID: LBWA8XD64h
d73b02db0bfc988682b6b5c176ae4f1df85459e2: Bug 1246883 - Load UA Stylesheet when printing the SVG document. r=jwatt, a=gchang
Mantaroh Yoshinaga <mantaroh@gmail.com> - Wed, 13 Dec 2017 08:58:05 +0900 - rev 445620
Push 1618 by Callek@gmail.com at Thu, 11 Jan 2018 17:45:48 +0000
Bug 1246883 - Load UA Stylesheet when printing the SVG document. r=jwatt, a=gchang Currently, Gecko load only minimal-xul.css if the document is the SVG[1]. In the case of printing SVG document, gecko should load ua.css for using style which related to print. This patch will load ua.css when printing the SVG document. [1] http://searchfox.org/mozilla-central/rev/67f38de2443e6b613d874fcf4d2cd1f2fc3d5e97/layout/base/nsDocumentViewer.cpp#2472 MozReview-Commit-ID: JtdaEvX8QTw
c77dd415d31f115d24335e3573fd087a3f3705cd: Bug 1387427 - Don't insert source content into the document for XSLT transforms. r=smaug, a=gchang
Peter Van der Beken <peterv@propagandism.org> - Fri, 03 Nov 2017 16:58:59 +0100 - rev 445619
Push 1618 by Callek@gmail.com at Thu, 11 Jan 2018 17:45:48 +0000
Bug 1387427 - Don't insert source content into the document for XSLT transforms. r=smaug, a=gchang
41f57230d558923a843e825da94e0146f3888b13: Bug 1403365 - Fix intermittent in browser_pageinfo_firstPartyIsolation.js. r=baku, a=test-only
Yoshi Huang <allstars.chh@mozilla.com> - Thu, 04 Jan 2018 16:45:18 +0800 - rev 445618
Push 1618 by Callek@gmail.com at Thu, 11 Jan 2018 17:45:48 +0000
Bug 1403365 - Fix intermittent in browser_pageinfo_firstPartyIsolation.js. r=baku, a=test-only When we try to load https://example.com/browser/browser/base/content/test/pageinfo/image.html, sometimes BrowserTestUtils will return early even the page doesn't load yet, for example, the browser.currentURI is still about:blank. And loading about:blank will cause error in pageInfo.js, hence caused the timeout. So I add more parameters to browserLoaded to make sure browwserLoaded is returned with the correct url.
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 +100000 tip