build/clang-plugin/tests/TestSprintfLiteral.cpp
author David Major <dmajor@mozilla.com>
Mon, 01 Jul 2019 21:37:44 +0000
changeset 543682 f0ac391dd02a4296a724462cdfa3c89cc8e39a00
parent 543680 ed65b4d20a8969f6b6d9789270fe574a36793bff
permissions -rw-r--r--
Bug 1557338 - Fix up TestSprintfLiteral.cpp for warnings on clang trunk r=andi LLVM r356397 added some new warnings to the compiler that in this file complain about `size argument is too large; destination buffer has size 100, but size argument is 101`. The easiest path is to just remove those lines; doing so doesn't really weaken the test coverage of the SprintfLiteral checker. Differential Revision: https://phabricator.services.mozilla.com/D36515

#include <cstdio>

void bad() {
  char x[100];
  snprintf(x, sizeof(x), "bar"); // expected-error {{Use SprintfLiteral instead of snprintf when writing into a character array.}} expected-note {{This will prevent passing in the wrong size to snprintf accidentally.}}
  snprintf(x, 100, "bar"); // expected-error {{Use SprintfLiteral instead of snprintf when writing into a character array.}} expected-note {{This will prevent passing in the wrong size to snprintf accidentally.}}
  const int hundred = 100;
  snprintf(x, hundred, "bar"); // expected-error {{Use SprintfLiteral instead of snprintf when writing into a character array.}} expected-note {{This will prevent passing in the wrong size to snprintf accidentally.}}
}

void ok() {
  char x[100];
  int y;
  snprintf(x, sizeof(y), "what");

  snprintf(x, 50, "what");

  int nothundred = 100;
  nothundred = 99;
  snprintf(x, nothundred, "what");
}

void vargs_bad(va_list args) {
  char x[100];
  vsnprintf(x, sizeof(x), "bar", args); // expected-error {{Use VsprintfLiteral instead of vsnprintf when writing into a character array.}} expected-note {{This will prevent passing in the wrong size to vsnprintf accidentally.}}
  vsnprintf(x, 100, "bar", args); // expected-error {{Use VsprintfLiteral instead of vsnprintf when writing into a character array.}} expected-note {{This will prevent passing in the wrong size to vsnprintf accidentally.}}
  const int hundred = 100;
  vsnprintf(x, hundred, "bar", args); // expected-error {{Use VsprintfLiteral instead of vsnprintf when writing into a character array.}} expected-note {{This will prevent passing in the wrong size to vsnprintf accidentally.}}
}

void vargs_good(va_list args) {
  char x[100];
  int y;
  vsnprintf(x, sizeof(y), "what", args);

  vsnprintf(x, 50, "what", args);

  int nothundred = 100;
  nothundred = 99;
  vsnprintf(x, nothundred, "what", args);
}