build/clang-plugin/LoadLibraryUsageChecker.cpp
author Tom Ritter <tom@mozilla.com>
Sat, 19 May 2018 01:26:33 -0500
changeset 475965 bf7ac536eb942fe12ef60f082f20ce30f0ec75a3
parent 473932 827deadecf7e43ad9f9891444637be01619a2ba8
child 508751 335e8f4298ce517967691df1468bdbae7f62c287
permissions -rw-r--r--
Bug 1457162 Remove -TC from CFLAGS r=ted -TC specifies 'treat all inputs at C files' which breaks things when you specify a @list file of inputs. During configure, -TP is required for C++ configure checks (although we could probably make it smart and not need it at all), but -TC does not seem to be required. MozReview-Commit-ID: DNA8vUMdIXb

/* This Source Code Form is subject to the terms of the Mozilla Public
 * License, v. 2.0. If a copy of the MPL was not distributed with this
 * file, You can obtain one at http://mozilla.org/MPL/2.0/. */

#include "LoadLibraryUsageChecker.h"
#include "CustomMatchers.h"

// On MacOS the filesystem is UTF-8, on linux the canonical filename is 8-bit
// string. On Windows data loss conversion will occur. This checker restricts
// the use of ASCII file functions for loading libraries.

void LoadLibraryUsageChecker::registerMatchers(MatchFinder *AstMatcher) {
  AstMatcher->addMatcher(
      callExpr(
          allOf(isFirstParty(),
                callee(functionDecl(anyOf(
                    allOf(isInSystemHeader(), anyOf(hasName("LoadLibraryA"),
                                                    hasName("LoadLibraryExA"))),
                    hasName("PR_LoadLibrary")))),
                unless(hasArgument(0, stringLiteral()))))
          .bind("funcCall"),
      this);
}

void LoadLibraryUsageChecker::check(const MatchFinder::MatchResult &Result) {
  const CallExpr *FuncCall = Result.Nodes.getNodeAs<CallExpr>("funcCall");

  if (FuncCall) {
    diag(FuncCall->getLocStart(),
         "Usage of ASCII file functions (such as %0) is forbidden.",
         DiagnosticIDs::Error)
        << FuncCall->getDirectCallee()->getName();
  }
}