author Nika Layzell <>
Tue, 25 Sep 2018 17:34:53 +0200
changeset 507828 5e6dae0c1e5a4939ccd406f14607f7fafffd45a7
parent 473192 61084cd281886ca3bbf4c19842e5f8f92d801337
permissions -rw-r--r--
Bug 1448426 - Wrap windows.h to avoid problematic define statements, r=froydnj,glandium By default, windows.h exposes a large number of problematic define statements which are UpperCamelCase, such as a define from `CreateWindow` to `CreateWindow{A,W}`. As many of these names are generic (e.g. CreateFile, CreateWindow), they can mess up Gecko code that may legitimately have its own methods with the same names. The header also defines some traditional SCREAMING_SNAKE_CASE defines which can mess up our code by conflicting with local values. This patch adds a simple code generator which generates wrappers for these defines, and uses them to wrap the windows.h wrapper using the `stl_wrappers` mechanism, allowing us to use windows.h in more places. Differential Revision:

# This Source Code Form is subject to the terms of the Mozilla Public
# License, v. 2.0. If a copy of the MPL was not distributed with this
# file, You can obtain one at

import runpy
import string

def generate(output, template, dataFile):
    with open(template, "r") as f:
        template = string.Template(
    data = runpy.run_path(dataFile)["data"]

    longhand_count = 0
    shorthand_count = 0
    alias_count = 0
    property_ids = []
    for prop in data:
        if prop.type() != "alias":
            if prop.type() == "longhand":
                assert shorthand_count == 0
                longhand_count += 1
                assert alias_count == 0
                shorthand_count += 1
            alias_count += 1

    output.write("/* THIS IS AN AUTOGENERATED FILE.  DO NOT EDIT */\n\n")
        "property_ids": "\n".join("  {},".format(p) for p in property_ids),
        "longhand_count": property_ids[longhand_count],
        "shorthand_count": property_ids[longhand_count + shorthand_count],