netwerk/base/NetworkInfoServiceCocoa.cpp
author Nicholas Nethercote <nnethercote@mozilla.com>
Fri, 02 Sep 2016 17:12:24 +1000
changeset 356450 177f41cecedb422d7a11156091ee718ec919c643
parent 342956 be7175764dc766594c5287ca184fc7a5c2f392d8
child 472483 17e1f96d453f869f9bb64cc1d889320ca2b4adba
permissions -rw-r--r--
Bug 1299384 - Use MOZ_MUST_USE with NS_warn_if_impl(). r=erahm. This change avoids lots of false positives for Coverity's CHECKED_RETURN warning, caused by NS_WARN_IF's current use in both statement-style and expression-style. In the case where the code within the NS_WARN_IF has side-effects, I made the following change. > NS_WARN_IF(NS_FAILED(FunctionWithSideEffects())); > --> > Unused << NS_WARN_IF(NS_FAILED(FunctionWithSideEffects())); In the case where the code within the NS_WARN_IF lacks side-effects, I made the following change. > NS_WARN_IF(!condWithoutSideEffects); > --> > NS_WARNING_ASSERTION(condWithoutSideEffects, "msg"); This has two improvements. - The condition is not evaluated in non-debug builds. - The sense of the condition is inverted to the familiar "this condition should be true" sense used in assertions. A common variation on the side-effect-free case is the following. > nsresult rv = Fn(); > NS_WARN_IF_(NS_FAILED(rv)); > --> > DebugOnly<nsresult rv> = Fn(); > NS_WARNING_ASSERTION(NS_SUCCEEDED(rv), "Fn failed");

/* -*- Mode: C++; tab-width: 8; indent-tabs-mode: nil; c-basic-offset: 2 -*- */
/* vim: set ts=8 sts=2 et sw=2 tw=80: */
/* This Source Code Form is subject to the terms of the Mozilla Public
 * License, v. 2.0. If a copy of the MPL was not distributed with this
 * file, You can obtain one at http://mozilla.org/MPL/2.0/. */

#include <string.h>
#include <unistd.h>
#include <sys/ioctl.h>
#include <sys/socket.h>
#include <sys/types.h>
#include <net/if.h>
#include <netdb.h>

#include "mozilla/DebugOnly.h"
#include "mozilla/ScopeExit.h"

#include "NetworkInfoServiceImpl.h"

namespace mozilla {
namespace net {

static nsresult
ListInterfaceAddresses(int aFd, const char* aIface, AddrMapType& aAddrMap);

nsresult
DoListAddresses(AddrMapType& aAddrMap)
{
    int fd = socket(AF_INET, SOCK_DGRAM, 0);
    if (fd < 0) {
        return NS_ERROR_FAILURE;
    }

    auto autoCloseSocket = MakeScopeExit([&] {
      close(fd);
    });

    struct ifconf ifconf;
    /* 16k of space should be enough to list all interfaces.  Worst case, if it's
     * not then we will error out and fail to list addresses.  This should only
     * happen on pathological machines with way too many interfaces.
     */
    char buf[16384];

    ifconf.ifc_len = sizeof(buf);
    ifconf.ifc_buf = buf;
    if (ioctl(fd, SIOCGIFCONF, &ifconf) != 0) {
        return NS_ERROR_FAILURE;
    }

    struct ifreq* ifreq = ifconf.ifc_req;
    int i = 0;
    while (i < ifconf.ifc_len) {
        size_t len = IFNAMSIZ + ifreq->ifr_addr.sa_len;

        DebugOnly<nsresult> rv =
          ListInterfaceAddresses(fd, ifreq->ifr_name, aAddrMap);
        NS_WARNING_ASSERTION(NS_SUCCEEDED(rv), "ListInterfaceAddresses failed");

        ifreq = (struct ifreq*) ((char*)ifreq + len);
        i += len;
    }

    autoCloseSocket.release();
    return NS_OK;
}

static nsresult
ListInterfaceAddresses(int aFd, const char* aInterface, AddrMapType& aAddrMap)
{
    struct ifreq ifreq;
    memset(&ifreq, 0, sizeof(struct ifreq));
    strncpy(ifreq.ifr_name, aInterface, IFNAMSIZ - 1);
    if (ioctl(aFd, SIOCGIFADDR, &ifreq) != 0) {
        return NS_ERROR_FAILURE;
    }

    char host[128];
    int family;
    switch(family=ifreq.ifr_addr.sa_family) {
      case AF_INET:
      case AF_INET6:
        getnameinfo(&ifreq.ifr_addr, sizeof(ifreq.ifr_addr), host, sizeof(host), 0, 0, NI_NUMERICHOST);
        break;
      case AF_UNSPEC:
        return NS_OK;
      default:
        // Unknown family.
        return NS_OK;
    }

    nsCString ifaceStr;
    ifaceStr.AssignASCII(aInterface);

    nsCString addrStr;
    addrStr.AssignASCII(host);

    aAddrMap.Put(ifaceStr, addrStr);

    return NS_OK;
}

} // namespace net
} // namespace mozilla