Bug 1563695 - Do not close SpdyConnectTransaction in TLSFilterTransaction. r=mayhemer, a=jcristau
authorDragana Damjanovic <dd.mozilla@gmail.com>
Fri, 05 Jul 2019 18:54:34 +0000
changeset 523061 cdbcaa87cf134d615259d5fd3b8c3fd0af415c33
parent 523060 c2d721bb99e101b6b02515f2ac79fd50c1b7ccd1
child 523062 7af424604cc50e52920fc01dfa04a451973d16bf
push id82
push userryanvm@gmail.com
push dateWed, 17 Jul 2019 22:38:20 +0000
treeherdermozilla-esr68@cf6798f00871 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersmayhemer, jcristau
bugs1563695
milestone68.1.0
Bug 1563695 - Do not close SpdyConnectTransaction in TLSFilterTransaction. r=mayhemer, a=jcristau Differential Revision: https://phabricator.services.mozilla.com/D37048
netwerk/protocol/http/TunnelUtils.cpp
--- a/netwerk/protocol/http/TunnelUtils.cpp
+++ b/netwerk/protocol/http/TunnelUtils.cpp
@@ -125,28 +125,16 @@ void TLSFilterTransaction::Close(nsresul
   }
 
   if (mTimer) {
     mTimer->Cancel();
     mTimer = nullptr;
   }
   mTransaction->Close(aReason);
   mTransaction = nullptr;
-
-  RefPtr<NullHttpTransaction> baseTrans(do_QueryReferent(mWeakTrans));
-  SpdyConnectTransaction* trans =
-      baseTrans ? baseTrans->QuerySpdyConnectTransaction() : nullptr;
-
-  LOG(("TLSFilterTransaction::Close %p aReason=%" PRIx32 " trans=%p\n", this,
-       static_cast<uint32_t>(aReason), trans));
-
-  if (trans) {
-    trans->Close(aReason);
-    trans = nullptr;
-  }
 }
 
 nsresult TLSFilterTransaction::OnReadSegment(const char* aData, uint32_t aCount,
                                              uint32_t* outCountRead) {
   LOG(("TLSFilterTransaction %p OnReadSegment %d (buffered %d)\n", this, aCount,
        mEncryptedTextUsed));
 
   mReadSegmentReturnValue = NS_OK;