Bug 1218456 - Document::GetContainer shouldn't be virtual. r=smaug a=pascalc
authorEmilio Cobos Álvarez <emilio@crisal.io>
Tue, 09 Jul 2019 16:17:38 +0000
changeset 523939 4fbc7ac047148c2386a287d35e98a10351249ef3
parent 523938 fadf81d7d16e2293ea3f9f064a8a7e30ed854809
child 523940 d866e8ed6eb281ceb11332ee8f99aa86bd0bd209
push id533
push userarchaeopteryx@coole-files.de
push dateMon, 04 Nov 2019 10:45:14 +0000
treeherdermozilla-esr68@2bc9b2075e5a [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerssmaug, pascalc
bugs1218456
milestone68.3.0
Bug 1218456 - Document::GetContainer shouldn't be virtual. r=smaug a=pascalc It's never overridden. Also chances are we should remove it and just use GetDocShell(). Differential Revision: https://phabricator.services.mozilla.com/D37405
dom/base/Document.h
--- a/dom/base/Document.h
+++ b/dom/base/Document.h
@@ -2109,17 +2109,17 @@ class Document : public nsINode,
    * Set the container (docshell) for this document. Virtual so that
    * docshell can call it.
    */
   virtual void SetContainer(nsDocShell* aContainer);
 
   /**
    * Get the container (docshell) for this document.
    */
-  virtual nsISupports* GetContainer() const;
+  nsISupports* GetContainer() const;
 
   /**
    * Get the container's load context for this document.
    */
   nsILoadContext* GetLoadContext() const;
 
   /**
    * Get docshell the for this document.