searching for reviewer(pascalc)
1b0a29b456b432d1c8bef09c233b84205ec9e13c: Bug 1635240 - Add policy for using SSO in private browsing. r=mconley a=pascalc
Michael Kaply <mozilla@kaply.com> - Mon, 11 May 2020 19:18:43 +0000 - rev 524828
Push 1037 by ryanvm@gmail.com at Fri, 22 May 2020 01:14:45 +0000
Bug 1635240 - Add policy for using SSO in private browsing. r=mconley a=pascalc Differential Revision: https://phabricator.services.mozilla.com/D74112
203a8c227a997c4ae7e970d0ec497d7292078d5c: Bug 1469629 - Read system level policies on Linux if available. r=stransky a=pascalc
Michael Kaply <mozilla@kaply.com> - Mon, 11 May 2020 07:10:02 +0000 - rev 524827
Push 1037 by ryanvm@gmail.com at Fri, 22 May 2020 01:14:45 +0000
Bug 1469629 - Read system level policies on Linux if available. r=stransky a=pascalc Differential Revision: https://phabricator.services.mozilla.com/D74323
dcfa7eaa9049f6c177fa4f171b48eca7c44089a3: Bug 1631618 - Make SharedWorkerService be alive until shutdown r=dom-workers-and-storage-reviewers,asuth, a=pascalc
Eden Chuang <echuang@mozilla.com> - Fri, 15 May 2020 13:49:39 +0000 - rev 524822
Push 1034 by jcristau@mozilla.com at Tue, 19 May 2020 14:27:58 +0000
Bug 1631618 - Make SharedWorkerService be alive until shutdown r=dom-workers-and-storage-reviewers,asuth, a=pascalc Using StaticRefPtr instead of a raw pointer for sSharedWorkerService in SharedWorkerService.cpp, and keeping sSharedWorkerService be alive until shutdown by registering sSharedWorkerService to ClearOnShutdown. Since sSharedWorkerService is not raw pointer anymore, SharedWorkerService needs not to inherit from SupportsCheckedUnsafePtr<CheckIf<DiagnosticAssertEnabled>> Differential Revision: https://phabricator.services.mozilla.com/D72379
2490d49ecf35bdf4b1e4ee6c3a0d855cfd51363e: Bug 1608421 - Only run the bugzilla-components task on mozilla-central. r=jmaher, a=pascalc
Marco Castelluccio <mcastelluccio@mozilla.com> - Thu, 07 May 2020 22:38:13 +0000 - rev 524803
Push 1026 by jcristau@mozilla.com at Thu, 14 May 2020 13:47:58 +0000
Bug 1608421 - Only run the bugzilla-components task on mozilla-central. r=jmaher, a=pascalc Differential Revision: https://phabricator.services.mozilla.com/D74329
0e73e813feb4fc069a90a89eadffe4741a14f1ac: Bug 1614339 - Ensure CloseInternal alive until it is finished; r=baku a=pascalc
Tom Tung <ttung@mozilla.com> - Tue, 03 Mar 2020 16:57:29 +0000 - rev 524646
Push 932 by archaeopteryx@coole-files.de at Wed, 04 Mar 2020 10:38:22 +0000
Bug 1614339 - Ensure CloseInternal alive until it is finished; r=baku a=pascalc Differential Revision: https://phabricator.services.mozilla.com/D63643
5c45ee1cf34779a351c0caf7b7efc82d6e49872d: Bug 1597963 - Pass VT_ERROR for Explorer to call ShellExecuteExW with null verb. r=aklotz a=pascalc a=jcristau
Toshihito Kikuchi <tkikuchi@mozilla.com> - Mon, 25 Nov 2019 22:26:42 +0200 - rev 524221
Push 654 by nbeleuzu@mozilla.com at Mon, 09 Dec 2019 23:12:53 +0000
Bug 1597963 - Pass VT_ERROR for Explorer to call ShellExecuteExW with null verb. r=aklotz a=pascalc a=jcristau The patch for Bug 1588975 specified the "open" verb to execute a target, but the default verb is not always "open". For example, the default verb for a font file is "preview". We should specify null verb to start the default operation. Now we use `IShellDispatch2.ShellExecute` to ask explorer.exe to call `ShellExecuteExW`. That method takes an optional `VARIANT` parameter as a verb. According to https://devblogs.microsoft.com/oldnewthing/20140919-00/?p=44023, we need to pass `VT_ERROR` to omit an optional parameter. If we pass other values such as `nullptr` with `VT_BSTR` or `VT_EMPTY`, explorer.exe calls `ShellExecuteExW` with the empty string `""` instead of `nullptr`, which is not considered as a valid verb if the target file is not associated with any app. Differential Revision: https://phabricator.services.mozilla.com//D54603
3bf7df179a7bd06fc0110a7507ac6cb1e13660f3: Bug 1597543 - Don't try and associate memory if we failed to create the reflector object r=bzbarsky a=pascalc
Jon Coppeard <jcoppeard@mozilla.com> - Tue, 19 Nov 2019 15:41:31 +0000 - rev 524139
Push 616 by ryanvm@gmail.com at Thu, 21 Nov 2019 15:53:06 +0000
Bug 1597543 - Don't try and associate memory if we failed to create the reflector object r=bzbarsky a=pascalc The problem is we're still calling JS::AddAssociatedMemory with a null object pointer. There's an asssertion for this in the JS engine but this doesn't happen in our tests. Differential Revision: https://phabricator.services.mozilla.com/D53813
d36df7bc997712725f81ed7ed35b6255f592b166: Bug 1597043: RootAccessible::ProcessDOMEvent: Return early if AsXULMultiSelectControl() on a XUL tree element fails. r=MarcoZ a=pascalc
James Teh <jteh@mozilla.com> - Mon, 18 Nov 2019 05:42:28 +0000 - rev 524138
Push 616 by ryanvm@gmail.com at Thu, 21 Nov 2019 15:53:06 +0000
Bug 1597043: RootAccessible::ProcessDOMEvent: Return early if AsXULMultiSelectControl() on a XUL tree element fails. r=MarcoZ a=pascalc This really shouldn't be possible. All XUL trees should have nsIDOMXULMultiSelectControlElement, and the tree is focused at this point, so it shouldn't be dying. Nevertheless, this sometimes happens in the wild and was causing crashes. Differential Revision: https://phabricator.services.mozilla.com/D53373
3b6a5df0a100e52b5bafa98e2a9e2a5265291d87: bug 1591691 - avoid network I/O when importing enterprise roots on Windows r=mhowell a=pascalc a=lizzard
Dana Keeler <dkeeler@mozilla.com> - Thu, 31 Oct 2019 00:36:53 +0000 - rev 524123
Push 607 by archaeopteryx@coole-files.de at Tue, 19 Nov 2019 14:54:40 +0000
bug 1591691 - avoid network I/O when importing enterprise roots on Windows r=mhowell a=pascalc a=lizzard Differential Revision: https://phabricator.services.mozilla.com/D51007
1997de426eaf38aa46ff3d0da1a59ca1422cef90: Bug 1594136 - Check for ended track in MediaStreamTrackAudioSourceNode. r=padenot a=pascalc
Andreas Pehrson <apehrson@mozilla.com> - Wed, 13 Nov 2019 13:13:48 +0000 - rev 524106
Push 600 by ryanvm@gmail.com at Mon, 18 Nov 2019 14:32:25 +0000
Bug 1594136 - Check for ended track in MediaStreamTrackAudioSourceNode. r=padenot a=pascalc Depends on D52521 Differential Revision: https://phabricator.services.mozilla.com/D52522
71aeb17c255b349615cdb0c9cb426f60ba0cb99f: Bug 1594136 - Add crashtest. r=padenot a=pascalc
Andreas Pehrson <apehrson@mozilla.com> - Wed, 13 Nov 2019 13:13:55 +0000 - rev 524105
Push 600 by ryanvm@gmail.com at Mon, 18 Nov 2019 14:32:25 +0000
Bug 1594136 - Add crashtest. r=padenot a=pascalc Differential Revision: https://phabricator.services.mozilla.com/D52521
2bc9b2075e5a630586add12ac8a44cbab2e60e25: Bug 1589972 - When an unrelated document loads, don't clear out search telemetry information for other documents. r=mikedeboer, a=pascalc
Mark Banner <standard8@mozilla.com> - Wed, 23 Oct 2019 12:07:51 +0000 - rev 523945
Push 533 by archaeopteryx@coole-files.de at Mon, 04 Nov 2019 10:45:14 +0000
Bug 1589972 - When an unrelated document loads, don't clear out search telemetry information for other documents. r=mikedeboer, a=pascalc Differential Revision: https://phabricator.services.mozilla.com/D49950
94d5c2a0f063415abed8348740cdf3ce77fe9b59: Bug 1589972 - Don't stop tracking search telemetry when the location change is for the same document. r=mikedeboer a=pascalc
Mark Banner <standard8@mozilla.com> - Wed, 23 Oct 2019 12:07:43 +0000 - rev 523944
Push 533 by archaeopteryx@coole-files.de at Mon, 04 Nov 2019 10:45:14 +0000
Bug 1589972 - Don't stop tracking search telemetry when the location change is for the same document. r=mikedeboer a=pascalc Differential Revision: https://phabricator.services.mozilla.com/D49949
cf06c61df5b3da0957cb1fc80c91115867edb94d: Bug 1587543 - Bump OpenH264 fallback downloader to 1.8.1.1. r=Callek a=pascalc
Bryce Seager van Dyk <bvandyk@mozilla.com> - Tue, 15 Oct 2019 15:17:26 +0000 - rev 523943
Push 533 by archaeopteryx@coole-files.de at Mon, 04 Nov 2019 10:45:14 +0000
Bug 1587543 - Bump OpenH264 fallback downloader to 1.8.1.1. r=Callek a=pascalc This change will cause Firefox to re-download the OpenH264 GMP if it already has the 1.8.1 version. This is being done to mitigate and issue where clients that already downloaded that version on previous versions of Firefox did not clear the mac quarantine attribute that prevents the lib being loaded in MacOS Catalina. Newer versions of Firefox will clear the attribute on download, so we want to trigger a re-download by those clients. We would typically expect this to be done by balrog, but we update these fallback rules to cover the edge case where balrog is not available and in order to keep these rules in step with those on balrog. The binaries pointed to by this 1.8.1.1 version are the same as the 1.8.1 version. This change is solely to trigger a re-download. Differential Revision: https://phabricator.services.mozilla.com/D49197
160054b48c93cf170ee5d55039b60a367a086a08: Bug 1218456 - Simplify CheckHandleEventForAnchorsPreconditions. r=smaug a=pascalc
Emilio Cobos Álvarez <emilio@crisal.io> - Tue, 09 Jul 2019 16:17:56 +0000 - rev 523942
Push 533 by archaeopteryx@coole-files.de at Mon, 04 Nov 2019 10:45:14 +0000
Bug 1218456 - Simplify CheckHandleEventForAnchorsPreconditions. r=smaug a=pascalc I've checked that this doesn't change behavior in the test-case for bug 30178, which is just an imagemap inside a link. Overall it'd be weird if we needed this for area-inside-a but not for stuff like nested links. Differential Revision: https://phabricator.services.mozilla.com/D37407
a7b2ca3b03c30520de5e0929fc551d22d1b48c60: Bug 1218456 - Remove nsILinkHandler. r=smaug a=pascalc
Emilio Cobos Álvarez <emilio@crisal.io> - Tue, 09 Jul 2019 16:17:47 +0000 - rev 523941
Push 533 by archaeopteryx@coole-files.de at Mon, 04 Nov 2019 10:45:14 +0000
Bug 1218456 - Remove nsILinkHandler. r=smaug a=pascalc Interfaces with just one implementation don't seem very useful. Differential Revision: https://phabricator.services.mozilla.com/D37406
d866e8ed6eb281ceb11332ee8f99aa86bd0bd209: Bug 1218456 - Allow navigating when there's no pres context. r=smaug a=pascalc
Emilio Cobos Álvarez <emilio@crisal.io> - Tue, 09 Jul 2019 16:17:27 +0000 - rev 523940
Push 533 by archaeopteryx@coole-files.de at Mon, 04 Nov 2019 10:45:14 +0000
Bug 1218456 - Allow navigating when there's no pres context. r=smaug a=pascalc Differential Revision: https://phabricator.services.mozilla.com/D37404
4fbc7ac047148c2386a287d35e98a10351249ef3: Bug 1218456 - Document::GetContainer shouldn't be virtual. r=smaug a=pascalc
Emilio Cobos Álvarez <emilio@crisal.io> - Tue, 09 Jul 2019 16:17:38 +0000 - rev 523939
Push 533 by archaeopteryx@coole-files.de at Mon, 04 Nov 2019 10:45:14 +0000
Bug 1218456 - Document::GetContainer shouldn't be virtual. r=smaug a=pascalc It's never overridden. Also chances are we should remove it and just use GetDocShell(). Differential Revision: https://phabricator.services.mozilla.com/D37405
fadf81d7d16e2293ea3f9f064a8a7e30ed854809: Bug 1218456 - Prevent navigating away in test_overlay.html. r=zbraniecki a=pascalc
Emilio Cobos Álvarez <emilio@crisal.io> - Tue, 09 Jul 2019 20:46:30 +0000 - rev 523938
Push 533 by archaeopteryx@coole-files.de at Mon, 04 Nov 2019 10:45:14 +0000
Bug 1218456 - Prevent navigating away in test_overlay.html. r=zbraniecki a=pascalc I'm not sure why the test structure is the way it is, but without this and with the changes from this bug we start navigating away which means we try to reach mozilla.org, which is forbidden in automation since non-local connections are, causing the failures that got me backed out in comment 25. Differential Revision: https://phabricator.services.mozilla.com/D37469
b0b995198592c2695181c1217eb95df822fc0eea: Bug 1570559 - When the target APZC changes mid-gesture, always clear the old APZC's gesture state. r=tnikkel, a=pascalc
Botond Ballo <botond@mozilla.com> - Fri, 06 Sep 2019 21:23:23 +0000 - rev 523899
Push 511 by ryanvm@gmail.com at Mon, 28 Oct 2019 13:34:18 +0000
Bug 1570559 - When the target APZC changes mid-gesture, always clear the old APZC's gesture state. r=tnikkel, a=pascalc Previously we were only doing this if content wasn't prevent-defaulting the events targeting the new APZC. Differential Revision: https://phabricator.services.mozilla.com/D44712
ea5154beddff08b919697e3bed6f38cfe3a3d82f: Bug 1560192 - Clean up prompt open calls in Prompter.jsm. r=Gijs, a=pascalc FIREFOX_67_0_4_BUILD1 FIREFOX_67_0_4_RELEASE
Johann Hofmann <jhofmann@mozilla.com> - Wed, 19 Jun 2019 21:59:18 +0000 - rev 522742
Push 28 by mozilla@hocat.ca at Mon, 01 Jul 2019 10:57:14 +0000
Bug 1560192 - Clean up prompt open calls in Prompter.jsm. r=Gijs, a=pascalc Differential Revision: https://phabricator.services.mozilla.com/D35371
1a95e4b8b2d28e76ef63335f96f2b4cc151497f9: Bug 1556076. Restore checking the return value of MakeInputStream in nsIconChannel on mac. r=aosmond a=pascalc FENNEC_67_0_2_BUILD1 FENNEC_67_0_2_RELEASE FIREFOX_67_0_2_BUILD2 FIREFOX_67_0_2_RELEASE
Timothy Nikkel <tnikkel@gmail.com> - Thu, 06 Jun 2019 12:33:00 +0300 - rev 522727
Push 28 by mozilla@hocat.ca at Mon, 01 Jul 2019 10:57:14 +0000
Bug 1556076. Restore checking the return value of MakeInputStream in nsIconChannel on mac. r=aosmond a=pascalc Differential Revision: https://phabricator.services.mozilla.com/D33892
f0900e70cbef3eaa7388001eb5e5ea8c6f86b1fa: Bug 1555962 - Add a perf test which is an order of magnitude slower without the previous patch. r=heycam a=pascalc
Emilio Cobos Álvarez <emilio@crisal.io> - Mon, 03 Jun 2019 19:55:37 +0000 - rev 522726
Push 28 by mozilla@hocat.ca at Mon, 01 Jul 2019 10:57:14 +0000
Bug 1555962 - Add a perf test which is an order of magnitude slower without the previous patch. r=heycam a=pascalc Depends on D33434 Differential Revision: https://phabricator.services.mozilla.com/D33435
4bde450ccf8a7992452f2adfd98277f20b510849: Bug 1555962 - Fix a typo that makes us reflow too much in abspos subtrees. r=jwatt a=pascalc
Emilio Cobos Álvarez <emilio@crisal.io> - Mon, 03 Jun 2019 12:10:29 +0000 - rev 522725
Push 28 by mozilla@hocat.ca at Mon, 01 Jul 2019 10:57:14 +0000
Bug 1555962 - Fix a typo that makes us reflow too much in abspos subtrees. r=jwatt a=pascalc Ugh, I accidentally introduced this in bug 1523071. :( Differential Revision: https://phabricator.services.mozilla.com/D33434
391c16d79dcc2230efa70b07e672b2e488c47807: Bug 1554167 - Remove pending shutdown sanitization immediately after shutdown sanitization finishes. r=mak,baku a=pascalc
Johann Hofmann <jhofmann@mozilla.com> - Thu, 30 May 2019 15:39:39 +0000 - rev 522724
Push 28 by mozilla@hocat.ca at Mon, 01 Jul 2019 10:57:14 +0000
Bug 1554167 - Remove pending shutdown sanitization immediately after shutdown sanitization finishes. r=mak,baku a=pascalc In https://hg.mozilla.org/mozilla-central/rev/25397a6f8c4f#l1.35 we added an early return to the SanitizeOnShutdown function to avoid cleaning principals by permission if the user had set their preferences to clear all storage on shutdown anyway. This unfortunately ended the function execution before it would call `removePendingSanitization("shutdown");` later on and thus remove the pending shutdown sanitization (which, in fact, had completed successfully earlier). The result is that the shutdown sanitization would be left dangling and run again on next startup, where, for reasons I don't fully understand, it would race and conflict with loading the home page, if that home page was from web content. The solution is to remove the pending shutdown sanitization immediately after the sanitization is done. As far as I can see there was never really a point in having it happen after session principal cleanup finished, since in case of a crash it would not run the principal cleanup again next startup, just the shutdown cleanup. For good measure I also moved the new tab container sanitization to happen earlier in this function, to prevent it from dangling as well. Differential Revision: https://phabricator.services.mozilla.com/D33087
a3f5330432615f332218aea8a704604d5e392c5c: Bug 1554744 - make button state in browser language dialog correct when there's no available languages, r=johannh a=pascalc
Gijs Kruitbosch <gijskruitbosch@gmail.com> - Fri, 31 May 2019 13:55:56 +0000 - rev 522723
Push 28 by mozilla@hocat.ca at Mon, 01 Jul 2019 10:57:14 +0000
Bug 1554744 - make button state in browser language dialog correct when there's no available languages, r=johannh a=pascalc Differential Revision: https://phabricator.services.mozilla.com/D33273
9bc4ce49c7bfa76b8190efd1d81a9bd7c2d2686d: Bug 1551282 and bug 1553436. Allow pages to override window.u2f but not the "sign" and "register" properties on the U2F object. r=jcj,smaug a=pascalc
Boris Zbarsky <bzbarsky@mit.edu> - Fri, 24 May 2019 20:40:59 +0000 - rev 522722
Push 28 by mozilla@hocat.ca at Mon, 01 Jul 2019 10:57:14 +0000
Bug 1551282 and bug 1553436. Allow pages to override window.u2f but not the "sign" and "register" properties on the U2F object. r=jcj,smaug a=pascalc There are two related problems this patch is trying to address. The first, and simpler, one is bug 1553436: there are websites that use existing variables and functions named "u2f" and adding a non-replaceable readonly property with that name on Window breaks them. The fix for this is straightforward: mark the property [Replaceable]. The second problem, covered by bug 1551282, involves sites that use the Google U2F polyfill. The relevant parts of that polyfill look like this: 'use strict'; var u2f = u2f || {}; u2f.register = some_function_that_only_works_right_in_Chrome; u2f.sign = some_function_that_only_works_right_in_Chrome; The failure mode for that code before this fix is that the assignment to "u2f" throws because it's a readonly property and we're in strict mode, so any code the page concatenates in the same file after the polyfill does not get run. That's what bug 1551282 is about. The [Replaceable] annotation fixes that issue, because now the polyfill gets the value of window.u2f and then redefines the property (via the [Replaceable] setter) to be a value property with that value. So far, so good. But then we need to prevent the sets of u2f.register and u2f.sign from taking effect, because if they are allowed to happen, the actual sign/register functionality on the page will not work in Firefox. We can't just make the properties readonly, because then the sets will throw due to being in strict mode, and we still have bug 1551282. The proposed fix is to make these accessor properties with a no-op setter, which is exactly what [LenientSetter] gives us. The rest of the patch is just setting up infrastructure for generating the normal bits we would generate if "sign" and "register" were methods and using that to create the JSFunctions at the point when the getter is called. The JSFunctions then get cached on the u2f instance object. Differential Revision: https://phabricator.services.mozilla.com/D32357
8b4e5a0c99fa6c09e7ef4f9ebb157a98efee3704: Bug 1553413 - Update and harden form data filtering for privacy to account for no data being passed in. r=dao a=pascalc
Mike de Boer <mdeboer@mozilla.com> - Wed, 22 May 2019 09:46:58 +0000 - rev 522721
Push 28 by mozilla@hocat.ca at Mon, 01 Jul 2019 10:57:14 +0000
Bug 1553413 - Update and harden form data filtering for privacy to account for no data being passed in. r=dao a=pascalc Differential Revision: https://phabricator.services.mozilla.com/D32116
5bb5e54bc396b91e6d4d16f7e9f4ca1c6f0a5118: Bug 1552275 - Fix Copy Link context menu in DevTools Inspector markup view. r=gl a=pascalc
Razvan Caliman <rcaliman@mozilla.com> - Mon, 20 May 2019 16:03:00 +0000 - rev 522720
Push 28 by mozilla@hocat.ca at Mon, 01 Jul 2019 10:57:14 +0000
Bug 1552275 - Fix Copy Link context menu in DevTools Inspector markup view. r=gl a=pascalc - Fixes the references to the correct event handler & InspectorFront after a previous mass refactoring in Bug 1529364. - Augments a test to ensure the clipboard content is correct executing the context menu action to copy a link. Differential Revision: https://phabricator.services.mozilla.com/D31765
0b7cdeda8ce9687c4bc03256551908582e629317: Bug 1552627 - pt 2, r=dveditz a=pascalc
Gijs Kruitbosch <gijskruitbosch@gmail.com> - Mon, 20 May 2019 06:19:51 +0000 - rev 522719
Push 28 by mozilla@hocat.ca at Mon, 01 Jul 2019 10:57:14 +0000
Bug 1552627 - pt 2, r=dveditz a=pascalc Depends on D31722 Differential Revision: https://phabricator.services.mozilla.com/D31723
a33f8698b1b9f3df3a2a5f90c0728c3f93c81873: Bug 1552627 - r=dveditz a=pascalc
Gijs Kruitbosch <gijskruitbosch@gmail.com> - Mon, 20 May 2019 06:32:46 +0000 - rev 522718
Push 28 by mozilla@hocat.ca at Mon, 01 Jul 2019 10:57:14 +0000
Bug 1552627 - r=dveditz a=pascalc Differential Revision: https://phabricator.services.mozilla.com/D31722
dab76a57636afe71343a32f05b0cf52ff69acf4f: Bug 1548804 - Remove origin suffix isolation for proxy credentials when setting authentication cache entry, r=valentin a=pascalc
Honza Bambas <honzab.moz@firemni.cz> - Fri, 07 Jun 2019 21:33:00 +0200 - rev 522717
Push 28 by mozilla@hocat.ca at Mon, 01 Jul 2019 10:57:14 +0000
Bug 1548804 - Remove origin suffix isolation for proxy credentials when setting authentication cache entry, r=valentin a=pascalc
8f446a8038936401283b7f943b793fe91a619e10: Backed out 2 changesets (bug 1495363) for causing bug 1542912 a=pascalc
Andreea Pavel <apavel@mozilla.com> - Thu, 16 May 2019 14:43:59 +0300 - rev 522716
Push 28 by mozilla@hocat.ca at Mon, 01 Jul 2019 10:57:14 +0000
Backed out 2 changesets (bug 1495363) for causing bug 1542912 a=pascalc Backed out changeset 1d6b361c337a (bug 1495363) Backed out changeset 7973453599bb (bug 1495363)
b6a4ddbd0aabe4126fd0f10a2ad24fbbc5bfabe1: Bug 1547399 - New stub installer background for release. r=agashlin a=pascalc
Matt Howell <mhowell@mozilla.com> - Wed, 08 May 2019 21:28:29 +0000 - rev 522699
Push 28 by mozilla@hocat.ca at Mon, 01 Jul 2019 10:57:14 +0000
Bug 1547399 - New stub installer background for release. r=agashlin a=pascalc The new background image has a white background behind the footer text, so this patch changes the color of the footer to black. It also moves the footer text a bit lower to align with the new logo placement. Differential Revision: https://phabricator.services.mozilla.com/D30210
df853c362664989e025d1206b59c37c435186a91: Bug 1550861 - Trailhead final uplift r=k88hudson,flod,r1cky a=pascalc
Ed Lee <edilee@mozilla.com> - Wed, 22 May 2019 18:59:12 -0700 - rev 522697
Push 28 by mozilla@hocat.ca at Mon, 01 Jul 2019 10:57:14 +0000
Bug 1550861 - Trailhead final uplift r=k88hudson,flod,r1cky a=pascalc Reviewers: k88hudson, flod, r1cky Reviewed By: k88hudson, flod, r1cky Subscribers: flod Bug #: 1550861 Differential Revision: https://phabricator.services.mozilla.com/D31877
ad5f0d47928f96a6bb998da9eb52284f63ac036e: Bug 1547830 - Ensure updated WNP is shown in the Trailhead dot release (aka 67.0.5) r=Gijs a=pascalc
Ed Lee <edilee@mozilla.com> - Wed, 22 May 2019 18:57:34 -0700 - rev 522696
Push 28 by mozilla@hocat.ca at Mon, 01 Jul 2019 10:57:14 +0000
Bug 1547830 - Ensure updated WNP is shown in the Trailhead dot release (aka 67.0.5) r=Gijs a=pascalc Reviewers: Gijs Reviewed By: Gijs Subscribers: tomprince Bug #: 1547830 Differential Revision: https://phabricator.services.mozilla.com/D31745
2a7896ba9aa5d982abe01f859d771d411fda8101: Bug 1551455 - Reinstall distribution language packs. r=kmag a=pascalc FIREFOX_67_0_BUILD2 FIREFOX_67_0_RELEASE
Michael Kaply <mozilla@kaply.com> - Fri, 17 May 2019 00:46:16 +0300 - rev 522690
Push 28 by mozilla@hocat.ca at Mon, 01 Jul 2019 10:57:14 +0000
Bug 1551455 - Reinstall distribution language packs. r=kmag a=pascalc Reviewers: kmag Reviewed By: kmag Subscribers: mossop Bug #: 1551455 Differential Revision: https://phabricator.services.mozilla.com/D31456
499809263177f7886716575b172501aa986a5b91: Bug 1550582 - Add wrench reftest. r=gw, a=pascalc FENNEC_67_0_BUILD1 FENNEC_67_0_RELEASE
Jamie Nicol <jnicol@mozilla.com> - Wed, 15 May 2019 10:45:25 +0000 - rev 522688
Push 28 by mozilla@hocat.ca at Mon, 01 Jul 2019 10:57:14 +0000
Bug 1550582 - Add wrench reftest. r=gw, a=pascalc Rename the old overlapping corners testcase and add comments to make the tests' purposes clearer: * The existing one is testing that a corner is clipped correctly when it overlaps with an adjacent corner. * The new one is testing that corners and segments are clipped correctly when opposite edges of the border overlap. Depends on D30814 Differential Revision: https://phabricator.services.mozilla.com/D30815
5f21e6f900c825223c2c076cb7cf7f928074ed05: Bug 1550582 - Ensure the overlap is filled correctly when opposite border edges overlap. r=gw, a=pascalc
Jamie Nicol <jnicol@mozilla.com> - Wed, 15 May 2019 10:43:25 +0000 - rev 522687
Push 28 by mozilla@hocat.ca at Mon, 01 Jul 2019 10:57:14 +0000
Bug 1550582 - Ensure the overlap is filled correctly when opposite border edges overlap. r=gw, a=pascalc To fix bug 1496540 it was made so that webrender clips border corner segments so that they do not overlap with their opposing edges. However, cases where opposing _edges_ both overlap with eachother (rather than just a corner overlapping with an edge), the corners are clipped too far and a gap is left in the middle. Additionally, no clipping was added to the edge segments. So rather than there be a gap there is an area that is painted twice, which is apparent if the colour is semi-transparent. This fixes these issues by identifying when opposing edges overlap and calculating the midpoint, then clipping the edges and corners to that midpoint instead. Differential Revision: https://phabricator.services.mozilla.com/D30814
fa5b6a15761ce4d81f730b756ff595eb91148376: Bug 1552156: Always set launcher pref default value to false; r=mhowell, a=pascalc
Aaron Klotz <aklotz@mozilla.com> - Thu, 16 May 2019 16:58:30 +0000 - rev 522686
Push 28 by mozilla@hocat.ca at Mon, 01 Jul 2019 10:57:14 +0000
Bug 1552156: Always set launcher pref default value to false; r=mhowell, a=pascalc Differential Revision: https://phabricator.services.mozilla.com/D31502
3126a5c2560c34a8acb33d62e54b2be0f704a190: Bug 1548795 - P2. Remove dom.performance.enable_scheduler_timing preference. r=tarek a=pascalc FIREFOX_67_0_BUILD1
Jean-Yves Avenard <jyavenard@mozilla.com> - Thu, 09 May 2019 23:12:12 +0000 - rev 522679
Push 28 by mozilla@hocat.ca at Mon, 01 Jul 2019 10:57:14 +0000
Bug 1548795 - P2. Remove dom.performance.enable_scheduler_timing preference. r=tarek a=pascalc Differential Revision: https://phabricator.services.mozilla.com/D30467
9faf017962724896d84b2c776454132beade33da: Bug 1548795 - P1. Don't use StaticPrefs in GPU process. r=mattwoodrow a=pascalc
Jean-Yves Avenard <jyavenard@mozilla.com> - Thu, 09 May 2019 23:12:12 +0000 - rev 522678
Push 28 by mozilla@hocat.ca at Mon, 01 Jul 2019 10:57:14 +0000
Bug 1548795 - P1. Don't use StaticPrefs in GPU process. r=mattwoodrow a=pascalc Differential Revision: https://phabricator.services.mozilla.com/D29984
fb5d546bb5b3c583a41225376e3e5a3674f90640: Bug 1535699 - Disable httpResponseProcessSelection on Fx67 for now. r=nika a=pascalc
Andrew Sutherland <asutherland@asutherland.org> - Mon, 13 May 2019 21:59:35 +0300 - rev 522677
Push 28 by mozilla@hocat.ca at Mon, 01 Jul 2019 10:57:14 +0000
Bug 1535699 - Disable httpResponseProcessSelection on Fx67 for now. r=nika a=pascalc Summary: This change also alters the test we added in bug 1535699 so that if the http process selection pref is disabled and parent intercept is not enabled, we expect the page to not migrate out of the file process. Reviewers: nika Bug #: 1535699 Differential Revision: https://phabricator.services.mozilla.com/D30685
ed39a05717aaba84fa217aada9bc2ce77cf98e11: Bug 1539118 - "Crash in mozilla::gfx::DrawTargetD2D1::CreateBrushForPattern when using Canvas" a=pascalc FENNEC_66_0_2_BUILD1 FENNEC_66_0_2_RELEASE FIREFOX_66_0_2_BUILD1 FIREFOX_66_0_2_RELEASE
Bas Schouten <bas> - Tue, 26 Mar 2019 05:06:00 +0200 - rev 522621
Push 28 by mozilla@hocat.ca at Mon, 01 Jul 2019 10:57:14 +0000
Bug 1539118 - "Crash in mozilla::gfx::DrawTargetD2D1::CreateBrushForPattern when using Canvas" a=pascalc
c00fbbe4f98880afd487fc8a1b67aed0bd46763b: Bug 1538966 - Beta/Release - Use legacy keyCode and charCode for sites with known issues. r=masayuki a=pascalc
Dennis Schubert <dschubert@mozilla.com> - Tue, 26 Mar 2019 17:40:24 +0200 - rev 522620
Push 28 by mozilla@hocat.ca at Mon, 01 Jul 2019 10:57:14 +0000
Bug 1538966 - Beta/Release - Use legacy keyCode and charCode for sites with known issues. r=masayuki a=pascalc Reviewers: masayuki Bug #: 1538966 Differential Revision: https://phabricator.services.mozilla.com/D24886
af42766a7d4e7b987bca92999b20d116e39976ce: Bug 1535612 - CSSKeyframeList::RemoveRule should clear parent references when removed. r=heycam, a=pascalc
Emilio Cobos Álvarez <emilio@crisal.io> - Wed, 20 Mar 2019 09:50:51 +0000 - rev 522618
Push 28 by mozilla@hocat.ca at Mon, 01 Jul 2019 10:57:14 +0000
Bug 1535612 - CSSKeyframeList::RemoveRule should clear parent references when removed. r=heycam, a=pascalc Differential Revision: https://phabricator.services.mozilla.com/D23729
4e09989843e23ea8f5ab88740cbb4d231c00a44c: Bug 1535766 - Handle unaligned buffers in WebrtcGmpVideoCodec::Encoded; r=bwc a=pascalc
Dan Minor <dminor@mozilla.com> - Tue, 19 Mar 2019 17:15:39 +0000 - rev 522616
Push 28 by mozilla@hocat.ca at Mon, 01 Jul 2019 10:57:14 +0000
Bug 1535766 - Handle unaligned buffers in WebrtcGmpVideoCodec::Encoded; r=bwc a=pascalc This uses the Endian routines to ensure that reads will match the endianess of the current machine, which is the expected behaviour of the openh264 plugin. The calls to readUint16 and readUint32 memcpy to a properly aligned buffer avoiding any problems with alignment. The memcpy adds some overhead but it seems negligible compared to the amount of work done to packetize and send the encoded data. These changes were tested by adding code to create an unaligned buffer and memcopying the received buffer into it. This also adds a null check for the received buffer as we have seen a small volume of null pointer crashes. Differential Revision: https://phabricator.services.mozilla.com/D24030
fa9b70ce49a8c298cccf62ea0e7179d5634b13a2: Bug 1521370 - Ensure WMF PDM is always initialized on the right thread. r=mattwoodrow,gerald. a=pascalc
Jean-Yves Avenard <jyavenard@mozilla.com> - Wed, 13 Mar 2019 06:16:52 +0000 - rev 522615
Push 28 by mozilla@hocat.ca at Mon, 01 Jul 2019 10:57:14 +0000
Bug 1521370 - Ensure WMF PDM is always initialized on the right thread. r=mattwoodrow,gerald. a=pascalc And only do it once. Depends on D22874 Differential Revision: https://phabricator.services.mozilla.com/D23247
15d61033a7ee9c680fee519b46cfcb7ea1efbdcc: Bug 1521370 - Always enable WMF VPX crashguard on Nightly r=mattwoodrow a=pascalc
Jean-Yves Avenard <jyavenard@mozilla.com> - Wed, 13 Mar 2019 01:52:26 +0000 - rev 522614
Push 28 by mozilla@hocat.ca at Mon, 01 Jul 2019 10:57:14 +0000
Bug 1521370 - Always enable WMF VPX crashguard on Nightly r=mattwoodrow a=pascalc There's nothing to get around it unfortunately, making firefox unusable without it. Differential Revision: https://phabricator.services.mozilla.com/D22874
2c61fe7ae01b271455162555e22cd044ef478ce7: Bug 1521370 - Remove unused method. r=mattwoodrow a=pascalc
Jean-Yves Avenard <jyavenard@mozilla.com> - Wed, 13 Mar 2019 01:50:41 +0000 - rev 522613
Push 28 by mozilla@hocat.ca at Mon, 01 Jul 2019 10:57:14 +0000
Bug 1521370 - Remove unused method. r=mattwoodrow a=pascalc Differential Revision: https://phabricator.services.mozilla.com/D22624