Bug 1460882 - Disable SANDBOX_EXPORTS for the MinGW Build. r=bobowen, a=jcristau
authorTom Ritter <tom@mozilla.com>
Fri, 11 May 2018 08:16:13 -0500
changeset 449335 9af1d77b0ec5d46be83c4afd4f30780a3f05f571
parent 449334 15638bdb5acb23230520993618fe0d5f57f8f281
child 449336 8d568f13019209d727e5ef0f777fe7d7ed27964b
push id43
push userryanvm@gmail.com
push dateWed, 23 May 2018 01:24:58 +0000
treeherdermozilla-esr60@54937944b922 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersbobowen, jcristau
bugs1460882
milestone60.0.2
Bug 1460882 - Disable SANDBOX_EXPORTS for the MinGW Build. r=bobowen, a=jcristau MozReview-Commit-ID: 2muTxIYUx6F
security/sandbox/moz.build
--- a/security/sandbox/moz.build
+++ b/security/sandbox/moz.build
@@ -151,19 +151,21 @@ elif CONFIG['OS_ARCH'] == 'WINNT':
             'chromium/sandbox/win/src/service_resolver_64.cc',
         ]
     else:
         SOURCES += [
             'chromium/sandbox/win/src/resolver_32.cc',
             'chromium/sandbox/win/src/service_resolver_32.cc',
         ]
 
-    for var in ('UNICODE', '_UNICODE', 'NS_NO_XPCOM', 'SANDBOX_EXPORTS',
+    for var in ('UNICODE', '_UNICODE', 'NS_NO_XPCOM',
                 '_CRT_RAND_S', 'CHROMIUM_SANDBOX_BUILD'):
         DEFINES[var] = True
+    if CONFIG['CC_TYPE'] != 'gcc':
+        DEFINES['SANDBOX_EXPORTS'] = True
 
     LOCAL_INCLUDES += ['/security/sandbox/chromium-shim']
     LOCAL_INCLUDES += ['/security/sandbox/chromium']
     LOCAL_INCLUDES += ['/nsprpub']
 
     DisableStlWrapping()
 
     # Suppress warnings in third-party code.