Bug 1479071 - Revert kPMDataFormatXMLCompressed to kPMDataFormatXMLNormal. r=mstange, a=RyanVM
authorMantaroh Yoshinaga <mantaroh@gmail.com>
Wed, 22 Aug 2018 02:07:28 +0000
changeset 450031 97ccdfcb42197c37ba788b28b5333495e3d6213a
parent 450030 07aedc90a6c16dca9f0727cb787c2af85aeb3a84
child 450032 d3e100fe45ae459b9e44f5be686bfcebf2b6c392
push id149
push userryanvm@gmail.com
push dateThu, 23 Aug 2018 15:05:47 +0000
treeherdermozilla-esr60@97ccdfcb4219 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersmstange, RyanVM
bugs1479071, 1411879
milestone60.1.1
Bug 1479071 - Revert kPMDataFormatXMLCompressed to kPMDataFormatXMLNormal. r=mstange, a=RyanVM Bug 1411879 introduced kPMDataFormatXMLCompress. However, this parameter caused the saving print settings problem. Before investigating this reason, this patch will revert this parameter. Differential Revision: https://phabricator.services.mozilla.com/D3943
widget/cocoa/nsPrintSettingsX.mm
--- a/widget/cocoa/nsPrintSettingsX.mm
+++ b/widget/cocoa/nsPrintSettingsX.mm
@@ -156,17 +156,17 @@ NS_IMETHODIMP nsPrintSettingsX::WritePag
 {
   NS_OBJC_BEGIN_TRY_ABORT_BLOCK_NSRESULT;
 
   PMPageFormat pageFormat = GetPMPageFormat();
   if (pageFormat == kPMNoPageFormat)
     return NS_ERROR_NOT_INITIALIZED;
 
   NSData* data = nil;
-  OSStatus err = ::PMPageFormatCreateDataRepresentation(pageFormat, (CFDataRef*)&data, kPMDataFormatXMLCompressed);
+  OSStatus err = ::PMPageFormatCreateDataRepresentation(pageFormat, (CFDataRef*)&data, kPMDataFormatXMLDefault);
   if (err != noErr)
     return NS_ERROR_FAILURE;
 
   nsAutoCString encodedData;
   encodedData.Adopt(PL_Base64Encode((char*)[data bytes], [data length], nullptr));
   if (!encodedData.get())
     return NS_ERROR_OUT_OF_MEMORY;