Bug 1560064 - Barrier: Remove JS_BROKEN_GCC_ATTRIBUTE_WARNING guards. r=sfink, a=RyanVM
authorMarco Trevisan (Treviño) <mail@3v1n0.net>
Thu, 20 Jun 2019 19:19:58 +0200
changeset 451241 40875ef8e478b3abf990a5e46b543eb7df4f03a8
parent 451240 018a95ef3070d3b37b16ea6d3b863ac2694d54da
child 451242 6df5bb56fbbf3ee77c799c558ef8632eed402fda
push id450
push userryanvm@gmail.com
push dateFri, 28 Jun 2019 15:12:37 +0000
treeherdermozilla-esr60@6df5bb56fbbf [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerssfink, RyanVM
bugs1560064
milestone60.7.3
Bug 1560064 - Barrier: Remove JS_BROKEN_GCC_ATTRIBUTE_WARNING guards. r=sfink, a=RyanVM
js/src/gc/Barrier.cpp
--- a/js/src/gc/Barrier.cpp
+++ b/js/src/gc/Barrier.cpp
@@ -167,35 +167,26 @@ template <typename T>
   if (!zone->maybeGetUniqueId(k, &keyId)) {
     // Key is dead and cannot match lookup which must be live.
     return false;
   }
 
   return keyId == zone->getUniqueIdInfallible(l);
 }
 
-#ifdef JS_BROKEN_GCC_ATTRIBUTE_WARNING
-#pragma GCC diagnostic push
-#pragma GCC diagnostic ignored "-Wattributes"
-#endif  // JS_BROKEN_GCC_ATTRIBUTE_WARNING
-
 #if !MOZ_IS_GCC
 template struct JS_PUBLIC_API MovableCellHasher<JSObject*>;
 #endif
 
 template struct JS_PUBLIC_API MovableCellHasher<GlobalObject*>;
 template struct JS_PUBLIC_API MovableCellHasher<SavedFrame*>;
 template struct JS_PUBLIC_API MovableCellHasher<EnvironmentObject*>;
 template struct JS_PUBLIC_API MovableCellHasher<WasmInstanceObject*>;
 template struct JS_PUBLIC_API MovableCellHasher<JSScript*>;
 
-#ifdef JS_BROKEN_GCC_ATTRIBUTE_WARNING
-#pragma GCC diagnostic pop
-#endif  // JS_BROKEN_GCC_ATTRIBUTE_WARNING
-
 }  // namespace js
 
 JS_PUBLIC_API void JS::HeapObjectPostBarrier(JSObject** objp, JSObject* prev,
                                              JSObject* next) {
   MOZ_ASSERT(objp);
   js::InternalBarrierMethods<JSObject*>::postBarrier(objp, prev, next);
 }