Bug 1285176 - Fix intermittent test_mousecapture.xhtml by removing a check whose success we can't guarantee. r=kats, a=test-only
authorGijs Kruitbosch <gijskruitbosch@gmail.com>
Wed, 18 Jan 2017 16:10:49 +0000
changeset 353661 ec7bc68407bc15224201ece596ae0a0ec4b53e6c
parent 353660 0a98114d9a15b3f78723ab73d5a9280a81212abd
child 353662 ed6e5d97950a01e80679a17e7abd4a3ed28e8f6b
push id6795
push userjlund@mozilla.com
push dateMon, 23 Jan 2017 14:19:46 +0000
treeherdermozilla-esr52@76101b503191 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerskats, test-only
bugs1285176
milestone52.0a2
Bug 1285176 - Fix intermittent test_mousecapture.xhtml by removing a check whose success we can't guarantee. r=kats, a=test-only MozReview-Commit-ID: KzuOs4e9mCe
toolkit/content/tests/mochitest/test_mousecapture.xhtml
--- a/toolkit/content/tests/mochitest/test_mousecapture.xhtml
+++ b/toolkit/content/tests/mochitest/test_mousecapture.xhtml
@@ -74,22 +74,23 @@ function selectionScrollCheck()
     otherWindow.removeEventListener("scroll", selectionScrollDone, false);
 
     var selectedText = otherWindow.getSelection().toString().replace(/\r/g, "");
     is(selectedText, "One\n\nTwo", "text is selected");
 
     // should have scrolled 20 pixels from the mousemove above and at least 6
     // extra 20-pixel increments from the selection scroll timer. "At least 6"
     // because we waited for 6 scroll events but multiple scrolls could get
-    // coalesced into a single scroll event. Therefore we allow 6-15 scrolls,
-    // which corresponds to a scroll position of 140 to 320. The 15 is chosen
-    // arbitrarily and can be adjusted.
+    // coalesced into a single scroll event, and paints could be delayed when
+    // the window loads when the compositor is busy. As a result, we have no
+    // real guarantees about the upper bound here, and as the upper bound is
+    // not important for what we're testing here, we don't check it.
     var scrollY = otherWindow.scrollY;
+    info(`Scrolled ${scrollY} pixels`);
     ok(scrollY >= 140, "selection scroll position after timer is at least 140");
-    ok(scrollY <= 320, "selection scroll position after timer is not more than 320");
     ok((scrollY % 20) == 0, "selection scroll position after timer is multiple of 20");
 
     synthesizeMouse(element, 4, otherWindow.innerHeight + 25, { type: "mouseup" }, otherWindow);
     disableNonTestMouseEvents(false);
     otherWindow.close();
 
     if (loadInWindow) {
       SimpleTest.finish();