Bug 1434380: Rewrite parts of reftest reference case grid-auto-min-sizing-definite-001-ref.html to be easier to understand & adjust. r=mats a=IanN DONTBUILD CLOSED TREE SEAMONKEY_2_49_ESR_RELBRANCH
authorDaniel Holbert <dholbert@cs.stanford.edu>
Tue, 30 Jan 2018 22:17:13 -0500
branchSEAMONKEY_2_49_ESR_RELBRANCH
changeset 357573 dc52d89bf6d8ff2cc8fa9a1c38b4088eafbda6a3
parent 357572 3562796c356716fbed4db33b9ea77d72fc639f04
child 357574 831b454b9038a9fc8b1cdb235cdde640e398f774
push id7836
push userfrgrahl@gmx.net
push dateMon, 15 Jul 2019 16:17:02 +0000
treeherdermozilla-esr52@3a4afe7ecac5 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersmats, IanN
bugs1434380
milestone52.9.1
Bug 1434380: Rewrite parts of reftest reference case grid-auto-min-sizing-definite-001-ref.html to be easier to understand & adjust. r=mats a=IanN DONTBUILD CLOSED TREE SeaMonkey ESR52 release branch only. In particular: - I'm specifying exact content-box sizes on some containers in the reference case, to match the actual (automatic / grid-area-determined) content-box sizes in the testcase. - I'm removing the element "w" and its selectors, since it was only used in one spot and it wasn't clear what it was being used for (and it doesn't exist in the testcase). - I'm specifying explicit margin and padding values for the ".v.r" and ".h.r" rules, based on observed values from the testcase, and I'm including comments to explain mathematically why they are correct. MozReview-Commit-ID: JKfxeTp1ZU9
layout/reftests/css-grid/grid-auto-min-sizing-definite-001-ref.html
--- a/layout/reftests/css-grid/grid-auto-min-sizing-definite-001-ref.html
+++ b/layout/reftests/css-grid/grid-auto-min-sizing-definite-001-ref.html
@@ -57,50 +57,41 @@ span.h {
 b40 {
   display: block;
   width: 40px;
   height: 40px;
   border: 1px solid pink;
   z-index: 1; position:relative;
 }
 
-w {
-  position:absolute;
-  background: lime;
-  border-width: 1px 0 0 3px;
-  border-style: solid;
-  height:48px;
-  width:75px;
+.h.r {
+  height: 42px;
+  width: 42px;
+  /* This margin-left is 20% of 98px-wide grid area */
+  margin-left: 19.6px;
+  /* This padding-bottom is 10% of 47.5px tall grid area */
+  /* This padding-left   is 30% of 98px wide grid area */
+  padding: 1px 3px 4.75px 29.4px;
 }
-.v > w {
-  border-width: 3px 0 0 1px;
-  left:-1px; top:-3px;
-  height:53px;
-  width:61px;
-}
-.h.r { margin-left:19px; padding: 1px 15px 37px 30px; }
-.v .h > w {
-  height:48px;
-  width:45px;
-}
-.v.r > w {
-  height:53px;
-  width:61px;
-}
-.v .v > w {
-  height:41px;
-  width:45px;
+.v.r {
+  height: 42px;
+  width: 42px;
+  /* This margin-left is 20% of 54px-wide grid area */
+  margin-left: 10.8px;
+  /* This padding-bottom is 10% of 102.5px tall grid area */
+  /* This padding-left   is 30% of 54px wide grid area */
+  padding: 1px 3px 10.25px 16.2px;
 }
 
 .r { position:relative; }
 
 .t6 { width:46px; }
-.t8 { width:118px; }
+.t8 { width:118px; height: 102.5px; }
 
-xx { 
+xx {
   display: block;
   background: lime;
   padding:32px 32px 16px 32px;
   margin: 0 0 32px 16px;
 }
   </style>
 </head>
 <body>
@@ -109,15 +100,15 @@ xx {
 <div class="grid"><span class="h"><x></x></span></div>
 <div class="grid"><span class="h bb"><x></x></span></div>
 <div class="grid"><span class="h"><x></x></span><span class="h"><x></x></span></div>
 <div class="grid" style="grid:48px / 122px"><span class="h r"><b40></b40></span></div>
 <br>
 <div class="grid"><span class="v"><x></x></span></div>
 <div class="grid t6"><span class="v bb"><x></x></span></div>
 <div class="grid"><span class="v"><x></x></span><span class="v"><x></x></span></div>
-<div class="grid t8"><span class="v r"><w></w><b40></b40></span></div>
+<div class="grid t8"><span class="v r"><b40></b40></span></div>
 
 <div class="grid"><xx class="v"></xx></div>
 <div class="grid v"><xx class="h"></xx></div>
 
 </body>
 </html>