Bug 1318903 - use !important to force vista/7 controls in fullscreen even on dark themes, r=dao, a=gchang
authorGijs Kruitbosch <gijskruitbosch@gmail.com>
Mon, 21 Nov 2016 16:41:23 +0000
changeset 352685 cf76a8e08edf33b38340deb976c10c5983c85058
parent 352684 ea3f6566462f1ea5127d94168838153867f23385
child 352686 9dd3c365bc5d04cfb5bd4170e86c74cfdeb9246c
push id6795
push userjlund@mozilla.com
push dateMon, 23 Jan 2017 14:19:46 +0000
treeherdermozilla-esr52@76101b503191 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersdao, gchang
bugs1318903
milestone52.0a2
Bug 1318903 - use !important to force vista/7 controls in fullscreen even on dark themes, r=dao, a=gchang MozReview-Commit-ID: eIleloCNMZ
browser/themes/windows/browser.css
--- a/browser/themes/windows/browser.css
+++ b/browser/themes/windows/browser.css
@@ -1101,17 +1101,21 @@ toolbar[brighttext] #close-button {
        (-moz-os-version: windows-win7) {
   #window-controls {
     margin-inline-start: 4px;
   }
 
   #minimize-button,
   #restore-button,
   #close-button {
-    list-style-image: url("chrome://global/skin/icons/windowControls.png");
+    /* Important to ensure this applies even on toolbar[brighttext] */
+    list-style-image: url("chrome://global/skin/icons/windowControls.png") !important;
+    /* Also override background color to a avoid hover background styling
+     * leaking through around the image. */
+    background-color: transparent !important;
     padding: 0;
   }
 
   #minimize-button {
     -moz-image-region: rect(0, 16px, 16px, 0);
   }
 
   #minimize-button:hover {