Bug 1407017 - Make --with-visual-studio-version a js_option. r=ted, a=IanN CLOSED TREE DONTBUILD SEAMONKEY_2_49_ESR_RELBRANCH
authorDavid Major <dmajor@mozilla.com>
Mon, 09 Oct 2017 12:16:00 -0400
branchSEAMONKEY_2_49_ESR_RELBRANCH
changeset 357475 c44482b0a53be1def0676a02783f4d6a10a07016
parent 357474 72b6b6f8b2109b259a6a716bf97119298befcb9b
child 357476 1b9aa9753d8ddee709edf8f00a728d7ce9ca4cef
push id7834
push userfrgrahl@gmx.net
push dateSun, 13 Jan 2019 12:17:02 +0000
treeherdermozilla-esr52@6e4ad8a8f2e8 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersted, IanN
bugs1407017
milestone52.9.1
Bug 1407017 - Make --with-visual-studio-version a js_option. r=ted, a=IanN CLOSED TREE DONTBUILD mozilla-esr52 SEAMONKEY_2_49_ESR_RELBRANCH
build/moz.configure/toolchain.configure
--- a/build/moz.configure/toolchain.configure
+++ b/build/moz.configure/toolchain.configure
@@ -420,19 +420,19 @@ def get_vc_paths(topsrcdir):
         tools_version = open(os.path.join(path, r'VC\Auxiliary\Build\Microsoft.VCToolsVersion.default.txt'), 'rb').read().strip()
         tools_path = os.path.join(path, r'VC\Tools\MSVC', tools_version, r'bin\HostX64')
         yield (Version(install['installationVersion']), {
             'x64': [os.path.join(tools_path, 'x64')],
             # The x64->x86 cross toolchain requires DLLs from the native x64 toolchain.
             'x86': [os.path.join(tools_path, 'x86'), os.path.join(tools_path, 'x64')],
         })
 
-option('--with-visual-studio-version', nargs=1,
-       choices=('2015', '2017'),
-       help='Select a specific Visual Studio version to use')
+js_option('--with-visual-studio-version', nargs=1,
+          choices=('2015', '2017'),
+          help='Select a specific Visual Studio version to use')
 
 @depends('--with-visual-studio-version')
 def vs_major_version(value):
     if value:
         return {'2015': 14,
                 '2017': 15}[value[0]]
 
 @depends(host, target, vs_major_version, check_build_environment, '--with-visual-studio-version')