Bug 1224326 - CRASH when pause then continue download several times. r=frg a=frg DONTBUILD CLOSED TREE SEAMONKEY_2_49_ESR_RELBRANCH
authorIan Neal <iann_cvs@blueyonder.co.uk>
Mon, 15 Jul 2019 18:08:01 +0200
branchSEAMONKEY_2_49_ESR_RELBRANCH
changeset 357570 8b321df52efd08e36805b5b8206c2def24f952be
parent 357569 e0e23e1fd9e3bf023397ebf0dd412ccc6d6954d4
child 357571 8a53acedcb5a9675044bcee05ea67f672fd54e5b
push id7836
push userfrgrahl@gmx.net
push dateMon, 15 Jul 2019 16:17:02 +0000
treeherdermozilla-esr52@3a4afe7ecac5 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersfrg, frg
bugs1224326
milestone52.9.1
Bug 1224326 - CRASH when pause then continue download several times. r=frg a=frg DONTBUILD CLOSED TREE Fix/hack for SeaMonkey ESR52 release branch only.
toolkit/components/downloads/nsDownloadManager.cpp
--- a/toolkit/components/downloads/nsDownloadManager.cpp
+++ b/toolkit/components/downloads/nsDownloadManager.cpp
@@ -3119,17 +3119,17 @@ nsDownload::OnStateChange(nsIWebProgress
 
       if (scan)
         (void)SetState(nsIDownloadManager::DOWNLOAD_SCANNING);
       else
         (void)SetState(nsIDownloadManager::DOWNLOAD_FINISHED);
 #else
       (void)SetState(nsIDownloadManager::DOWNLOAD_FINISHED);
 #endif
-    } else {
+    } else if (aStatus != NS_BINDING_ABORTED) {
       // We failed for some unknown reason -- fail with a generic message
       (void)FailDownload(aStatus, nullptr);
     }
   }
 
   mDownloadManager->NotifyListenersOnStateChange(aWebProgress, aRequest,
                                                  aStateFlags, aStatus, this);
   return NS_OK;