Bug 1309851 - Fix "Intermittent valgrind-test | Valgrind timed out (reached 1800 second limit)". r=n.nethercote@gmail.com.
authorJulian Seward <jseward@acm.org>
Thu, 10 Nov 2016 11:25:19 +0100
changeset 352012 87a690e25827b4ce1cd8149c9e87893f6772420a
parent 352011 9afc1d0229c76f3876972638bbe398a91385e241
child 352013 9d15c879fb12cccd023a440ec4a446ad3fda1999
push id6795
push userjlund@mozilla.com
push dateMon, 23 Jan 2017 14:19:46 +0000
treeherdermozilla-esr52@76101b503191 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersn
bugs1309851
milestone52.0a1
Bug 1309851 - Fix "Intermittent valgrind-test | Valgrind timed out (reached 1800 second limit)". r=n.nethercote@gmail.com.
build/valgrind/mach_commands.py
--- a/build/valgrind/mach_commands.py
+++ b/build/valgrind/mach_commands.py
@@ -108,16 +108,19 @@ class MachCommands(MachCommandBase):
                 '--vex-iropt-register-updates=allregs-at-mem-access',
                 '--gen-suppressions=all',
                 '--num-callers=36',
                 '--leak-check=full',
                 '--show-possibly-lost=no',
                 '--track-origins=yes',
                 '--trace-children=yes',
                 '-v',  # Enable verbosity to get the list of used suppressions
+                # Avoid excessive delays in the presence of spinlocks.
+                # See bug 1309851.
+                '--fair-sched=yes',
             ]
 
             for s in suppressions:
                 valgrind_args.append('--suppressions=' + s)
 
             supps_dir = os.path.join(build_dir, 'valgrind')
             supps_file1 = os.path.join(supps_dir, 'cross-architecture.sup')
             valgrind_args.append('--suppressions=' + supps_file1)