Backed out changeset b04c5c12b200 (bug 1316486) for webgl failures
authorCarsten "Tomcat" Book <cbook@mozilla.com>
Thu, 10 Nov 2016 12:37:05 +0100
changeset 351925 827b1805b72469f2612649b41df015359777fe0a
parent 351924 324fdf1165e8ae5bd57cb91e5aca3daf083d57a7
child 351926 4ee98684375e8c3c3dabccf8285268fa57f0f8a5
child 352020 1f58f59c9003b8ab1188258b75bc08d5209f696b
push id6795
push userjlund@mozilla.com
push dateMon, 23 Jan 2017 14:19:46 +0000
treeherdermozilla-esr52@76101b503191 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
bugs1316486
milestone52.0a1
backs outb04c5c12b2009fb0d32887aeaad68cd048ec3992
Backed out changeset b04c5c12b200 (bug 1316486) for webgl failures
dom/canvas/WebGLContextGL.cpp
--- a/dom/canvas/WebGLContextGL.cpp
+++ b/dom/canvas/WebGLContextGL.cpp
@@ -165,19 +165,19 @@ WebGLContext::BindRenderbuffer(GLenum ta
         return;
 
     if (target != LOCAL_GL_RENDERBUFFER)
         return ErrorInvalidEnumInfo("bindRenderbuffer: target", target);
 
     if (!ValidateObjectAllowDeletedOrNull("bindRenderbuffer", wrb))
         return;
 
-    if (wrb && wrb->IsDeleted()) {
-        return ErrorInvalidOperation("BindRenderbuffer: bind a deleted buffer");
-    }
+    // silently ignore a deleted buffer
+    if (wrb && wrb->IsDeleted())
+        return;
 
     // Usually, we would now call into glBindRenderbuffer. However, since we have to
     // potentially emulate packed-depth-stencil, there's not a specific renderbuffer that
     // we know we should bind here.
     // Instead, we do all renderbuffer binding lazily.
 
     if (wrb) {
         wrb->mHasBeenBound = true;