Bug 1325148 - Temporarily disable leakchecking in crashtests on linux, r=jmaher, a=test-only
authorAndrew Halberstadt <ahalberstadt@mozilla.com>
Wed, 21 Dec 2016 17:06:29 -0500
changeset 353332 7bdc0736906babab2e5f01f394859202da71b60a
parent 353331 6c6b325d419763fef5172fdbd06e500f023a428e
child 353333 05a3443d658d29e77cae1da1915ca51814534d73
push id6795
push userjlund@mozilla.com
push dateMon, 23 Jan 2017 14:19:46 +0000
treeherdermozilla-esr52@76101b503191 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersjmaher, test-only
bugs1325148, 1325215
milestone52.0a2
Bug 1325148 - Temporarily disable leakchecking in crashtests on linux, r=jmaher, a=test-only This is being disabled because of the leak in bug 1325215. It slipped in because leak checking in reftest was temporarily failing to turn the job orange. We are disabling leak checking so we can land the fix ASAP and prevent further bustage from slipping through in the mean time. Once bug 1325215 has been fixed, this should be backed out. MozReview-Commit-ID: 74VGhHvZtIG
layout/tools/reftest/runreftest.py
--- a/layout/tools/reftest/runreftest.py
+++ b/layout/tools/reftest/runreftest.py
@@ -362,17 +362,27 @@ class RefTest(object):
             ix = v.find("=")
             if ix <= 0:
                 print "Error: syntax error in --setenv=" + v
                 return None
             browserEnv[v[:ix]] = v[ix + 1:]
 
         # Enable leaks detection to its own log file.
         self.leakLogFile = os.path.join(profileDir, "runreftest_leaks.log")
-        browserEnv["XPCOM_MEM_BLOAT_LOG"] = self.leakLogFile
+
+        # Leak checking was broken in reftest unnoticed for a length of time. During
+        # this time, a leak slipped into the crashtest suite. The leak checking was
+        # fixed by bug 1325148, but it couldn't land until the regression in crashtest
+        # was also fixed or backed out. Rather than waiting and risking new regressions,
+        # temporarily disable leak checking in crashtest. Fix is tracked by bug 1325215.
+        if options.suite == 'crashtest' and mozinfo.info['os'] == 'linux':
+            self.log.warning('WARNING | leakcheck disabled due to bug 1325215')
+        else:
+            browserEnv["XPCOM_MEM_BLOAT_LOG"] = self.leakLogFile
+
         return browserEnv
 
     def killNamedOrphans(self, pname):
         """ Kill orphan processes matching the given command name """
         self.log.info("Checking for orphan %s processes..." % pname)
 
         def _psInfo(line):
             if pname in line: