Bug 1317462 - Remove XULappId capability from Marionette. r=automatedtester, a=test-only
authorAndreas Tolfsen <ato@mozilla.com>
Tue, 15 Nov 2016 00:23:31 +0000
changeset 352815 735d9cd1eb175bf51b151968ad7718dddd967892
parent 352814 191d4889fc848394a5cdc1a24de413b3a633c7c9
child 352816 b19a90e15e88781d4254011566f9a142c11674c1
push id6795
push userjlund@mozilla.com
push dateMon, 23 Jan 2017 14:19:46 +0000
treeherdermozilla-esr52@76101b503191 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersautomatedtester, test-only
bugs1317462
milestone52.0a2
Bug 1317462 - Remove XULappId capability from Marionette. r=automatedtester, a=test-only MozReview-Commit-ID: 5kgY3SAYFrr
testing/marionette/driver.js
testing/marionette/harness/marionette/tests/unit/test_capabilities.py
--- a/testing/marionette/driver.js
+++ b/testing/marionette/driver.js
@@ -145,17 +145,16 @@ this.GeckoDriver = function(appName, ser
     "takesElementScreenshot": true,
     "takesScreenshot": true,
     "proxy": {},
 
     // Selenium 2 compat
     "platform": Services.sysinfo.getProperty("name").toUpperCase(),
 
     // proprietary extensions
-    "XULappId" : Services.appinfo.ID,
     "appBuildId" : Services.appinfo.appBuildID,
     "processId" : Services.appinfo.processID,
   };
 
   this.mm = globalMessageManager;
   this.listener = proxy.toListener(() => this.mm, this.sendAsync.bind(this));
 
   // always keep weak reference to current dialogue
--- a/testing/marionette/harness/marionette/tests/unit/test_capabilities.py
+++ b/testing/marionette/harness/marionette/tests/unit/test_capabilities.py
@@ -42,20 +42,18 @@ class TestCapabilities(MarionetteTestCas
         self.assertTrue(self.caps["takesElementScreenshot"])
         self.assertTrue(self.caps["takesScreenshot"])
 
     def test_selenium2_compat(self):
         self.assertIn("platform", self.caps)
         self.assertEqual(self.caps["platform"], self.caps["platformName"].upper())
 
     def test_extensions(self):
-        self.assertIn("XULappId", self.caps)
         self.assertIn("appBuildId", self.caps)
 
-        self.assertEqual(self.caps["XULappId"], self.appinfo["ID"])
         self.assertEqual(self.caps["appBuildId"], self.appinfo["appBuildID"])
 
     def test_we_can_pass_in_capabilities_on_session_start(self):
         self.marionette.delete_session()
         capabilities = {"desiredCapabilities": {"somethingAwesome": "cake"}}
         self.marionette.start_session(capabilities)
         caps = self.marionette.session_capabilities
         self.assertIn("somethingAwesome", caps)