Bug 1338574 - Part 5: Use MOZ_CRASH_UNSAFE_OOL in Necko. r=valentin, a=NPOTB
authorEmanuel Hoogeveen <emanuel.hoogeveen@gmail.com>
Tue, 21 Feb 2017 18:01:56 +0100
changeset 355807 697713a6841ca85e9daadf8bcbbe20585141ef8f
parent 355806 b10d9b0c187f525bda8bb521998302f1830ae2c6
child 355808 1d14abf37cf8cac38763f79c70742fac5a0fbb16
push id7088
push userryanvm@gmail.com
push dateThu, 11 May 2017 21:13:08 +0000
treeherdermozilla-esr52@5e85bc599d0c [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersvalentin, NPOTB
bugs1338574
milestone52.1.2
Bug 1338574 - Part 5: Use MOZ_CRASH_UNSAFE_OOL in Necko. r=valentin, a=NPOTB
netwerk/ipc/NeckoParent.cpp
--- a/netwerk/ipc/NeckoParent.cpp
+++ b/netwerk/ipc/NeckoParent.cpp
@@ -145,18 +145,17 @@ GetRequestingPrincipal(const FTPChannelC
 
 // Bug 1289001 - If GetValidatedOriginAttributes returns an error string, that
 // usually leads to a content crash with very little info about the cause.
 // We prefer to crash on the parent, so we get the reason in the crash report.
 static MOZ_COLD
 void CrashWithReason(const char * reason)
 {
 #ifndef RELEASE_OR_BETA
-  MOZ_CRASH_ANNOTATE(reason);
-  MOZ_REALLY_CRASH();
+  MOZ_CRASH_UNSAFE_OOL(reason);
 #endif
 }
 
 const char*
 NeckoParent::GetValidatedOriginAttributes(const SerializedLoadContext& aSerialized,
                                           PContentParent* aContent,
                                           nsIPrincipal* aRequestingPrincipal,
                                           DocShellOriginAttributes& aAttrs)