Bug 1338655 - Don't try to build mp4parse bindings. r=froydnj a=IanN DONTBUILD CLOSED TREE SEAMONKEY_2_49_ESR_RELBRANCH
authorRalph Giles <giles@mozilla.com>
Mon, 15 Jul 2019 18:07:58 +0200
changeset 357557 65825fac321f21f865e50b7c09aaa968c040d2c4
parent 357556 0a7fa4f920705845b8fd50c38fe7bb9b72b5a869
child 357558 3c7797e7a8ddd3b7ddebcfe400828787e041d161
push id7836
push userfrgrahl@gmx.net
push dateMon, 15 Jul 2019 16:17:02 +0000
treeherdermozilla-esr52@3a4afe7ecac5 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersfroydnj, IanN
Bug 1338655 - Don't try to build mp4parse bindings. r=froydnj a=IanN DONTBUILD CLOSED TREE SeaMonkey ESR52 release branch only. We use the cheddar crate to generate a C header file for our mp4parse_capi wrapper crate. Currently we do this at code check-in time via update-rust.sh. Cargo 0.18 and later will try to execute a build.rs file in the crate source tree regardless of whether it's specified in Cargo.toml so patching out that line just results in 'crate cheddar not found'. This change restores the old behaviour by substituting a 'build = false' line instead. We do have syntex vendored, but we don't currently build it by default, so I prefer this solution to just vendoring cheddar and generating the header at build time. The syntex crate is quite large and adds significantly to our compile time. MozReview-Commit-ID: InJRRODWAdP
--- a/media/libstagefright/binding/mp4parse-cargo.patch
+++ b/media/libstagefright/binding/mp4parse-cargo.patch
@@ -27,17 +27,18 @@ diff --git a/media/libstagefright/bindin
 index aeeebc65..5c0836a 100644
 --- a/media/libstagefright/binding/mp4parse_capi/Cargo.toml
 +++ b/media/libstagefright/binding/mp4parse_capi/Cargo.toml
 @@ -18,17 +18,9 @@ exclude = [
 -build = "build.rs"
++build = false
  "mp4parse" = {version = "0.6.0", path = "../mp4parse"}
 -rusty-cheddar = "0.3.2"
 -fuzz = ["mp4parse/fuzz"]