Bug 1168179 - Mark nsPresContext::mMedium as MOZ_UNSAFE_REF. r=dbaron
authorMichael Layzell <michael@thelayzells.com>
Tue, 16 Jun 2015 08:17:00 -0400
changeset 267308 57f67506a3541717bf7cf382e100e09bca89d494
parent 267307 f5d9db72645de852ff60ebe7d12f9e5f522bf7d4
child 267309 a1558d74b4db051c079d1cf3414effae2ef8160b
push id4932
push userjlund@mozilla.com
push dateMon, 10 Aug 2015 18:23:06 +0000
treeherdermozilla-esr52@6dd5a4f5f745 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersdbaron
bugs1168179
milestone41.0a1
Bug 1168179 - Mark nsPresContext::mMedium as MOZ_UNSAFE_REF. r=dbaron
layout/base/nsPresContext.h
--- a/layout/base/nsPresContext.h
+++ b/layout/base/nsPresContext.h
@@ -1225,18 +1225,17 @@ protected:
                                             // since there is no dependency
                                             // from gfx back to layout.
   nsRefPtr<mozilla::EventStateManager> mEventManager;
   nsRefPtr<nsRefreshDriver> mRefreshDriver;
   nsRefPtr<nsTransitionManager> mTransitionManager;
   nsRefPtr<nsAnimationManager> mAnimationManager;
   nsRefPtr<mozilla::RestyleManager> mRestyleManager;
   nsRefPtr<mozilla::CounterStyleManager> mCounterStyleManager;
-  nsIAtom*              mMedium;        // initialized by subclass ctors;
-                                        // weak pointer to static atom
+  nsIAtom* MOZ_UNSAFE_REF("always a static atom") mMedium; // initialized by subclass ctors
   nsCOMPtr<nsIAtom> mMediaEmulated;
 
   nsILinkHandler*       mLinkHandler;   // [WEAK]
 
   // Formerly mLangGroup; moving from charset-oriented langGroup to
   // maintaining actual language settings everywhere (see bug 524107).
   // This may in fact hold a langGroup such as x-western rather than
   // a specific language, however (e.g, if it is inferred from the