Bug 1315242 - Part 6: Update test_frame_01.html to follow new behavior of location. r=bgrins
authorTooru Fujisawa <arai_a@mac.com>
Fri, 11 Nov 2016 06:34:14 +0900
changeset 352147 4e1adcac2cfd09116a522c79a4baafc02d26fee3
parent 352146 fa67f98c5ffd878b667226c589e819d3c1c91fea
child 352148 28dc1d71a791a56cb27ace782d4f4fa758323d28
push id6795
push userjlund@mozilla.com
push dateMon, 23 Jan 2017 14:19:46 +0000
treeherdermozilla-esr52@76101b503191 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersbgrins
bugs1315242
milestone52.0a1
Bug 1315242 - Part 6: Update test_frame_01.html to follow new behavior of location. r=bgrins
devtools/client/shared/components/test/mochitest/test_frame_01.html
--- a/devtools/client/shared/components/test/mochitest/test_frame_01.html
+++ b/devtools/client/shared/components/test/mochitest/test_frame_01.html
@@ -62,41 +62,68 @@ window.onload = Task.async(function* () 
     }, {
       file: "mahscripts.js",
       line: 55,
       shouldLink: true,
       tooltip: "View source in Debugger → http://myfile.com/mahscripts.js:55",
     });
 
     // Check when there's no parseable URL source;
-    // should not render line/columns
+    // should not link but should render line/columns
     yield checkFrameComponent({
       frame: {
         source: "self-hosted",
         line: 1,
       }
     }, {
       file: "self-hosted",
+      line: "1",
       shouldLink: false,
-      tooltip: "self-hosted",
+      tooltip: "self-hosted:1",
+    });
+    yield checkFrameComponent({
+      frame: {
+        source: "self-hosted",
+        line: 1,
+        column: 10,
+      }
+    }, {
+      file: "self-hosted",
+      line: "1",
+      column: "10",
+      shouldLink: false,
+      tooltip: "self-hosted:1:10",
     });
 
     // Check when there's no source;
-    // should not render line/columns
+    // should not link but should render line/columns
     yield checkFrameComponent({
       frame: {
         line: 1,
       }
     }, {
       file: "(unknown)",
+      line: "1",
       shouldLink: false,
-      tooltip: "(unknown)",
+      tooltip: "(unknown):1",
+    });
+    yield checkFrameComponent({
+      frame: {
+        line: 1,
+        column: 10,
+      }
+    }, {
+      file: "(unknown)",
+      line: "1",
+      column: "10",
+      shouldLink: false,
+      tooltip: "(unknown):1:10",
     });
 
-    // Check when there's a column, but no number;
+    // Check when there's a column, but no line;
     // no line/column info should render
     yield checkFrameComponent({
       frame: {
         source: "http://myfile.com/mahscripts.js",
         column: 55,
       }
     }, {
       file: "mahscripts.js",