Bug 958714 part 3: Remove obsolete assertion & comment. r=mats a=IanN DONTBUILD CLOSED TREE SEAMONKEY_2_49_ESR_RELBRANCH tip
authorDaniel Holbert <dholbert@cs.stanford.edu>
Tue, 30 Jan 2018 22:24:58 -0500
branchSEAMONKEY_2_49_ESR_RELBRANCH
changeset 357576 3a4afe7ecac570decfb1d388eee2682d5d15dbc8
parent 357575 c90c92c68b2120d7c8382d6d5d60cfc0892e7107
push id7836
push userfrgrahl@gmx.net
push dateMon, 15 Jul 2019 16:17:02 +0000
treeherdermozilla-esr52@3a4afe7ecac5 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersmats, IanN
bugs958714
milestone52.9.1
Bug 958714 part 3: Remove obsolete assertion & comment. r=mats a=IanN DONTBUILD CLOSED TREE SeaMonkey ESR52 release branch only. MozReview-Commit-ID: jL2Xi4Okhb
layout/generic/ReflowInput.cpp
--- a/layout/generic/ReflowInput.cpp
+++ b/layout/generic/ReflowInput.cpp
@@ -146,35 +146,24 @@ FontSizeInflationListMarginAdjustment(co
       }
 
     }
   }
 
   return 0;
 }
 
-// NOTE: If we ever want to use SizeComputationInput for a flex item or a
-// grid item, we need to make it take the containing-block block-size as
-// well as the inline-size, since flex items and grid items resolve
-// block-direction percent margins and padding against the
-// containing-block block-size, rather than its inline-size.
 SizeComputationInput::SizeComputationInput(nsIFrame *aFrame,
                                    nsRenderingContext *aRenderingContext,
                                    WritingMode aContainingBlockWritingMode,
                                    nscoord aContainingBlockISize)
   : mFrame(aFrame)
   , mRenderingContext(aRenderingContext)
   , mWritingMode(aFrame->GetWritingMode())
 {
-  MOZ_ASSERT(!aFrame->IsFlexOrGridItem(),
-             "We're about to resolve percent margin & padding "
-             "values against CB inline size, which is incorrect for "
-             "flex/grid items. "
-             "Additionally for grid items, this path doesn't handle baseline "
-             "padding contribution - see SizeComputationInput::InitOffsets");
   ReflowInputFlags flags;
   InitOffsets(aContainingBlockWritingMode, aContainingBlockISize,
               mFrame->GetType(), flags);
 }
 
 // Initialize a reflow state for a child frame's reflow. Some state
 // is copied from the parent reflow state; the remaining state is
 // computed.